🇬🇧United Kingdom @vijaycs85

re-rolling the patch as it doesn't apply cleanly on gitlab-ci.yml file and watchdog entry as it is causing circular dependency.

Addressed the logger issue.

As mentioned in #25 and #33, the logger causing circular dependency (esp. with drush). I have added review comments in relavent lines in the MR #13

changes look good. thanks!

changes look good, but the test failure seems legit as the error message changed?

vijaycs85 → made their first commit to this issue’s fork.

Thank you.

Thank you! pushed to 1.x

Fix typo

yay! finally green. pushed to 2.0.x

Hope this would fix the test failures.

thanks @suzymasri.

Perhaps the solution moving forward is to create a 2.x (Webform 6.2.x) branch that supports D10, while keeping D9 support on 1.x (Webform 5.x)

yeah, though we are on beta on 1.x, it doesn't make sense to introduce breaking changes. I have created 2.0.x from current HEAD.

Thanks for working on this. Here is some review comments.

1. +++ b/composer.json
   @@ -35,6 +35,11 @@
   +        {
   +            "name": "Piyush Kumar (piyushsms91)",
   +            "homepage": "https://www.drupal.org/u/piyushsms91",
   +            "role": "Co-maintainer"
   

   We can't add the person here unless they are co-maintainer on drupal.org.

2. +++ b/tests/src/Functional/WebformEncryptEditSumissionsTest.php
   @@ -62,7 +67,7 @@ class WebformEncryptEditSumissionsTest extends BrowserTestBase {
   -    $this->drupalPostForm('/webform/test_encryption', $edit, 'Submit');
   +    $this->submitForm($edit, 'Save');
   
   +++ b/tests/src/Functional/WebformEncryptFunctionalTest.php
   @@ -102,7 +107,7 @@ class WebformEncryptFunctionalTest extends BrowserTestBase {
   -    $this->drupalPostForm('/webform/test_encryption', $edit, 'Submit');
   +    $this->submitForm($edit, 'Save');
   
   +++ b/tests/src/Functional/WebformEncryptUninstallTest.php
   @@ -53,18 +58,18 @@ class WebformEncryptUninstallTest extends BrowserTestBase {
   -    $this->drupalPostForm('/webform/test_encryption', $edit, 'Submit');
   +    $this->submitForm($edit, 'Save');
   
   @@ -124,7 +129,7 @@ class WebformEncryptUninstallTest extends BrowserTestBase {
   -    $this->drupalPostForm('/webform/test_encryption', $edit, 'Submit');
   +    $this->submitForm($edit, 'Save');
   

   wrong submit button value on update.

Most of the changes here are cleanup than necessary for upgrade. But they are good cleanup to go with, so leaving them in.

We need to include coverage for adding a new entity type from the form and make sure it appears in the views drop down. I have a feeling we need to clear the views cache on the submit of this form so that the hook_views_data would get regenerated, but test would show as if that's the case.

the config form looks good. probably we just need to add some test coverage.

Thanks @pwolanin. tested and confirmed it is working with custom headers.

Tested agains 2.0.0-beta2 (esp. for the new feature ✨ Support adding custom JWT headers and also make the headers available after decoding Fixed ) and looks good.

alexpott → credited vijaycs85 → .

I think the problem is with the media dependency on info.yml

@arthur.islamov could you provide interdiff → ?

Re-rolling against 8.9.x (and works for 8.8.x as well).

Manually tested the patch (8.7.x HEAD) with default_content module and the exported node has the layout configuration and node-level override details (as below).

"layout_builder__layout": [
        {
            "section": {
                "layout_id": "layout_onecol",
                "layout_settings": [],
                "components": {
                    "b9d1b078-51c2-4918-a69b-5a4b58e3a947": {
                        "uuid": "b9d1b078-51c2-4918-a69b-5a4b58e3a947",
                        "region": "content",
                        "configuration": {
                            "id": "block_content:18853fa3-6af3-44a2-a14e-799af4e46910",
                            "label": "Working block",
                            "provider": "block_content",
                            "label_display": 0,
                            "status": true,
                            "info": "",
                            "view_mode": "full",
                            "context_mapping": []
                        },
                        "additional": [],
                        "weight": 1
                    }
                },
                "third_party_settings": []
            }
        }
]