- πΊπΈUnited States swirt Florida
This approach makes a lot of sense. Many sites are only going to use this module to expose something specific and are unlikely to make use of all the possible things to expose.
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
I'm headed to Florida Drupal Camp later this week. I'll have time to take a shot at this.
- πΊπΈUnited States swirt Florida
I am sorry I am not able to attend this year (first year I have missed in 8 yrs). Would have liked to work on this with you.
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
I'll send you the code to review.
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
I worked on this during Florida Drupal Camp and got pretty close to all the way done. I'm working through some initialization issues and probably some incorrect config schema related to my collection of values (checkboxes).
I'm going to try to finish this work up and get a merge request in front of you all soon.
- @cosmicdreams opened merge request.
- πΊπΈUnited States cosmicdreams Minneapolis/St. Paul
Oh cool tests!
- Status changed to Needs work
almost 2 years ago 4:08pm 17 April 2023 - π¬π§United Kingdom vijaycs85 London, UK
the config form looks good. probably we just need to add some test coverage.
- π¬π§United Kingdom vijaycs85 London, UK
We need to include coverage for adding a new entity type from the form and make sure it appears in the views drop down. I have a feeling we need to clear the views cache on the submit of this form so that the hook_views_data would get regenerated, but test would show as if that's the case.