Florida
Account created on 25 April 2007, over 18 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States swirt Florida

swirt created an issue.

🇺🇸United States swirt Florida

To QA

  1. Login to tugboat preview admin:admin
  2. validate that the new content type exists.
🇺🇸United States swirt Florida

Thanks sirclickalot, jparmar, and bhogue for all your work on this and contributing. Unfortunately it took the problem in the wrong direction. node_link_report does not use views_data_export. It was mistakenly added to the composer.json as a result of copy and paste.
I created an MR to remove it and will merge that shortly.

The nice thing about MR rather than patches is that they generate tugboat preview instances so it makes it really quick to review things on vanilla installs.

🇺🇸United States swirt Florida

swirt made their first commit to this issue’s fork.

🇺🇸United States swirt Florida

This has been resolved and released with 8.x-1.20

Would close this but need to leave it open for any future 11 related rector updates.

🇺🇸United States swirt Florida

Thank you nidhi27. I am sorry this one is so delayed. Somehow I missed it.

🇺🇸United States swirt Florida

Sorry, I thought I merged this but I was on my phone. This is now merged.

🇺🇸United States swirt Florida

Thank you maxilein I will get it released next week.

🇺🇸United States swirt Florida

Blocked until we have a design.

🇺🇸United States swirt Florida

This one is blocked until we have a design.

🇺🇸United States swirt Florida

Sorry this one is not ready yet. I thought we had a design already created but I was mistaken. This one is blocked until we have a design.

🇺🇸United States swirt Florida

Thank you all for working on this.

🇺🇸United States swirt Florida

Nicely done Nidhi27. Thank you so much for working on this.

🇺🇸United States swirt Florida

Thank you so much Nidhi27 for this contribution.

🇺🇸United States swirt Florida

You are my hero. Thank you for digging in and figuring this out @dmundra

🇺🇸United States swirt Florida

Released as 8.x-1.19

🇺🇸United States swirt Florida

Thank you vlyalko for this contribution. It is much appreciated.

🇺🇸United States swirt Florida

swirt made their first commit to this issue’s fork.

🇺🇸United States swirt Florida

paraderojether interesting find related to a discrepancy between gitlab ci and local run. I am not sure of what the difference is. I want to investigate this discrepancy further So I will leave the failed checks that you found in place as a way to test whether I have got gitlab CI matching full phpcs.

@nidhi27 as always, thank you for your work. Sorry I let this one get stalled out for so long.

🇺🇸United States swirt Florida

Thank you again @adriancooke and @kelsmith. I think most of this design has been implemented and some refinements made in another ticket that took into account the rule add / edit method that did not exist when we were hashing things out. So I am going to close this out. And thank you arijit acharya for getting us off to a good start.

🇺🇸United States swirt Florida

This is working fine in tugboat but for some reason in local ddev contrib instance the tabs do not show up. I think it is an env issue.

🇺🇸United States swirt Florida

swirt created an issue.

🇺🇸United States swirt Florida

Assuming that the submodules should not be enabled, this seems to working fine and RTBC

🇺🇸United States swirt Florida

Crediting tsquare212 for solving this with rules entity.

🇺🇸United States swirt Florida

Crediting tsquared212 for the rules implementation that pulled this off.

🇺🇸United States swirt Florida

This is already handled by the cleaverness of the rules. Crediting Tsquare212 for getting it accompished.

🇺🇸United States swirt Florida

Closing this as this is already accounted for with the rules.

🇺🇸United States swirt Florida

I am calling this functionally complete. The validation of Rules works. The messages need some UX improvement but the functionality works. This even has test coverage for the rules.

🇺🇸United States swirt Florida

Fantastic work Jordan.wood Thank you so much for this contribution.

🇺🇸United States swirt Florida

Note, the classes should have been added as attributes to the render array, however at this time, SDC do not support attributes
Process #attributes render property Active

🇺🇸United States swirt Florida

This is largely complete. It did result in two more tickets.

  1. 🐛 Add html preprocessing for the message. Active
  2. 🐛 Get CSS/scss working for SDC Active
🇺🇸United States swirt Florida

swirt created an issue.

🇺🇸United States swirt Florida

Tugboat build and linting is both running and passing.

🇺🇸United States swirt Florida

After this is merged, then the magic button on the project page can be clicked to bring in the Readme.

🇺🇸United States swirt Florida

Merging this is blocked by 🐛 Composer requirements do not exist Active . After that is merged, then retriggering tugboat and gitlab CI on this PR should pass.

🇺🇸United States swirt Florida

Thank you rkoller for this suggestion and the accompanying documentation. I will work on this soon.

🇺🇸United States swirt Florida

This is fixed as it was resolved by Add tugboat previews Active

🇺🇸United States swirt Florida

Added to README and project page.

🇺🇸United States swirt Florida

Crediting Fen for his suggestion to add this.

🇺🇸United States swirt Florida

Closing this out with the new module Prevent Version Disclosure

Thanks nod_ for the push in that direction. That way I don't have to keep re-rolling this patch for our use.

🇺🇸United States swirt Florida

swirt created an issue.

Production build 0.71.5 2024