To QA
- Login to tugboat preview admin:admin
- validate that the new content type exists.
Released as 8.x-1.21 →
Thanks sirclickalot, jparmar, and bhogue for all your work on this and contributing. Unfortunately it took the problem in the wrong direction. node_link_report does not use views_data_export. It was mistakenly added to the composer.json as a result of copy and paste.
I created an MR to remove it and will merge that shortly.
The nice thing about MR rather than patches is that they generate tugboat preview instances so it makes it really quick to review things on vanilla installs.
This has been resolved and released with 8.x-1.20 →
Would close this but need to leave it open for any future 11 related rector updates.
Thank you nidhi27. I am sorry this one is so delayed. Somehow I missed it.
Sorry, I thought I merged this but I was on my phone. This is now merged.
Thank you maxilein I will get it released next week.
Blocked until we have a design.
This one is blocked until we have a design.
Sorry this one is not ready yet. I thought we had a design already created but I was mistaken. This one is blocked until we have a design.
Thank you all for working on this.
Thank you Tsquared212 for reviewing this.
Nicely done Nidhi27. Thank you so much for working on this.
Thank you so much Nidhi27 for this contribution.
You are my hero. Thank you for digging in and figuring this out @dmundra
Released as 8.x-1.19 →
Released as 8.x-1.19 →
Thank you vlyalko for this contribution. It is much appreciated.
paraderojether interesting find related to a discrepancy between gitlab ci and local run. I am not sure of what the difference is. I want to investigate this discrepancy further So I will leave the failed checks that you found in place as a way to test whether I have got gitlab CI matching full phpcs.
@nidhi27 as always, thank you for your work. Sorry I let this one get stalled out for so long.
Thank you again @adriancooke and @kelsmith. I think most of this design has been implemented and some refinements made in another ticket that took into account the rule add / edit method that did not exist when we were hashing things out. So I am going to close this out. And thank you arijit acharya for getting us off to a good start.
This is working fine in tugboat but for some reason in local ddev contrib instance the tabs do not show up. I think it is an env issue.
swirt → created an issue.
Assuming that the submodules should not be enabled, this seems to working fine and RTBC
Crediting tsquare212 for solving this with rules entity.
Crediting tsquared212 for the rules implementation that pulled this off.
This is already handled by the cleaverness of the rules. Crediting Tsquare212 for getting it accompished.
Closing this as this is already accounted for with the rules.
I am calling this functionally complete. The validation of Rules works. The messages need some UX improvement but the functionality works. This even has test coverage for the rules.
Fantastic work Jordan.wood Thank you so much for this contribution.
Note, the classes should have been added as attributes to the render array, however at this time, SDC do not support attributes
✨
Process #attributes render property
Active
This is largely complete. It did result in two more tickets.
- 🐛 Add html preprocessing for the message. Active
- 🐛 Get CSS/scss working for SDC Active
Tugboat build and linting is both running and passing.
After this is merged, then the magic button on the project page can be clicked to bring in the Readme.
Merging this is blocked by 🐛 Composer requirements do not exist Active . After that is merged, then retriggering tugboat and gitlab CI on this PR should pass.
Thank you rkoller for this suggestion and the accompanying documentation. I will work on this soon.
This is fixed as it was resolved by ✨ Add tugboat previews Active
Added to README and project page.
Crediting Fen for his suggestion to add this.
Closing this out with the new module Prevent Version Disclosure →
Thanks nod_ for the push in that direction. That way I don't have to keep re-rolling this patch for our use.
Crediting nod_ for the code gifted in ✨ Javascript Version Disclosure Active