Oops, just saw it was merged. Any future MRs will get tugboat preview environments.
No need to change anything. The tugboat env goes away after 10 days of no use. Closing the PR and reopening it a minute later should revive it.
Tugboat previews will start working again when this is done. Right now they are broken because of the docroot / web discrepancy for the patch.
Needs a setting too or enable current aggregation.
This is needed for the current functionality on PDC.
Solution is something like this:
- After as part of the theme aggregation the theme name is kept and used to trigger a current aggregation.
- It will trigger its own cache tag invalidation
- It will load all published datasets and add them to a zip.
- Of course there will have to be separate aggregation of private.
- Manifest should also be included.
This MR also included work for ✨ Archives marked private should be private Active
This was pretty involved to account for multiple options for handling private files. But I think I have it working.
Revised this after ✨ Remove settings for different retention periods Active was merged.
Archve timing is corrected to be in the final hour of the year. This also gets the functionality of the annual archive process working.
This may have to be too specific to a given site. It may have to be a custom Batch Operation.
This was competes as part of the work along with ✨ Add api endpoint for topic archives Active
This issue should only be closed after This module and all its dependencies have stable releases.
Crediting theloneliestmonk for raising this question.
Data currently in use looks like this
{
"Dialysis facilities": {
"2018": [
{
"url": "https:\/\/data.cms.gov\/provider-data\/sites\/default\/files\/archive\/Dialysis%20facilities\/2018\/dfc_archive_04_2018.zip",
"size": 6507709,
"type": "Monthly",
"month": "04",
"day": "04"
},
...
I'd like to keep the url, sized, and type but the rest of the structure is a little odd. Perhaps only clustering by Theme on the theme aggregation API
The locations and file names have been standardized. They now agree with any archives that are created automatically.
The filename and location logic has been moved to the Util service. We will need to use those in DdaArchive presave to manipulate where the file goes and what it is named.
I added the sitename to the annual file just so the filename has context if seen outside the site.
Crediting skyriter for helping me determine this was an existing issue.
This is now fixed. I will get this tagged for a new release tonight.
Nice work @skyriter thank you for cleaning this this up and getting the business logic out of the block.
I tested this out on my setup where I was seeing the error and everything is now clear.
Nice work.
Skipping and map options are now observed in the theme and keyword aggregations.
Individual type archives are intentionally not impacted by these.
Need to remember to add dismissible option too. THat is blocked on the USWDS variants because USWDS has not defined it, but the the template for the non USWDS alerts should just the same way the base module does.
Interesting note. The patching approach even worked on the Tugboat preview environments. So that is a plus.
I created a followup ticket for when DKAN core is on d.o. 📌 Remove patch when DKAN core is on D.o Active
I am calling this complete.
Thank you @stefan.korn. I could not have solved this without you.
I think the solution I used here 🐛 Fail to install via composer Active will resolve this until DKAN core moves to D.o. It is not perfect and will not work for everyone on simple install, but it does solve the problem.
It took way longer than I thought to get this working as best as currently possible with current dkan limitation.
I was able to have the module include a patch to add the dkan dependencies back. If you are already using composer-patches AND your site uses "web" as your docroot, then this will work by simply composer requiring the module
You can see the composer changes here
https://git.drupalcode.org/project/dkan_dataset_archiver/-/blob/1.0.x/co...
and the patch and README here https://git.drupalcode.org/project/dkan_dataset_archiver/-/tree/1.0.x/pa...
The solution is not pretty and is prone to failure, but for now I think it is the best we can do.