Automated Drupal 10 compatibility fixes

While testing the patch we came across many D10 depreciations error, which needs to be fixed.

Fixes the D10 compatibility issues.

Fixes the tests errors.

Please review the Drupal 10 compatibility fix patch, we have taken care of the test case also.

Tested the patch and it works correct. RTBQ

Thanks for working on this. Here is some review comments.

1. +++ b/composer.json
   @@ -35,6 +35,11 @@
   +        {
   +            "name": "Piyush Kumar (piyushsms91)",
   +            "homepage": "https://www.drupal.org/u/piyushsms91",
   +            "role": "Co-maintainer"
   

   We can't add the person here unless they are co-maintainer on drupal.org.

2. +++ b/tests/src/Functional/WebformEncryptEditSumissionsTest.php
   @@ -62,7 +67,7 @@ class WebformEncryptEditSumissionsTest extends BrowserTestBase {
   -    $this->drupalPostForm('/webform/test_encryption', $edit, 'Submit');
   +    $this->submitForm($edit, 'Save');
   
   +++ b/tests/src/Functional/WebformEncryptFunctionalTest.php
   @@ -102,7 +107,7 @@ class WebformEncryptFunctionalTest extends BrowserTestBase {
   -    $this->drupalPostForm('/webform/test_encryption', $edit, 'Submit');
   +    $this->submitForm($edit, 'Save');
   
   +++ b/tests/src/Functional/WebformEncryptUninstallTest.php
   @@ -53,18 +58,18 @@ class WebformEncryptUninstallTest extends BrowserTestBase {
   -    $this->drupalPostForm('/webform/test_encryption', $edit, 'Submit');
   +    $this->submitForm($edit, 'Save');
   
   @@ -124,7 +129,7 @@ class WebformEncryptUninstallTest extends BrowserTestBase {
   -    $this->drupalPostForm('/webform/test_encryption', $edit, 'Submit');
   +    $this->submitForm($edit, 'Save');
   

   wrong submit button value on update.

Most of the changes here are cleanup than necessary for upgrade. But they are good cleanup to go with, so leaving them in.

Removing Webform 5.x in favour of 6.2.x, since the latter is the only Webform version that supports Drupal 10.

Perhaps the solution moving forward is to create a 2.x (Webform 6.2.x) branch that supports D10, while keeping D9 support on 1.x (Webform 5.x)

thanks @suzymasri.

Perhaps the solution moving forward is to create a 2.x (Webform 6.2.x) branch that supports D10, while keeping D9 support on 1.x (Webform 5.x)

yeah, though we are on beta on 1.x, it doesn't make sense to introduce breaking changes. I have created 2.0.x from current HEAD.

Added patch against 2.0.x branch.

Hope this would fix the test failures.

yay! finally green. pushed to 2.0.x

Automatically closed - issue fixed for 2 weeks with no activity.