- Issue created by @super_romeo
- @super_romeo opened merge request.
- Status changed to Needs review
over 1 year ago 9:42am 25 March 2023 - π¨π¦Canada jibran Toronto, Canada
Which version of core and symfony are you using?
- π·πΈSerbia super_romeo Belgrade
D10.0.6, Symfony 6, HAL last version.
- First commit to issue fork.
- Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass - Open on Drupal.org βCore: 10.1.x + Environment: PHP 8.1 & MySQL 5.7last update
over 1 year ago Waiting for branch to pass Since drupal/hal has been moved from the core to the contrib module, we must declare a dependency on it.
I pushed the dependency declaration to the issue branch.
I have also prepared a patch (based on changes in the issue branch) that applies to both 3.0.0 and 4.0.0-alpha2.- First commit to issue fork.
- last update
over 1 year ago 72 pass - last update
over 1 year ago 72 pass - last update
over 1 year ago 52 pass - @codebymikey opened merge request.
- last update
over 1 year ago 52 pass - last update
over 1 year ago 72 pass - π¦πΊAustralia acbramley
I think this should be closed as a duplicate of π DynamicEntityReferenceItemNormalizer broken on D10 Needs review , the preferred approach would be to use core's serializer rather than a new dependency imo.
This
Drupal\serialization\Normalizer\EntityReferenceItemNormalizer
serializer class being referenced by that issue doesn't exist as far as I'm aware.The closest thing to
EntityReferenceItemNormalizer
in core is probably theEntityReferenceFieldItemNormalizer
class, but it seems like the::normalize()
method returns an entirely different data structure, so keeping the original class seems like the easiest way to avoid introducing subtle bugs.- π©πͺGermany Tomefa Dresden
Can confirm that the patch in #10 fix this issue by adding back drupal/hal module as a dependency.
- πΉπ·Turkey emircan erkul Turkey
Reviewed and I can confirm #10 solves the problem.
- Status changed to RTBC
about 1 year ago 6:45am 27 October 2023 - π©πͺGermany DiDebru
Set this to RTBC code looks good and it solves the issue.
- πΏπ¦South Africa epicure.club
Have this problem on a site.
Curious why this is not being committed? - last update
12 months ago Patch Failed to Apply - π©πͺGermany flefle
Latest patch for 4.0.0-alpha3 version. Maybe something to put into next release?
- Status changed to Needs work
12 months ago 1:33pm 8 January 2024 - π¨π¦Canada jibran Toronto, Canada
As mentioned in #3354499-6: DynamicEntityReferenceItemNormalizer broken on D10 β , hal is contrib module now so let's remove it from DER and move it to hal.
- Status changed to Closed: won't fix
12 months ago 3:44am 12 January 2024 - π¨π¦Canada jibran Toronto, Canada
I'm closing this in favor of β¨ Add DynamicEntityReferenceItemNormalizer Active in the HAL issue.
- π¦πΊAustralia acbramley
@jibran shouldn't we remove the normalizer from DER then?