Declaration of DynamicEntityReferenceItemNormalizer::normalize() must be compatible

Which version of core and symfony are you using?

D10.0.6, Symfony 6, HAL last version.

Since drupal/hal has been moved from the core to the contrib module, we must declare a dependency on it.
I pushed the dependency declaration to the issue branch.
I have also prepared a patch (based on changes in the issue branch) that applies to both 3.0.0 and 4.0.0-alpha2.

Attached static patch (it should apply to both 3.x and 4.x)

I think this should be closed as a duplicate of 🐛 DynamicEntityReferenceItemNormalizer broken on D10 Needs review , the preferred approach would be to use core's serializer rather than a new dependency imo.

This Drupal\serialization\Normalizer\EntityReferenceItemNormalizer serializer class being referenced by that issue doesn't exist as far as I'm aware.

The closest thing to EntityReferenceItemNormalizer in core is probably the EntityReferenceFieldItemNormalizer class, but it seems like the ::normalize() method returns an entirely different data structure, so keeping the original class seems like the easiest way to avoid introducing subtle bugs.

Can confirm that the patch in #10 fix this issue by adding back drupal/hal module as a dependency.

Reviewed and I can confirm #10 solves the problem.

Set this to RTBC code looks good and it solves the issue.

Have this problem on a site.
Curious why this is not being committed?

Latest patch for 4.0.0-alpha3 version. Maybe something to put into next release?

As mentioned in #3354499-6: DynamicEntityReferenceItemNormalizer broken on D10 → , hal is contrib module now so let's remove it from DER and move it to hal.

I'm closing this in favor of ✨ Add DynamicEntityReferenceItemNormalizer Active in the HAL issue.

@jibran shouldn't we remove the normalizer from DER then?

Updated the patch from #10 🐛 Declaration of DynamicEntityReferenceItemNormalizer::normalize() must be compatible Needs review to make it compatible with DER version-3.1.0

jibran → closed merge request !9

jibran → closed merge request !12