DynamicEntityReferenceItemNormalizer broken on D10

ah we'll need a dep on the contrib module

We have https://git.drupalcode.org/project/drupal/-/blob/10.1.x/core/modules/ser... - can we not use that?

We obviously need tests for this too

Can we please have a suggestion on #6? Assigning it to Lee as he is HAL module maintainer.

HEAD tests are fixed now, let's see how it goes

I am havind trouble getting this change to work. AFAICT, the class is named EntityReferenceFieldItemNormalizer, not EntityReferenceItemNormalizer. Am I missing something?

#11 is right, I can't see that class in 10.1.x or 11.x. How did tests pass??

Wondered the same, but the obvious answer is: this is not tested. :) There is actually more information in the companion/duplicate issue, 🐛 Declaration of DynamicEntityReferenceItemNormalizer::normalize() must be compatible Needs review , although I agree that the "correct" answer is to remove the dependency entirely.

I created a new branch that "corrects" the name of the base class, but as noted in the other issue, it is actually quite different, so I guess the other issue may be the correct solution for the short term, while this one serves as a better, future solution.

I'm closing this in favor of ✨ Add DynamicEntityReferenceItemNormalizer Active in the HAL issue.

Note to others: the normalizer was completely removed in 📌 [DER] Fix GitLab CI Fixed , so latest dev shouldn't have this problem.

Also, double-check that you _really_ need hal module. Maybe you still have it installed because you use default_content 1.x or something else that used to depend on it? You should only get this error if you have that module installed.

jibran → closed merge request !10