🇦🇺Australia @larowlan

Links in core support attributes, one of which is class

Could we just put a class attribute in the menu links (where they live in various core modules) and use that, rather than a new property

This is how link attributes module works

If people want to modify they can use the discovered alter hook ?

📌 add gitlabci Active

Crediting folks from 📌 Fix the issues reported by phpcs Needs work

larowlan → created an issue.

Check your input formats to see what is configured for the aggregator format, perhaps it's being filtered out

Should be in the habit of running it, I don't think there are any updates, but good habit to get into

📌 Fix gitlab and test next major Needs review

larowlan → made their first commit to this issue’s fork.

11 here we come

larowlan → created an issue.

📌 Add gitlabci Active Not prepared to mark this without tests, so did that instead

You can install the 1.x version on 10.3 and it should 'just work' because of how extension discovery works in Drupal - modules/contrib will take precedence over core/modules.

And then when D11 comes out you shouldn't have to do anything.

3.x is done, 5.x needs work

larowlan → made their first commit to this issue’s fork.

Thanks folks - marking this as a duplicate of 📌 Add gitlabci Active

Not transferring credit because I don't give credit for PHPCS issues for those who already have such credits, these are great first issues, but not for established contributors.

larowlan → created an issue.

benjifisher → credited larowlan → .

larowlan → created an issue.

Oh and also, that warning is about usage of the media entity. This module doesn't have anything to do with deleting media - its to do with deleting the file attached to the media.

So I think there's a disconnect there.

So that warning is coming from entity usage module.

Media file delete will allow you to delete it if there is only 1 usage but prevents if there is more than, whilst entity usage warns if there is more than zero.

I would suggest that you:
* triple check the usage - if there's only one usage and its on the media entity you're deleting - its all working - happy days
* turn of entity usage delete warnings for media entities - looking at the code, it looks like this can be done from the entity usage settings form

Let me know how you get on

The module makes use of file usage data from core. There are known bugs with that API in core.
The module also supports the more robust entity usage module. I would recommend using that if you can.

Thanks

ta

Thanks, is there a logo for 'don't use this module, no one looks after it' 😜

Will commit later this week, but yeah the only people here stepped in to stop it getting security unsupported.

Yeah this came from how we test on circle ci where spin up is faster, agree on current gitlab setup it's hurting us in overall resection time

The trusted hosts setting in settings.PHP allow lists valid hosts

The text only fail isn't going to admin/comment is what I'm saying

thanks, its in

crosspost

yeah I don't really mind so long as it's not misleading - something is better than nothing

looks good, thanks folks, will try to get this committed later in the week

I agree in a framework manager capacity. The key tenet here is moving the destination/source plugins into migrate module. +1 from me.

Thanks @banoodle

@fkildoo - you can turn an MR into a patch by adding `.diff` to the URL - for this issue the patch is at https://git.drupalcode.org/project/drupal/-/merge_requests/8790.diff - however you shouldn't reference that URL directly (as anyone can get access to the branch). Instead you should download the file into e.g. a PATCHES folder inside your codebase, and then with composer patches reference it using a file URL (e.g. "./PATCHES/name-of-the-saved-file.patch". Thanks again 💪

Left a question on the MR

Back to NR for #8

Committed to 11.x and backported to 11.0.x, 10.4.x and 10.3.x

Thanks folks

Left a question/observation on the MR

Left some questions on the MR, feel free to self-RTBC after replying/changes

Committed to 11.x and backported to 11.0.x, 10.4.x and 10.3.x

Left a question on the MR

Also keen to see this go in, but the test makes me think we're left with a performance regression in place of the bug.

Left some comments on the MR - thanks folks.

Did anyone look into #19? That would address @tim.plunkett's concern in #17

Committed to 11.x

Per https://www.drupal.org/about/core/policies/core-change-policies/allowed-... → this isn't eligible for backport to 11.0.x.

Glad to see this one resolved.

Updating issue credits

@fkildoo, @rbomhof or @banoodle - any chance you could try the RTBC MR for a few days and report back if it fixes your issue?

Updating issue credits

Committed to 11.x and backported to 11.0.x, 10.4.x and 10.3.x

Thanks everyone!

Fixed a typo in a comment, waited for a green test-run - which passed.
Committed to 11.x and backported 11.0.x, 10.4.x and 10.3.x

Thanks folks 🙌

larowlan → made their first commit to this issue’s fork.

larowlan → created an issue.

larowlan → created an issue.

larowlan → created an issue.

larowlan → created an issue.

https://www.drupal.org/project/jsonapiamenu_items/releases/1.2.2 →

cutting a release, thanks all

Thanks mate, appreciate the help 🙌

Thanks for being patient with me

likewise, lots going on atm with D11 around the corner

FWIW I'm plus one for this

larowlan → created an issue.

0️⃣ Who is here today? Comment in the thread to introduce yourself. We’ll keep the meeting open for 24 hours to allow for all time zones.

1️⃣ What topics do you want to discuss? Post in this thread and we’ll open threads for them as appropriate

2️⃣ Action items

2️⃣.1️⃣ Approve minutes

2️⃣.2️⃣ TBD

3️⃣ Fixed since last meeting

4️⃣ RTBC issues

4️⃣.1️⃣ #3339746: Coding style for PHP Enumerations →

4️⃣.2️⃣ #3324368: Update CSS coding standards to include PostCSS and Drupal 10 →

5️⃣ New issues

5️⃣.1️⃣ #3458314: Convention or recommendation for line breaks in constructor parameter signature with promoted properties →

6️⃣ Active issues

6️⃣.1️⃣ #3263602: Allow type hinting with classes where appropriate →

6️⃣.2️⃣ #1368794: Using '&' in doxygen @param documentation →

6️⃣.3️⃣ #1539738: Define and document a policy on list() syntax →

6️⃣.4️ #3280642: Use fully-qualified class names in code in api.php files →

6️⃣.5️⃣ #3259666: Require backslash prefix for global functions →

6️⃣.6️⃣ #3422530: Require short ternary (Elvis operator) syntax →

6️⃣.7️⃣ #2325985: No documentation about @group @coversDefaultClass @covers →

7️⃣ Should we try to recruit a manager to help with admin tasks such as running meetings, blog posts etc. A lot of the people on the committee wear multiple hats (core committers, subsystem maintainers etc). These tasks take us away from other contributions

Created those issues and a bonus one as children of this one.
I need to do some security team tasks tomorrow, but if I get through those I'll start on some of these as well.

Used the pnx²b 😉 tag and flagged with colleagues as well.

larowlan → created an issue.

larowlan → created an issue.

larowlan → created an issue. See original summary → .

larowlan → created an issue.

larowlan → created an issue.

larowlan → created an issue.

larowlan → changed the visibility of the branch 3454519-pluggable-storage-components to hidden.

Thanks. I fixed this in 📌 Add gitlabci Fixed

larowlan → created an issue.

Gah I merged that by mistake, E_TOO_MANY_TABS

Going to revert it and reopen

larowlan → made their first commit to this issue’s fork.

larowlan → made their first commit to this issue’s fork.

larowlan → created an issue.

Cheers!

larowlan → made their first commit to this issue’s fork.

Jquery is still used in the JS, so this needs the actual work done still

larowlan → created an issue.

It's a start