When this came up on my RSS feeds I thought it was a change record 😀
bbrala → credited larowlan → .
Thanks @apaderno - the application period for the Drupal 11 update cycle has closed. Marking this as postponed for consideration during the D11 - D12 cycle.
mcdruid → credited larowlan → .
Do I have to update something in my yml file to take advantage of the update? https://git.drupalcode.org/project/forum/-/jobs/1611292
You need to update your config to use bundle:node
Too fast 🤩 agree to do them both here given you've already done it.
Do we need a simple test for this?
Comment #26 mentions an update path but that seems to be missing now?
Thanks for the reroll
We need some tests for this and also would need a rebuild task that used batch to recreate after re-enable
larowlan → changed the visibility of the branch 2251789-forumblockbasedefaultconfiguration-uses-a to hidden.
larowlan → changed the visibility of the branch 512864-comment-count-query to hidden.
Left a review on the MR
Thanks, we need some tests for this new behaviour though.
Hi, we no longer test patches anymore - are you able to open an MR? thanks!
I think we should hard code 'update and delete' for now to stop the bleeding and then revisit for configurablity
larowlan → made their first commit to this issue’s fork.
Opened
📌
Fix fails in HEAD (aka whack a mole)
Active
for the fails which have snuck into HEAD in the last week 🙃
Merged thanks
larowlan → made their first commit to this issue’s fork.
larowlan → created an issue.
I think this makes sense.
Left a small suggestion on the MR.
We need to resolve the test failures too.
Merged the 5.x, question on the 3.x
larowlan → made their first commit to this issue’s fork.
larowlan → created an issue.
Should we also consider anchor position with a polyfill now it's in chrome and Firefox has also signalled intent to ship? There's a polyfill from oddbird
I think we can just return a non zero int instead of throwing
Yeah that would probably mean we'd need a subtree split solution in some way- tricky
pameeela → credited larowlan → .
pameeela → credited larowlan → .
This sandbox is unsupported - it became workbench moderation which then went into core as content moderation
Thanks
larowlan → created an issue.
larowlan → created an issue.
Oh, a second PR with test only changes? Thanks @smustgrave - nice one
Yeah,.we just need to know which test fails so someone can run it locally - thanks!
I'm learning French so it actually is useful because I need the practise 😂 - thanks!
Fixed, thanks folks. one more down, about 50 odd to go!
larowlan → changed the visibility of the branch 3421571-add-gitlab-ci to hidden.
larowlan → made their first commit to this issue’s fork.
larowlan → created an issue.
Cutting a new release
Also linking to https://bradfrost.com/blog/post/a-global-design-system/
I was the one who asked for this, but I agree with #8
It's a shame we don't use https://www.npmjs.com/package/postcss-mixins because this would be a good case for it.
It's also a shame there's no display: visually-hidden in the platform, but I see there are folks proposing it so perhaps at some point we will be able to ditch this.
Thanks, I'll try to get gitlabci setup today and add OPT_IN_TEST_NEXT_MINOR which would catch this.
Great slides @pdureau - is there a recording anywhere?
There's now a default content import API in core that handles files (courtesy of recipe API) we could make use of that
These should support both manually entered fields but also drawing fields from a node where the link, title, teaser etc is centrally managed
quietone → credited larowlan → .
larowlan → created an issue.
Pushed a possible MR for a hux-only fix
larowlan → made their first commit to this issue’s fork.
Something like this for hux (1.3.x branch) seems to work
Any reason hux can't implement destructable and just call the inner method from its implementation?
Fixed thanks
Committed to 11.x and backported to 11.0.x, 10.4.x and 10.3.x
larowlan → created an issue.
larowlan → made their first commit to this issue’s fork.
larowlan → created an issue.
Can we please have this recreated as an MR against forum contrib (instead of core) - thanks!
Can we please have this recreated as an MR against forum contrib (instead of core) - thanks!
Can we get the MR recreated against forum contrib (instead of core) - thanks
Hiding patches
larowlan → created an issue.
I think this is because the admin needs to be able to configure the block still
So we probably need a fallback
Agree 3 feels like the worst option
Tour is gone from core and I think improving the UX so tours aren't needed is probably better use of time
This issue isn't forum specific, even the new navigation module has to battle this