ComponentTreeItem specifies wrong main property

wim leers → credited larowlan → .

OMG LOL!

It's not that we specified the wrong property, it's that the inherited \Drupal\Core\Field\FieldItemBase::mainPropertyName() does not make sense for XB's field type.

(I bet there will be more such things — few field types in the Drupal ecosystem have as many field properties as XB's field type…)

Thanks for the bug report!

WTAF happened to this MR? It's still @fago's commit from 10:43, so I don't think he pushed again? There was 1 commit, now there's 8?!

I've been intermittently seeing this kind of problem on GitLab. Seems like it's having some integrity issues…

Was going to merge, will now wait a bit for this to re-settle 🙃

Thanks for the quick reviews!

It's not that we specified the wrong property, it's that the inherited \Drupal\Core\Field\FieldItemBase::mainPropertyName() does not make sense for XB's field type.

yep, exactly!

>here was 1 commit, now there's 8?!

They were there from the beginning.
Maybe, there was some glitch between 0.x and 1.x when I created the PR, I was confused about the branches. But the diff is correct, so it should be fine to just squash-merge it.

AHHHHHHHHHH! So you developed on 0.x, the MR targeted 0.x and then you changed it to 1.x
That explains everything.

Except … HOW F'ING STUPID GitLab is being here, for not showing such a significant change (different target branch) in the "activity" entries:

It lists zero-impact activity there, but this it does not.

Made me lose 20 minutes of my day. 😬

But the diff is correct, so it should be fine to just squash-merge it.

Can't do that due to A) it not applying to 1.x, B) hence not running tests, C) the d.o-GitLab integration. Need to use the "merge" button on d.o, and then this won't work.

Rebased to be able to land this 👍

Oh I see, I'm sry to have caused this issue and it ate your time. The 1.x/0.x separation was new to me. :-/

No worries — it's an adjustment for all of us. I'm disappointed by GitLab/d.o's integration with it, not in your MR, that I'm very grateful for! 😄 Merged 😊

Automatically closed - issue fixed for 2 weeks with no activity.