- Issue created by @jessebaker
- Merge request !883#3518708 Fix for inline vh units causing iframe to grow infinitely ā (Merged) created by jessebaker
- š¬š§United Kingdom jessebaker
The MR !883 should fix the issue for inline
vh
units.Iām not sure what the solution for elements with
vh
units set in a separate stylesheet would look like. To access the style with JS means callinggetComputedStyle()
but that always returns the height inpx
regardless of what unit was specified. Perhaps some kind of rate limit on the iframe height check? Perhaps parsing stylesheets before the page is rendered somehow? -
jessebaker ā
committed bafaf272 on 0.x
Issue #3518708 by jessebaker: Components with height in VH can cause the...
-
jessebaker ā
committed bafaf272 on 0.x
- š®š±Israel heyyo Jerusalem
I experienced the same bug, just by setting margin-top, or margin-block (but not margin-bottom).
Video attached. - š¦šŗAustralia larowlan š¦šŗš.au GMT+10
@heyyo is that against 0.x? Can you share that SDC (or point me towards somewhere it lives in a repo)?
@jessebaker this was merged is 'Active' the correct status?
- š®š±Israel heyyo Jerusalem
Yes my test was against 0.x, but after I saw another issue on the same bug, didn't test it yet.
https://www.drupal.org/project/experience_builder/issues/3534490 š Cannot use `h-screen` from Tailwind with XB ActiveCan you share that SDC (or point me towards somewhere it lives in a repo)?
It's a local playground for now, still unsure to contribute.
But it's a custom theme with daisyui/tailwind, and this bug appears just by applying the tailwind class mt-{y} or my-{y}
which sets only margin-top or margin-block, nothing related to height of the container.
I didn't test outside tailwind, to see we have the same issue - š®š±Israel heyyo Jerusalem
I confirm, that margin-top/margin-block issue is fixed with the other issue:
https://www.drupal.org/project/experience_builder/issues/3534490 š Cannot use `h-screen` from Tailwind with XB Active - š«š®Finland lauriii Finland
This is getting fixed in š Cannot use `h-screen` from Tailwind with XB Active