- Issue created by @neograph734
- Merge request !74Update RendererBase.php to use renderRoot instead of using render with is_root_call. โ (Merged) created by neograph734
- ๐ฆ๐บAustralia jannakha Brisbane!
- installed entity print on clean D11.2.1
- warning shows up
- applied patch
- no warning after patchthanks for your contribution!
- ๐ฆ๐บAustralia jannakha Brisbane!
this may break old versions of Drupal (10.3 and under)
https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Render%21...Will be released as part of 3.x
- ๐จ๐ฆCanada joseph.olstad
There's currently no 3.x branch.
10.4 , 11.1/11.2 are current.
10.3 is not current.
Easier solution is to update the .info.yml file rather than new branch
^10.4 || ^11.1
- ๐ฆ๐บAustralia jannakha Brisbane!
Currently itโs
9.4^ || 10^ || 11^There will be more D11 compatibility issues coming
Thereโs no visibility of how many Drupal 9-10.3 installations still out there
Will be good to move on to proper versioning
- ๐ฎ๐ฑIsrael jsacksick
Thereโs no visibility of how many Drupal 9-10.3 installations still out there
- ๐จ๐ฆCanada joseph.olstad
There is no need to make a new branch.
All we have to do is change entity_print.info.yml
from
^9.4 || ^10 || ^11
to
^10.4 || ^11.1
Composer will then ensure that running ^9.4 or 10.0/10.1/10.2/10.3 will get the most recent release that has
^9.4 || ^10 || ^11
Everyone with 10.4 || 11.1 will get the fix that we publish in a new release. There's no need for a new branch to protect someone with 9.4 or 10.0
- ๐จ๐ฆCanada tame4tex
From what I can see on gitlab
\Drupal\Core\Render\RendererInterface::renderRoot
existed in 9.4.0 (see https://git.drupalcode.org/project/drupal/-/blob/9.4.0/core/lib/Drupal/Core/Render/RendererInterface.php?ref_type=tags). Is this an assumption it wont work or has it been confirmed?This bug is also causing test failures on other issues which creates a lot of unnecessary noise (e.g. โจ Add link settings to the views global print link Needs work ).
+1 for not requiring a new branch to expedite the release of the fix. Paragraphs โ is an example of a very populate module that drops support for Drupal versions in a minor release.
-
jsacksick โ
committed e8828c63 on 8.x-2.x authored by
neograph734 โ
Issue #3531508 by neograph734, jannakha, joseph.olstad, jsacksick,...
-
jsacksick โ
committed e8828c63 on 8.x-2.x authored by
neograph734 โ
- ๐ฎ๐ฑIsrael jsacksick
I don't see why a new branch is required... If all we do is calling renderRoot which kinda always existed (it was added 10 years ago)... So I think we can just merge this?
- ๐ฆ๐บAustralia VladimirAus Brisbane, Australia
This API is not available for Drupal core 10.2 and earlier so update is required to specify core constrains it in
.info,yml
file. - ๐ฎ๐ฑIsrael jsacksick
@vladimiraus: Did you not read the comment #10?
How is this API not available for Drupal core 10.2 and earlier?
renderRoot() has been around for 10 years? What am I missing?
See https://git.drupalcode.org/project/drupal/-/blob/9.4.0/core/lib/Drupal/C...
It even existed in Drupal 8: See https://git.drupalcode.org/project/drupal/-/blob/8.0.x/core/lib/Drupal/C...
- ๐ฆ๐บAustralia larowlan ๐ฆ๐บ๐.au GMT+10
Folks, let's stay civil here
- ๐ฎ๐ฑIsrael jsacksick
@larowlan: I didn't mean to be offensive. This probably came out wrong. I was just genuinely trying to understand what is it am I missing here.