🇦🇺Australia @VladimirAus

Thanks, everyone. Committed. 🥂

vladimiraus → made their first commit to this issue’s fork.

fubarhouse → credited vladimiraus → .

fubarhouse → credited vladimiraus → .

fubarhouse → credited vladimiraus → .

fubarhouse → credited vladimiraus → .

fubarhouse → credited vladimiraus → .

fubarhouse → credited vladimiraus → .

fubarhouse → credited vladimiraus → .

fubarhouse → credited vladimiraus → .

fubarhouse → credited vladimiraus → .

fubarhouse → credited vladimiraus → .

fubarhouse → credited vladimiraus → .

vladimiraus → created an issue.

I got similar error when trying to "Replicate" the submission.

Symfony\Component\Routing\Exception\MissingMandatoryParametersException: Some mandatory parameters are missing ("webform") to generate a URL for route "entity.webform_submission.canonical". in Drupal\Core\Routing\UrlGenerator->doGenerate() (line 180 of core/lib/Drupal/Core/Routing/UrlGenerator.php).

Error is happening on tab of the submission

bit not in the the submission list

jjchinquist → credited vladimiraus → .

Thanks @kul.pratap.
Seems like you brought many other changes. Please, only commit changes related to the issue, not 1000 files.

vladimiraus → created an issue.

jct321 → credited vladimiraus → .

jct321 → credited vladimiraus → .

Thanks @nginex. Production data is too complex to export.
Let me setup clear instance and try to replicate it.
From what I investigated, entities that are referenced in text fields are being exported as well (both taxonomies and nodes).

Nope, getting

The website encountered an unexpected error. Try again later.

Error: Xdebug has detected a possible infinite loop, and aborted your script with a stack depth of '512' frames in Drupal\Core\TypedData\DataDefinition->getDataType() (line 54 of core/lib/Drupal/Core/TypedData/DataDefinition.php).

After further investigation I found versions 1.4.7+ are unusable for complex websites with a lot of references.

The issues discovered:

• Even if taxonomy terms are UNselected in config, the module still exports taxonomies
• Taxonomies go into infinite loop, because of $this->exporter->doExportToArray($entity->get('parent')->entity) in Drupal\single_content_sync\Plugin\SingleContentSyncBaseFieldsProcessor\TaxonomyTerm::exportBaseValues()
• Instead of single content it is now exports all the content linked with no mechanism to stop it so it can result in hundreds of nodes instead of one.

Digging further, the module collects same entity multiple times so looks like it is cyclic until it runs out of memory or times out.

 array:2 [▼
  0 => "taxonomy_term"
  1 => "1336"
]
 array:2 [▼
  0 => "taxonomy_term"
  1 => "439"
]
 array:2 [▼
  0 => "taxonomy_term"
  1 => "1336"
]
 array:2 [▼
  0 => "taxonomy_term"
  1 => "439"
]
 array:2 [▼
  0 => "taxonomy_term"
  1 => "1336"
]
 array:2 [▼
  0 => "taxonomy_term"
  1 => "439"
]
 array:2 [▼
  0 => "taxonomy_term"
  1 => "1336"
]
 array:2 [▼
  0 => "taxonomy_term"
  1 => "439"
]

vladimiraus → created an issue.

Pushed to 5.0.x
needs review and testing.

All done. Thanks everyone. 🍻

vladimiraus → made their first commit to this issue’s fork.

Thanks for reporting @paulmartin84.
Committing now.

vladimiraus → changed the visibility of the branch 3428424-automated-drupal-11 to hidden.

Seems fixed.

phpstan is green.
Ready for review.

vladimiraus → changed the visibility of the branch 2.x to hidden.

Reviewed. Minor fixes added.

Documentation reviewed. One path issue found and fixed.

gargsuchi → credited vladimiraus → .

gargsuchi → credited vladimiraus → .

Created MR#45 that works with the latest version.
It does work for me, however if the button if not added to CKEditor, it kills the whole page still.

vladimiraus → changed the visibility of the branch ckeditor5-alt to hidden.

vladimiraus → changed the visibility of the branch 3274028-ckeditor-5-compatibility to hidden.

vladimiraus → changed the visibility of the branch ckeditor5 to active.

vladimiraus → changed the visibility of the branch ckeditor5 to hidden.

vladimiraus → made their first commit to this issue’s fork.

Added merge request.
+1 for merge

vladimiraus → made their first commit to this issue’s fork.

vladimiraus → changed the visibility of the branch 3435462-drupal-11 to active.

vladimiraus → changed the visibility of the branch 3435462-drupal-11 to hidden.

vladimiraus → changed the visibility of the branch 3435462-drupal-11 to hidden.

Asked on the Slack in #contribute.

vladimiraus → made their first commit to this issue’s fork.

Moved D7 down and will review existing guides.

Thanks @klemendev for details and testing.
Anyone else having similar issues?

vladimiraus → made their first commit to this issue’s fork.

Refactored help() functions so they have output defined and use only one return statement.

vladimiraus → made their first commit to this issue’s fork.

Cheers @liam morland
Test needs to be reverted as they were updated.

Thanks for opening the issue.

• Can you clarify other code-quality issues?
• I can not locate a patch to review

I would recommend a solution similar to views where we can toggle ajax / not ajax in config.

One of the reasons Ajax was removed is that it stopped working with media libraries and other Ajax dependent modules a while back.

Tested on 10.4. Ajax functionality is back, but styling for media library and clicking media library is broken.

One of the reasons Ajax was removed in 🐛 AJAX error when editing term content Postponed: needs info is that it stopped working with media libraries and other Ajax dependent module.

This issue was committed. Keep it close.
Cheers @klausi for opening 🐛 Restore term clicking AJAX functionality Active .

Added change record.

vladimiraus → made their first commit to this issue’s fork.

vladimiraus → made their first commit to this issue’s fork.

vladimiraus → made their first commit to this issue’s fork.

vladimiraus → made their first commit to this issue’s fork.

vladimiraus → made their first commit to this issue’s fork.

vladimiraus → made their first commit to this issue’s fork.

vladimiraus → made their first commit to this issue’s fork.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.

Drupal 7 is no longer supported.
Closing as outdated.