Needs more work.
- Define actions for views
- Upgrade path
VladimirAus → changed the visibility of the branch 3447956-show-publish-status to active.
VladimirAus → changed the visibility of the branch 3447956-show-publish-status to hidden.
VladimirAus → created an issue.
VladimirAus → changed the visibility of the branch 2.0.x to hidden.
Works well and tested on majority of the objects.
VladimirAus → changed the visibility of the branch 3334746-api-v3 to hidden.
VladimirAus → made their first commit to this issue’s fork.
VladimirAus → made their first commit to this issue’s fork.
Also fixed acknowledgement issue.
Committed! 🍻
Committed! Cheers 🍻
Committed! Thank you! 🍻
Looking good. Thank you for your contribution.
Thank you! Committed! 🥂
Committed! Thank you! 🍻
Thank you! Committed! 🧁
--no-interaction
was removed from versions 10 and 11. There is no option documented anymore.
Otherwise looks good.
Looks like phpstan
and php unit tests
need some love: https://git.drupalcode.org/project/user_registrationpassword/-/pipelines...
I'll add separate issue for phpcs
and eslint
.
VladimirAus → changed the visibility of the branch 3435290-automated-drupal-11 to hidden.
Looks good @mably! 🧁
Committing.
PHP Stan is good to go for Drupal 11.
PHPCS tasks were moved to
🐛
Create PHPCS fixes based on Gitlab CI
Active
.
VladimirAus → created an issue.
VladimirAus → changed the visibility of the branch 3434434-automated-drupal-11 to hidden.
Hello, I added Drupal 10 CKEditor 5 replacement page → for Media library.
Happy to maintain /core-modules-and-themes/core-modules/media-library-module/
or whole /core-modules-and-themes
guide.
VladimirAus → changed the visibility of the branch 3261924-avoid-warning-from-d11.0 to hidden.
Trying to bring all changed into new branch as pull from 11.x returns too many merge conflict. 🤷♀️
Also, changing branch to 11.0.x
That makes a bit more sense.
Ready for review.
PHPStan has only one issue and it depends on the other module.
Looks good. 🧁
Looks good.
Adding your name to the license? Why?
Please remove License file.
So, what's going to happen when someone would create cookieyes_scripts
module and then it will clash with this module?
The branch is fixed now. Thanks @apaderno.
However, the offer to maintain module for Drupal 10 and 11 still stands if maintainer @CookieYes won't reply.
Committed based on upgrade_status report!
Also removed license file as it is automatically generated by drupal.org.
VladimirAus → created an issue.
Thanks @apaderno 🍭
VladimirAus → created an issue.
VladimirAus → created an issue.
VladimirAus → changed the visibility of the branch 3445501-script-insert-d10-2 to active.
VladimirAus → changed the visibility of the branch 3445501-fix-js-location to hidden.
@apaderno please read issue description and create separate tasks for CI and help and other issues.
Namespace for drupal is cookieyes_scripts
, however namespace for the composer is cookie_consent_notice_by_cookieyes
.
If someone would create cookieyes_scripts
module on drupal.org, it would clash with this module hence the comment about namespace.
Hello, this module has couple of issues that prevents it to be used: #3445609: Naming of project/namespace is not up to convention → and #3445605: Gitlab: The default branch of this project clashes with another ref → .
The maintainer has no option to contact them.
I added comments to the above issues.
Please add me as maintainer if owner won't reply in the coming weeks.
I'm happy to maintain the module to resolve
#3445609: Naming of project/namespace is not up to convention →
and
#3445605: Gitlab: The default branch of this project clashes with another ref →
.
Cannot contact the maintainer so will create the issue.
Please the update MR.
VladimirAus → changed the visibility of the branch 3445609-naming-of-projectnamespace to hidden.
Looks good. Ready to be merged.
Merge conflict due to incorrect tag name that clashes with branches.
It crashed for me so it could at one point. 🤷♂️
No credits given?
Way to go! 👎
VladimirAus → created an issue.
Thank you! Committed! 🍻
Changes committed! Thank you! 🥂
Thank you! Committed! 🍻
Thank you! Committed! 🧁
VladimirAus → made their first commit to this issue’s fork.
Thank you! Committed! 🍻
Thank you! Committed! 🧁
PHPCS issues will be addressed in 📌 Fix the issues reported by phpcs Needs review .
Ready for review.
VladimirAus → changed the visibility of the branch 3434480-automated-drupal-11 to hidden.
Thank you! Merged! 🧁
Thank you all! Committed! 🍻
Thank you! Committed! 🧁
Thank you! Committed! 🍻
Thank you! Committed! 🍻
VladimirAus → made their first commit to this issue’s fork.
Great work! Thank you all! 🍰
Committed!
VladimirAus → made their first commit to this issue’s fork.
Thank you! 🧁
Committed.
@DECHEN DORJI: steps - remove code marked as deprecated. Example: https://git.drupalcode.org/project/shorthand/-/blob/4.0.x/src/Entity/Sho...
@thakurnishant_06: thanks for the commit. There is merge error.
Added header and footer screenshots.
- Updated animated screenshot to 10.2.6
- Added list of umami features
- Added information about umami theme
VladimirAus → created an issue.
- Added version note
- Added Drupal 10 screenshots
- Replaced example from Blocks (which no longer exists) to Views.
Minor spaces and highlighting fixes.
@nofue version 1.0.0 is no longer supported.
If you can replicate the functionality on current active version, feel free to reopen the issue. 🕯️
@Gurkawal: if you identified security issue, you should submit it
here →
.
If you are referring to
🐛
CSRF on delete url
Fixed
, it was fixed.
The following issues needs to be fixed:
Drupal\Core\Entity\EntityDeleteForm
should be be used.- PHPCS warnings
- Tests needs to be modified / added
Resolved MR conflict and added patches for D10 and D11.
VladimirAus → made their first commit to this issue’s fork.
PHPCs was fixed.
Created separate PHP Stan and PHP Unit fixes:
✨
Gitlab CI: PHP Stan and PHP Unit fixes
Active
VladimirAus → created an issue.
VladimirAus → created an issue.
@mortona2k - Delete conformation issue was opened here ✨ Paragraph delete should have confirm form Needs work . Merge requests are welcome!