- 🇦🇺Australia VladimirAus Brisbane, Australia
Thank you for your contributions.
Drupal 7 is no longer supported.
Closing issue as outdated.
The current GPT JavaScript implementation is not following Google's recommendations, it seems like a mixture of both synchronous and asynchronous code. This page provides examples of both modes. Please note that in asynchronous mode API calls are wrapped in googletag.cmd.push()
all the time.
Current implementation has the .enableServices()
call outside of that wrapper which may result in firing ads before all the configuration has occurred. When in synchronous mode, there should be no wrapper at all.
Also, the Google examples use an inline snippet for asynchronous loading of gpt.js to maximise comaptibility which could work fine with every browser where the async attribute is not supported.
I suggest to fix the inline code first as per the recommendations and then offer the option to switch between synchronous and asynchronous loading.
Please study the attached example code files and see how the syntax changes compared to the current implementation (also attached).
googletag.cmd.push()
)googletag.cmd.push()
)googletag.enableServices();
Closed: outdated
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Thank you for your contributions.
Drupal 7 is no longer supported.
Closing issue as outdated.