Proposing a 7.x-2.x branch

Created on 12 April 2017, over 8 years ago
Updated 20 July 2025, 8 days ago

Problem/Motivation

I would like to propose a 7.x-2.x branch to the DFP module.
This will clean up the JS necessary to render ads making it easier to inject your own custom JS via files vs the textfields that are available now in 7.x-1.x.

Proposed resolution

I've moved all the JS being generated inline to Drupal settings and provided files to replace the inline JS.
I have also added a simple way to add JS for google tag manager vs https://www.drupal.org/project/google_tag β†’ . Not saying this is a replacement, just an easy way to add the necessary JS (see https://developers.google.com/tag-manager/quickstart) that requires only a simple container ID.

The discussion began here: https://www.drupal.org/node/2629154 β†’

* The patch involved in the update removes the existing form elements that allow adding JS via textfields.

🌱 Plan
Status

Closed: outdated

Version

1.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States scottalan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024