Account created on 16 May 2011, over 14 years ago
#

Merge Requests

More

Recent comments

🇨🇦Canada joseph.olstad

We're deep into the third minor of Drupal 11 (the first being 11.0.x, second 11.1.x and the third 11.2.x)

It's time to release a this module for Drupal 11 please!

🇨🇦Canada joseph.olstad

Email sent August 15th at 10h54 AM mountain time.

Used d.o contact form.

Hello @mxrtinax,

Your excellent module has a high priority outstanding issue. Drupal 11 compatibility! There's a merge request available. Please merge this asap and please tag a new release.
https://www.drupal.org/project/search_api_html_element_filter/issues/343... 📌 Automated Drupal 11 compatibility fixes for search_api_html_element_filter Needs review

Also there's an important performance optimisation available also that I would recommend merging and including in this release.
https://www.drupal.org/project/search_api_html_element_filter/issues/347... 🐛 Slowness - postprocessSearchResults Active

So, two merge requests are waiting for you.

If you would like assistance with this module please assign me as a co-maintainer. My username is joseph.olstad.

Thank you,

🇨🇦Canada joseph.olstad

Omg, yes we need this Drupal 11 fix. I'll ping someone in my circles.

🇨🇦Canada joseph.olstad

Release v4.0.91 is the release that will have the fix.

🇨🇦Canada joseph.olstad

Justification:

  1. The solution is in scope
  2. Has tests
  3. Tests are passing
  4. Tests only fails
🇨🇦Canada joseph.olstad

It would be nice if the page_manager module provided a hyperlink to this translation page from the variant page. Very helpful to find this.

🇨🇦Canada joseph.olstad

The block title is translated through the config translation interface, check it at /admin/config/regional/config-translation/page_variant in your site. The core "Configuration Translation" module is required.

🇨🇦Canada joseph.olstad

I've illustrated this quite vividly in the attached mp4 video with audio.

https://www.drupal.org/files/issues/2021-10-25/drupal_org_core_issue__31...

Two runs in the video, one without the patch, the next with the patch.

🇨🇦Canada joseph.olstad

I added a comment to the PR 34 in wxt_bootstrap. We can test this out a bit more and see what happens in wild environments.

🇨🇦Canada joseph.olstad

We split the check button out from that other issue to make it easier to review.

🇨🇦Canada joseph.olstad

We're also using this patch, I'm not sure if it's needed for the check button functionality though, might be overkill.
#3212816: Interval of 86400 (one day) is impractical for debugging using GUI

We're also using other linkchecker patches that are unrelated to this.

🇨🇦Canada joseph.olstad

lazzyln

Travail impeccable sur ce module.

@joel_pittet propose une amélioration pertinente.

🇨🇦Canada joseph.olstad

Hmm, ok sorry I mis-read the issue title, this isn't a duplicate.

🇨🇦Canada joseph.olstad

Setting as a bug report since a hook_update could easily deal with the second upgrade related issue which is to clear out and re-analyze the links.

🇨🇦Canada joseph.olstad

The latest change made in comment #47 and #48 breaks automated testing, the pipeline fails and phpcs fails.

I'll make a new MR that excludes this change

🇨🇦Canada joseph.olstad

setting to 2.1.x
(what is 3.0.x)? maybe 3.0.x instead?

🇨🇦Canada joseph.olstad

@lee.cocklin, thanks for creating this issue and for the patch. I made changes as mentioned (phpcs fixes and rebase to linkchecker instead of your Drupal project) and created a merge request which triggers the pipeline.

Everything shows up green in the pipeline.

🇨🇦Canada joseph.olstad

phpcs is green, phpunit tests are also passing

🇨🇦Canada joseph.olstad

Ok, that patch was not made from a clone of linkchecker , it was made from someones drupal repo. Cleaned it up and preparing a merge request.

🇨🇦Canada joseph.olstad

joseph.olstad made their first commit to this issue’s fork.

🇨🇦Canada joseph.olstad

@imclean , ya when you're using the above merge request or patch there's a "Check links" button which when pressed will check links. This means you won't have to wait for cron which is often set as weekly on a set interval for instance. No waiting, want it to happen right now then click the button.

🇨🇦Canada joseph.olstad

Ok, I had another look at the recent changes. Nothing shocking. Must be upstream issues causing the pipeline failures.

🇨🇦Canada joseph.olstad

Serious chaos has happened with layout_builder_st
we had @phenaproxima running things, he ended up doing a build of 2.0.x that we have been using successfully with Drupal 11.1.8

Now I see the latest 2.0.x won't even run testing as it says this:

8) Drupal\Tests\layout_builder_st\Functional\Rest\LayoutBuilderEntityViewDisplayJsonBasicAuthTest::testGet
Unable to install modules: module 'layout_builder_st' is incompatible with this version of Drupal core.

@phenaproxima basically did some heavy modifications from 1x to 2.0.x. It was functional and we have been using it since several months. However there's now been a major reversal on the approach, a new maintainer, did you guys even have a discussion before handoff .

Here's what we have been using with Drupal 11.1.8

            "name": "drupal/layout_builder_st", 
            "version": "dev-2.0.x",
            "source": {
                "type": "git",
                "url": "https://git.drupalcode.org/project/layout_builder_st.git",
                "reference": "68f690c8fb7a679128deaa22bc3d5f0272caec18"
            },
            "require": {
                "drupal/core": "^10 || ^11"
            },

with these patches

                    "drupal/layout_builder_st": {
                        "3411037 - Fix core removing contextual translation links": "https://git.drupalcode.org/project/layout_builder_st/-/merge_requests/5.patch", 
                        "3420063 - Call to a member function getConfig() OverridesSectionStorage.php": "https://git.drupalcode.org/project/layout_builder_st/-/merge_requests/6.diff",
                        "3069964 - Null fix for moderation dashboard, otherwise WSOD on login": "https://www.drupal.org/files/issues/2025-01-02/3069964-null-fix.patch"
                    },
🇨🇦Canada joseph.olstad

How does this MR help

We don't have to wait a week for cron to re-scan when we're testing out linkchecker releases and or other patches.

🇨🇦Canada joseph.olstad

Please upgrade to 2.0.1-rc1 and let me know how it works out for you. I won't tag 2.0.1 until I get at least some statistics on usage or some kind of feedback.

🇨🇦Canada joseph.olstad

Please upgrade to 2.0.1-rc1 and let me know how it works out for you. I won't tag 2.0.1 until I get at least some statistics on usage or some kind of feedback.

🇨🇦Canada joseph.olstad

Please upgrade to 2.0.1-rc1 and let me know how it works out for you. I won't tag 2.0.1 until I get at least some statistics on usage or some kind of feedback.

🇨🇦Canada joseph.olstad

Please upgrade to 2.0.1-rc1 and let me know how it works out for you. I won't tag 2.0.1 until I get at least some statistics on usage or some kind of feedback.

🇨🇦Canada joseph.olstad

Please upgrade to 2.0.1-rc1 and let me know how it works out for you. I won't tag 2.0.1 until I get at least some statistics on usage or some kind of feedback.

🇨🇦Canada joseph.olstad

That said, I'm curious as to how you are using this MR. Are you checking internal, external or both types of links?

We're checking both types of links.

How does the MR help?

We're clicking the re-analyze button (a real Snoozer) before clicking the "Check links" button (another snoozer).

🇨🇦Canada joseph.olstad

Ok, seems like there's something I could do to improve this situation however I'm not sure as to what the root cause of it is other than "something" in the bootstrap "3x" theme in combination with "some" version of core and likely "some combination" of other modules and or specific configuration.

These are basically symptoms listed above with a workaround.

Good that there's a workaround however so I appreciate everyones feedback and attention here.

🇨🇦Canada joseph.olstad

For us we want to do a full scan with button press without waiting for cron.

Sounds like #26 is a new feature requests. Should be a new issue.

🇨🇦Canada joseph.olstad

Please try release 3.38

if there's still an issue let me know asap.

🇨🇦Canada joseph.olstad

Ok, I published version 3.38

should be ok.

This conflict can be avoided simply by the change of removing entreprise7pro/bootstrap from the composer.json of bootstrap 3.38 which I have done.

There's no real need for this due to the way that the theme code works.

https://www.drupal.org/project/bootstrap/releases/8.x-3.38

🇨🇦Canada joseph.olstad

composer why drupal/bootstrap_library

?

bootstrap_library , why are you using this?

I suggest you uninstall the bootstrap_library module. It is not needed.

We can add a conflict with bootstrap_library.

🇨🇦Canada joseph.olstad

Hi @m_i_c_h_a_e_l , you will be way further ahead by starting from Drupal CMS.  There's more and more recipes for it and these recipes save a lot of time making best practices decisions for you and starting everything off with the best possible defaults that are more than just defaults they're curated configurations that are now called recipes.  

Drupal CMS is about making it easier and more fun for those that aren't full time Drupalistas like some of us.  It's meant to be easy and it is.

🇨🇦Canada joseph.olstad

ah wow it's late (or very early), actually I tested again and the EventSubscriber and hook approach are doing the same exact thing. Both are not doing what I want­.

🇨🇦Canada joseph.olstad

This was related to my case, attributes were not getting through into emails when tokens were used.

For those using the "message" module.

🐛 Unable to use inline styles when tokens are used in a message (patch provided) Needs review

🇨🇦Canada joseph.olstad

Please create a merge request with an update to the README.md

🇨🇦Canada joseph.olstad

Best thing would be to pin this workaround as a note on all 2.1.x and 3.0.x release notes and add it to the README.md.

🇨🇦Canada joseph.olstad

Yes please manually perform the workaround. I'm not sure of a better way at this time that would work for everyone as some folks may still need dynamic_entity_reference.

It's a catch 22 here.

Then have a celebration for no longer needing dynamic_entity_reference! A significant simplification!

🇨🇦Canada joseph.olstad

joseph.olstad made their first commit to this issue’s fork.

🇨🇦Canada joseph.olstad

yes thanks, the ai_ollama_provider works well, I tested it last week!

🇨🇦Canada joseph.olstad

Also, I'm hesitant to move forward on this until 2.0.1-rc1 becomes 2.0.1 . Currently I see zero usage on 2.0.1-rc1 so I will be waiting a while yet.

https://www.drupal.org/project/toc_api/releases/2.0.1-rc1

🇨🇦Canada joseph.olstad

hmm, looks good however I have no cycles to test this or to confirm the approach at this moment.

I'll let this simmer and see how many others start using it.

🇨🇦Canada joseph.olstad

Hi @danrod, that's great, now migrate_tools, entityqueue and panels have the issue numbers but still looking for field_group issue number and page_manager issue number (if there is).

Production build 0.71.5 2024