🇨🇦Canada @joseph.olstad

joseph.olstad → created an issue.

@vladimiraus I appreciate your assistance on this. Have you tried it yourself yet with D11.0.3 ?

The phpstan errors are due to d.o pipeline stricter and stricter test settings for Drupal 11 that are causing this.

They're asking for dependency injection in various spots.

verbatim as MR 66

I've got bootstrap 3 functioning on Drupal 11.0.3

Instructions and illustrations here:

#3428283-38: Automated Drupal 11 compatibility fixes for bootstrap →

Next step is to make it work with wet-boew.

This might eventually require forking wet-boew just as I have forked bootstrap.

Ok, so here's the steps to get Bootstrap working with D11:

Install the latest Drupal 11

• mkdir web/themes/contrib
• cd web/themes/contrib
• git clone git@git.drupal.org:project/bootstrap.git
• git fetch "git@git.drupal.org:issue/bootstrap-3428283.git" 'project-update-bot-only'
• git checkout -b 'bootstrap-3428283-project-update-bot-only' FETCH_HEAD
• install the bootstrap theme from the web ui
• Go to bootstrap settings /admin/appearance/settings/bootstrap
• look for the CDN settings
• Change the provider to "Custom"
• review the Custom URLs, place these ones in if they're not correct.
  

  https://cdn.jsdelivr.net/gh/entreprise7pro/bootstrap@v3-dev-6/dist/css/bootstrap.css
  https://cdn.jsdelivr.net/gh/entreprise7pro/bootstrap@v3-dev-6/dist/css/bootstrap-theme.css
  https://cdn.jsdelivr.net/gh/entreprise7pro/bootstrap@v3-dev-6/dist/js/bootstrap.js
  

  →

1. hit the apply button
2. press save configuration

→

working through some issues, I'll try to slow down the noise here.

Sorry, somehow I missed this. I'm a bit apprehensive about radical new changes to the bootstrap project.

I am one of the co-maintainers of bootstrap and I lack permissions to edit the project page.

It seems that this project is being pulled into several directions.

My priority right now is Drupal 11 compatibility for the 8.x-3.x branch.

Perhaps all of the current co & full maintainers should set up a meeting to discuss what is going on and make sure that we have some common goals.

I've already been preparing a version of the bootstrap 3.x library that aims to be compatible with jQuery4. It is currently undergoing testing. cdns are already available.

https://bootstrap.7pro.ca

@alexpott ,

On translations of an entity a core message advises us to edit the non-translateable fields on the source language. The test code included with this MR illustrates a lack of validation to this effect. Translation functionality for contrib entities such as "Paragraphs" is otherwise broken. While core node entities do not have this problem by themselves, when other entity types such as "Paragraphs" are used with nodes, this issue surfaces.

Currently there is no other known solution.

The tests-only fail illustrates where the failure occurs. All tests pass with the MR code in it's entirety.

greggles → credited joseph.olstad → .

The title accurately describes what leads us to this issue.

Patch 112 is incorrect, it is missing a change.

Here is a link to the MR patch https://git.drupalcode.org/project/drupal/-/merge_requests/9429.patch

Please review the 2.0.x dev and 3.0.x dev

Thanks for the fix!

I'll do my preliminary review, the issue description seems wrong. The hook in question is this:
hook_action_info_alter() appears to be a Drupal 7 api.

I've pushed up an MR with the removal of this hook, needs review.

Ok, gotcha!

If you know of any security vulnerabilities, pleasr let me know where to find them! If they affect current supported jQuery3/4 with bootstrap 3, then they'll be dealt with, if it's for older versions only, then no.
Keep in mind, I already gutted IE support which actually went well, was pretty straight forward.

1. MR has tests
2. MR pipeline passes tests
3. MR pipeline tests-only test is failing as expected
4. Patch is fixing this issue in the wild

Safe to say we can rely on php8 +, php 7.4 is officially unsupported by Symfony based Drupals. This module is for D10/D11 not D8.
Therefore, I have no objection to the objection. With that said, I'm ok with strpos. I myself am hooked on strpos but str_contains is far easier to understand and reads better.

With that said, the pipeline is currently failing, would appreciate some assistance fixing that.

based on latest report

Pipeline for MR 9429 passed and is green (YAY!).

https://git.drupalcode.org/issue/drupal-3025039/-/pipelines/276042

Running the tests-only job now, normally expect it to fail.

https://github.com/wet-boew/wet-boew/issues/9808

wow very strange comment #23 vanished.

I've figured out how the cdn works, but I haven't added it to the docs, here it is:

css: https://cdn.jsdelivr.net/gh/entreprise7pro/bootstrap@v3-dev-2/dist/css/bootstrap.min.css
css_theme: https://cdn.jsdelivr.net/gh/entreprise7pro/bootstrap@v3-dev-2/dist/css/bootstrap-theme.min.css
js: https://cdn.jsdelivr.net/gh/entreprise7pro/bootstrap@v3-dev-2/dist/js/bootstrap.min.js

Also made a host for the docs.

https://bootstrap.7pro.ca/

Ok I've spent some time on the fork, upgraded bootstraps javascript to accept jQuery 4. I removed nearly all microsoft IE support from the entire branch. I am able to compile all of this, it is compiling and I have compiled it and pushed it up and made a github release of bootstrap and called it v3-dev-1
the actual release once it's tested and people are happy with it will be 3.4.2

Here's the zip file you can try out, with the dist folder has the compiled js and css
https://github.com/entreprise7pro/bootstrap/archive/refs/tags/v3-dev-1.zip

There's also the same thing in tar.gz
https://github.com/entreprise7pro/bootstrap/archive/refs/tags/v3-dev-1.t...

Hi @jncventura, ok, do you have a github account? Perhaps I can grant you admin access to my fork.
BTW
https://github.com/entreprise7pro/bootstrap/archive/refs/tags/v3-dev-1.zip

I appreciate folks helping to review this build of bootstrap against Drupal 11.

Thanks

I'm working on a 3x fork, the main branch is the v4/v5 stuff, v3-dev is the 3x dev branch, I'll set this as the default branch shortly.
Fork is here:
https://github.com/entreprise7pro/bootstrap

@jncventura, perhaps I'm missing something however radix is already doing something similar to what I'm suggesting we do. With that said, there's maybe a manual step that the radix project does. The Bootstrap license is an MIT License, which afaik, is compatible with Drupal licensing. Perhaps there's a nuance I'm missing here?

Ok, thanks for that @jcnventura.

We'll 100% for sure have to fork twbs bootstrap and remove that version check and any IE11/IE10 specific js code, should be a fairly easy task.

Suggest that we add a contrib module , example, call it bootstrap3, in there would be the build sources and compile instrucitons, this is where we'd have the new version of bootstrap and it would generate an optimized min js that we'll consume and add as a dependency for use by the bootstrap theme.

Some refactoring involved, I am imagining that this is 100% do-able.

The radix theme actually includes bootstrap sources in it's builds, we could do something similar to what radix does but I think to align with how we've been doing things for years and to avoid hacks (radix can get messy), I'm suggesting putting it in a support module called bootstrap3 (for example).

ah, excuse me, ya it really is that simple.

actually, one more patch

Ya, I had another look at the change notice, this is something trivial, just some cleanup for a D7 views attribute that was never working in D8+ views.

Related change notice →
see patch 8 above

@smulvih2,
please review patch

Ok, if it's just this, then it's trivial.
There may be more to this however.

ah ok, I'm not aware of anything terribly broken in 5.2.x relating to this however ya, it seems like I've seen reminents of this in config export diffs.

From my searches of our code base, this change is appears to be quite extensive and non-trivial.

Perhaps target this for 5.3.x instead of 5.2.x with option of deferring to 6.0.x

The actual patch code it hasn't changed in several years.

with that said, all that is left is test coverage and that won't affect anyone using it.

6 years and still counting

@recrit, it's possible to use the automatically generated patch from gitlab

joseph.olstad → created an issue.

Pipeline seems to have gone bonkers.

Undefined variable: $this

Makes no sense.

Oh thanks yes I missed that, here it is: https://git.drupalcode.org/project/wxt/-/commit/99cc0c5a77

PHPUnit version 10 deprecations forced a couple changes to the test to the MR9429

The MR 9429 patch is a reroll of patch 94, almost identical except for some fuzz.

MR9429 is targetting 11.x , the others were tainted/OR not targetting 11.x and tainted with unrelated commits and noise.

MR9429 is clean and only includes the desired changes with the new test case.

MR 1105 , I am unable to correct the branch, it should be for an 11.x merge

I'll create a new MR for 11.x

Merged the latest 11.x into MR1105

Pushed up the fix that was added in patch 94

We've hit this on a project that uses D10.2.5 and the paragraphs module.

The patch has tests.

We're currently reviewing patch #94 which so far is helping.

needs to be pushed into github upstream

@smulvih2, please push this to upstream

@smulvih2 , please push to upstream , let's see what the pipeline does.

Hmm, ok I pushed it into gitlab however it also has to go into github for the pipeline to be triggered.

Hmm, ok, sounds good, seeing as this is for behat code, if it does fail it'll fail in the pipeline.

Fixed in 5.3.x

https://git.drupalcode.org/project/wxt/-/commit/d82c0488f

Creditted also.

@jcnventura , you mentioned/claimed above in comment #12 📌 Automated Drupal 11 compatibility fixes for bootstrap Active that bootstrap 3.4.x is not compatible with jQuery 4, however have you actually proven/tested this to be not compatible with jQuery 4?

A current twbs bootstrap maintainer suggested to test it as it "might" already be compatible with jQuery 4.

Apparently jQuery 4 is very compatible with jQuery 3, most of the deprecations are related to legacy browser support for browsers such as IE11 and older browsers.

It may actually prove to be a fairly small effort to get things going with jQuery 4. Step 1 is to test it as-is.

This should actually go into the 6.0.x branch which hasn't yet been created.

I would have to check, this change is likely not necessary and might actually cause an exception.

Entity query example:

\Drupal::entityQuery('node')
  ->accessCheck(FALSE)

Here's the original change notice. No mention of entityTypeManager

https://www.drupal.org/node/3201242 →

Has someone created a similar solution for D10/D11 yet?

if not, maybe try using this:

https://www.drupal.org/project/drupalmoduleupgrader →

Use drupalmoduleupgrader with Drupal 9.5 and approximately PHP 8.0 and it's drush command to convert a module from D7 to D9, from there, you'll get 80% of the way to D9 and just need 20% to convert to Drupal 9, once it's been modified to be fully working on Drupal 9, there's the upgrade_status → module that offers a set of drush commands that can be used to upgrade the module from D9 to D10 and then from D10 to D11

This is probably still needed, there are still many important D6/D7 only projects that would still be very useful for D10/D11 and beyond

ah, maybe not

This is already fixed in 2.x-dev

greggles → credited joseph.olstad → .

Ok wow, the phpmailer library makes this too easy. Simply include an <img src="data:base64:xyz"> element, it's auto converted to a file attachment and the src= value changes to cid:phpmailer-0something automatically. something that Outlook can consume.

Magic happening here!

Would be great to have a bit of background with this along with some simple documentation.

I'll be digging more into this tomorrow and run some more indepth tests.

I scoured d.o for related documentation, it is very light.

I've dug a bit more into the PHPMailer library and it is starting to possibly make sense.

I'll try a few things soon and see how it goes.

Great, is ck4 still usable?

Thanks for this, I've merged patch 7 into #3469258-24: Multiple dialogs open / have to click multiple times →
where I've added a description of the fix.

I've tested the latest patch #23 with the improvements from 3395581 merged in and:

Use case:

Open two browser windows, same session

• Keep activity going on the right side window (manually) on my right screen, do not touch left screen.
• As long as the activity is performed before the 30 minute timeout, the time dialog does not show up on either tab, once it's openned however, it doesn't close other dialogs that may be opened if the session timeout has elapsed there could be two dialogs openned at the same time but each doesn't know about the other.
• The good part is, that dialog won't show up as long as there is activity in "one" of the open tabs/windows before 30 minutes (session limit).

Summary:

I think this is good enough for now, as a followup issue we can make a new ticket to investigate closing other possibly open dialogs by pressing OK on one of them.

new patch

Pretty sure this is a bug in the VBO module, possibly related to the D7 version, however if you can prove otherwise then please let us know.

Thanks everyone!

https://www.drupal.org/project/libraries/releases/4.0.5 →

You might want to try version 2.0.6

also, it's good to read the README.md

https://git.drupalcode.org/project/view_custom_table/-/blob/2.0.x/README.md

VIEWS CUSTOM TABLE

CONTENTS OF THIS FILE

1. Introduction
2. Requirements
3. Installation
4. Configuration

INTRODUCTION

The Views Custom Table module gives the functionality to integrate your custom
table to views. So you can use strong features of the views for your custom
table. This module use hook_view_data() to implement functionality.

For a full description of the module, visit the project page:
https://www.drupal.org/project/view_custom_table →

To submit bug reports and feature suggestions, or to track changes:
https://www.drupal.org/project/issues/view_custom_table →

REQUIREMENTS

This module requires the following modules:

Views (Drupal Core)
Views UI (Drupal Core)

INSTALLATION

Install as you would normally install a contributed Drupal module. Visit:
https://www.drupal.org/docs/extending-drupal/installing-modules →
for further information.

CONFIGURATION

Configure user permissions in Administration » People » Permissions:

Add custom table in views

• Give user access to add his custom table to the system.

Administer all custom table in views

• Give user access to administer all the custom tables, added by all the users

Administer own custom table in views

• Give user access to administer own custom tables

Manage custom tables in Administration » Structure » Views » View CustomTable menu.

Alternately, there's instructions on the project page: →

How to use:

1. Download and extract files in module folder.
2. Enable module from module list
3. Go to Home » Administration » Structure » Views » View Custom Table
4. Add your custom table in system using "Add Custom Table" link
5. Add Relationship with drupal entities if any, otherwise leave none.
6. Clear drupal cache
7. Add a new view and you will see your custom table name in "Show" drop-down field.

@heikkiy , we have noticed exactly what you described.

The patch from comment #50 fixes the problem.

If it's configuration related, you could compare with our configuration:

enabled: true
timeout: 60
max_timeout: 172800
padding: 30
logout_regardless_of_activity: false
no_individual_logout_threshold: true
role_logout: false
role_logout_max: false
redirect_url: /
include_destination: true
no_dialog: false
message: 'We are about to log you out for inactivity. If we do, you will lose any unsaved work. Do you need more time?'
inactivity_message: 'You have been logged out due to inactivity.'
inactivity_message_type: status
modal_width: 450
enforce_admin: true
jstimer_format: '%hours%:%mins%:%secs%'
jstimer_js_load_option: false
use_alt_logout_method: false
use_watchdog: true
dialog_title: 'Autologout Alert'
disable_buttons: false
yes_button: ''
no_button: ''
whitelisted_ip_addresses: ''
cookie_secure: true
cookie_httponly: false
cookie_samesite: Lax
cookie_lifetime: 31536000

@dan.d , when I was testing this firefox would not let go of the cached autologout.js for some reason. Can you please re-try in a different web browser completely (other than the one you normally use?) ?.

It could be cache related. This functionality is working for us.

With that said, I have other patches.

            "drupal/autologout": {
                "3308456 - Secure attribute for cookie.": "https://www.drupal.org/files/issues/2024-08-14/3308456-30.patch",
                "3456716 - TypeError LoggerChannelInterface.": "https://git.drupalcode.org/project/autologout/-/merge_requests/62.patch",
                "3469258 - Multiple dialogs open.": "https://www.drupal.org/files/issues/2024-08-27/3469258-17.patch",
                "3372010 - Undefined array key in AutologoutSubscriber->onRequest().": "https://www.drupal.org/files/issues/2024-06-18/autologout_3372010-29.patch"
            },

You might want to re-try using all of these patches.

Just updated ckeditor4_codemirror , 7000+ installs.
https://www.drupal.org/project/ckeditor4_codemirror/releases/1.0.5 →

Hello, I was pinged about this outstanding issue and noticed that the most recent release was tagged and released by myself. However I just checked and noticed that I'm no longer listed as a maintainer on this project. So it looks like someone removed me as a maintainer without telling me. Anyhow, good luck!

╭─◀ ☕ j olstad ▶ ~/drupal.org/phpmailer_smtp ▶ 📂4 📃12 🔗0 ▶ 🔀 2.2.x ▶
╰❯ $ grep cid * -iR
README.md: prevent you from accidentally sending out e-mails to real users from a

Hello @imclean,
I grepped the entire codebase of phpmailer_smtp , no documentation on cid, no code mentioning cid and I didn't find any documentation on this subject relating to the phpmailer_smtp module.

Hmm, not sure how I created this twice, oops

joseph.olstad → created an issue. See original summary → .

joseph.olstad → created an issue.