Account created on 16 May 2011, over 14 years ago
#

Merge Requests

More

Recent comments

🇨🇦Canada joseph.olstad

How close are we or far away are we from the goal of making code generated Drupal 10 compatible?

This module has been quite helpful in the past with custom modules especially or is there another way to use the rector on custom modules and custom themes?

It is still very useful for projects that are far behind and that need to be brought forward.

🇨🇦Canada joseph.olstad

Needs to be redone. Conflicts.

🇨🇦Canada joseph.olstad

@pobster, if you find a solution for this it would be great and we'll try again for version 3.7!

🇨🇦Canada joseph.olstad

I don't have this on the agenda however if someone has a patch to submit , please open a new issue and create a merge request.

🇨🇦Canada joseph.olstad

I believe a composer up resolves this.

I did see it myself but no longer see it after we upgraded.

🇨🇦Canada joseph.olstad

We've added new functionality that is likely a good solution for this.

We added a new sub module called safedelete_menu_report

What this module does is provide archived parent and orphaned children list

Add safedelete_menu_report submodule - provides archived parent and orphaned children list Active

The safedelete module also provides an orphaned node report straight from the safedelete module.

🇨🇦Canada joseph.olstad

Thanks, we'll put this through it's paces today again. Re-test everything and knock on wood.

https://www.drupal.org/project/ckeditor5_table_fix/releases/1.0.4

🇨🇦Canada joseph.olstad

FYI, a change was made related to the handling of caption elements, appears to still be working.

https://git.drupalcode.org/project/ckeditor5_table_fix/-/merge_requests/...

🇨🇦Canada joseph.olstad

Thanks @neslee canil pinto and @podarok!

🇨🇦Canada joseph.olstad

Thanks @baikho for this fix.

🇨🇦Canada joseph.olstad

Adding related issue in case a regression is detected, it will be easier to unwind later.

🇨🇦Canada joseph.olstad

joseph.olstad made their first commit to this issue’s fork.

🇨🇦Canada joseph.olstad

ok , test failures are due to the code changes. It's likely the automated tests need to be re-aligned for the updated functionality.

With that said, someone needs to review the patch file from MR 44 and explain the changes, review the changes and confirm that this is correct.

🇨🇦Canada joseph.olstad

Hmm, ok test failures could be caused by 11.2.x
running new tests.

🇨🇦Canada joseph.olstad

Need to fully understand the changes and evaluate what changes and or automated testing changes may need to be done.

🇨🇦Canada joseph.olstad

@podarok, there's an easier/faster alternative . I've done this for jq_ui and livre

Here's a bit of background on it.

https://a1.11pro.ca/en/public-documentation/drupalorg/dx-composer-replac...

I'll probably do some more tests in the next 6 months and come up with an even easier instruction set.

🇨🇦Canada joseph.olstad

I brought this into livre also, just pulled from this upstream of 3.0.x into my origin livre 1.0.x.

https://www.drupal.org/project/livre/releases/1.0.0-beta4

🇨🇦Canada joseph.olstad

I'll sort this out hopefully in the next month or two.

🇨🇦Canada joseph.olstad

ok I have been developing this simple_crop module with a copy of drupal cms 1.x from July 2025 or so.

Might explain some of the weirdness.

🇨🇦Canada joseph.olstad

ok finally, I have some patches.

Silently failing with the book 3.0.x code due to changes in the way they implemented it. Now they expect ->getBook to be called not ->book

This is a partial fix not fully done yet.

Testing with:

composer require drupal/livre

OR

use the merge requests listed above. Preferring livre right now for my testing.

And these patches, first is for wxt_bootstrap

next is for wxt_ext_book

See both patches

🇨🇦Canada joseph.olstad

The important book patch was inadvertantly removed back in 2024 during commit 591824aef9 between 5.1.1 and 5.2.0

🐛 restore non book bundle solution to wxt-6.1.x Active

🇨🇦Canada joseph.olstad

The module currently is functional however it isn't 100% complete according to my plans.

🇨🇦Canada joseph.olstad

Hi @bmango, thanks for the report, I'll fix this soon. For now, you can unzip or untar the module to try it out. Or clone it into your contrib folder.

🇨🇦Canada joseph.olstad

Please tag this for a Drupal 11 release. It's been two years now without a tagged release.

https://www.drupal.org/project/youtubechannel

🇨🇦Canada joseph.olstad

The maintainer is alive.

https://www.drupal.org/project/site_alert/releases/8.x-1.4

1.4 was released supporting Drupal 11!

Thanks

With that said, there's some other things I'd do if I was maintainer of this project.

TODO

  • Add a link to the project page of site_alert to urge new installs to choose the more popular sitewide_alert module instead
🇨🇦Canada joseph.olstad

8 days to go

🇨🇦Canada joseph.olstad

I'm also looking to disable auto-submit.

🇨🇦Canada joseph.olstad

Basically not needed now, Livre 1.0.x is compatible with Drupal 10.5.x, Drupal 11.1.x, Drupal 11.2.x and Drupal 11.3.x and is based off of the 3.0.x branch of the Book module.

Keeping an eye on the upstream for changes, will ensure git aligns when possible.

🇨🇦Canada joseph.olstad

moving this back to 3.0.x since this issue is closed and my related merge request for 2.0.x was rejected.

🇨🇦Canada joseph.olstad

I'm evaluating the 3.0.x functionality as it pertains to this feature. I'm seeing the same/similar result to what I saw with a modified version of @sylus patch from #3173808-26: Make book child content-type configurable per enabled book content-type (not seeing the next/previous buttons in the footer)

In my testing of 3.0.x, I'm not seeing the next/previous buttons in the footer.
I'll be doing extensive testing and work on this in the comming 24 hours where I'll set up vanilla Drupal 11.2.5, Drupal 11.1.8 and Drupal 10.4.8 with the 3.0.x functionality and see if I can find a winning recipe and or make adjustments if necessary.

Might just require a totally vanilla setup in my testing so I'll baseline it and go from there.

🇨🇦Canada joseph.olstad

joseph.olstad changed the visibility of the branch 3554905-merge-3.0.x-into-2.0.x-with-fixes to hidden.

🇨🇦Canada joseph.olstad

joseph.olstad changed the visibility of the branch 3554905-full-backport to hidden.

🇨🇦Canada joseph.olstad

joseph.olstad changed the visibility of the branch 3554905-cleaner-backport to hidden.

🇨🇦Canada joseph.olstad

Next commit will add test coverage for 10.5.x

🇨🇦Canada joseph.olstad

@smustgrave, prior to me fork/replacing the book module, any feedback on this is appreciated. It's 100% passing, all green!

🇨🇦Canada joseph.olstad

Houray 100% green!!!! party time!

Production build 0.71.5 2024