🇨🇦Canada @joseph.olstad

Duplicate of 📌 Automated Drupal 11 compatibility fixes for chart_suite Needs review

3461574 is in better shape, adjust status for 3429121

joseph.olstad → made their first commit to this issue’s fork.

Found a deprecation issue caused by wet-boew.js

working on a PR for wet-boew now. I'll test a build first.

https://github.com/wet-boew/wet-boew/issues/9851

please add the tests to the MR in #3435672

This is almost ready to go in for the Drupal 11 upgrade except the maintainer has asked for additional tests to be written covering operations based on the given permission.

📌 Automated Drupal 11 compatibility fixes for webform_revision_ui Needs review

So, needs more tests.

ok @jurgenhaas, I'll have to go through the test scenarios manually in my environment. Hopefully some time this week or next week!

Thanks for your work on this!

Thanks Adam, and yes good idea for the supported versions!

Upgrading now from my override to the new release! :)

The test failures are related to a test that checks the default configs, the new accept_null option that defaults to false is unexpected by the test so there's some adjustments to be made to resolve that.

Then there's the two additional tests as requested by @smustgrave

so basically 3 remaining items to resolve.

1. fix existing tests for default configs expected values
2. test coverage for the boolean operator handling 'accept_null' or 'accept null'
3. test coverage for the update hook

Ah yes the dynamic property! Love those!

Awesome! Thank you very much!

tests are passing

I'm running this merge request right now in Drupal 11.1.1 using a composer override and all the bigmenu functionality is working as designed (including the breadcrumb and children)!

@jibran, we're already testing anonymous and editor in new tests

https://git.drupalcode.org/project/webform_revision_ui/-/merge_requests/...

@smulvih2,

reminder, since we're using overrides, the namespace of patches needs to follow suit.

What I'm doing is this:

            "drupaloverride/layout_builder_st": {
                "3420063 - Fix getConfig() on null in OverridesSectionStorage": "https://www.drupal.org/files/issues/2024-03-29/layout_builder_st-call_to_a_member_function_getconfig-3420063-26.patch",
                "3069964 - Argument 1 passed to isTranslation must implement SectionStorageInterface, null given.": "https://www.drupal.org/files/issues/2025-01-02/3069964-null-fix.patch"                 
            },      
            "drupal/layout_builder_st": {
                "3420063 - Fix getConfig() on null in OverridesSectionStorage": "https://www.drupal.org/files/issues/2024-03-29/layout_builder_st-call_to_a_member_function_getconfig-3420063-26.patch",
                "3069964 - Argument 1 passed to isTranslation must implement SectionStorageInterface, null given.": "https://www.drupal.org/files/issues/2025-01-02/3069964-null-fix.patch"
            },

I'm keeping both, since eventually we'll remove the overrides but we need the patches either way (for now).

This applies to other drupaloverrides modules, we're possibly missing patches for when running 6.1.x.

codemirror - test to see how this is working.

This is the library I'm including:

        {
            "type": "package",
            "package": {
                "name": "cdubz/ckeditor5-source-editing-codemirror",
                "version": "35.1.0",
                "type": "drupal-library",
                "extra": {
                    "installer-name": "ckeditor5-source-editing-codemirror"
                },
                "dist": {
                    "url": "https://registry.npmjs.org/@cdubz/ckeditor5-source-editing-codemirror/-/ckeditor5-source-editing-codemirror-35.1.0.tgz",
                    "type": "tar"
                },
                "require": {
                    "composer/installers": "*"
                }
            }
        },
        {
            "type": "package",
            "package": {
                "name": "codemirror/codemirror",
                "version": "5.65.8",
                "type": "drupal-library",
                "extra": {
                    "installer-name": "codemirror"
                },
                "dist": {
                    "url": "https://registry.npmjs.org/codemirror/-/codemirror-5.65.8.tgz",
                    "type": "tar"
                },
                "require": {
                    "composer/installers": "*"
                }
            }
        },

and then corresponding entries in the require section of the composer.json

Ok a bit of a lift to get the tests lined up. The default config tests , due to the new filter option.

Default Config (Drupal\KernelTests\Config\DefaultConfig)

Ok, a bit of a minor issue for me, as I can do workarounds, but we could smoothen this part out.

In order to upgrade to WxT 6.1.x the following modules must be uninstalled before going into D11

• ckeditor4_codemirror (while this module IS Drupal 11 compatible, it has a dependency on the "ckeditor" module which is marked obsolete/unsupported.

Here's what happens when you try to uninstall it in WxT 5.4.x:

do you also want to uninstall wxt_ext_editor? So there's a dependency set in wxt_ext_editor, which is fine for 5.4.x but in 6.1.x there's no ckeditor4_codemirror module available. It could be faked out with a stub module like drush gen module. just to get an info.yml for it to be able to uninstall it. I'll do this myself but we could make this easy by including this in the wxt/custom/modules

core modules removed from D11

• tour
• action

I'm guessing that the tour and action module could safely be uninstalled in WxT 5.5.x or 5.4.x as I don't think they're actually needed anymore?

Patch is currently the same as the MR

joseph.olstad → made their first commit to this issue’s fork.

Experiencing some sort of strange issue with the remote so I'll just push up the updated 11.x patch.

The merge /conflict resolution affected two classes, I'll try to test this manually. The MR doesn't apply cleanly to D11.1.1 so I've rolled another patch for 11.1.1 and I'll be testing this patch rather than the MR.

For builds on D11.1.1 wanting this, should be able to use this diff

Dropped support for D8/D9.

joseph.olstad → made their first commit to this issue’s fork.

Has anyone here tested this with D11 ?

tagged an rc1 release for you

https://www.drupal.org/project/keycloak/releases/2.2.1-rc1 →

Reverting this change for 2.2.1-rc1

🐛 Wrong redirect uri if system name is not keycloak Active

Hmm, very strange why this code was changed in the first place.

see the related ticket

🐛 Error to built redirect URL Fixed

Ok, I'll merge this and tag a 2.2.1-rc1 including this change. I'd like it to get some usage in the wild before tagging 2.2.1

joseph.olstad → made their first commit to this issue’s fork.

w00t! It's ready!

Ok, I am hoping you have time to work on this, appreciate it a lot!

@C-Logemann, absolutely stellar work on this project. I hope to one day be able to use it on one of my projects. Have you started using it? With that said, we need a Drupal 11 release.

Perhaps tag a 2.0-alpha with the D11 merge request.

https://www.drupal.org/project/boost/issues/3428282 📌 Automated Drupal 11 compatibility fixes for boost Needs review

ok this works, I tested it!

reviewing

joseph.olstad → made their first commit to this issue’s fork.

jurgenhaas, want to take a look?

Hmm,
Seems there's smoke in the twig files?

templates/toc-tree.html.twig

and

templates/toc-default.html.twig

and this

#pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725 → ',

Yes the missing core service is confusing. And for the regex, these tests were extremely broken prior to this merge request and they have deleted the historical jenkins results so I don't know when this was last working (if ever). This merge request is a vast improvement. With that said, we'll continue to use this merge request and review the results manually. Merging this would be good if we could merge and tag an alpha or beta or rc release for D11 that'd be a step in the right direction.

Please credit everyone from

🐛 Revisions tab shows up when the anonymous user accesses the Webforms Needs review

And

🐛 Use the magic method instead of "versionHistory" method from VersionHistoryController class Active

Please add credit for these contributors:
jamesyao , mohit_aghera , progga , smulvih2 , jibran

I like the suggested changes.
Still all green!

ok wow, kinda weird but ya great sleuthing!

I'd like to also be able to easily disable it for when I'm working in dev environments and I for some reason need to turn some things off temporarily.

#19 summs it up nicely.

Thanks @shelane!

Cool, great work. I'll update my build soon and check this out. The Ajax fix sounds perfect thanks

Hiding the related patches here accordingly.

and this patch for page_manager has to go on top of our other page_manager patches, put it at the end.

Using page_manager with Drupal 11 I had to make this change:

Sorry I haven't yet made a patch, but pasting the code:

diff --git a/src/Controller/PageManagerController.php b/src/Controller/PageManagerController.php
index 6cd4edb..e952bca 100644
--- a/src/Controller/PageManagerController.php
+++ b/src/Controller/PageManagerController.php
@@ -44,27 +44,26 @@ class PageManagerController extends ControllerBase {
    * @return string
    *   The title for a particular page.
    */
-  public function pageTitle($page_manager_page_variant) {
-    if (is_string($page_manager_page_variant)) {
-      $page_manager_page_variant = $this->entityRepository->loadEntityByConfigTarget('page_variant', $page_manager_page_variant);
+   public function pageTitle(?PageVariantInterface $page_manager_page_variant) {
+    if ($page_manager_page_variant === null) {
+      // Provide a fallback title or throw an exception if a title is required.
+      return $this->t('Default Page Title');
     }
 
     // Get the variant context.
     $contexts = $page_manager_page_variant->getContexts();
-    // Get the variant page entity.
 
     $tokens = [];
-
-    foreach ($contexts as $key => $context){
+    foreach ($contexts as $key => $context) {
       $tokens[$key] = $context->getContextValue();
     }
 
     // Get the page variant page title setting.
     $variant_title_setting = $page_manager_page_variant->getPageTitle();
+
     // Load the Token service and run our page title through it.
     $token_service = \Drupal::token();
-    return $token_service->replace($variant_title_setting,
-      $tokens);
+    return $token_service->replace($variant_title_setting, $tokens);
   }
 
 }

Replace one of those patches.

drupaloverride/entity_browser_block

can be replaced with

drupal/entity_browser_block:'^2.0'

@dqd there's nothing stopping us from accepting a merge request that we could use for a new branch for the purpose you just mentioned. If you or anyone else tables something forward we could consider it.

patch 42a → fixes allowing turning on and off css / js aggregation and cache settings.
patch 42b → allows changing the wxt_library theme
patch 43 → resolves a php warning/error message that is thrown by the report a problem form

Another patch

Testing it out, needs a couple patches:

@smustgrave was granted co-maintainer privileges!

I imagine he'll tag and release very soon! w00t!

@samuel.mortenson , thank you very much! @smustgrave, congratulations!

Ok thanks @mdsohaib4242

We're using the latest bootstrap version 3.34 and do not need this patch. I checked and I'm not using it.

Thanks!

Ok so good news, the automated tests are stuck on a 403 error, this means that the test user lacks a permission.

Should be easy to figure out, likely related to the other fails. I'd say that this is a tests only failure. We've been using this merge request branch in our builds now and no issues have been reported yet.

All green!

Sounds related, hope you can figure it out! :)

I'll check the test results in the morning, but I did test this last change locally and it worked.

I like this idea!

How big of a quarum do we need to get approval for this initiative?

@cmlara, I'm pretty insulted by your insinuations in comment #14. It's been nearly two months since this offer to co-maintain was openned. Hardly suspect at all. Really, there's 8000 installs of this project and more and more people are getting tasked with Drupal 11 upgrades. Serious Drupal projects that cares about availability and caching in any meaningful way will be using varnish_purger.

In a followup to comment #11 , the digitalist company website is based on Webflow, is not Drupal . I'm guessing this company is no longer using Drupal, which explains why this project is no longer being maintained.

@dieterholvoet has followed the ownership process. Others including myself have reached out to the maintainer without response. @avpaderno , please re-review.

https://www.drupal.org/project/roleassign/releases/2.0.3 →

Thanks!

@smustgrave, there's important fixes mixed in that affect/improve the automated testing that we have set up for the Drupal 11 upgrade.

Rather than unwind, would prefer we move forward with these.

Some new information came to light on this issue, will followup here soon.

FTLOG please!

Thanks @smustgrave!

ok great, thanks for that!

Message to Claudiu (claudiu.cristea) :

Subject: embed_block, D11 compatibility

Hello Claudiu, thank for your work on this embed_block module. It's due for Drupal 11, there's a merge request open and we're using it but would prefer to use a tagged release rather than a composer override on a merge request branch.
The issue is here: https://www.drupal.org/project/embed_block/issues/3430098 📌 Automated Drupal 11 compatibility fixes for embed_block Needs review .

Many thanks for your prompt collaboration!

Joseph Olstad

Message to Ilius (idimopoulos):

Subject: embed_block, D11 compatibility

Hello Ilias, I also sent a message to Claudiu about this. Thank for your work on this embed_block module. It's due for Drupal 11, there's a merge request open and we're using it but would prefer to use a tagged release rather than a composer override on a merge request branch.
The issue is here: https://www.drupal.org/project/embed_block/issues/3430098 📌 Automated Drupal 11 compatibility fixes for embed_block Needs review .

Many thanks for your prompt collaboration!

Joseph Olstad

Message to Pieter (pfrenssen):

Subject: embed_block, D11 compatibility

Hello Pieter, I also sent a message to Claudiu about this. Thank for your work on this embed_block module. It's due for Drupal 11, there's a merge request open and we're using it but would prefer to use a tagged release rather than a composer override on a merge request branch.
The issue is here: https://www.drupal.org/project/embed_block/issues/3430098 📌 Automated Drupal 11 compatibility fixes for embed_block Needs review .

Many thanks for your prompt collaboration!

Joseph Olstad

kdborg, have a look at my comment in #15, see if that helps.

kdborg, the archive_current_revision_action comes from this class in moderated_content_bulk_publish/src/Plugin/Action/ArchiveCurrentRevisionAction.php

as for the issue noted in #11, that one I can probably patch for/ fix easily and you can try that when it's ready. With that said, you should probably delete the moderated_content_bulk_publish module and do a composer install to get it fresh again.

You may have misconfigured the bulk operation field though, this I've never heard of or seen what you have described in comment #10.

Would be good to get some more info as mentioned in #12

ok thanks for reporting those errors, I'll try to address them in the next couple days.

Needing a D11 release, I'll ping the maintainers.

I recommend merging this and cutting a 1.6.0-beta1 release so that we can scrap our composer overrides (please!).

All you have to do is merge and tag the 8.x-1.x as 1.6.0-beta1

This way 1.5 stays as the recommended release and we can work on improving 1.6.0 in Drupal 11 without resorting to painful composer overrides that complicate upgrades for those using our distribution of Drupal (WxT).

the drupal ci/cd does the rest.

https://www.drupal.org/project/entity_translation_unified_form/releases/... →

Pushed that in, I'll tag a release now.
Would be nice to get some basic automated test as I recently did for the safedelete module. (incomplete testing but has "something").

@smulvih2 for some reason in Slack you reported a related error in WxT 6.1.

The admin_toolbar_links_access_filter module needs to be uninstalled prior to upgrading to wxt 6.1 and it should not be found in wxt.

Should be an easy fix to this:
Add this Javascript, ensure it loads AFTER jQuery and just before wet-boew.js

if (typeof Zepto !== 'undefined' && typeof Zepto.isArray !== 'function') {
    Zepto.isArray = Array.isArray;
}

Logged an issue upstream in wet-boew/wet-boew

Hope to fix soon

https://github.com/wet-boew/wet-boew/issues/9846