🇨🇦Canada @joseph.olstad

still reviewing this, it might not actually be working at all and possibly introduces a regression.

Another CK5 bug to fix
Added label / anchor use case to the issue summary, described below

CKEditor 4 accepted this:

<li class="checkbox" id="chbx-p2">
<input class="action-checkbox-2 cb-dmm" id="eg5-2" type="checkbox">
<label for="eg5-2">You hold a federal wine licence issued by the Canada Revenue Agency (CRA) under 
<a href="https://laws-lois.justice.gc.ca/eng/acts/e-14.1/page-2.html#h-179017">section&nbsp;14 of the <cite>Excise Act, 2001</cite></a>, valid at the time you apply to the program and up to or after March&nbsp;31,&nbsp;2026
</label>
</li>

CKEditor 5 turns the above into this (SURPRISE!):

<li class="checkbox" id="chbx-p2">
<input class="action-checkbox-2 cb-dmm" id="eg5-2" type="checkbox"> 
<label for="eg5-2">You hold a federal wine licence issued by the Canada Revenue Agency (CRA) under </label>
<a href="https://laws-lois.justice.gc.ca/eng/acts/e-14.1/page-2.html#h-179017"><label for="eg5-2">section&nbsp;14 of the&nbsp;</label></a>
<cite><a href="https://laws-lois.justice.gc.ca/eng/acts/e-14.1/page-2.html#h-179017"><label for="eg5-2">Excise Act, 2001</label></a></cite>
<label for="eg5-2">, valid at the time you apply to the program and up to or after March&nbsp;31,&nbsp;2026</label>
</li>

https://www.drupal.org/project/wxt/releases/6.1.0 →

Very nice work!

This is possibly a duplicate of the fixed issue:

#3307555: Message sent in interface language instead of set language as MessageTemplate::getText() is not fully respecting the $langcode parameter →

D11 compatibility was merged into the 2.0.x branch a while ago, forgot to publish a tag though.

What's the difference between 2.0.x and 3.0.x? Why the new branch?

Should explain this in the project page or release notes and README.md.

We've been using 2.0.x-dev with Drupal 11 for a few months now , not sure how extensively it's been used but it's deployed in production since a few months and I haven't heard of any complaints yet.

Thank you!

Helps if the patch has the correct issue number

Cool, thanks for testing, this is on my radar 100%, I'd like to test a few of my multilingual setups , we tend to publish and unpublish both of our languages at the same time.

joseph.olstad → created an issue.

It's that time again!

Drupal 11 support , any volunteers?
💬 Drupal 11 compatibility Needs work

joseph.olstad → created an issue.

pipeline results look half decent.

RTBC on https://www.drupal.org/files/issues/2025-04-10/interdiff-last-bot.693881... →

and ALSO RTBC on:

https://git.drupalcode.org/project/iek/-/merge_requests/1#note_494646

Merge the MR#1 and apply this patch →

Hello Jay, I'm sending the same message to you as I am sending to Sándor Juhász.

Your module is appreciated by over 2000 enthusiasts. They have started migrating to Drupal 11 however will not be able to take advantage of your module in Drupal 11 since it's currently not advertising it'self as compatible. There's a merge request ready for you, imho, should be an easy win.

https://www.drupal.org/project/iek/issues/3430975 📌 Automated Drupal 11 compatibility fixes for iek Needs review

I recommend moving forward with fix. Then please tag a release so that we are able to install this wonderful module in Drupal 11 with ease.

Thank you,

Joseph Olstad

I've reached out to the maintainers.

Sent this message:

Hello Maintainer1, I'm sending the same message to you as Maintainer2 and Maintainer3.

Your module is appreciated by over 2000 enthusiasts. They have started migrating to Drupal 11 however will not be able to take advantage of your module in Drupal 11 since it's currently not advertising it'self as compatible. There's a couple merge requests that are ready for review, imho, should be an easy win.

https://www.drupal.org/project/ape/issues/3428169 📌 Automated Drupal 11 compatibility fixes for ape Needs review

AND

https://www.drupal.org/project/ape/issues/3520321 🐛 Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/web/modules/contrib/ape/src/Form/SettingsForm.php Active

I recommend moving forward with fixes to ensure that these two issues are fixed. Then please tag a release so that we are able to install this wonderful module in Drupal 11 with ease.

Thank you,

Joseph Olstad

Is anyone maintaining this project? Drupal 11.2.0 will be released in a few weeks from now. It's been a full year since 11.0.0. It's time that this gets in.

Please co-ordinate this above fix with this fix for PHP 8.3+ also required for D11:

🐛 Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /var/www/html/web/modules/contrib/ape/src/Form/SettingsForm.php Active

ok sure, sounds like a good idea. I'll plan to do some testing on this in the comming weeks . Meanwhile I applaud any others wishing to help review and test this.

We've started reducing scope 📌 Defer disruptive 11.3 deprecations for removal until 13.0 Active , scaling back.

• All that is left is to increase the number of minor releases to accomodate symfony 8 in Drupal 11.8+.
• Modify the Drupal core release schedule to stretch out Drupal 11 by 4 years, throw a postpone party, everyone gives hi-5s and kudos!

All this is justified by the following:

Increasing velocity for:

• Drupal CMS
• Drupal 11
• Recipes (Drupal marketplace)
• Worlds (Drupal marketplace)

Lets put Drupal into maximum overdrive , high gear!

We need a huge postpone party for Drupal 12 and tell the world how great Drupal 11 and Drupal CMS are and get some enthusiasm going for the soon to be updated roadmap and crank up the volume on the extra 4 years for Drupal 11.

There's a path forward!

Thank you!

update issue summary with link mentioned by @ptsimard.

There's a few options for moving modules out a the profiles folder, there is a composer entry for this , could modify the path.

There's a few different options. We'll see how this unfolds.

Install profile still functioning correctly in Drupal 11 with WxT.

With that said, investigate how we can carefully transition over to recipes, whether or not this is possible without breaking things.

Ok great, thanks for this, it looks very good.

If we're happy with it, put it in the 2.0.x dev , and then let it simmer in there for a while.

We should close this when the upstream toc_filter patch is committed/resolved/fixed.

this was not tagged so there's no need to publish a release to revert.

There's a conflict reverting this.

Now with the fix in 🐛 Not possible to unselect the checkbox Active , no longer need a convoluted way to get the boolean value. $this->value works from a custom views filter plugin based on the Boolean filter base class when using a single checkbox option.

Upgrade bef and use the code in the merge request from 2921024 which hopefully will be merged ASAP.

the workaround mentioned above had issues, so we explored the related patch and went with the patch solution instead.

This is fixed by the patch/merge request in:
🐛 Not possible to unselect the checkbox Active

To resolve, upgrade to 7.1.x-dev and apply the merge request patch from 2921024

ok, I tested this solution again, it works well!

Thank you very much @smustgrave

Looking to improve this:
🐛 Improve performance of LinkExtractorBatch & allow to skip unpublished moderated content Active

joseph.olstad → created an issue.

Blame PHP 8.2+ for this in combination with contrib.

tested merge request against 💬 With single checkbox option, $this->value always true Active

didn't help

Same issue in better_exposed_filters 7.1.x-dev

Tested with and without the merge request patch from 🐛 Not possible to unselect the checkbox Active

same issue

Seems to be the right approach, I will test this patch now

joseph.olstad → created an issue.

@ar_howard , please try the mentioned patch

https://www.drupal.org/files/issues/2025-05-05/3522806-04.patch →

Ok I have figured out a solution for this, here is the crux of it:

mymodule.views.inc

use Drupal\Core\StringTranslation\TranslatableMarkup;

/**
 * Implements hook_views_data_alter().
 */
function mymodule_views_data_alter(array &$data) {
  $data['paragraphs_item_field_data']['include_session_paragraph'] = [
    'title' => new TranslatableMarkup('Show event sessions'),
    'help' => new TranslatableMarkup('Show event "session" paragraphs toggle filter.  When off/false, only calendar_entry paragraphs are included in the results.'),
    'filter' => [
      'id' => 'include_session_paragraph',
      'group' => 'MyModule',
    ],
  ];
}

src/Plugin/views/filter/IncludeSessionParagraph.php

namespace Drupal\mymodule\Plugin\views\filter;

use Drupal\views\Plugin\views\filter\BooleanOperator;
use Drupal\Core\Form\FormStateInterface;

/**
 * Controls paragraph filtering by presence of field_title (i.e. calendar_entry only).
 *
 * @ingroup views_filter_handlers
 *
 * @ViewsFilter("include_session_paragraph")
 */
class IncludeSessionParagraph extends BooleanOperator {

  /**
   * Workaround for BEF checkbox filters.
   */
  public function acceptExposedInput($input) {
    if (!parent::acceptExposedInput($input)) {
      return FALSE;
    }

    // If the filter value is not present in the input, reject.
    // This is the critical fix for BEF + Single On/Off checkbox.
    $identifier = $this->options['expose']['identifier'];
    if (!array_key_exists($identifier, $input)) {
      return FALSE;
    }

    return TRUE;
  }

  /**
   * {@inheritdoc}
   */
  protected function defineOptions() {
    $options = parent::defineOptions();
    return $options;
  }

  /**
   * {@inheritdoc}
   */
  public function buildOptionsForm(&$form, FormStateInterface $form_state) {
    parent::buildOptionsForm($form, $form_state);
    $form['value']['#title'] = $this->t('Show event sessions');
  }

  /**
   * {@inheritdoc}
   */
  public function query() {
    $identifier = $this->options['expose']['identifier'];
    $input = $this->view->getExposedInput();
    $include_sessions = isset($input[$identifier]) && $input[$identifier] === '1';

    if (!$include_sessions) {
      $alias = $this->query->ensureTable('paragraph__field_title', 'paragraphs_item_field_data');
      $this->query->addWhereExpression(1, "$alias.field_title_value IS NOT NULL");
    }
  }


}

So this filter is added and in bef configured as a single checkbox in the advanced options of bef

The crux was adding the acceptExposedInput method which sets up the expose identifier and adjusting the query method to capture the input

(from the query method) like this:

    $identifier = $this->options['expose']['identifier'];
    $input = $this->view->getExposedInput();
    $include_sessions = isset($input[$identifier]) && $input[$identifier] === '1';

So, I got it working without a patch.

Otherwise the value is always true no matter what was selected so could not use $this->value , instead use the approach mentioned above until this is fixed.

joseph.olstad → created an issue.

Patch #31 no longer applies.

@smustgrave, please reopen this, Andypost is correct, this patch needs to be ported. I'm using Drupal 10.4 with a checkbox exposed bef , the issues reported by Andy Post relating to the patch that needs porting is still unresolved for 8.x-3.x or whatever it's called now.

We've published a contrib module that fixes ck5 tables

https://www.drupal.org/project/ckeditor5_table_fix →

joseph.olstad → created an issue.

joseph.olstad → created an issue. See original summary → .

Thanks for reporting,

Please provide a pull request or patch for this change.

haha, true RTBC for this.

🐛 Layout builder fatal error Active
is needed.

Patch for the toc_filter module → : #3518549-13: Fatal error after updating to toc_api:^2 →

OR

For the toc_filter module: https://git.drupalcode.org/project/toc_filter/-/merge_requests/14.diff

joseph.olstad → created an issue.

@joel_osc , actually I think it's MR6 that is the gotcha , @liam morland combined two patches into one. With that said, I'm going dizzy looking at patches all day long.

Ideally some of these fixes eventually get merged so that we don't have to use so many patches.

@smulvih2 , not sure if this patch even works anymore, although it doesn't appear to cause any harm.

**edit**

Thanks

@natemow, as a maintainer it is your responsibility to check the box next to the contributors name at the bottom of issues marked as "Fixed".

• acidaniel at Phase2 for Phase2 3 patches
• prasaddeole
• nisha_j
• damienmckenna

Please look for these account names in this issue, put a checkbox beside them, so they get credit for their contribution!

What this does is re-enforce the desire to contribute and it helps us identify who is actively contributing to Drupal!

@natemow, as a maintainer it is your responsibility to check the box next to the contributors name at the bottom of issues marked as "Fixed".

• acidaniel at Phase2 for Phase2 4 patches

Please look for these account names in this issue, put a checkbox beside them, so they get credit for their contribution!

What this does is re-enforce the desire to contribute and it helps us identify who is actively contributing to Drupal!

@natemow, as a maintainer it is your responsibility to check the box next to the contributors name at the bottom of issues marked as "Fixed".

• valeriasalis 1 patches attached 2 comments made
• natemow at Interactive Strategies 2 comments made
• damienmckenna at Third and Grove

Please look for these account names in this issue, put a checkbox beside them, so they get credit for their contribution!

What this does is re-enforce the desire to contribute and it helps us identify who is actively contributing to Drupal!

@phenaproxima, we're not using 3008924. Using Drupal 11.1.7 , latest layout_builder_st with fixes from these issues:

#3420063-26
AND
#3069964-25

RTBC on Patch #25

With that said, the merge request is combining in a seperate fix that is from:
🐛 Error: Call to a member function getConfig() OverridesSectionStorage.php Active

So if you're using patch #3420063-26: Error: Call to a member function getConfig() OverridesSectionStorage.php → the merge request will not apply to your build.

However if you want both fixes
#3420063-26: Error: Call to a member function getConfig() OverridesSectionStorage.php →

AND

#3069964-25: Argument 1 passed to Drupal\layout_builder_st\EventSubscriber\ComponentPluginTranslate::isTranslation() must implement interface Drupal\layout_builder\SectionStorageInterface, null given →

in the same diff, then use the merge request patch

Patch #26 is good

Same issue affects 2.0.x-dev.

This is still needed, we're going to have to cook this patch into our builds.
Otherwise big fat WSOD when using moderation dashboard on login

I'd like to support paragraphs, if a client sponsors this I'll develop it. Otherwise I could mentor someone to build this.

@smulvih2, great work on this custom filter that fixes this issue! Amazing! Was ready to call an ambulance after I saw this bug, but now all that is needed is a call to Guiseppe and Bob.

we're still using this.

Snapshot in time up to the MR from a few minutes ago

Not only failing but no longer applying to the latest core 11.1.7

joseph.olstad → created an issue. See original summary → .