PHP 8.4 compatibility improved

f1mishutka → changed the visibility of the branch 3528571-php-8.4-compatibility to hidden.

Simple patch ready in merge request. Actually just a matter of php syntax, no functionality changed.

Merged into 8.x-3.x-dev

Thanks!

There are still nullable parameters and another deprecation

FILE: /var/www/html/docroot/themes/contrib/bootstrap/src/Plugin/Provider/ProviderException.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 29 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be
    |         | explicitly nullable instead. Found implicitly nullable parameter: $previous.
    |         | (PHPCompatibility.FunctionDeclarations.RemovedImplicitlyNullableParam.Deprecated)
------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/docroot/themes/contrib/bootstrap/src/Plugin/Markdown/AllowedHtml/Bootstrap.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 23 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be
    |         | explicitly nullable instead. Found implicitly nullable parameter: $activeTheme.
    |         | (PHPCompatibility.FunctionDeclarations.RemovedImplicitlyNullableParam.Deprecated)
------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/docroot/themes/contrib/bootstrap/src/Utility/ArrayObject.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 17 | WARNING | When the magic __serialize() and __unserialize() methods are available and the code base does not need
    |         | to support PHP < 7.4, the implementation of the Serializable interface can be removed.
    |         | (PHPCompatibility.Interfaces.RemovedSerializable.RedundantSerializableImplementation)
------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/docroot/themes/contrib/bootstrap/src/SerializedResponse.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
------------------------------------------------------------------------------------------------------------------------
  98 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be
     |         | explicitly nullable instead. Found implicitly nullable parameter: $request.
     |         | (PHPCompatibility.FunctionDeclarations.RemovedImplicitlyNullableParam.Deprecated)
 127 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be
     |         | explicitly nullable instead. Found implicitly nullable parameter: $request.
     |         | (PHPCompatibility.FunctionDeclarations.RemovedImplicitlyNullableParam.Deprecated)
 143 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be
     |         | explicitly nullable instead. Found implicitly nullable parameter: $request.
     |         | (PHPCompatibility.FunctionDeclarations.RemovedImplicitlyNullableParam.Deprecated)
------------------------------------------------------------------------------------------------------------------------


FILE: /var/www/html/docroot/themes/contrib/bootstrap/deprecated.php
------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 718 | WARNING | Implicitly marking a parameter as nullable is deprecated since PHP 8.4. Update the type to be
     |         | explicitly nullable instead. Found implicitly nullable parameter: $target.
     |         | (PHPCompatibility.FunctionDeclarations.RemovedImplicitlyNullableParam.Deprecated)
------------------------------------------------------------------------------------------------------------------------

f1mishutka → changed the visibility of the branch issue-3528571-php8.4-compatibility to hidden.

MR 61 looks good and works for us.

This is all merged into the 8.x-3.x dev branch

I'll wait a bit before tagging 3.36

https://www.drupal.org/project/bootstrap/releases/8.x-3.36 →

Thanks @hosterholz!

crediting for fix

joseph.olstad → credited dejan.maric.max → .

joseph.olstad → credited socialnicheguru → .

creditted dejan.maric.max and socialnicheguru for their work in the related issue.