Tremendous work! Thank to everybody!
P.S.: I'm proud to be a part of such awesome community. Drupal people make world a better place. Literally!
Any chance to have this merged at least to -dev branch?
Thanks.
Curious why the bag is different
This is hidden somewhere deep in Drupal core I think. We do bootstrap Drupal core with custom code (similar to index.php) for bunch of our specific integrational tests. So I did not dig to deep about masquerade and core interaction :)
better replace check for bag classname
Done: check replaced to instanceof.
Added MR with simple solution for this problem
f1mishutka → created an issue.
With release of 10.3.0 this issue became critical show stopper. Could we have it released ASAP please?
Thanks!
I still can't install it without the new release since composer keeps saying is not compatible. I'm curious how others were able to install it on Drupal 10 sites.
We successfully use this module under Drupal 10 since February'23.
We use approach described in this article https://www.computerminds.co.uk/articles/apply-drupal-9-compatibility-pa... with this merge request https://git.drupalcode.org/project/form_mode_manager/-/merge_requests/8
But for sure normal release for D10 will be much more convenient for everybody.
Great! Thank you!
Super! Thank you very much!
It would be much more better to have D10 release and drupal.org will mark it as D10-compatible automatically.
Thanks!
Any chance to have this merged? It is almost 3 years of this bug already :(
Fix in MR is very simple. And it works for years in at least 8 projects for us.
Thanks in advance!
As I understand jQuery UI stays in Drupal 10 core. So there is no need to rely on jquery_ui module.
So there is no need to second patch with `core/jquery.ui` replaced to `jquery_ui/jquery_ui`
We are running bootstrap theme under Drupal 10 for two month already with just patch from merge request with no issues at all.
My proposal is to merge it as simple as it is in merge request. This is enough quick-fix for people can use it already under Drupal 10 without patches) and then concentrate efforts on issue #3343712 as a long-term solution for Drupal 10.1+
f1mishutka → created an issue.
Changed priority to Major because this could be show stopper for projects under Drupal 10
f1mishutka → created an issue.
Confirm patch from #7 works under Drupal 10.
Please merge ASAP to be able to use it in production.
Thank you!
1) Confirm patch #3 working
2) Created MR with this patch applied to be able to install module under D10 using composer (with this approach: https://www.computerminds.co.uk/articles/apply-drupal-9-compatibility-pa... ).
3) Increasing priority to 'Major' because this is show stopper for switching to Drupal 10.
Waiting for MR to be merged and new version released. Thank you!
f1mishutka → made their first commit to this issue’s fork.
1) Confirm patch #6 working
2) Created MR with this patch applied to be able to install youtube module under D10 using composer (with this approach: https://www.computerminds.co.uk/articles/apply-drupal-9-compatibility-pa... ).
3) Increasing priority to 'Major' because this is show stopper for switching to Drupal 10.
Waiting for MR to be merged and new version released. Thank you!
Duplicate of https://www.drupal.org/project/form_mode_manager/issues/3297262 📌 Automated Drupal 10 compatibility fixes RTBC
Created merge request with all changes from ProjectUpdateBot and D10 support added to .info files
f1mishutka → made their first commit to this issue’s fork.
Conffirm merge request code works with Drupal 10.
Installed it by composer from https://git.drupalcode.org/issue/views_ical-3299451/-/tree/3299451-autom... by described at https://www.computerminds.co.uk/articles/apply-drupal-9-compatibility-pa....
Confirm patch from #2 as working.
I've created separate branch for this issue with patch applied https://git.drupalcode.org/issue/realname-3289257/-/tree/3289257-d10-patch
to be able to install it with composer as described here: https://www.computerminds.co.uk/articles/apply-drupal-9-compatibility-pa...
f1mishutka → made their first commit to this issue’s fork.
Created merge request with
1) patch from #2 applied
2) version requirements inn .info and composer.json extended to support D10
Please merge to have at least -dev version compatible with Drupal 10.
f1mishutka → made their first commit to this issue’s fork.
Confirm: patch solved problem. Thank you!
Seems to be quite urgent as in show stopper for Drupal 10. Any chances new version with this patch released soon?
3302607-39.patch worked for me, Drupal 10.0.3.
Thank you!
fixed with 3.26 release
Any chance for D10 version to be released soon?
Merge Request for 1.14 added