Automated Drupal 11 compatibility fixes for youtube

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.1.0
2. mglaman/phpstan-drupal: 1.2.9
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.1, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.1
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.1

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
Therefore these changes update the info.yml file for Drupal 11 compatibility.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.1
2. mglaman/phpstan-drupal: 1.2.11
3. palantirnet/drupal-rector: 0.20.1

Working fine with drupal 11.0.5

Tests are not currently passing or able to run and the MR is showing as unmergeable.

ivnish → changed the visibility of the branch 3435793-automated-drupal-11 to hidden.

@markdorison I fixed test. MR looks mergeable, please review

@ivnish This looks great; thank you!

Since this is dropping support for Drupal 9, does anyone feel that we should create a new major version of the module or are we so far past when Drupal 9 support was dropped (11/1/23) that we should not worry about that?

I think we could create 2.1.0 release

Rerolling the patch for 2.0.0

The previous patch doesn't work with Composer due to version string. This one should work.

Check this patch for Drupal 11 Compatibility

Hi there! #14 works for me. We're on version `^2.0`.
Thanks for the patch!

Hello, patch #15 working in Drupal 11.1.2.

Confirm it is working for Drupal 11.1.5

The patch in comment #15 has a few problems:

-core_version_requirement: ^9.3 || ^10
+# version: VERSION
+core_version_requirement: ^9 || ^10 || ^11

1. It's adding a unnecessary "# version: VERSION" line:
2. It has not removed the support for Drupal 9. However, the required changes to support Drupal 11 break compatibility with Drupal 9, so it should no longer be supported.

+
+# Information added by Drupal.org packaging script on 2023-03-21
+version: '2.0.0'
+project: 'youtube'
+datestamp: 1679360588

3. The patch is adding information that is added by Drupal.org packaging script and thus should not be commited.

+use GuzzleHttp\Exception\RequestException;
 use Drupal\Component\Utility\Html;
 use Drupal\Component\Utility\UrlHelper;
+use Drupal\field\Entity\FieldConfig;
 use Drupal\Core\File\FileSystemInterface;
 use Drupal\Core\Language\LanguageInterface;
 use Drupal\Core\Link;
 use Drupal\Core\Url;
-use Drupal\field\Entity\FieldConfig;
 use Drupal\file\Entity\File;
 use Drupal\image\Entity\ImageStyle;
-use GuzzleHttp\Exception\RequestException;
+use \Drupal\Core\Utility\Error;
+use \Psr\Log\LogLevel;
+use Drupal\Core\File\FileExists;

4. The patch is messing up with the alphabetical order of the elements
5. The patch is putting a slash \ before the namespace, it should not
6. The patch is adding an unused use, \Psr\Log\LogLevel

-  preg_match("/^(?:http(?:s)?:\/\/)?(?:www\.)?(?:youtu\.be\/|youtube\.com\/(?:(?:watch)?\?(?:.*&)?v(?:i)?=|(?:embed|v|vi|user|shorts)\/))([^\?&\"'<> ]+)/", $input, $matches);
+  preg_match("/^(?:http(?:s)?:\/\/)?(?:www\.)?(?:youtu\.be\/|youtube\.com\/(?:(?:watch)?\?(?:.*&)?v(?:i)?=|(?:embed|v|vi|user)\/))([^\?&\"'<> ]+)/", $input, $matches);

7. The patch is reverting a commit by mistake: https://git.drupalcode.org/project/youtube/-/commit/3a78b1da75fc4103e4ee...

-  $file = \Drupal::service('file.repository')->writeData($data, $destination, FileSystemInterface::EXISTS_REPLACE);
+  $file = file_save_data('File content', $destination, FileExists::REPLACE);

8. The patch is reverting to the use of file_save_data, which is deprecated in Drupal 9.3.0 and removed in Drupal 10.0.0.

Therefore I'm providing attached a new patch, it runs against 2.x-dev.

Please do not use patches! it's hard to review. This issue has an MR

This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

It is important that any automated tests available are run and that you manually test the changes.

Drupal 11 Compatibility

According to the Upgrade Status module → , even with these changes, this module is not yet compatible with Drupal 11.

Currently Drupal Rector, version 0.20.3, cannot fix all Drupal 11 compatibility problems.

Therefore, these changes did not update the info.yml file for Drupal 11 compatibility.

The compatibility issues that Upgrade Status found after the Drupal Rector fixes were applied are attached to help you resolve them manually.

Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

Debug information

These packages were used to generate the fixes:

1. drupal/upgrade_status: 4.3.6
2. mglaman/phpstan-drupal: 1.3.7
3. palantirnet/drupal-rector: 0.20.3

- Merged MR fixes
- Fixed Testing issues
- Brought code to PHPStan level 6
- Drupal coder Coding Style fixes
- Disabled CSPell check

Also tested locally manually. Works fine.

I'd suggest to release this as v3 (?)

Please release version with D11 compatibility. This module is last "show stopper" for our project D11-migration.

Thanks everybody for the efforts!

Version 3 would also help me.

Guys, please release it at least as "beta".

There is D11.5 already coming to us and we have no "YouTube Field" version for Drupal 11...

Thanks!

I have created the 3.x branch, merged the MR into it, and created a 3.0.0-beta1 release. Thanks to everyone for their help, support, and patience!