#ProjectUpdateBotD11

Hello, patch #15 working in Drupal 11.1.2.

Tested on Drupal 11.1.3, module works as expected.
RTBC +1

Looks good, thanks for the changes.

Thank you for the new release 🙏

@manishvaity Thank you for your work to get this module D11 ready.
I added a few corrections/additions, fixes reported by Drupal Rector, and basic .gitlab-ci.yml.
I leave a comment in MR about core_version_requirement, I think it makes sense.
Put the task back into Needs Review for someone to review.

Thanks for everyone's work here. Merged in, and will roll a Drupal 11-ready release shortly.

Thanks for the D11 compatability fixes of the module.

When can we expect a stable version for installation via Composer?

Changing status to "Needs work" as some deprecations discovered with drupal-check

 ------ ----------------------------------------------
  Line   field_image_style.module
 ------ ----------------------------------------------
  32     Call to an undefined method
         Drupal\Core\Form\FormInterface::getEntity().
 ------ ----------------------------------------------

 ------ --------------------------------------------------------------------------
  Line   src/Plugin/Field/FieldFormatter/ImageStyleImageFormatter.php
 ------ --------------------------------------------------------------------------
  140    Call to an undefined method
         Drupal\Core\Entity\EntityInterface::getFileUri().
 ------ --------------------------------------------------------------------------

@guietc and @julien' Any news on releasing a tagged Drupal 11 version?

Adjusted the previous patch to fix a deprecated Symfony's method call.

Automatically closed - issue fixed for 2 weeks with no activity.

OK, at this point, it looks like it is all happening here. That is fine too.

Branch 8.x-1-default should probably be deleted.

I'm looking at the 4 remaining issues.

Can this be merged into the branch and a new release made please?

Automatically closed - issue fixed for 2 weeks with no activity.

Sounds good to me, good job. Hope a maintainer will merge this anytime soon.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Left a comment on the MR, which is incomplete, the patch still allows D9, which is not correct, needs to be at least 10.1

Can we get a merge and a D11 ready release please?

I created a MR since monitoring has a D11 compatible version.
Can we get a merge and a new D11 ready release?
Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.

The patch here has the same pattern several times and it's all because of watchdog_exception being deprecated.
To me, this patch looks sufficient to allow the module to be installed on drupal 11, I don't understand why the info.yml is not updated though?

Automatically closed - issue fixed for 2 weeks with no activity.

abu-zakham → credited rajab natshah → .

Checked the module with upgrade_status and this MR would be enough.

Can we get a release please?

Great news, thanks a lot!

RTBC++
I have tested it with media_avportal https://www.drupal.org/project/media_avportal/issues/3431855 📌 Automated Drupal 11 compatibility fixes for media_avportal Needs review . All works as expected.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Version 3.0.0-alpha1 → released!

This is looking perfect for my needs also. However, we're upgrading to D11. Any chance of this being merged in and released?

Tested this with Drupal CMS 1.0.2 and the posts titles are imported but the content is ignored.

Issue reported by Update Status module can be ignored till Drupal 12 release.

================================================================================
Config Override Warn, --
Scanned on Tue, 03/04/2025 - 20:32

FILE: web/modules/contrib/config_override_warn/config_override_warn.module

STATUS         LINE                           MESSAGE                           
--------------------------------------------------------------------------------
Ignore         32   Call to deprecated method renderPlain() of class            
                    Drupal\Core\Render\Renderer. Deprecated in drupal:10.3.0 and
                    is removed from drupal:12.0.0. Use                          
                    Drupal\Core\Render\RendererInterface::renderInIsolation()   
                    instead.                                                    
--------------------------------------------------------------------------------

Greetings,

I merged bot's changes and added corrections to get tests green. They were failed due to changes done in 📌 Correct spelling in Config tests Fixed , specifically this changes.
Also I checked test on D11 and added fixes to get them working as well.
Changes were pushed into 3428552-automated-drupal-11

Like a charm

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Also waiting for the changes to be committed!

Is the module maintainer still active?

Hope the module works fine on D11, as you tell here. I didn't test it on D11 yet.

The new release is coming

All green and good to go I think. Can we get this reviewed ASAP as this is the last module holding up one of site upgrades to Drupal 11!

All green pipeline:
https://git.drupalcode.org/issue/entity_update-3430260/-/pipelines/439664

Patch for those using composer lenient:
https://git.drupalcode.org/project/entity_update/-/merge_requests/12.diff

darren.fisher → made their first commit to this issue’s fork.

Merged into new 3.x dev branch.

Leaving open as advised.

Fixed in WEB-T 1.0.4.

Fixed in WEB-T 1.0.4.

Fixed in WEB-T 1.0.4.

Thank you

prudloff → closed merge request !5

Automatically closed - issue fixed for 2 weeks with no activity.

@danrod, great work, fixing the phpstan issues appears to have also fixed the automated tests. 33 tests pass.

I fixed all of the PHPSTAN / PHPCS issues that were popping up in the tests/ directory, I ran the tests and they all passed now, I'm not familiar with ths module so I'll need to check if I broke other components of the module by fixing this:

daniel@drupal:/var/www/html$ ./vendor/bin/phpunit web/modules/contrib/toc_api/tests/ --verbose -c web/core/phpunit.xml
PHPUnit 10.5.45 by Sebastian Bergmann and contributors.

Unknown option "--verbose"
daniel@drupal:/var/www/html$ ./vendor/bin/phpunit web/modules/contrib/toc_api/tests/ -c web/core/phpunit.xml
HTML output directory sites/simpletest/browser_output is not a writable directory.

PHPUnit 10.5.45 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.14
Configuration: /var/www/html/web/core/phpunit.xml

.................................                                 33 / 33 (100%)

Time: 00:02.034, Memory: 6.00 MB

OK (33 tests, 178 assertions)
daniel@drupal:/var/www/html$ 

I aware that they are other issues other than the CI messages and the tesd directory, for now I am moving this to "Needs Review"

smustgrave → closed merge request !3

Hi there! #14 works for me. We're on version `^2.0`.
Thanks for the patch!

Re-rolling patch to work with version that includes information added by Drupal.org.

Automatically closed - issue fixed for 2 weeks with no activity.

Thank you @trembormc!

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

I am looking at the PHPSTAN issues, is the disabledTestRender() really needed?

tests/src/Kernel/TocManagerTest.php

  /**
   * Tests TOC rendering. Temporarily disabled.
   *
   * @return bool|string
   *   This return a string or a boolean value.
   */
  public function disabledTestRender() {
    /** @var \Drupal\Core\Render\RendererInterface $renderer */
    $renderer = \Drupal::service('renderer');
    /** @var \Drupal\toc_api\TocManager $toc_manager */
    $toc_manager = \Drupal::service('toc_api.manager');
    /** @var \Drupal\toc_api\TocBuilder $toc_builder */
    $toc_builder = \Drupal::service('toc_api.builder');

Automatically closed - issue fixed for 2 weeks with no activity.

Covered in 📌 Trigger tests on CI Active

Automatically closed - issue fixed for 2 weeks with no activity.

mattyb → credited kewesley → .

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Updated to version 1.0.4 with Drupal 11 compatibility.
Thanks for the RTB

Duplicate of 📌 Automated Drupal 11 compatibility fixes for video_embed_peertube Needs review

Duplicate of 📌 Automated Drupal 11 compatibility fixes for video_embed_peertube Needs review

Duplicate of 📌 Automated Drupal 11 compatibility fixes for video_embed_peertube Needs review

Automatically closed - issue fixed for 2 weeks with no activity.

Merged.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

@andeersg, review the MR please.

All tests are green! We support Drupal 11 now! :-)

Setting this to active so the bot can post updates

This probably means we should be rebuilding the relevant cache when the entity_reference_integrity_enforce.settings form is submitted.

Correction: I believe the proper approach is to add a cacheable dependency to the entity deletion form that we're altering, so that it is reset when config:entity_reference_integrity_enforce.settings changes.

I pushed a commit. Let's see if tests pass now...

Apologies for the delay

https://www.drupal.org/project/search_api_algolia/releases/3.1.0 →

I'm using this module (patched) on a D11 site. What issues are you seeing?

Fixed with the 2.3 release.

Duplicate of 📌 Automated Drupal 11 compatibility fixes for layout_builder_st Needs review .

It's a caching issue. The /node/1/delete page gets cached after the first time it's accessed (before the reference integrity module configuration is saved), so the second time it's accessed it still shows the "Confirm" submit button. I experienced the same thing testing manually. Notably it still prevents the user from deleting the entity when that happens - it seems to just reload the confirm form and then the expected "You can not delete this as it is being referenced by another entity" message is visible (and the submit button is gone).

This probably means we should be rebuilding the relevant cache when the entity_reference_integrity_enforce.settings form is submitted.

smustgrave → closed merge request !3

Agreed. Thank you for this useful module and creating a new tagged release!!

Any news? Desperate for a D11 release!!!

I suggest that this require a minimum of Drupal 10.1 so that DeprecationHelper is not needed. Or set it at Drupal 10.3 since that is the oldest currently supported.

There's one failing test...

    Enforced Integrity (Drupal\Tests\entity_reference_integrity_enforce\Functional\EnforcedIntegrity)
     ✘ Node integrity
       ┐
       ├ Behat\Mink\Exception\ExpectationException: An element matching css ".form-submit" appears on this page, but it should not.
       │
       │ /builds/project/entity_reference_integrity/vendor/behat/mink/src/WebAssert.php:888
       │ /builds/project/entity_reference_integrity/vendor/behat/mink/src/WebAssert.php:492
       │ /builds/project/entity_reference_integrity/modules/entity_reference_integrity_enforce/tests/src/Functional/EnforcedIntegrityTest.php:84
       │ /builds/project/entity_reference_integrity/modules/entity_reference_integrity_enforce/tests/src/Functional/EnforcedIntegrityTest.php:50
       ┴

Setting this to "Needs work"... I'll see if I can figure out what's going wrong...

deimos → changed the visibility of the branch project-update-bot-only to active.

deimos → changed the visibility of the branch project-update-bot-only to hidden.

Automatically closed - issue fixed for 2 weeks with no activity.

Rebased MR11 onto the new 2.x branch. Some of the changes were already taken care of in 📌 Add .gitlab-ci.yml to run tests and linting Active , so now it's just declaring ^11 support in the *.info.yml files (I amended the commit to add it to the enforce sub-module too, which didn't have core_version_requirement previously.

PS: We should probably set up CI so running tests would become easier.

This is done! 📌 Add .gitlab-ci.yml to run tests and linting Active

So let's see how the tests go...

m.stenta → made their first commit to this issue’s fork.

Automatically closed - issue fixed for 2 weeks with no activity.

The above patch didn't work for me. Here is a working patch.

Automatically closed - issue fixed for 2 weeks with no activity.

This is trivial and should be merged.

Adding stable patch for composer patching, please ignore for all other purposes.

Moving issue to the latest branch and creating MR for it.

Hi @maintainers. Can we get this committed soon? We need to migrate a project to Drupal 11, and this module is blocking it.

@fathershawn thanks for your help with these tests. Everything is passing now with Gitlab Pipelines.

https://git.drupalcode.org/project/search_api_coveo/-/merge_requests/22

+1 for mably as a new co-maintainer and a 3.x branch

@wiifm we are using this module on several of our websites.

Happy to help as a co-maintainer if needed.

I don't want release untested code in any way (alpha or beta). If some one can test the code form the PR - this will be helpful for the next release.

Added Drupal 11 support.
This patch doesn't apply, so added new patch for easy apply.