#ProjectUpdateBotD11

Worked on #3496782 and did not see that you resolved this issue before in patch #6.

Because for #3496782 the MR!11 is already created and most other changes already part of 3.x-dev branch, I only tested the last open topic: Fixing the paragraph edit form (disabling the checkbox was not possible).

Your patch resolved the problem so I opened MR!12. With these two MRs a D11 release should be possible.

Thank you for all your work on this great module.

jan kellermann → made their first commit to this issue’s fork.

Automatically closed - issue fixed for 2 weeks with no activity.

Thanks, merged to 1.0.x.

Automatically closed - issue fixed for 2 weeks with no activity.

I'll get back to reviewing this the next few days, with that said, follow my instructions, this diff is applying cleanly against the head of 8.x-1.x provided there's no conflicting patches being applied and I had no choice but to add two fixes from two other issues into this MR. The only fix I didn't include that I'm using elsewhere is this one: https://www.drupal.org/files/issues/2025-01-02/3069964-null-fix.patch →

@almador, delete your version, back off your other patches, grab the 8.x-1.x dev release clean clone or the latest tagged release and apply the merge request diff, see how that works.
The only other patch you might need other than the MR diff is this one: https://www.drupal.org/files/issues/2025-01-02/3069964-null-fix.patch →

MR3 works with D10 and D11.

MR22 worked but MR24 didn't work for me.

If I'm applying only 2 first patches (without the patch from this topic):

"drupal/layout_builder_st": {
"Issue #3420063: Error: Call to a member function getConfig() OverridesSectionStorage.php": "https://www.drupal.org/files/issues/2024-03-29/layout_builder_st-call_to_a_member_function_getconfig-3420063-26.patch",
"Issue #3069964: Argument 1 passed to Drupal.. must implement interface Drupal null given": "https://www.drupal.org/files/issues/2019-07-24/isTranslation-null-given.patch"
},

I'm receiving this error:
Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "class_resolver", path: "string_translation -> string_translator.locale.lookup -> config.factory -> config.typed -> class_resolver -> entity_type.manager". in Drupal\Component\DependencyInjection\Container->get() (line 149 of core/lib/Drupal/Component/DependencyInjection/Container.php).

Thanks, I created a new release.

^10.4 || ^11.1

Hi, Joseph and thank you for your efforts!

AFAIU, it's not the final version yet?

Tried both diff and patch in my local environment, they are not applying cleanly:
https://git.drupalcode.org/project/layout_builder_st/-/merge_requests/16...
https://git.drupalcode.org/project/layout_builder_st/-/merge_requests/16...

This has been merged and Drupal 11 has been released, so I'm closing now.

@jibran, the test results are EXTREMELY green now!

I also fixed a few phpstan issues and a bunch of phpcs issues.

Intentionally left one remaining phpstan issue (a design choice), accept the risk is my recommendation. Let's move forward please!

The tests ARE passing with Drupal 11.1.

https://git.drupalcode.org/issue/config_revision-3451887/-/jobs/3850135

OK (7 tests, 101 assertions)

Please move forward!

Also tested successfully on core 11.1

LGTM, tested on Drupal 11.1

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

@adcillc @adci_contributor, any news on a Drupal 11 compatible tagged version?

bbu23 → credited nk_ → .

Need the above fixed before I can get drupal/blog pulled into my project with composer.

@nevergone, you committed the change to the *.info file, but not to composer - https://git.drupalcode.org/project/blog/-/commit/74cfa3ccc8a8a14d51ad1b1596eea1527ec76fe9

Still need change in this patch.

RTBC++

Both url_embed and embed do not have D11 releases

URL Embed does have a D11-compatible release -- https://www.drupal.org/project/url_embed/releases/3.0.0-beta2 → -- but you're right that since it declares a dependency on drupal/embed, you can't use it with a D11 site.

Can we please create a follow-up to fix the test fails?

Restored the original override approach as the decorator approach does NOT work. The class_revolver.inner parameter is not available and the service is not available.

Yes we need a D11 release ASAP. Other module, like url_embed, require this module (drupal/embed). I am currently updating a distro to D11.1, and running into an issue. Both url_embed and embed do not have D11 releases, and one requires the other, so it is not possible to do my usual composer.json workaround for this by defining a repository that points to the D11 PR branch in Drupal's gitlab. Therefore, to get the working, I will need to have a D11 release for embed.

I agree with @borisson_, it's better to just get a release out, so that people can actually include this module in their project, then issues can be ironed out quickly using patches in separate tickets.

@almador , sometimes the patch file doesn't work depending on how the patch is being applied, try the diff file instead.

https://git.drupalcode.org/project/layout_builder_st/-/merge_requests/16...

With that said, I'm not done fixing.

Hi, Joseph!

Can't apply patch from:
https://git.drupalcode.org/project/layout_builder_st/-/merge_requests/16...

Automatically closed - issue fixed for 2 weeks with no activity.

I'm not able to reopen this ticket, but it is not completed because the core version specified in services.info.yml is still 10 and not 11. I will see if I can make a new MR.

Manual Dependency Injection with Decorator Pattern

• Manual Injection avoids relying on the #[AutowireDecorated] attribute, which is not natively supported in Drupal's DI system.
• Explicit Definition aligns with Drupal's preferred service configuration, ensuring compatibility with core patterns.
• Backward and Forward Compatible: This approach works with both current and future versions of Drupal.

LGTM!

LGTM!

LGTM!

+1 let's get a new release

MR #8 Looks Good to me!

This has now been merged and a new release is available

LGTM!

I'm unable to install this fork in D11 with composer due to its dependency on flysystem v2 which is not D11 compatible. It needs to be dependent on version 3, or at least this MR: https://git.drupalcode.org/issue/flysystem-3451092/-/tree/fix-merge-error

@borisson_ thank you for your vote of confidence! I am taking the liberty of changing the status to "Reviewed & tested by the community" on your behalf.

Applied the patch from:
https://git.drupalcode.org/project/layout_builder_st/-/merge_requests/16...

And received the error:
PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function Drupal\layout_builder_st\DependencyInjection\DecoratedClassResolver::__construct(), 0 passed in /app/public_html/core/lib/Drupal/Component/DependencyInjection/Container.php on line 261 and exactly 1 expected in /app/public_html/modules/contrib/layout_builder_st/src/DependencyInjection/DecoratedClassResolver.php:17

Here is the list of my patches:
"drupal/layout_builder_st": {
"Issue #3420063: Error: Call to a member function getConfig() OverridesSectionStorage.php":
" https://www.drupal.org/files/issues/2024-03-29/layout_builder_st-call_to... →
3420063-26.patch",
Issue #3069964 Argument 1 passed to Drupal.. must implement interface Drupal null given":
" https://www.drupal.org/files/issues/2019-07-24/isTranslation-null-given.... → ",
"Issue #3431600: Automated Drupal 11 compatibility fixes for layout_builder_st":
"patches/layout_builder_st_3431600_16_2.patch"

+1 let's get a new release with this included!

Fixed issues reported by PHPCS, now the build is passing.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

I can't see anything fundamentally wrong with this fix.

I've tagged @dave reid on a related section of his code that is being removed by this merge request. Should he not have any objections I believe we need to move forward!

I propose regardless, take the current MR , merge it and cut an rc1 release or a beta release. If you're really afraid of this change then please create a new branch and tag a beta release so that we can move forward with D11!

vishal.kadam → closed merge request !3

All changes have been merged and D11 is released

@prashant mishra, did you intend to close the merge request without merging?

New release 4.0.0 has updates

vladimiraus → changed the visibility of the branch project-update-bot-only to hidden.

Here's a diff file from @srjosh's MR #5 for applying via Composer.
Retrieved from https://git.drupalcode.org/project/kaltura_media/-/merge_requests/5.diff

MR!4 Makes this module compatible with Drupal 11. Functionality is working as expected.
RTBC +1

Thank you all! Committed. 🍻

vladimiraus → changed the visibility of the branch 3429733-automated-drupal-11 to hidden.

vladimiraus → changed the visibility of the branch project-update-bot-only to hidden.

The changes done here by @znerol are the right way to go, these look to be is the most minimal changes needed to get d11 compatibility.

I would suggest to merge those and tag a new release, the followup issues created can be done in the next release imho

This is just a .info.yml update, so I think it can be committed and a new release can be launched as well.

Both of these merge requests should be committed, after that a new release should be helpful for people trying to upgrade.

This looks great, I think we should commit this, and release a stable version of the module

MR!2 Makes this module compatible with Drupal 11. Functionality is working as expected.

RTBC +1

vladimiraus → changed the visibility of the branch 3438752-automated-drupal-11 to hidden.

The #MR2 works for both Drupal 10 and Drupal 11. Attaching the upgrade status screenshot for reference. Moving the issue to RTBC.

Tests are failing. We need to change .gitlab-ci.yml to run tests with both, Drupal 10 and 11

Since this is only a .info.yml update, this can be applied without much stress by the maintainers. I think it would be helfpul to also get a tagged release after this

Looks great, I hope we can commit the merge request from @jeroent. Especially since this also fixes the tests I think it should be committed.

To make it easier for people to upgrade, I think a new tagged release will be helpful as well.

This is just a core version requirement bump, so it could be committed. However I think the value of this module has gone down now that drupal supports this out of the box by having the new annotation.

For this reason I suggest to make a drupal 11 compatible release and after that this module should either be unsupported or it should use the new format.
I would suggest the first.

It looks like the only thing that's needed here is the .info.yml update, so this should be stress-free to commit. It would be great to also get a new tagged release after the commit.

I agree with @liampower. This looks good to go.

This is just a .info.yml update, so it should be stress-free to commit.

In the proposed info.yml change there would be support for drupal 8.8 all the way through to 11.x, I guess having only 10 and 11 is enough though? I think this can be committed and a new release can be tagged?

Since this is only a .info.yml change I guess this can be committed and a new release can be tagged. This should make upgrading easier.

Automatically closed - issue fixed for 2 weeks with no activity.

MR!3 Makes this module compatible with Drupal 11. Functionality is working as expected.

RTBC +1

#MR!10 works for both Drupal 10 and Drupal 11. Attaching screenshot for reference.
Moving this to RTBC.

Starting with release Beta13 Drupal 11 compatibility has been supported. Additional fixes were applied in Beta14 with more stringent typehinting and static analysis checks.

Will work on PHPUnit testing.

Thank you @podarok

@JeroenT I'm going to move the CI stuff into a separate issue and close this. Thanks!

I updated it for D11. However, bear in mind this module is going away since the dev version of D11 has the same functionality.

I bet it needs to check CI template as very probably it needs changes but it doable in follow-up if any maintainer can be found

Added the correct patch and not the old one that did not apply =)

I applied MR 35 as a patch:

https://git.drupalcode.org/project/context/-/merge_requests/35.patch

But then the D11 compatibility patch didn't apply anymore after that so I made a new one (in attachment) that does work.

Apply it after the above patch.

@hatuhay can we get this merged and a new release? Upgrading a distro to D11 and we use this module. Can help report any bugs once it's installed on my D11 site. Thanks!

Thank you!

Released 1.1.3 with Drupal 11 compatibility

Drupal 11 compatible in new version 1.0.1

Hey guys. Is there something more needed before you can cut a release for D11 ? I would think not since @andypost marked it RTBC 5 months ago, but if you are missing something, I can probably do it.

Automatically closed - issue fixed for 2 weeks with no activity.

Step #1:

Resolve this issue:
🐛 Error: Call to a member function getConfig() OverridesSectionStorage.php Active

Step #2, continue working on the rest.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

MR4 makes the module compatible with d10 and d11 and functionality works in both versions

MR!3 Makes this module compatible with Drupal 11. Functionality is working as expected.

RTBC +1

MR!12 Makes this module compatible with Drupal 11. Functionality is working as expected.
RTBC +1

MR!12 Makes this module compatible with Drupal 11. Functionality is working as expected.

Automatically closed - issue fixed for 2 weeks with no activity.

Why this patch is not deployed?
Can you please accept this patch?

manishvaity → changed the visibility of the branch 3431537-d11_ready to hidden.

Released in 1.1.0

l_vandamme → closed merge request !1

The above patch is not getting applied due to line number mismatch. Recreating it.

Tnx

MR!3 Makes this module compatible with Drupal 11. Functionality is working as expected.
RTBC +1

MR2 works with D10 and D11.

MR!30 Makes this module compatible with Drupal 11. Functionality is working as expected.

RTBC +1

I have created patch for this module, and the MR makes it compatible with d10 and d11. Checked the functionality in both d10 and d11, its working fine.

MR 8 works with D10 and D11.

want to set up a meeting to look at this together @Grevil?

MR 2 works with D10 and D11.

About to push up a commit to bring in gitlab-ci

prashant mishra → closed merge request !3

rahul17 → made their first commit to this issue’s fork.

rahul17 → made their first commit to this issue’s fork.

Adding screenshot of working module from D11.

anish.a → changed the visibility of the branch 3434141-automated-drupal-11 to hidden.

anish.a → changed the visibility of the branch project-update-bot-only to hidden.

MR!1 Makes this module compatible with Drupal 11. Functionality is working as expected.

RTBC +1