#ProjectUpdateBotD11

@mkalkbrenner Thanks for that! Can we have a new release as well?

I did tests locally and seems ok on D11

Upgrade to 3.0.1 and use contributed module Book 2.0.0

Merge request 32 looks good to me!

Following up, after ~60 days of testing in a D11 environment, the compatibility fix works. Closing this ticket as "fixed."

sanduhrs → closed merge request !10

@elendev a new version 3.0.0 is out with D11 support.

pbonnefoi → closed merge request !17

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Assigning to @mkalkbrenner who manages the D9+ branches.

Raising priority to Major since this is a relatively simple fix to enable D11 compatibility.

The patch is simple, applying and working on the Drupal 11.x version. Moving to RTBC.

Drupal 11 is stable for a while now, there won't be any more new patches from the bot! Setting this "Fixed".

Automatically closed - issue fixed for 2 weeks with no activity.

Fixed in 4.0.0

Automatically closed - issue fixed for 2 weeks with no activity.

In
https://git.drupalcode.org/project/blocache/-/merge_requests/4/diffs#395...

the json does not seem to be valid:

  "require": {
    "drupal/core": "^9.1 || ^10" || ^11
  }

"^9.1 || ^10" || ^11 should be "^9.1 || ^10 || ^11"

Looks good

Any chance of a Drupal 11 version?

New release created with this change: 2.0.1

Martin (@mandclu), could this issue be closed or fixed now?
It's been more than a year without activity.

Thanks in advance!

hmm. going to have to use dev version on a Drupal 11 production website :(

Fix in https://www.drupal.org/project/elevenlabs/issues/3525035 🐛 Refactor Active

Automatically closed - issue fixed for 2 weeks with no activity.

I merged the code changes needed for Drupal 11 compatibility. I will create a new release shortly.

Looking at the PHPStan errors reported from GitLab CI, I cannot find any Drupal 11 compatibility issue. They should be fixed in an issue to fix all the PHPStan errors.

Some of the issues reported by PHPStan are false positives.

Thanks @alexpott

This is correct and should be applied as return type to getSubscribedEvents in InitSubscriber

Automatically closed - issue fixed for 2 weeks with no activity.

Thanks!

There are other PHPStan errors which could be caused by incompatibilities with Drupal 11.
I removed the call to user_is_blocked(), which is deprecated in Drupal 11 and removed in Drupal 12.

Amazing, thanks.

Hi, @brendanrjohn I plan to accept the update this weekend.

Automatically closed - issue fixed for 2 weeks with no activity.

The proposed solution is not working for me (Drupal 11, php 8.3) . I made the following patch to use with the one for changing the core version, and it appears to be working.

Bump. This needs to be reviewed.

+1 RTBC. Looks great.

I also approve of the idea of a 2.x branch and release.

Confirmed. Please merge MR !9 rather than 7. MR 9 adds composer.json to the project.

When looking at the Update Status module's report, these two changes are the only changes it sees as needed for D11.

Very simple changes. RTBC. Please merge.

Going with this one too!

You're right. This shows how low-maintained this module is. 1.2.0 released now.

s.kostiukevych → made their first commit to this issue’s fork.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

To be clear if you navigate to /admin/commerce/config/timeslots without the changes above, you get a WSOD that says

The website encountered an unexpected error. Try again later.

ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in /app/web/modules/custom/commerce_timeslots/src/Form/TimeSlotSettingsForm.php on line 34 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 44 of core/lib/Drupal/Core/Form/ConfigFormBase.php).
Drupal\commerce_timeslots\Form\TimeSlotSettingsForm->__construct(Object, Object) (Line: 42)
Drupal\commerce_timeslots\Form\TimeSlotSettingsForm::create(Object) (Line: 36)
Drupal\Core\DependencyInjection\ClassResolver->getInstanceFromDefinition('\Drupal\commerce_timeslots\Form\TimeSlotSettingsForm') (Line: 48)
Drupal\Core\Controller\HtmlFormController->getFormObject(Object, '\Drupal\commerce_timeslots\Form\TimeSlotSettingsForm') (Line: 58)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 593)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 121)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 183)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 53)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle(Object, 1, 1) (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 36)
Drupal\Core\StackMiddleware\AjaxPageState->handle(Object, 1, 1) (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle(Object, 1, 1) (Line: 709)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

So there are some Drupal 11 compatibility issues that need to be fixed. There is this change record https://www.drupal.org/node/3404140 → that was put into play: New parameter added to \Drupal\Core\Form\ConfigFormBase::__construct

It had to be fixed.

Additionally there are some lingering Drupal 10 deprecations that are out there. See 🐛 Uncaught ReferenceError: Modernizr is not defined at timeslots.js Active . This will need to be addressed as well before anyone can successfully use this module on drupal 11

Updated gitlab CI and tugboat. Now needs updates to the tests for Drupal 11 support

dmundra → changed the visibility of the branch 3461614-automated-drupal-11 to hidden.

Any chance of a Drupal 11 version?

Unless strong objections, v2 is fine and users should be encouraged to update to that rather than stay on v1

I rebased this branch on top of latest 8.x-1.x (with merged 📌 Add basic test coverage Active ), and added a commit that changes DataDefinitionUndefinedNormalizer::extractPropertyData() so that it returns an array instead of an object. The declared return type is array, so it was wrong for it to return an object, and now that causes a fatal error with Symfony 7+.

Tests are all green (except PHPStan, which will be fixed separately: 📌 Fix PHPStan errors Active ). Setting this back to "Needs Review". Please review this most recent commit and set to RTBC so we can get this merged! :-)

Yes, PLEASE!!!

Please release this change.

The patch above (#1) did not work for me

Since there is a version out flagged for 11, I assume this is outdated.

Thank you @kerrymick! I also tested it successfully, automatically and manually both in D10 & D11. I ran into 🐛 Views exposed filters don't combine with contextual filters when using exposed form in block Needs work using the standard taxonomy term view for testing, but it is not related to the module itself.

manuel.adan → made their first commit to this issue’s fork.

Tested the patch and can confirm that it works.

Patch tested and works as expected.

We have also been utilising this really useful module on drupal 11 with the above patch without issue, and it would be great to see a release.

Any chance for a commit and and a D11 version?

Merged to branch 2.0.x

jayelless → reopened merge request !13

jayelless → changed the visibility of the branch 3428910-automated-drupal-11 to active.

jayelless → changed the visibility of the branch project-update-bot-only to hidden.

jayelless → closed merge request !13

jayelless → made their first commit to this issue’s fork.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Thanks @aurora-norris! Now we are one error and one test failure away from release:

1) Drupal\Tests\menu_link_weight\FunctionalJavascript\MenuLinkWeightNodeJavascriptTest::testMenuFunctionality
Drupal\Core\Extension\Exception\UnknownExtensionException: Unknown themes: classy.
/builds/issue/menu_link_weight-3431965/web/core/lib/Drupal/Core/Extension/ThemeInstaller.php:136
/builds/issue/menu_link_weight-3431965/web/core/lib/Drupal/Core/Test/FunctionalTestSetupTrait.php:466
/builds/issue/menu_link_weight-3431965/web/core/tests/Drupal/Tests/BrowserTestBase.php:554
/builds/issue/menu_link_weight-3431965/web/core/tests/Drupal/Tests/BrowserTestBase.php:367
/builds/issue/menu_link_weight-3431965/tests/src/FunctionalJavascript/MenuLinkWeightJavascriptTestBase.php:72
--
There was 1 failure:
1) Drupal\Tests\menu_link_weight\Functional\MenuLinkWeightNodeTest::testNodeForm
Behat\Mink\Exception\ExpectationException: Link with label fd2g4uxp found.
/builds/issue/menu_link_weight-3431965/web/core/tests/Drupal/Tests/WebAssert.php:591
/builds/issue/menu_link_weight-3431965/web/core/tests/Drupal/Tests/WebAssert.php:357
/builds/issue/menu_link_weight-3431965/tests/src/Functional/MenuLinkWeightNodeTest.php:38

liam morland → made their first commit to this issue’s fork.

I've further updated the MR to fixed the renamed Yaml class. This is now working on our D11 site.

Automatically closed - issue fixed for 2 weeks with no activity.

I've gotten rid of the error that menu_link_weight is incompatible with this Drupal version

MR !6 doesn't apply properly (patching via composer). MR !4 does

Automatically closed - issue fixed for 2 weeks with no activity.

hamza_niazi → changed the visibility of the branch 3431150-d11-update to hidden.

It is working for me also

Thanks @liuyuanchao.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

hamza_niazi → changed the visibility of the branch project-update-bot-only to hidden.

Automatically closed - issue fixed for 2 weeks with no activity.

Thanks for the feedback @deviantintegral. I think this module is not working anymore as of Drupal 10.3 because hook_form_field_storage_config_edit_form_alter was deprecated → in 10.2. I am assigning this issue to myself so I can fix it for Drupal 10.3+ and 11+. I think the code changes will call for a major version bump on the next release.

This issue was closed pre-maturely. Drupal 11 compatibility is required. I have openned a new issue for this.

🐛 Drupal 11 compatibility fixes for l10n_client Needs work

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

This is where the stdClass object is coming from: https://git.drupalcode.org/project/jsonapi_schema/-/blob/ed083e4274feec8...

It appears that the (object) cast was originally added in this commit (which created the normalizers): 08a4b2f2 (from #3060299: Remove TypeMapper plugins in favor of normalizers → ).

... despite the fact that the parent method's docblock declares a return type of array: https://git.drupalcode.org/project/jsonapi_schema/-/blob/08a4b2f2b930a6a...

It appears @ tried to remove this in cd73c2f2, but then reverted that in d30041d3

So we have some things to detangle here... :-/

Setting this back to Needs Work because the automated tests I'm working on in 📌 Add basic test coverage Active revealed a bug that will affect Drupal 11 compatibility.

I have rebased on top of the commit in 📌 Add basic test coverage Active that causes the issue to demonstrate the failing test (notably it passes on 8.x-1.x).

There was 1 error:
1) Drupal\Tests\jsonapi_schema\Kernel\JsonApiSchemaTest::testJsonApiSchema
PHPUnit\Framework\Exception: Uncaught PHP Exception TypeError: "Drupal\jsonapi_schema\Normalizer\ComplexDataDefinitionNormalizer::normalize(): Return value must be of type ArrayObject|array|string|int|float|bool|null, stdClass returned" at /builds/project/jsonapi_schema/src/Normalizer/ComplexDataDefinitionNormalizer.php line 51
ERRORS!
Tests: 1, Assertions: 0, Errors: 1.

The declaration of normalize() return types revealed a bug with our current code. When the field module is enabled, there are cases where normalize() attempts to return a stdClass object, which is not allowed. I don't know the exact cause of this yet, but we'll have to figure it out before this can be merged.

This existing issue seems to be closely related: 🐛 Decimal field causes error message on custom entity Active

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

@maintainers , please action this!

Automatically closed - issue fixed for 2 weeks with no activity.

Tests are passing on both Drupal 10 and 11! 🎉

I think we still need to declare a minimum minor version of Drupal 10 (eg: ^10.1 or ^10.2).

As far as I can tell, the only change that requires this is the one related to https://www.drupal.org/node/3359695 → , which was introduced in Drupal 10.1. I pushed an amended commit that updates the version constraint to ^10.1.

This is ready for final review! (But of course must wait for 📌 Add basic test coverage Active to be merged.) If anyone has other concerns/considerations, now is the time to voice them! If I don't hear anything by next week then I will assume the previous RTBC applies, along with the newly restored Drupal 10 support per @dmitry.korhov's feedback.

Thanks all!

Rebased on top of the commits from 📌 Add basic test coverage Active so that tests can run. I restored the declaration of Drupal 10 support in jsonapi_schema.info.yml. I also added a commit to ensure tests run on the latest major Drupal version (11). This was disabled in 📌 Add basic test coverage Active because they would fail.

I think we still need to declare a minimum minor version of Drupal 10 (eg: ^10.1 or ^10.2).

@dmitry.korhov: I looked closer and I think you're right that it's possible to support both Drupal 10 and 11. I mistakenly assumed that the method signature changes were a breaking change and that it wouldn't be possible to support both.

Relatedly, I've started writing automated tests for this module in a merge request in 📌 Add basic test coverage Active (which leverages 📌 Add .gitlab-ci.yml Active ). These will be very helpful for continued development and bug fixing, and will also allow us to demonstrate that it works in both Drupal 10 and 11.

There is still more work to be done to finish the first pass at automated tests, but I will rebase this issue's MR onto that one so that we can test this in parallel in the meantime.

please commit and release

avpaderno → changed the visibility of the branch 3429891-automated-drupal-11 to hidden.

Thanks @chrisfromredfin, I've tested the changes and they work for me.

Automatically closed - issue fixed for 2 weeks with no activity.

I also tried the module, and it could work.

@yogen.prasad Did you install the phpoffice/phpword?

ddev composer require phpoffice/phpword": "~0.18.3

New release created with D11 support