🇮🇳India @joshi88

Hi Vishal . Do you have any rough idea, that how long will it take to final review. Because my d10 module depend on this. Once it will be approve then you will consider d10 project…

Ok..

@Vishal. Please guide me what would be my next step..

Thanks @Vishal.

HI Vishal.. Please also guide me for my D10 project.. You had mentioned on #9.

@vishal I have fixed. Please have a look when you will get a chance.

@vishal have you got a chance to review it..

HI @apaderno have you got the chance to review it.

I have fixed above errors.. Please have a look.

Hi @vishal I have removed unwanted comment from zoomnow.js file.
Module name in zoomnow.info file:

name = ZoomNow
description = will show zoom functionality on images.
package = Zoom
core = "7.x"
configure = admin/config/user-interface/zoomnow
dependencies[] = jquery_update

@Vishal Please review it.. Please guide me What I need to do, if still its not eligible.

@apaderno I am working on

Domain Base Css

Project.

#9, @vishal I had worked on Drupal 7 project.
https://www.drupal.org/project/zoomnow → Please have a look.

@vishal What I need to do?

Please fix
FILE: ...htdocs/my_site_name/web/modules/custom/momento/src/MomentoCacheBackend.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
133 | ERROR | unserialize() is insecure unless allowed classes are limited.
| | Use a safe format like JSON or use the allowed_classes option.
--------------------------------------------------------------------------------

FILE: ...y_site_name/web/modules/custom/momento/src/Client/MomentoClientFactory.php
--------------------------------------------------------------------------------
FOUND 39 ERRORS AFFECTING 39 LINES
--------------------------------------------------------------------------------
15 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
20 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
34 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
41 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
43 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
48 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
50 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
55 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
57 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
60 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
61 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
62 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
64 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
65 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
67 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
69 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
71 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
73 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
75 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
78 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
79 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
80 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
81 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
82 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
83 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
84 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
87 | ERROR | [x] Object operator not indented correctly; expected 18 spaces
| | but found 20
93 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
94 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
95 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
96 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
97 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 12
98 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
99 | ERROR | [x] Line indented incorrectly; expected 4 spaces, found 8
100 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 4
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 39 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------/code>

No @vishal.Its my first contribution For Drupal 10.

I have already run --phpcs command..

joshi88 → created an issue.