Contrib.social

Automated Drupal 11 compatibility fixes for ableplayer

Open on Drupal.org →
Created on 15 March 2024, 9 months ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 11.

Changes will periodically be added to this issue that remove deprecated API uses. To stop further changes from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD11" tag from the issue to stop the bot from posting updates.

The changes will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated changes until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD11" tag is left on this issue, new changes will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the changes posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot changes. The bot will still post new changes then if there is a change in the new generated patch compared to the changes that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated changes.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated changes, remove the "ProjectUpdateBotD11" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated changes again, add back the "ProjectUpdateBotD11" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated changes will be posted here.

    If the issue is reopened, then new automated changes will be posted.

    If you are using another issue(s) to work on Drupal 11 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Using the merge request

  1. Review the merge request and test it.
  2. Thoroughly test the changes. These changes are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the merge request, create a new branch and merge request and work from there.

Warning: The 'project-update-bot-only' branch will always be overwritten. Do not work in that branch!

Providing feedback

If there are problems with one of the changes posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Needs review

Version

3.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @project update bot
  • Comment 9 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug info

    Bot run #11-115424

    This patch was created using these packages:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.7
    3. palantirnet/drupal-rector: 0.20.0
  • Merge request !35Automated Project Update Bot fixes → (Merged) created by project update bot
  • Comment 9 months ago →
    project update bot

    This is an automated patch generated using Upgrade Status and Drupal Rector. Please see the issue summary for more details. A merge request (MR) is also openend and updated.

    It is important that any automated tests available are run and that you manually test the changes.

    Drupal 11 Compatibility

    According to the Upgrade Status module → these changes make this module compatible with Drupal 11! 🎉
    Therefore these changes update the info.yml file for Drupal 11 compatibility.

    Leaving this issue open, even after committing the current patch or merging the MR, will allow the Project Update Bot → to post additional Drupal 11 compatibility fixes as they become available in Drupal Rector.

    Debug information

    Bot run #11-137198

    These packages were used to generate the fixes:

    1. drupal/upgrade_status: 4.1.0
    2. mglaman/phpstan-drupal: 1.2.10
    3. palantirnet/drupal-rector: 0.20.1
  • Pipeline finished with Failed
    9 months ago
    Total: 139s
    #137295
  • Comment 8 months ago →
    🇺🇸United States CarlyGerard

    Tested automated code fixes, works as expected.

  • Status changed to RTBC 8 months ago
  • First commit to issue fork.
  • Pipeline finished with Skipped
    8 months ago
    #145097
  • Comment 8 months ago →
    System Message
  • Status changed to Needs review 8 months ago
  • Comment 8 months ago →
    🇺🇸United States theMusician
  • First commit to issue fork.
  • Merge request !41Project update bot only → (Merged) created by mark_fullmer
  • Pipeline finished with Failed
    24 days ago
    Total: 137s
    #352479
  • Pipeline finished with Success
    24 days ago
    Total: 172s
    #352524
  • Comment 24 days ago →
    🇺🇸United States mark_fullmer Tucson

    I functionally tested this module in the context of Drupal 11 and can confirm that the basic functionality -- that of using AblePlayer's field formatter -- works as expected. As such, I'm marking this as RTBC.

    Static analysis of the code did not turn up any Drupal 11 deprecations, per se, but there was missing schema definitions, and outdated implementations in the tests. I updated those where I could -- it's clear that one of the tests is a work-in-progress, so I let that be -- and now PHPUnit tests are passing on both Drupal 10 and Drupal 11.

    Of note: the maintainers have set the minimum core version requirement to ^10.3 in the 3.x development branch. Based on my reading of the latest views in https://www.drupal.org/project/ideas/issues/3357742 🌱 Guidelines for semantic versioning and Drupal core support Needs review , this module can drop support for Drupal 9 in a minor version release, since Drupal 9 is no longer supported.

    I therefore encourage the maintainers to release a 3.2.0 minor version release that provides Drupal 11 compatibility, given that Drupal 11 has been released for nearly six months now. Thank you!

  • Comment 19 days ago →
    🇺🇸United States theMusician

    Thank you Mark. I'll see what I can do this week. The changes look appropriate. Thank you for working through a manual test of the functionality as well. It seems to be all well and good on my local D11 too.

    Are you using this at UT Austin?

  • Comment 18 days ago →
    🇺🇸United States mark_fullmer Tucson

    Thanks, Max! Yes, we use this at UT Austin. A representative implementation: https://cml.music.utexas.edu/about/video-essays-learning-music

  • Comment 12 days ago →
    🇺🇸United States theMusician

    Thank you Mark. The new release has been authored.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024