Automatically closed - issue fixed for 2 weeks with no activity.
- 🇪🇸Spain budalokko Girona
Committed and new release available. Thanks @bwaindwain !
-
budalokko →
committed 6b348ffd on 2.1.x
Issue #3433938 by budalokko, bwaindwain: Drupal 11 compatibility
-
budalokko →
committed 6b348ffd on 2.1.x
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇩🇪Germany Anybody Porta Westfalica
@smustgrave tests are currently failing and I don't have time to fix that currently. If you can confirm 4.x is fine for a stable release or fix the tests, I can of course tag a new beta2 release compatible with Drupal 11. Just don't want to break something in a rush. Thanks!
Thanks, MR is merged. Will make a new release within the next two weeks.
-
b_sharpe →
committed 20618ccd on 1.0.x
Issue #3435423: Automated Drupal 11 compatibility fixes for...
-
b_sharpe →
committed 20618ccd on 1.0.x
- 🇨🇦Canada bisonbleu
The issue I'm having with patches failing is related to additional lines added by Drupal.org's packaging script in views_field_view_test_config.info.yml. I have this
name: 'Views field view test Config' type: module description: 'Provides default views for tests.' package: Testing # version: VERSION core_version_requirement: ^9 || ^10 dependencies: - drupal:views # Information added by Drupal.org packaging script on 2023-02-02 version: '8.x-1.0-beta5' project: 'views_field_view' datestamp: 1675318986
but the patches expect this:
name: 'Views field view test Config' type: module description: 'Provides default views for tests.' package: Testing version: VERSION core_version_requirement: ^9 || ^10 dependencies: - drupal:views
- 🇨🇦Canada mparker17 UTC-4
@cb_govcms, good catch, thank you!
@nghua, thanks for fixing the issues raised by myself and @cb_govcms. (I don't have permission to mark the thread that @cb_govcms started as "resolved" however)
I've code-reviewed the updated merge-request, and I'm happy with it. I also re-ran my test case from earlier on a freshly-cloned copy of the merge request, and it works for me.
I'm going to mark this as Reviewed and Tested by the Community. Thanks everyone!
- 🇨🇦Canada mregnault
I had trouble installing the patch with Drupal 10.3.10, apparently some of the modifications on the
content_access.module
file can not be applied (the changed order in the use statements). I recreated a patch by changing just that and it works for me. I leave the patch here in case someone stumbles upon the same issue. - First commit to issue fork.
- 🇺🇸United States smustgrave
Possible to get a tagged release of this module please.
- 🇧🇪Belgium dieterholvoet Brussels
I spent the bigger part of the day on ECK, merging issues, fixing the automated test suite and fixing all code style issues in the codebase. The only other issue I want to merge before creating a release is 📌 EckEntityRouteProvider does not use link templates Needs review , but that one needs a rebase. After that, I’m going to do a last round of manual testing and create a new release.
- 🇫🇷France dqd London | N.Y.C | Paris | Hamburg | Berlin
#19 📌 Automated Drupal 11 compatibility fixes for eck Needs review : There doesn't seem to be a good reason to drop support for Drupal 9.4, so I'm adding that back.
Absolutely right. 200% Agreed. TBH, I was in conflict on this previously already twice, but it was based on a "trend" in many contrib regarding PHP version support in sync with Drupal core. I wondered why so many users wanted me to remove Drupal 9 support on projects I maintain and they convinced me at this time. But this surely affects not all contrib modules.
#13 📌 Automated Drupal 11 compatibility fixes for eck Needs review : Sorry, but to be clear for the logs, there haven't been raised any issue but only work has been continued on MR50 in line with update bot and previous contributors and it just got some minor basic adds/changes for ^11 compatibility as a starting point. And functional and procedual changes and updates in the code base should always be rather discussed carefully with the project maintainers anyways. Also, please do not assign update bot issues to yourself.
Thanks @dieterholvoet for finally updating/fixing and merging a carefully written out commit. Do you prefer any existing follow ups to work on with prio for an upcoming release?
- @bisonbleu opened merge request.
-
mradcliffe →
committed f7be7081 on 2.0.x
Issue #3428523 by mradcliffe: Updates to use attribute class discovery...
-
mradcliffe →
committed f7be7081 on 2.0.x
- 🇸🇰Slovakia poker10
Thanks for the thoughts @firfin. Week or two ago, I updated the XML Sitemap project description (see https://www.drupal.org/project/xmlsitemap → ), so the branches should be described also here. It is true, that the 2.0.x branch is with the D11 support and I do not think we will add it to the previous 8.x-1.x branch. If you feel that this IS should be updated as well, feel free to update it.
I am not aware of any new issues with the 2.0.x branch so far. One of the reasons it was tagged as beta was the fact, that I am not as familiar with the D8+ branches of the module (was previously maintaining only the D7 branch). But if there won't be any new issues, I think that we can tag a stable release soon.
- 🇺🇸United States pcate
After applying the latest MR to the 3.x dev branch and runing the Upgrade Status module it shows the following issue:
File name: modules/contrib/gcontent_moderation/tests/modules/gcontent_moderation_test/src/GroupStateTransitionValidation.php Line: 96 Error: Call to deprecated method loadRevision() of interface Drupal\Core\Entity\EntityStorageInterface. Deprecated in drupal:10.1.0 and is removed from drupal:11.0.0. Use Drupal\Core\Entity\RevisionableStorageInterface::loadRevision instead.
- 🇺🇸United States pcate
Rector patch applied cleanly and after running Upgrade Status module → it shows are Drupal 11 compatible.
- 🇺🇸United States pcate
Rector patch applied cleanly and after running Upgrade Status module → it shows are Drupal 11 compatible.
- 🇺🇸United States pcate
Patch #4 ( https://www.drupal.org/files/issues/2024-10-31/new_relic_rpm-3433555-4_0... → ) applied cleanly and after running Upgrade Status module → it shows are Drupal 11 compatible.
- 🇨🇦Canada adriancid Montreal, Canada
I give you permission to handle the issue queue for the moment, after I see some contribution I can give you more permissions.
- 🇳🇱Netherlands firfin
This is a pretty long thread. But would it be fair to summarize it as: for D11 use version 2?
And in that case can we add a summary to the OP?
Finally, a link to the issues stopping a official / non-beta release would be helpful, so people can help with those.
Because not everyone is capable or able to use beta-releases ( not skilled enough with composer, government compliance, etc.) - 🇺🇸United States pcate
Rector MR #3 applied cleanly and after running Upgrade Status module → it shows are Drupal 11 compatible.
- 🇨🇭Switzerland znerol
Another follow-up: 📌 Inject ModuleExtensionList into EmbedTypeBase constructor Active
- 🇺🇸United States pcate
Rector patch applied cleanly and after running Upgrade Status module → it shows are Drupal 11 compatible.
- 🇺🇸United States pcate
Rector patch applied cleanly and after running Upgrade Status module → it shows are Drupal 11 compatible.
- 🇺🇸United States pcate
Rector patch applied cleanly and after running Upgrade Status module → it shows are Drupal 11 compatible.
-
mradcliffe →
committed 4a612c7d on 2.0.x
Issue #3428523 by mradcliffe: Adds any type as fallback for list data...
-
mradcliffe →
committed 4a612c7d on 2.0.x
- 🇧🇪Belgium zero2one
Thank you for the pull request.
Changes are merged into the 8.x-1.x branch.
- 🇨🇭Switzerland znerol
Automated tests are green for MR !25 . I did some manual testing with
entity_embed
andentity_browser
. Haven't come across any problems so far. Also filed 📌 Add test coverage for EmbedSettingsForm Active as another follow-up. - 🇮🇳India arunkumark Coimbatore
Thanks for showing interest in the Module. I would recommend working on active issues and helping the module close the issues.
-
mradcliffe →
committed 4f0f0bdd on 2.0.x
Issue #3428523 by mradcliffe: Updates tests to include previous major
-
mradcliffe →
committed 4f0f0bdd on 2.0.x
-
mradcliffe →
committed 028105ce on 2.0.x
Issue #3428523 by mradcliffe: Updates for Drupal 11
-
mradcliffe →
committed 028105ce on 2.0.x
- First commit to issue fork.
- 🇮🇳India patelh84
Verified MR !3 with Drupal 10 and Drupal 11, functionality is working as expected and module is compatible with Drupal 11.
- @znerol opened merge request.
- 🇨🇭Switzerland znerol
There are still legit unresolved comments in MR !24. Going through the history of this issue, I notice that there has been a release with a BC break which had to be reverted subsequently (#50). I am not surprised that the maintainers are reluctant to merge this as is.
It was suggested to keep changes to a minimum when adapting contrib modules to new core releases. I very much agree with that approach. Based on the recommendation in #53 I'm going to work on a new MR with only the changes required for a D11 compatible release. The rest should go into dedicated issues:
- 💬 Drop support of CKEditor4 and include functionjavascript tests for ckeditor5 Needs work
- 🐛 PHPStan issue reported in gitlab Active
- 🐛 Fix PhpCS issue reported in gitlab RTBC
- 📌 Fix ESLint pipeline Active
- 🇮🇳India patelh84
Verified MR6 with Drupal 10 and Drupal 11, functionality is working as expected and module is compatible with Drupal 11.
- 🇵🇱Poland sandboxpl Poland 🇵🇱
All right, I've created a follow up issue to check the recaptcha checkbox part of tests: https://www.drupal.org/project/simple_recaptcha/issues/3495253 📌 JavaScript tests - recaptcha checkbox does not work anymore Active
And new release for Drupal 11 compat is now available: https://www.drupal.org/project/simple_recaptcha/releases/8.x-1.0-beta9 →Thanks everyone for all the help with this issue!
- 🇮🇳India rahul1707
I have added D11 compatibility issue fixes in MR !3. Kindly review it.
There is one existing ajax error while updating product to cart and patch is already available for the same.
Patch - https://www.drupal.org/files/issues/2023-06-02/3364372-5.patch →
Issue - https://www.drupal.org/project/commerce_ajax_atc/issues/3364372 🐛 Ajax error after update commerce cart Fixed - Issue created by @sarigaraghunath
- 🇩🇰Denmark beltofte Copenhagen 🇩🇰
Fixed in https://www.drupal.org/project/siteimprove/releases/3.0.1 → .
Thanks for helping with the Drupal 11 support.
-
sandboxpl →
committed 1950d7c8 on 8.x-1.x authored by
kim.pepper →
[#3451320] Drupal 11 compatibility
-
sandboxpl →
committed 1950d7c8 on 8.x-1.x authored by
kim.pepper →
-
dieterholvoet →
committed 3d008fa8 on 2.x authored by
project update bot →
Issue #3430042 by sarigaraghunath, project update bot, realityloop, dqd...
-
dieterholvoet →
committed 3d008fa8 on 2.x authored by
project update bot →
- 🇧🇪Belgium dieterholvoet Brussels
There doesn't seem to be a good reason to drop support for Drupal 9.4, so I'm adding that back.
- 🇧🇪Belgium dieterholvoet Brussels
dieterholvoet → changed the visibility of the branch 3430042-automated-drupal-11 to hidden.
- Issue created by @sarigaraghunath
- 🇮🇳India rahul1707
Verified MR !13 with Drupal 10 and Drupal 11, functionality is working as expected and module is compatible with Drupal 11.
Moving this to RTBC.
- 🇩🇪Germany Anybody Porta Westfalica
@heddn, so it actually makes sense now, to merge #3494209: Drupal 7 to Drupal 11 migration runs forever and this issue!
Merge now and proceed here also fixing that issue? (To simplify testng).
Important note is: The other issue is still unsolved and we have not found the root cause yet.
Leaving for @heddn to decide how to proceed. We could also copy the D11 changes from here over to the other issue for now to keep them separate for now...
- 🇮🇳India manishvaity
MR!2 Makes this module compatible with Drupal 11. Functionality is working as expected.
RTBC +1
- 🇩🇪Germany Grevil
HA, no way. We actually run into 🐛 Drupal 7 to Drupal 11 migration runs forever Active through the tests now!
ERROR: Job failed: execution took longer than 1h0m0s seconds
@heddn, so it actually makes sense now, to merge 🐛 Drupal 7 to Drupal 11 migration runs forever Active and this issue!
- 🇩🇪Germany Anybody Porta Westfalica
@phenaproxima I agree with @heddn's comment, what do you think? Would be great to get this fixed, looking at the stack of modules waiting for this to be fixed. For that reason setting priority to Major.
First I think we now need to agree on how to proceed.
- 🇩🇪Germany Anybody Porta Westfalica
Thanks for the fixes @grevil! Hopefully entity_embed will become D11 compatible soon...
- 🇮🇳India rahul1707
MR !7 works for both Drupal 10 and Drupal 11. Functionality is working as expected and module is D11 compatible.
Moving this to RTBC.
- 🇩🇪Germany Grevil
This should be it. Let's wait for entity_embed to get official D11 compatibility.
- Issue created by @annoul4
- 🇮🇳India manishvaity
MR!3 Makes this module compatible with Drupal 11. Functionality is working as expected.
RTBC +1
- 🇩🇪Germany yannickoo Berlin
This has been released with the latest version of YAML Editor 🤗
- 🇩🇪Germany yannickoo Berlin
Hey jradhak! Thanks for your support, really appreciated 🤗 I have just realized a new version that is compatible with Drupal 11 🚀
- 🇮🇳India abhi_khandelwal Gandhinagar
The #MR2 works for both Drupal 10 and Drupal 11. Attaching the upgrade status screenshot for reference. Moving the issue to RTBC.
- 🇮🇳India peelas02
verified functionality MR8 in Drupal 10 and Drupal 11, working as expected
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇨🇦Canada joseph.olstad
@jsobiecki , please tag 2.1.1 , this fix is only in the dev-2.x right now, should have a tag !
- 🇮🇳India shashi_shekhar_18oct
shashi_shekhar_18oct → changed the visibility of the branch 2.0.x to hidden.
- @shashi_shekhar_18oct opened merge request.
- First commit to issue fork.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇨🇦Canada bisonbleu
Tried all 3 MR patches. Unfortunately only the project-update-bot patch from MR11 applies correctly when it is added in composer.json. So something is not right in MR12 and MR13.
Automatically closed - issue fixed for 2 weeks with no activity.
Automatically closed - issue fixed for 2 weeks with no activity.
-
liam morland →
committed 74060fdc on 5.2.x
Issue #3430593: Use contructor property promotion in FillPdfAccessHelper
-
liam morland →
committed 74060fdc on 5.2.x
- Issue created by @emptyvoid
- 🇨🇦Canada bwaindwain
Tried MR12 in D10.4.0 and D11.1.0. Works fine. +1 RTBC
Thanks @budalokko
-
martygraphie →
committed 170bc76f on 1.0.x authored by
rvivancos →
Issue #3430747 by rvivancos, leontin: Automated Drupal 11 compatibility...
-
martygraphie →
committed 170bc76f on 1.0.x authored by
rvivancos →
- First commit to issue fork.
- 🇩🇪Germany Grevil
🐛 Drupal 7 to Drupal 11 migration runs forever Active isn't finished yet anyway and the current MR there, doesn't solve that issue as explained in the comments.
- 🇩🇪Germany Grevil
Yea no idea. I haven't decorated a symfony service before, so I am unsure what I am doing wrong here.... https://symfony.com/doc/current/service_container/service_decoration.html is not very helpful to be honest.
The current implementation should be correct, as we autowire the class_resolver as the constructor argument, but I still get the following error:
[error] ArgumentCountError: Too few arguments to function Drupal\layout_builder_st\DependencyInjection\DecoratedClassResolver::__construct(), 0 passed in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 and exactly 1
Even if I do it the non autowire way, like described in the docs, I get the exact same error.
If I add:
class_resolver: ~
I get an error, that the decorated class couldn't get found (which makes sense, as we delete it, but its in the docs for some reason).@phenaproxima do you have experience with decorating symfony services? Could you help me finish this?
- 🇪🇸Spain omarlopesino
It breaks in Drupal 11.1 because it does not have the function layout_builder_at_form_entity_form_display_edit_form_alter anymore, which is used by this module.
Please check this patch that adds backwards compatibility among different Drupal versions. if you see it ok, we can add it to the bot merge request.
-
martygraphie →
committed 31c24098 on master authored by
lleytere →
Issue #3489841: Drupal 11 compatibility fixes for components_extras...
-
martygraphie →
committed 31c24098 on master authored by
lleytere →
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
There is no need for
::backwardsCompatibleCall()
if the minimum is set to Drupal 10.3.A release node should be made for 2.0.x.
Is there a reason 2.0.x is not marked as a recommended branch?
-
liam morland →
committed a116cd9f on 5.2.x
Issue #3430593: Mark as nullable params with null default
-
liam morland →
committed a116cd9f on 5.2.x
- @sarigaraghunath opened merge request.
- First commit to issue fork.
-
oksana-c →
committed bd3490e1 on 8.x-1.x authored by
mark_fullmer →
Issue #3485965 by mmarler, mark_fullmer, patelh84, cchiste, oksana-c:...
-
oksana-c →
committed bd3490e1 on 8.x-1.x authored by
mark_fullmer →
- First commit to issue fork.
- 🇫🇷France izus
duplicate of https://www.drupal.org/project/search_api_attachments/issues/3474910 ✨ Drupal 11 Ready Needs review
- 🇮🇳India chandansha
I have Compatibility this module for drupal 11.
Please review.
Thanks! - @chandansha opened merge request.
- First commit to issue fork.
- @priti197 opened merge request.
- First commit to issue fork.
- Issue created by @abhi_khandelwal
- 🇵🇱Poland sandboxpl Poland 🇵🇱
Okey this will lead us to nowhere, even after validating that the click event is triggered, and adding 30s timeout, it keeps spinning and spinning:
going back from iframe to page content still shows empty checkbox:
This will lead us to nowhere and will take lot of time to investigate , since it is only 3 tests and all other tests are passing, I will create a separate issue for that ( it could be that we will have to completely change the idea for the checkbox itself, maybe it is not even possible to test it anymore ). - 🇧🇪Belgium dieterholvoet Brussels
We should probably make sure automated tests are passing before committing/releasing this one: 🐛 Fix tests Active
- 🇨🇭Switzerland ytsurk Switzerland
Hi Sariga,
we appreciate your work on 📌 Drupal 11 compatibility Active and are not looking for a co-maintainer currently.
But if you keep steady contributing, we can talk about.
- 🇧🇪Belgium dieterholvoet Brussels
Thanks for offering, but your account is a bit too new for me to trust you with access to this widely used module. Also, I think there are enough maintainers right now. About the D11 compatible release: I'll work on that soon.
- @anjalikishor opened merge request.
- 🇵🇱Poland sandboxpl Poland 🇵🇱
For tests, it seems that switch to recaptcha iframe is working properly, the only thing we miss is clicking on right element, let's try to switch from .recaptcha-checkbox to #recaptcha-anchor element
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇧🇪Belgium matthiasm11
Thanks for the work. I've created a new release 2.2.0 containing support for D11.
I'll leave this issue open for a while, as per option (1) proposed by the update bot.
- @rahul17 opened merge request.
- First commit to issue fork.
-
sourav_paul →
committed d7218ea9 on 8.x-1.x
Issue #3488334: Drupal 11 compatibility fixes for fakeobjects
-
sourav_paul →
committed d7218ea9 on 8.x-1.x
- 🇮🇳India rahul1707
I have changed core_version_requirement in info.yml file as suggested in #5. Kindly merge this MR.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
I was able to reproduce the test fail locally, but wasn't able to work out what the cause is.
There are a few eslint errors too which could clean up the javascript but I assume that can be done in a follow up.
- 🇺🇸United States luke.leber Pennsylvania
Stand by for 4.0.0-alpha2 as soon as the main pipeline goes green.
-
luke.leber →
committed 509c85ed on 4.0.x authored by
shashi_shekhar_18oct →
Issue #3433346: Automated Drupal 11 compatibility fixes for juicebox
-
luke.leber →
committed 509c85ed on 4.0.x authored by
shashi_shekhar_18oct →
- 🇺🇸United States luke.leber Pennsylvania
I've manually tested the common use cases for this module against 11.1 and 10.4 including...
- Media reference field configured to display juicebox formatters
- Image field configured to display juicebox formatters
- View configured to display content as juicebox galleries
Given we have green tests and a solid manual test, I'm going to merge this in and cut 4.0.0-alpha2 for folks waiting. If anything did manage to slip through, I'll be available to triage things throughout the week after the day job.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
The others can be closed by a project owner.
- 🇦🇺Australia kim.pepper 🏄♂️🇦🇺Sydney, Australia
It seems the Automated Drupal 11 compatibility bot force pushes over our MR.
I've created a new one.
- @kimpepper opened merge request.
- 🇺🇸United States luke.leber Pennsylvania
luke.leber → changed the visibility of the branch 4.0.x to hidden.
- 🇺🇸United States luke.leber Pennsylvania
luke.leber → changed the visibility of the branch 3433346-automated-drupal-11 to hidden.
- 🇺🇸United States luke.leber Pennsylvania
Green on 10.4.0, 11.0.8, and 11.1.0.
Testing on PREVIOUS_MAJOR, PREVIOUS_MINOR, and CURRENT seems very logical to me. Setting to Needs Review for manual testing.
- 🇺🇸United States luke.leber Pennsylvania
This module does, indeed need work, as there are missing schema definitions.
Leaving NW so that someone can look into the test failures, or I can pick them back up when I'm able.
- @abhi_khandelwal opened merge request.
- First commit to issue fork.
- 🇵🇱Poland sandboxpl Poland 🇵🇱
ah the gitlab-ci.yml file is added via fork , so this test won't trigger the pipeline
- 🇵🇱Poland sandboxpl Poland 🇵🇱
The merge request is compatible enough to make it all work, but I see the js tests failing and the issue is following:
1) we switch to recaptcha iframe and click the checkbox, it seems that it somewhat has been clicked:
https://issue.pages.drupalcode.org/-/simple_recaptcha-3451320/-/jobs/374...
2) yet on the next screen we can see that checkbox is empty again:
https://issue.pages.drupalcode.org/-/simple_recaptcha-3451320/-/jobs/374...The generated output of recaptcha checkbox is following:
<span class="recaptcha-checkbox goog-inline-block recaptcha-checkbox-unchecked rc-anchor-checkbox recaptcha-checkbox-clearOutline" role="checkbox" aria-checked="false" id="recaptcha-anchor" tabindex="0" dir="ltr" aria-labelledby="recaptcha-anchor-label"> <div class="recaptcha-checkbox-border" role="presentation"> </div> <div class="recaptcha-checkbox-borderAnimation" role="presentation"> </div> <div class="recaptcha-checkbox-spinner" role="presentation"> <div class="recaptcha-checkbox-spinner-overlay"> </div> </div> <div class="recaptcha-checkbox-checkmark" role="presentation"></div> </span>
And what seems to be missing here is:
1) Element class remains recaptcha-checkbox-unchecked while it should become recaptcha-checkbox-checked
2) Aria attribute aria-checked remains false , while it should be switched to trueIt seems that final step of 3 failing js tests is not working with current markup/behavior of recaptcha widget things we can try:
1) Click on element with ID = recaptcha-anchor and not class = recaptcha-checkbox
2) optionally wait until aria-checked attribute has been really changed to true , and/or element class has been successfuly changed to recaptcha-checkbox-checkedInspiration:
https://github.com/remarkablemark/remarkablemark.github.io/blob/master/_...
https://git.drupalcode.org/project/recaptcha/-/blob/8.x-3.x/tests/src/Fu... - 🇺🇸United States luke.leber Pennsylvania
The update bot has messed up the support ranges here.
The deprecation helper service was introduced in Drupal 10.1.3, but it has the module support range specified as >=10. That means that 10.0.0 through 10.1.2 users would have their sites killed by this.
The support range has to be at minimum
^10.1.3 || ^11
here. I strongly recommend using^10.3 || ^11
since that's what we're able to test on though...Setting back to needs work. If no one else picks this up before I'm able to, I'll make the commit myself, but in the meantime feel free.
- 🇺🇸United States fkelly
In order to make tests run, we need to integrate gitlab-ci.yml into the branch we are trying to test. A few days ago I put a gitlab-ci yml into the 4.0.x branch but that's not sufficient. We somehow need to replace the drupalci.yml file (Now obsolete) with a gitlab-ci.yml file in the branch we are trying to use for the update.
I am not familiar with all the steps and "privileges" needed to do this. The code that milan, shashi and manishaity are proposing may do this but we need to correct an up-to-date gitlabci.yml file to make it happen.
I will ping (email) our senior maintainer, Luke, to see if he can help move this along.
Personally I am spending all my Drupal time trying to find/develop an alternative recommended approach to using Juicebox for slideshows within Drupal. Nearly 10 years ago the Drupal wizards switched over to using a media module instead of just ftp'ng jpg and xml files up to sites/files. All the recent developments for slideshows are using media. I think that the patches now pending may get us to a stable Drupal 11 release but I recommend that we plan to make Juicebox obsolete after that.
Sorry for the delays and for my lack of expertise.
- 🇺🇸United States fkelly
fkelly12054@gmail.com → made their first commit to this issue’s fork.
- @sarigaraghunath opened merge request.
- First commit to issue fork.
- @abhinavk opened merge request.
- First commit to issue fork.
- 🇩🇪Germany Anybody Porta Westfalica
@heddn: See 🐛 Drupal 7 to Drupal 11 migration runs forever Active for a major issue in D11 - could you maybe review that one?
Please decide, if we should incorporate these changes here or keep them separate. Afterwards indeed we should fix the tests, as written above.
- @rahul17 opened merge request.
- Issue created by @sarigaraghunath
- 🇮🇳India manishvaity
MR!12 Makes this module compatible with Drupal 11. Functionality is working as expected.
RTBC +1
- @sarigaraghunath opened merge request.
- First commit to issue fork.
- @shashi_shekhar_18oct opened merge request.
- First commit to issue fork.
- @sarigaraghunath opened merge request.
- First commit to issue fork.
- 🇺🇸United States daddison
Hi maintainers. Thanks for this useful module. The update bot patch contains trivial changes for Drupal 11. When will you release a new stable version with support for Drupal 11?
- Issue created by @jradhak
- heddn Nicaragua
This is mostly postponed on getting entity_embed compatible. But while we are waiting for that, there are still some obvious failures, both in phpstan and in the unit tests that should be rectified to help keep this moving. We should investigate if we move to the new version of
Masterminds\HTML5\Parser\StringInputStream
and what version of that we should support. Secondly, we should fixFileEntitySourceFieldInstanceTest
and any other failures of similar nature. - 🇮🇳India rahul1707
Getting below issue in Drupal 11 which has been resolved.
TypeError: Cannot access offset of type Drupal\Core\StringTranslation\TranslatableMarkup in isset or empty in Drupal\Core\Plugin\DefaultPluginManager->doGetDefinition() (line 45 of core/lib/Drupal/Component/Plugin/Discovery/DiscoveryTrait.php).
Kindly review this.
- 🇩🇪Germany Anybody Porta Westfalica
📌 Automated Drupal 10 compatibility fixes Needs review rector adds a trait to the tests, should we copy that over and close the D10 issue already?
- 🇦🇺Australia interlated
PHP 8.4 warnings from latest git pull
PHP Deprecated: Drupal\layout_paragraphs\Access\LayoutParagraphsBuilderAccess::access(): Implicitly marking parameter $operation as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/layout_paragraphs/src/Access/LayoutParagraphsBuilderAccess.php on line 52
PHP Deprecated: Drupal\layout_paragraphs\Access\LayoutParagraphsBuilderAccess::access(): Implicitly marking parameter $component_uuid as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/layout_paragraphs/src/Access/LayoutParagraphsBuilderAccess.php on line 52
PHP Deprecated: Drupal\layout_paragraphs\Access\LayoutParagraphsBuilderAccess::access(): Implicitly marking parameter $paragraph_type as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/layout_paragraphs/src/Access/LayoutParagraphsBuilderAccess.php on line 52
PHP Deprecated: Drupal\xmlsitemap\XmlSitemapStorage::__construct(): Implicitly marking parameter $memory_cache as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/xmlsitemap/src/XmlSitemapStorage.php on line 43
PHP Deprecated: Drupal\xmlsitemap\XmlSitemapStorage::doLoadMultiple(): Implicitly marking parameter $ids as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/xmlsitemap/src/XmlSitemapStorage.php on line 78
PHP Deprecated: Drupal\xmlsitemap\Entity\XmlSitemap::loadByContext(): Implicitly marking parameter $context as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/xmlsitemap/src/Entity/XmlSitemap.php on line 200
PHP Deprecated: Drupal\xmlsitemap\XmlSitemapInterface::loadByContext(): Implicitly marking parameter $context as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/xmlsitemap/src/XmlSitemapInterface.php on line 147
PHP Deprecated: auto_detect_line_endings is deprecated in /Users/jrobens/Sites/gardensofstone2/web/sites/default/civicrm.settings.php on line 573
PHP Deprecated: Log::log(): Implicitly marking parameter $priority as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/vendor/pear/log/Log.php on line 240
PHP Deprecated: Smarty::getTemplateVars(): Implicitly marking parameter $_ptr as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/vendor/civicrm/civicrm-packages/Smarty/Smarty.class.php on line 1086
PHP Deprecated: Drupal\civicrm\Form\UserProfile::buildForm(): Implicitly marking parameter $user as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/civicrm/src/Form/UserProfile.php on line 71
PHP Deprecated: Drupal\context_ui\Form\ConditionDeleteForm::buildForm(): Implicitly marking parameter $context as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/patched/context/modules/context_ui/src/Form/ConditionDeleteForm.php on line 92
PHP Deprecated: Drupal\context_ui\Form\ReactionDeleteForm::buildForm(): Implicitly marking parameter $context as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/patched/context/modules/context_ui/src/Form/ReactionDeleteForm.php on line 95
PHP Deprecated: Drupal\context\Reaction\Blocks\Form\BlockDeleteForm::buildForm(): Implicitly marking parameter $context as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/patched/context/src/Reaction/Blocks/Form/BlockDeleteForm.php on line 95
PHP Deprecated: Drupal\context\Reaction\Blocks\Form\BlockFormBase::buildForm(): Implicitly marking parameter $context as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/patched/context/src/Reaction/Blocks/Form/BlockFormBase.php on line 206
PHP Deprecated: Drupal\fontawesome\Form\EditorIconDialog::buildForm(): Implicitly marking parameter $editor as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/patched/fontawesome/src/Form/EditorIconDialog.php on line 71
PHP Deprecated: Drupal\layout_paragraphs\Form\EditComponentForm::buildForm(): Implicitly marking parameter $layout_paragraphs_layout as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/layout_paragraphs/src/Form/EditComponentForm.php on line 21
PHP Deprecated: Drupal\layout_paragraphs\Form\EditComponentForm::buildForm(): Implicitly marking parameter $component_uuid as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/layout_paragraphs/src/Form/EditComponentForm.php on line 21
PHP Deprecated: Drupal\layout_paragraphs\Form\DeleteComponentForm::buildForm(): Implicitly marking parameter $layout_paragraphs_layout as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/layout_paragraphs/src/Form/DeleteComponentForm.php on line 63
PHP Deprecated: Drupal\layout_paragraphs\Form\DeleteComponentForm::buildForm(): Implicitly marking parameter $component_uuid as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/layout_paragraphs/src/Form/DeleteComponentForm.php on line 63
PHP Deprecated: Drupal\media_bulk_upload\Form\MediaBulkUploadForm::buildForm(): Implicitly marking parameter $media_bulk_config as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/patched/media_bulk_upload/src/Form/MediaBulkUploadForm.php on line 176
PHP Deprecated: Drupal\photos\Form\PhotosUploadForm::buildForm(): Implicitly marking parameter $node as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/patched/photos/src/Form/PhotosUploadForm.php on line 184
PHP Deprecated: Drupal\photos\Controller\PhotosRearrangeController::access(): Implicitly marking parameter $account as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/patched/photos/src/Controller/PhotosRearrangeController.php on line 125
PHP Deprecated: Drupal\photos\Controller\PhotosRearrangeController::access(): Implicitly marking parameter $node as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/patched/photos/src/Controller/PhotosRearrangeController.php on line 125
PHP Deprecated: Drupal\photos\Controller\PhotosRearrangeController::access(): Implicitly marking parameter $user as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/patched/photos/src/Controller/PhotosRearrangeController.php on line 125
PHP Deprecated: Drupal\tfa\Form\TfaOverviewForm::buildForm(): Implicitly marking parameter $user as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/tfa/src/Form/TfaOverviewForm.php on line 108
PHP Deprecated: Drupal\tfa\Form\TfaSetupForm::buildForm(): Implicitly marking parameter $user as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/tfa/src/Form/TfaSetupForm.php on line 163
PHP Deprecated: Drupal\tfa\Form\TfaDisableForm::buildForm(): Implicitly marking parameter $user as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/tfa/src/Form/TfaDisableForm.php on line 95
PHP Deprecated: Drupal\ds\Form\FieldDeleteForm::buildForm(): Implicitly marking parameter $request as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/contrib/ds/src/Form/FieldDeleteForm.php on line 77
PHP Deprecated: Drupal\photos\Controller\PhotosImageViewController::__construct(): Implicitly marking parameter $entity_repository as nullable is deprecated, the explicit nullable type must be used instead in /Users/jrobens/Sites/gardensofstone2/web/modules/patched/photos/src/Controller/PhotosImageViewController.php on line 72
[success] Cache rebuild complete. Thanks for the updates kalash :).
Looks like there might be a typo at https://git.drupalcode.org/project/gcontent_moderation/-/merge_requests/..., changing the decorates from gcontent_moderation to content_moderation?
- 🇪🇸Spain budalokko Girona
Any caring soul wishing to test MR 12?
Patch -> https://git.drupalcode.org/project/plupload_widget/-/merge_requests/12.diff