#Drupal 11 compatibility

Automatically closed - issue fixed for 2 weeks with no activity.

@kmonty, there's already a duplicate open issue just as you wished for 📌 Automated Drupal 11 compatibility fixes for layout_builder_st Needs review

It has nothing but the bot changes however be warned, there are currently 16 errors in the automated tests.

I highly suggest you re-consider your opinion and start rowing with us here because we're down to only 4 errors in this issues merge request.

Would be nice to get some extra eyes on this and finish it.

Looks good, thanks.

greg boggs → made their first commit to this issue’s fork.

With this patch I got this module working in Drupal 11. I added the fixes by @Project Update Bot here to the patch then I made extra fixes. If you apply this patch you need to download this file jquery-migrate-3.5.2.min.js from https://github.com/jquery/jquery-migrate into \md_slider\assets\js\libraries folder and delete the old version jquery-migrate-1.2.1.min.js.

If you applied the patch at issue Fix the errors/warnings reported by PHP_CodeSniffer 📌 Fix the issues reported by phpcs Active you may have to take if off as this patch conflicts with it.

cyrille.miskiewicz → changed the visibility of the branch d11-compatibility-d10+-only to hidden.

cyrille.miskiewicz → changed the visibility of the branch project-update-bot-only to active.

Can we get a new, official release for the D11 compatibility, please?

The tests (and the module it'self) has been broken for quite some time yet thanks to the work in this issue not only is the merge request make the module functional in Drupal 11.1.3 but we're down to only 4 automated test errors thanks to the recent changes by @lkmorland.

The deprecations in 10.3/10.4 made things complicated, don't forget the massive changes in PHPUnit it'self which was significantly overhauled upstream and the switch from jenkins to gitlab lost our history of test results as those were flushed out.

We're very close to getting all the tests to pass.

Check this patch for Drupal 11 Compatibility

Thank you for testing this sethhill. It was just released as 1.0.3

Changing status back to active to receive future updates.

Thanks for the confidence in #55 and #56. Unfortunately, I will not likely have time to work more on this.

It would be good to get tests passing first, even if just on Drupal 10. I have them passing in 📌 Make coding standards fixes Active , though that required removing some of the tests.

The scope of this PR is unmanagable in my opinion. For example, the first file in the PR is js/contextual.js. That file has nothing to do with D11 compatibility.

That issue is addressed in 🐛 Contextual links for translation are removed by core RTBC .

The PR in this issue goes against standard issue encapsulation practices and puts roadblocks to the community to participate. It's not even clear to me what should be tested here, as this has turned into a meta issue, rather than a D11 compatibility issue.

Humble suggestion: close issues with merges that are considered blockers first?

I tested it locally with D11 and I did not notice any issues.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Merged & tagged

Automatically closed - issue fixed for 2 weeks with no activity.

@jibran, please merge this Drupal 11 release fix and please also tag a release.

This module is one of our few remaining override modules and we'd prefer to normalize this situation.

Extensive testing has been performed over the past 2 months. No issues with this module running against Drupal 11.1.3.

setting to active for @lkmorland
only 4 to go.

I reverted the changes I attempted, they didn't fix anything.

@lkmorland, you're on a roll, I'll let you continue with this.

Small change I made was added in an attempt to resolve the 403 errors on the jsonapi

https://issue.pages.drupalcode.org/-/layout_builder_st-3431600/-/jobs/44...

If the change doesn't help (specifying jsonapi as a dependency) which I suspect it won't, perhaps lacking a permission as a 403 is an access denied error.

I did add some extra layout permissions also in an attempt to resolve the 200 status code assertion

@liammorland, thanks, you fixed 3 errors. I just pushed a couple small changes, we'll see if it helps.

Can we get a new, official release for the D11 compatibility, please?

Downloaded and applied this patch. Functionality appears to be working as expected in D11. Marking as RTBC.

Can we get a D11 release?

Currently is four options on the table:

1. Fix the failing test and then ping the maintainer.
2. Fork this project and publish a release of the fork.
3. Use composer lenient. (I don't like this option)
4. Use an override approach (We're doing this) and wait until 1) or 2) is resolved.

What has already been done:

• 🐛 Make spelling corrections and exceptions Active
• 📌 Make tests pass Active
• 📌 Enable GitLab CI automated testing Active

These three changes were all merged into the above merge request.

Remaining work is:

• Fix the remaining fail in the automated test.

Downloaded and applied this patch, and all seems to be well. Marking as RTBC.

I finally am able to get this module to work in Drupal 11. It took many more deprecation fixes than is covered in the patches here and also it took upgrading this library, \modules\contrib\md_slider\assets\js\libraries\jquery-migrate-1.2.1.min.js to a more recent version like jquery-migrate-3.5.2.min.js which you can download here, https://github.com/jquery/jquery-migrate

Perhaps I will submit the fixes I made as a MR later on.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Would be great if we could get at least a dev release with this! Thank you! :)

@joseph.olstad maybe ping a maintainer?

@heilop could you maybe tag a release, please?

New MR!5 opened to address all upgrade path issues and ensure that tests pass. Can we get this merged and tagged for release now?

darren.fisher → made their first commit to this issue’s fork.

+1 for RTBC! A tagged release would be great please!

+1 RTBC. MR !4 is working for me. Can we get this merged and a tagged release out for Drupal 11?

MR!18 LGTM. Can we get this merged and a new tagged release for Drupal 11?

Sorry to bump again but can we get a tagged release with D11 compatibility?

Automatically closed - issue fixed for 2 weeks with no activity.

I've pushed up Drupal 11 support to the 2.0.x branch. It removes any deprecated code. All automated tests are working though it has not yet been run in a production Drupal 11 environment.

The pipeline is green. It is recommended to review and merge 📌 Add gitlab ci Active first...

msnassar → changed the visibility of the branch project-update-bot-only to hidden.

Automatically closed - issue fixed for 2 weeks with no activity.

With these patches is quickedit working in Drupal 11?

danrod → closed merge request !2

any chance for merge?

Automatically closed - issue fixed for 2 weeks with no activity.

Any chance this one can land?

Automatically closed - issue fixed for 2 weeks with no activity.

Also tested it, works fine!

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Fixed in release 3.0.0-beta3

guedressel → closed merge request !4

Hey all,

Apologies for being AWOL. Drupal contrib development is not top of my pile anymore. I am happy to promote a co-maintainer.

I had a look at the MR, cloned it on a fresh D10 site, and had a look at the MR comments. I have addressed the file extension issue.

Please take a look.

Also happy to drop D9 support, as this is EOL (they can always pin to an older version).

I created a new branch on the MR 3434369-manual-drupal-11

I probably went a bit wide with D11 fixes as I started addressing coding standard issues trying to get all the Pipelines tests to run. We are down to 4 PHP Unit tests that aren't passing.

https://git.drupalcode.org/issue/search_api_coveo-3434369/-/jobs/4414965

Happy to dig in further on why those tests aren't passing if I can get a bit more context.

I added a PR here https://git.drupalcode.org/project/account_field_split/-/merge_requests/10 .

Please review and test on D10 and up.

Automatically closed - issue fixed for 2 weeks with no activity.

neclimdul → closed merge request !1

joevagyok → credited skaught → .

Thank you all!

Hi maintainers! Please release a version for Drupal 11.

Hi, the patch require update composer.json too, I think :)

patch applies fine to the dev version.

Patch applies fine to the current dev version.

Since all in that thread were pushing to merge the proposed update I expected that at least someone tested the update. However, as fast as I can see - the update still needs some work to be done. For some reasons ate least in Drupal 10.4.2 and D11 - forms UI cache is not invalidated after module installation.

Does anyone tested that update?

I will check and create a release shortly.

You can always reach me in slack https://drupal.slack.com/archives/D01F4DBR9C1 .

Automatically closed - issue fixed for 2 weeks with no activity.

Loos good, works for me!

Huge shoutout to @dww for tagging a new release! Thank you.

FWIW, on my mac, for some reason patch fails to apply when using composer install --prefer-dist, but passes with composer install --prefer-source.

Will it be officially ported to D11?

Subscribing! bump it pls

+1

+ 1

Automatically closed - issue fixed for 2 weeks with no activity.

Nothing left to commit, so marking as fixed.

+1 to make a Drupal 11 release. Thank you!

+1 for an official release

bluegeek9 → changed the visibility of the branch project-update-bot-only to hidden.

Automatically closed - issue fixed for 2 weeks with no activity.

Attached patch with some additional fixes.
Added core version and fixed incompatible method.

Hiding MR!8 as I agree with @pfrenssen, that we should focus on the Drupal >= 10.3 approach in MR!9 instead (of course the maintainer should decide in the end). https://git.drupalcode.org/project/responsive_favicons/-/merge_requests/... still needs to get resolved, before this can go back to NR, again

grevil → changed the visibility of the branch project-update-bot-only to hidden.

Automatically closed - issue fixed for 2 weeks with no activity.

Patch for 3.0.0

https://www.drupal.org/files/issues/2025-02-19/field_count_formatter-343... →

Thanks

No, I don't have any direct contact info for any of the maintainers... (also don't know who actually has permission to publish releases)

Tested on 1x site

Hi @weseze, are you able to contact any of the other maintainers to action this?

Tagged https://www.drupal.org/project/condition_query/releases/8.x-1.5 → so I don't forget. 😂

Pushed some more commits. Test seems to be working now on all versions.

Nope, still failing. I'm way out of time for this. If anyone wants to get the Kernel test passing on D11, knock yourself out. 😉

Thanks/sorry,
-Derek

Let's see if that solves it... 🤞

Probably https://www.drupal.org/node/3337193 → is the culprit

Not sure why, and don't have time to further investigate, but the tests are still failing on D11, even with compatibility declared.

Everyone: Thank you for manually testing the Drupal 11 upgrade.

I'd like to leave an additional comment regarding the explicit dropping of support for Drupal 9.

Given that no testing has been performed against Drupal 9, it's my opinion that it's unlikely that any future enhancements to this module will be tested against Drupal 9 or prior either. Given this, it's even more unlikely that support ranges excluding Drupal 9 would be considered in future merge requests, meaning that unfortunate site owners that are still trapped in Drupal 9 could otherwise be unwittingly walked into WSOD situations. The most responsible thing to do as a community is to drop support so that users stuck on out of support versions of Drupal will not be able to brick their site by an upgrade of this module that couldn't be effectively tested against end of life software.

I'll cut a new release for Drupal 11 support shortly. Thanks again.

Automatically closed - issue fixed for 2 weeks with no activity.

The MR is working well on a D 11.x site.

1. I created a new block
2. I installed Condition Query module (from the MR)
3. I limited the block to appear based on a condition query
4. The block appeared when the condition query matched and didn't when it wasn't present.

I setup a stock D11 site to test this MR.

1. I installed Webform and Webform Javascript Setting modules
2. In a custom module I added a new property to drupalSettings
3. I setup a new Webform Javascript Setting configuration option to target the above drupalSettings property.
4. I created a new Webform with a Javascript Setting element targeting the above setting.
5. I submitted the Webform
6. The value from my custom drupalSettings property was properly set in the Webform result.

Is there anything else I should test before we consider cutting a D11 release?

Changes to the social_auth module require a little change in the config form constructor.

Patch attached.

fixed in latest update.

Is working for me. Can we have an official release to get the D11 support?

becw → closed merge request !1

Any news on this update? When can we expect a D11 compatible tagged version?

Looks good

Automatically closed - issue fixed for 2 weeks with no activity.

I tested on a Drupal 11 site.

The module is working correctly.

(I also didn't see any problems on the settings page)

The patch does not apply to v 2.0.0

Automatically closed - issue fixed for 2 weeks with no activity.

The patch does not apply to Version 1.0.0
Could you create a dev version that is compatible to D11?

Automatically closed - issue fixed for 2 weeks with no activity.

Look at this patch: https://www.drupal.org/project/better_fields_report/issues/3428959 📌 Automated Drupal 11 compatibility fixes for better_fields_report Needs review
There is a comment to avoid New Lines at the end of the file

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

sadashiv → closed merge request !5

Thanks for the request, have released https://www.drupal.org/project/civicrm_member_roles/releases/8.x-1.0-beta4 →

Thanks,
Sadashiv.

Attached a static ds--2025-02-18--3507312--mr-43.patch file.
From this point of MR43
To be used with Composer Patches

Automatically closed - issue fixed for 2 weeks with no activity.

I'll test drive this over the weekend on 11.x. Given there were no manual tests against Drupal 9 and it's end of life, I think it's best to explicitly drop support, leaving ^10.3 || ^11 as the support range.

Claiming that Drupal 9 is still actively supported would be somewhat false advertising 😅.

Automatically closed - issue fixed for 2 weeks with no activity.

Does anyone want to be added as a maintainer to tag said release?

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

Chiming in that this module made my org's D11 wishlist holdout list - https://www.timbers.dev/article/our-drupal-11-waiting-wishlist-getting-s....

It has over 10k registered sites, so it's fairly well used. Do you need additional support/maintainers to get work on getting a D11-compatible version ready? After reading through the related open issues, it sounds like the plan is to release a completely new major version to slim the codebase down while supporting all the new realfavicon.net functionality/updates?

We are using this patch on several Drupal 11 projects and everything seems to work correctly.

After resolving the conflicts in the MR, I tested it with Drupal 11, and it worked as expected. I will proceed with merging it.

Closing as fixed since this has been committed: https://git.drupalcode.org/project/current_page_crumb/-/commit/5e39000de...
Now we just need a new release.

Also ready for a Drupal 11 release.

Works for me also.

The MR in Draft because of 📌 Add gitlab ci Active . CI MR should be merged first then rebase this one... Anyway, I will leave this to the maintainers... So mark as Ready for review

Looks good, works fine also in my tests

I confirm, the stable version does not work with drupal 11