#Drupal 11 compatibility

@avattikonda Thanks for using the module, I have added a new release with D11 compatibility.

Merged. Setting back to active for future updates.

Yes, you're right. There is no guarantee that a third-party module will not be broken with each update. Thanks for the link

Yes, you're right. There is no guarantee that a third-party module will not be broken with each update. Thanks for the link

Yes, you're right. There is no guarantee that a third-party module will not be broken with each update. Thanks for the link

Would it be possible to release a new version of the module that supports Drupal 11? We greatly appreciate the work you've done so far, and having Drupal 11 compatibility would help us and other users continue to benefit from the module in our projects since the Rector patch applied cleanly and after running Upgrade Status module it shows are Drupal 11 compatible.

Automatically closed - issue fixed for 2 weeks with no activity.

@volanar see 🌱 [policy] Impact on contributed projects and its maintainers Active .

I think the specific point you're raising is partly because Drupal CMS was released not very long after Drupal 11.0.0 - so while there are over 3,000 projects with stable Drupal 11-compatible releases, there are 6,000 without.

However, it will be even more pronounced on the day 12.0.0 is released when you would still want new Drupal CMS sites to start on 12.0.0, and hence any dependencies to also have stable Drupal 12 compatible releases, but I think that's better discussed in the issue above.

Drupal cms uses a lot of third-party modules, which is great. That's why I'm referring to the drupal cms, not the drupal core, since an important component of the drupal cms is the trouble-free operation of the core and third-party modules. Therefore, it's worth thinking about how to keep up-to-date third-party modules. You should not leave users alone with abandoned or rarely updated modules. Some modules have not been updated for years, but are used on thousands of sites. Users do not upgrade to new versions of drupal due to the fact that developers have abandoned or for some reason do not update modules. A strategy is needed to solve this problem. Because this is a global issue and no less important than the drupal core updates.

Merged. Thanks! Setting back to active in case project update bot has more changes in the future.

Automatically closed - issue fixed for 2 weeks with no activity.

This issue, and MR, are bullshit. The proposed code fix would be a fatal error because you can't use $this in a static method.

Project Browser is D11-ready and everyone using Drupal CMS knows that. :)

There is no compatibility with Drupal CMS. The compatibility is with Drupal core.

Ask the maintainer of the module to create a release that supports Drupal 11 and it will be installable on Drupal CMS in project browser.

It seems silly to have installReadiness2 ... ?!

Automatically closed - issue fixed for 2 weeks with no activity.

Any plan to add the support to drupal 11?

Apparently this was merged but not closed.

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

The patch did not cover the new submodules. I will create a new task and also push some code cleanup.

I have tagged a new release, but unable to actually publish the release. I'm missing permissions for that...

It looks like peelas02 is the only active maintainer of this project currently. Is there any news on getting this work merged, tagged, and released?

yes, we can include gitlab-ci.yml file.

I have added Drupal 11 compatibility and cleaned up some code issues.

Automatically closed - issue fixed for 2 weeks with no activity.

@anybody, good reminder. done!

@bcizej, thank you for the update! I appreciate the information about the module being obsolete since Drupal 10.2.

Automatically closed - issue fixed for 2 weeks with no activity.

id.aleks → closed merge request !9

The module is obsolete and not required since Drupal 10.2.

Automatically closed - issue fixed for 2 weeks with no activity.

MR!9 Makes this module compatible with Drupal 11. Functionality is working as expected.

RTBC +1

@oksana-c could you please tag a new D11 compatible release with priority?

All green.

Just a slight adjustment, everything else LGTM!

Thanks everyone! Tagging a new D11 compatible release. :)

@peter törnstrand https://www.drupal.org/node/3442349 →

Both MRs work for me using Drupal 11.1.1

Enable module of this branch in Drupal 11 occurs error: Route "commerce_stock.admin_settings" does not exist.

Automatically closed - issue fixed for 2 weeks with no activity.

I reproduced this issue and applied MR-4 successfully and the fix is working for me.
Before:

After:

The changes looks good to me thus moving it to RTBC+!

I have reviewed the MR and it is working perfectly in drupal11 site. It has fixed the compatibility issue with Drupal 11.

However, the changes should have been done in 3434353-automated-drupal-11 branch instead of the project-update-bot-only branch as given in the bot instructions.

@shivam_tiwari Please make the changes in the 3434353-automated-drupal-11 branch and raise a new MR from that branch.

Moving the issue to Needs Work state.

Merged -- not fully tested, so making an Alpha release. Any issues found should be created as new issues!

Requested in Slack @ https://drupal.slack.com/archives/C1BMUQ9U6/p1737427230495489

Deployed in release 1.1.0-rc1.

Automatically closed - issue fixed for 2 weeks with no activity.

flashwebcenter → closed merge request !1

Duplicate of 📌 Automated Drupal 11 compatibility fixes for chart_suite Needs review

3461574 is in better shape, adjust status for 3429121

Automatically closed - issue fixed for 2 weeks with no activity.

joseph.olstad → made their first commit to this issue’s fork.

I am looking forward to an official D11 release

Module marked obsolete in favor of drush generate phpstorm-meta.

I tested this module on Drupal 11 and it works fine, no issues found.
Can this be added to the dev branch?

I got an error
TypeError: Cannot access offset of type array on array in Drupal\Core\Database\Query\Merge->key() ...
and I used this ( https://www.drupal.org/project/views_natural_sort/issues/3500675 🐛 TypeError: Cannot access offset of type array on array in Drupal\Core\Database\Query\Merge->key() (line 331 of core/lib/Drupal/Core/Database/Query/Merge.php). Active ) to fix it.
In src/EventSubscriber/StatisticsCounterSubscriber.php
I changed from ->key(['nid' => $node->id()]) to >keys(['nid' => $node->id()])

      Database::getConnection('default')->merge('node_counter')
        ->key(['nid' => $node->id()])
        ->fields([

to

      Database::getConnection('default')->merge('node_counter')
        ->keys(['nid' => $node->id()])
        ->fields([

and now works fine.

Automatically closed - issue fixed for 2 weeks with no activity.

baikho → credited shadcn → .

Committed to 3.x, see https://git.drupalcode.org/project/search_exclude/-/commit/9a829f79d0c64...

Amazing!! Thank you! I wondered if I was missing something!!

Fixed in Release 3.0.3

Automatically closed - issue fixed for 2 weeks with no activity.

Yea, we explicitly do not want the suggested change as the comment says.

Ready for Drupal 11.

#8 📌 Automated Drupal 11 compatibility fixes for media_revisions_ui Needs review works for me.

Automatically closed - issue fixed for 2 weeks with no activity.

ok @jurgenhaas, I'll have to go through the test scenarios manually in my environment. Hopefully some time this week or next week!

Thanks for your work on this!

drupal supports this out of the box by having the new annotation

@borisson_ I tried Googling for documentation on these new annotations. Did not find anything. Can you point me in the right direction on these new annotations?

alt.dev → changed the visibility of the branch 3.x to hidden.

alt.dev → made their first commit to this issue’s fork.

Time to get ready for Drupal 11.

Automatically closed - issue fixed for 2 weeks with no activity.

MR!9 Makes this module compatible with Drupal 11. Functionality is working as expected.
RTBC +1

Thanks all!

tess bakker → closed merge request !2

MR!6 Makes this module compatible with Drupal 11. Functionality is working as expected.
RTBC +1

I have verified MR !6 against drupal 10 and drupal 11, it makes module compatible with drupal 11, functionality is working as expected and upgrade status is showing no error.

Moving this to RTBC.

I'm not deep into twig, so this is certainly a task for someone else.

MR!9 : https://git.drupalcode.org/project/opigno_module/-/merge_requests/9 Makes the module D11 compatible, no issues in upgrade status, Kindly review and do the RTBC..

id.aleks → closed merge request !31

Drupal 11 compatibility will be included in the next Opigno LMS release and will be done by Opigno team.

id.aleks → closed merge request !6

id.aleks → closed merge request !4

@grevil could you finally check this for 2.x?

MR!5 Makes this module compatible with Drupal 11. Functionality is working as expected.

RTBC +1

harivenuv → closed merge request !9

Thanks @nterbogt! Let us know if you need a hand with any of the other changes :)

I've merged to 1.1.x for now... have to make a few other changes before I can roll a release. So will confirm if composer restrictions are working as expected.

Tested this with Drupal 11, with ✨ Let GDToolkit support AVIF image format Needs work and ✨ Add support for GD Needs review and can confirm it's working as expected.

I think we need to add a version constraint to composer.json since we have breaking changes for Drupal < 10.3 so sites on 10.2 can't accidentally update to this. Or does the composer facade handle this automatically from the .info file?

Yes, we also need to test per permission and make sure all the operations are supported by newly added permissions.

Thanks Adam, and yes good idea for the supported versions!

Upgrading now from my override to the new release! :)

Automatically closed - issue fixed for 2 weeks with no activity.

Ah yes the dynamic property! Love those!

tests are passing

I'm running this merge request right now in Drupal 11.1.1 using a composer override and all the bigmenu functionality is working as designed (including the breadcrumb and children)!

Automatically closed - issue fixed for 2 weeks with no activity.

Automatically closed - issue fixed for 2 weeks with no activity.

A simple gitlab CI file needs to be added too so tests run.

still needs actioning.

rajab natshah → changed the visibility of the branch project-update-bot-only to hidden.

@benstallings I've opened a follow-up and pointed to your MR - 📌 Drupal 11 support Active

Any chance of a tagged release?

Maybe working a little bit through the issue queue or even providing the D11 upgrade would help with the decision.

Automatically closed - issue fixed for 2 weeks with no activity.

Added next child issue: 🐛 Crawling broken on D11 Active

After the fixing of both issues above I tried as next step with demo_umami to crawl with "node: article, page, recipes" and got this error:
Deprecated function: Creation of dynamic property Drupal\boost\BoostCacheGenerate::$config is deprecated in Drupal\boost\BoostCacheGenerate->__construct() (line 53 of modules/contrib/boost/src/BoostCacheGenerate.php).

Automatically closed - issue fixed for 2 weeks with no activity.

Hi all, is there a plan to release a Drupal 11 version of this module? If not, would the maintainers be open to having a co-maintaner?

Tested and works great, would be nice to get this in an official release. Thanks!

I added child Issues for fixing:

• 🐛 ypeError: DrushCommands::logger() Active
• 🐛 ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct() Active

I tried to install in a fresh Core 11.1.1 after drush site:install demo_umami with drush en boost and got this error:

TypeError: Drush\Commands\DrushCommands::logger(): Return value must be of type ?Drush\Log\DrushLoggerManager, Drupal\Core\Logger\LoggerChanne  
  l returned in Drush\Commands\DrushCommands->logger() (line 77 of /var/www/h-kee7x/dev/dyn/boost/vendor/drush/drush/src/Commands/DrushCommands.  
  php). 

Additionally on Config page admin/config/development/performance/boost there is this error:

ArgumentCountError: Too few arguments to function Drupal\Core\Form\ConfigFormBase::__construct(), 1 passed in web/modules/contrib/boost/src/Form/BoostSettingsForm.php on line 72 and exactly 2 expected in Drupal\Core\Form\ConfigFormBase->__construct() (line 44 of core/lib/Drupal/Core/Form/ConfigFormBase.php).

I believe this errors are not limited to D11 but should be fixed in other Issues.

For testing via composer.

Install patch management:
composer require cweagans/composer-patches

For using D10 projects in D11 :
composer require mglaman/composer-drupal-lenient

Add to "extra" section in main composer.json:

   "drupal-lenient": {
            "allowed-list": [
                "drupal/boost"
            ]
        },
        "patches": {
            "drupal/boost": {
                "Automated Drupal 11 compatibility fixes for boost, #3428282": "https://www.drupal.org/files/issues/2024-05-30/boost.1.x-dev.rector.patch"
            }
        },

To get the automated patch working, we need the dev version.
composer require drupal/boost:1.x-dev@dev

The MR created by the bot was based on a wrong branch so I closed that one because !17 is also there.

Thanks @joseph.olstad for creating a fresh one and adding the patch of the bot.

c-logemann → closed merge request !16

Automatically closed - issue fixed for 2 weeks with no activity.

Fixed in new release (2.0.0)

@jibran, we're already testing anonymous and editor in new tests

https://git.drupalcode.org/project/webform_revision_ui/-/merge_requests/...

We need per operation to permission test.

we can't commit this until we add all the tests.

Dropped support for D8/D9.

joseph.olstad → made their first commit to this issue’s fork.

joseph.olstad → made their first commit to this issue’s fork.

Can the maintainers provide a timeline for when this compatibility will be provided in a new release? Thanks for all the work you do!

jurgenhaas, want to take a look?

Hmm,
Seems there's smoke in the twig files?

templates/toc-tree.html.twig

and

templates/toc-default.html.twig

and this

#pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725 → ',

I'm testing this on core 11.1.1, using toc_api from this MR, along with toc_filter 2.3.0. I'm running into an error when saving a node that is using the [toc] token, assume the error is coming from toc_api:

TypeError: Drupal\Core\Render\MetadataBubblingUrlGenerator::generateFromRoute(): Argument #2 ($parameters) must be of type array, null given, called in /var/www/html/core/lib/Drupal/Core/Url.php on line 769 in Drupal\Core\Render\MetadataBubblingUrlGenerator->generateFromRoute() (line 104 of core/lib/Drupal/Core/Render/MetadataBubblingUrlGenerator.php).

Drupal\Core\Url->toString(1) (Line: 175)
Drupal\Core\Utility\LinkGenerator->generate(Object, Object) (Line: 102)
Drupal\Core\Render\Element\Link::preRenderLink(Array)
call_user_func_array(Array, Array) (Line: 107)
Drupal\Core\Render\Renderer->doTrustedCallback(Array, Array, 'Render #pre_render callbacks must be methods of a class that implements \Drupal\Core\Security\TrustedCallbackInterface or be an anonymous function. The callback was %s. See https://www.drupal.org/node/2966725 → ', 'exception', 'Drupal\Core\Render\Element\RenderCallbackInterface') (Line: 825)
Drupal\Core\Render\Renderer->doCallback('#pre_render', Array, Array) (Line: 387)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 203)
Drupal\Core\Render\Renderer->render(Array) (Line: 484)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 120)
__TwigTemplate_e9204f7060e2bc684929174b8b8efc1d->{closure}() (Line: 2058)
Twig\Extension\CoreExtension::captureOutput(Object) (Line: 88)
__TwigTemplate_e9204f7060e2bc684929174b8b8efc1d->macro_tree_links(Array) (Line: 67)
__TwigTemplate_e9204f7060e2bc684929174b8b8efc1d->doDisplay(Array, Array) (Line: 387)
Twig\Template->yield(Array, Array) (Line: 343)
Twig\Template->display(Array) (Line: 358)
Twig\Template->render(Array) (Line: 35)
Twig\TemplateWrapper->render(Array) (Line: 33)
twig_render_template('modules/contrib/toc_api/templates/toc-tree.html.twig', Array) (Line: 354)
Drupal\Core\Theme\ThemeManager->render('toc_tree', Array) (Line: 446)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 203)
Drupal\Core\Render\Renderer->render(Array) (Line: 484)
Drupal\Core\Template\TwigExtension->escapeFilter(Object, Array, 'html', NULL, 1) (Line: 51)
__TwigTemplate_2dc37c9b3f055a0c562225983c06be41->doDisplay(Array, Array) (Line: 387)
Twig\Template->yield(Array, Array) (Line: 343)
Twig\Template->display(Array) (Line: 358)
Twig\Template->render(Array) (Line: 35)
Twig\TemplateWrapper->render(Array) (Line: 33)
twig_render_template('modules/contrib/toc_api/templates/toc-default.html.twig', Array) (Line: 354)
Drupal\Core\Theme\ThemeManager->render('toc_default', Array) (Line: 446)
Drupal\Core\Render\Renderer->doRender(Array, ) (Line: 203)
Drupal\Core\Render\Renderer->render(Array) (Line: 157)
Drupal\toc_api\TocBuilder->renderToc(Object) (Line: 184)
Drupal\toc_filter\Plugin\Filter\TocFilter->process

Yes the missing core service is confusing. And for the regex, these tests were extremely broken prior to this merge request and they have deleted the historical jenkins results so I don't know when this was last working (if ever). This merge request is a vast improvement. With that said, we'll continue to use this merge request and review the results manually. Merging this would be good if we could merge and tag an alpha or beta or rc release for D11 that'd be a step in the right direction.

Please credit everyone from

🐛 Revisions tab shows up when the anonymous user accesses the Webforms Needs review

And

🐛 Use the magic method instead of "versionHistory" method from VersionHistoryController class Active

Please add credit for these contributors:
jamesyao , mohit_aghera , progga , smulvih2 , jibran

I like the suggested changes.
Still all green!

@joseph.olstad tests are almost green. There are just 2 phpunit tests that I don't know how to fix. There is 1 about a missing core service, that's confusing. And another 1 is about regex and I don't think we've changed anything there and this must have failed already before.

Could you probably have a look into that? Everything else is resolved.

Left some review comments.

The MR applies and I can update my project from D10 to D11 using drupal lenient.
But when I try to use media_bulk_uploads, I get this error:
Call to a member function guessMimeType() on null

comming from this piece of code:

      $show_alt = (boolean) $media_bulk_config->get('show_alt');
      $alt_required = (boolean) $media_bulk_config->get('alt_required');
 
      foreach ($uploaded_files as $uploaded_file) {
        $errors = [];
 
        // Validate file alt.
        $mime = $this->mimeTypeGuesser->guessMimeType($uploaded_file['path']);

The mimeTypeGuesser is never instantiated.

The #MR6 works for both Drupal 10 and Drupal 11. Attaching the upgrade status screenshot for reference. Moving the issue to RTBC.

I updated my project to D11.1 and I could no longer use this module to edit the page.
JS error:

Uncaught TypeError: Cannot read properties of undefined (reading 'message')
    at Drupal.behaviors.lb_ipe_attach_behaviors.attach.$ajax_link.get.options.error (ipe.js?v=11.1.1:82:67)
    at c (jquery.min.js?v=4.0.0-beta.2:2:23212)
    at Object.fireWith [as rejectWith] (jquery.min.js?v=4.0.0-beta.2:2:23973)
    at E (jquery.min.js?v=4.0.0-beta.2:2:69804)
    at XMLHttpRequest.<anonymous> (jquery.min.js?v=4.0.0-beta.2:2:72283)

If I disable this module and just use layoutbuilder to edit the page, that works fine.

MR!31 Makes this module compatible with Drupal 11. Functionality is working as expected.

RTBC +1

MR!4 Makes this module compatible with Drupal 11. Functionality is working as expected.

RTBC +1

The warnings are fixed, this was a single fix in variables.

Oh, automatic merge failed and I missed this. Sorry. I changed the target branch to correct 2.0.x and this change should be available now in latest dev release. Stable release will be soon.

Tested:

• ✅ Drupal 11
• ✅ Module Custom Permissions has been installed.
• ✅ Configure related permissions link is working.
• ✅ Added a new Access development admin config page for the system.admin_config_development

rajab natshah → changed the visibility of the branch 3429471-automated-drupal-11 to hidden.

rajab natshah → changed the visibility of the branch 2.x to hidden.

rajab natshah → changed the visibility of the branch project-update-bot-only to hidden.

Drupal ~10.3 and 10.4 were released.
Updated the core version requirement to ^10.3 || ^11, and removed the deprecation message, and replace it with Error::logException

I'm not seeing Drupal 11 support on any of the branches?
https://git.drupalcode.org/project/media_thumbnails_video/-/blob/2.x/med...
https://git.drupalcode.org/project/media_thumbnails_video/-/blob/2.0.x/m...
https://git.drupalcode.org/project/media_thumbnails_video/-/blob/2.0/med...

Schemata 8.x-1.0 stable was released on: 12 Sep 2024 by: japerry →
https://www.drupal.org/project/schemata/releases/8.x-1.0 →
With Support for Drupal 11

Changed drupal/schemata to ^1 in the composer.json file.

MR: https://git.drupalcode.org/project/opigno_messaging/-/merge_requests/4 is ready to merge as all the functionality is working on D10 and D11, also there are no errors in upgrade status.

MR!5 Makes this module compatible with Drupal 11. Functionality is working as expected. No error reported by upgrade status

Hello, a new release is planned ?