๐Ÿ‡ฎ๐Ÿ‡ณIndia @AkashKumar07

Account created on 17 July 2019, over 5 years ago
#

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

The patch was applied successfully.

I have also verified the changes on my local. LGTM.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

AkashKumar07 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

I have committed the changes in the issue branch. Needs review!

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

AkashKumar07 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

I have verified @sarwan_verma's changes and it looks good to me.
I have just removed the extra space. Moving to RTBC.
Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

AkashKumar07 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

AkashKumar07 โ†’ changed the visibility of the branch 2838059-allow-to-field to active.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

AkashKumar07 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

AkashKumar07 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

Adding a reroll of #17.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

Added a return type hint. Please review.
Thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

I have updated my last patch. Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

The patch addresses #21. Please review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

Hi @larowlan,
I have removed the isset($items[$delta]) as per #63 comment.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

The patch addresses the #19 suggestions. Please review.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

Reviewing #4.
The block condition closing is not correct. It should be closed after

if ($variables['base_plugin_id'] === 'search_form_block') {}

Reviewing #5
The patch naming convention is not correct. Please refer to this guideline.
https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... โ†’

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

I am closing the issue. Please feel free to reopen the issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

The patch will not apply because the changes already exist in the default branch.
I am closing the issue as outdated.

Please feel free to reopen the issue if there is anything pending.
Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

Added use StringTranslationTrait for translation function.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

The #2 changes look good to me. Moving to RTBC.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

The patch naming convention is not correct. For more details please refer to https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... โ†’

I reviewed the patch and found some coding standard issues.
Please follow the below suggestion.

/** @var \Drupal\block\BlockInterface $block */
$block = \Drupal::entityTypeManager()
    ->getStorage('block')
    ->load($variables['elements']['#id']);
if ($block) {

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

The #3 changes look good to me. Moving to RTBC.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

Hi,
I am interested to maintain this project further.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

Hi,
I am interested in maintaining this project further.

Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

The patch removes $this->t() and whitespace errors.

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

This patch addresses the first 3 points of #7 and also removes the whitespace errors.
Thanks!

๐Ÿ‡ฎ๐Ÿ‡ณIndia AkashKumar07

This patch addresses the #11 changes. Please review.
Thanks!

Production build 0.71.5 2024