The patch was applied successfully.
I have also verified the changes on my local. LGTM.
AkashKumar07 โ made their first commit to this issueโs fork.
I have committed the changes in the issue branch. Needs review!
AkashKumar07 โ made their first commit to this issueโs fork.
I have verified @sarwan_verma's changes and it looks good to me.
I have just removed the extra space. Moving to RTBC.
Thanks!
AkashKumar07 โ made their first commit to this issueโs fork.
AkashKumar07 โ changed the visibility of the branch 2838059-allow-to-field to active.
AkashKumar07 โ made their first commit to this issueโs fork.
AkashKumar07 โ made their first commit to this issueโs fork.
Updating the drupal versions.
Added a patch for 11.x
Adding a reroll of #2.
Adding a reroll of #6.
Adding a reroll of #17.
Adding ? for null type hint.
Added a return type hint. Please review.
Thanks.
I have updated my last patch. Thanks!
The patch addresses #21. Please review.
Hi @larowlan,
I have removed the isset($items[$delta])
as per #63 comment.
Thanks!
The patch addresses the #19 suggestions. Please review.
Reviewing #4.
The block condition closing is not correct. It should be closed after
if ($variables['base_plugin_id'] === 'search_form_block') {}
Reviewing #5
The patch naming convention is not correct. Please refer to this guideline.
https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... โ
Thanks!
I am closing the issue. Please feel free to reopen the issue.
The patch will not apply because the changes already exist in the default branch.
I am closing the issue as outdated.
Please feel free to reopen the issue if there is anything pending.
Thanks!
Added use StringTranslationTrait for translation function.
The #2 changes look good to me. Moving to RTBC.
Thanks!
The patch naming convention is not correct. For more details please refer to https://www.drupal.org/docs/develop/git/using-git-to-contribute-to-drupa... โ
I reviewed the patch and found some coding standard issues.
Please follow the below suggestion.
/** @var \Drupal\block\BlockInterface $block */
$block = \Drupal::entityTypeManager()
->getStorage('block')
->load($variables['elements']['#id']);
if ($block) {
Thanks!
AkashKumar07 โ created an issue.
The #3 changes look good to me. Moving to RTBC.
Thanks!
Hi,
I am interested to maintain this project further.
Thanks!
Hi,
I am interested in maintaining this project further.
Thanks!
The patch removes $this->t() and whitespace errors.
This patch addresses the first 3 points of #7 and also removes the whitespace errors.
Thanks!
This patch addresses the #11 changes. Please review.
Thanks!