- Issue created by @Volha_Si
- Status changed to Needs review
over 1 year ago 7:06am 14 August 2023 - last update
over 1 year ago Patch Failed to Apply - Status changed to Needs work
over 1 year ago 12:23pm 14 August 2023 - last update
about 1 year ago 234 pass - last update
about 1 year ago 234 pass - Status changed to Needs review
about 1 year ago 8:18am 22 August 2023 - Status changed to Needs work
about 1 year ago 9:28pm 11 September 2023 - 🇺🇸United States DamienMcKenna NH, USA
Thank you for reporting the problem and for providing a patch.
Views needs to retain compatibility with PHP 5, so this won't work as-is.
- 🇺🇸United States DamienMcKenna NH, USA
I think this needs further work as none of the logic in the "else" section of that code should run if the value is NULL.
- last update
11 months ago PHPLint Failed - last update
11 months ago PHPLint Failed - last update
11 months ago 234 pass - last update
11 months ago 233 pass, 1 fail - last update
11 months ago 234 pass - last update
11 months ago 234 pass - last update
11 months ago 228 pass, 7 fail - last update
11 months ago run-tests.sh exception - last update
11 months ago CI error - Status changed to RTBC
11 months ago 1:20am 21 December 2023 - Status changed to Needs review
11 months ago 11:21am 21 December 2023 - last update
11 months ago 234 pass - 🇺🇸United States DamienMcKenna NH, USA
isset() and !is_null() are a bit redundant, and neither confirm that the value is numerical.
How about this?
- Status changed to RTBC
11 months ago 12:25pm 21 December 2023 - last update
11 months ago 234 pass -
DamienMcKenna →
committed b51a602f on 7.x-3.x authored by
Volha_Si →
Issue #3376468 by joseph.olstad, Volha_Si, DamienMcKenna, AkashKumar07,...
-
DamienMcKenna →
committed b51a602f on 7.x-3.x authored by
Volha_Si →
- Status changed to Fixed
11 months ago 3:37pm 21 December 2023 - 🇺🇸United States DamienMcKenna NH, USA
Excellent, thanks for the quick reviews.
Committed.
Automatically closed - issue fixed for 2 weeks with no activity.