🇨🇦Canada @Liam Morland

liam morland → created an issue.

Please put your patch into the issue fork and make a merge request.

liam morland → created an issue.

Rebased

liam morland → made their first commit to this issue’s fork.

This is probably a Drupal core issue.

This should be rebased onto 2.8.x.

I created a merge request with patch #7.

liam morland → made their first commit to this issue’s fork.

liam morland → made their first commit to this issue’s fork.

As warning message as an interim step would be fine. It would be helpful for the patch to be put into a merge request so that tests can run on it.

Merged in:

https://git.drupalcode.org/project/entity_field_condition/-/commit/4dba6...

phpcs and cspell issues are fixed, plus a couple of phpstan issues.

https://git.drupalcode.org/project/entity_field_condition/-/commit/f747d...

Perhaps this should be done on branch 2.0.x instead.

liam morland → made their first commit to this issue’s fork.

liam morland → created an issue.

I think any any significant, backward incompatible changes should be done only in 4.x so that 3.x can be stable. The majority of openid_connect users are on 3.0.x already, so big changes need to be avoided.

It doesn't need to be bug-free before getting a stable tag. It would probably be reasonable to give it a stable tag now and continue with bug fixes in patch-level releases.

Having a stable release would allow people to start moving off the very old 8.x-1.4 and upgrade to Drupal 11.

The changes described above where made except:

• This did not change the Drupal search block. The theme generates a gcds-search component if configured. Alternatively, blocks may be placed in the search slot.
• A dependency on ui_suite is not needed for the other changes, so no dependency was added.

Looks good!

I just added a spelling exception needed by my recent change.

I have added instructions to branch 3520780-composer.

We also have mnsami/composer-custom-directory-installer installed. Maybe that is is needed.

It looks like you need to have composer/installers installed for the installer-paths key to work.

I thought that datatables wasn't mandatory for csvfile_formatter. If so, we would expect people to install it via their own Composer files instead of it being always installed with csvfile_formatter.

Adopted issue template.

Updated draft for documentation:

The DataTables library can be installed with:
composer require 'datatables.net/datatables.net-dt:^2.2'

You will probably need to update your composer.json file by adding the following in the extra, installer-paths section:

            "web/libraries/{$name}": [
                "datatables.net/datatables.net",
                "datatables.net/datatables.net-dt",
                "type:drupal-library"
            ],

If you are installing a different way, you may need to change the file names and locations from what is in csvfile_formatter.libraries.yml. You can do that with hook_library_info_alter().

I have it working now on version 2.2.2 using the Composer instructions from the bottom of this page:

https://datatables.net/download/

I had the change the file paths, see branch 3520780-composer.

I just pushed to the issue fork a commit updating the version key to match the changes. I will test this.

The DataTables library can be installed with:
composer require 'datatables/datatables:^1.10'

You will probably need to update your composer.json file by adding the following in the extra, installer-paths section:

            "web/libraries/{$name}": [
                "datatables/datatables",
                "type:drupal-library"
            ],

If you are installing a different way, you may need to change the file names and locations from what is in csvfile_formatter.libraries.yml. You can do that with hook_library_info_alter().

We have it installed with this in the Composer require section: "datatables/datatables": "^1.10",

This is in the extra, installer-paths section:

            "html/libraries/{$name}": [
                "datatables/datatables",
                "type:drupal-library"
            ],

This is what we already had.

Created child issue ✨ Make theme that depends on a module Active .

liam morland → created an issue.

All checks are passing.

liam morland → created an issue.

Should this issue be moved to that queue?

The best thing would be to create a separate webform_bootstrap module project.

Current state of merge request.

Please try it without the patch to see if that is the problem. If so, report the problem with the patch on that issue.

Rerolled on 3.0.x.

There are still a few phpcs issues on branch 2.0.x. They are all "Missing short description in doc comment". Perhaps this issue should stay open for those to get fixed.

Is there a reason the "Build attributes string" code doesn't use the Drupal Attribute class?

liam morland → created an issue.

All that is left in the merge request is adding a return type declaration.

8.x-3.x is no longer supported. There is almost nothing left in this merge request anyway.

This commit causes core_version_requirement and the version of core required in composer.json to not match.

There is no need for the php key in the info file since the version given is lower than the minimum for versions of Drupal shown in core_version_requirement.

Is there a reason it doesn't run the normal coding standards checks?

phpstan tests now pass. Only one simple change needed.

liam morland → made their first commit to this issue’s fork.

Merge request created based on the patch in #27.

liam morland → made their first commit to this issue’s fork.

Is anyone else seeing this? Are you able to user bisect to figure out which commit broke it?

This is Ubuntu with libapache2-mod-php8.3.

I just had this problem. It went away when I rebooted the server and ran drush clear-cache. A clear-cache by it self did not fix it. Running apachectl graceful and then clear-cache also did not fix it.

This should probably be a submodule so that the submodule can depend on Media module.

We can really move anything ahead until fixing 📌 Make GitLab CI tests pass Active .

Should this issue be moved to the wxt_library queue?

It would be best for the change to be in an issue fork and merge request.

This patch appears to be for wxt_library not wxt.

Add link to ThemeExtensionList

This patch is the current state of the merge request.

Note that there are two classes called MenuLinkContent:

• \Drupal\menu_link_content\Entity\MenuLinkContent
• \Drupal\menu_link_content\Plugin\Menu\MenuLinkContent

This patch is the current state of the merge request.

This change introduced a comment error for updateLink(). The comments now say this function can @return array|null. In fact, it can only @return array.

liam morland → made their first commit to this issue’s fork.

Correct issue link.

liam morland → created an issue.

This issue removes translatable_menu_link_uri_iterate_menu(). It would have better backward compatibility if that function continued to exist as a deprecated function that calls the new service.

All tests are passing. The change in 🐛 Too few arguments to function Drupal\translatable_menu_link_uri\LinkIterator::__construct() Active is also in this merge request so that tests will pass. That issue should be merged first.

liam morland → created an issue.

The merge request will fix this issue. (It could also be fixed by using isset() instead of !is_null().)

liam morland → created an issue.

liam morland → created an issue.

liam morland → created an issue.

liam morland → made their first commit to this issue’s fork.

I created a merge request with the patch in #4.

liam morland → made their first commit to this issue’s fork.

There is a merge request with this change in 🐛 Version 8.x-3.6 is not compatible anymore with PHP 7.4 Active .

Setting status based on 🐛 PHP 8 requirement for the latest 3.x version Active .

liam morland → created an issue.

Please put these changes into an issue fork and merge request.

Thanks!

Thanks!

Thanks for the patch. For the renamed method, there should be a deprecated method with the old name that calls the new name.