I don't see how this is outdated; it's still something that could be useful. If you don't want to have this change, the status could be "won't fix".
liam morland → made their first commit to this issue’s fork.
liam morland → made their first commit to this issue’s fork.
liam morland → made their first commit to this issue’s fork.
liam morland → made their first commit to this issue’s fork.
liam morland → made their first commit to this issue’s fork.
liam morland → made their first commit to this issue’s fork.
liam morland → made their first commit to this issue’s fork.
Looks good.
Thanks for the patch.
Why is this change required? Please update the issue summary.
Tests are not passing.
Looks good except instead of "This ensures the NameAdditionalPreferredTrait is used correctly", I suggest "This is used by NameAdditionalPreferredTrait" or something like that.
Thanks for the patch.
Please make coding standards fixes.
Looks good
There could be a 2.0 version of http_status_code which is based on redirect but adds non-redirects like 410.
Drupal 7 is no longer supported.
This is still applicable to the Drupal 8+ version.
The merge requests should be updated to target branch 2.0.x.
liam morland → created an issue.
Closing based on #5.
The issue may be that it is using the "Automatically include table of contents" setting instead of the "Display table of contents in a block" setting. I have implemented this change in the merge request.
liam morland → made their first commit to this issue’s fork.
liam morland → created an issue.
The merge request currently makes a change and then un-does it.
liam morland → made their first commit to this issue’s fork.
The merge request avoids the issue in #12 and it has a test.
Unless I am misunderstanding something, this should be closed as duplicate of 🐛 Fatal error after updating to toc_api:^2 Active .
liam morland → created an issue.
Let's keep the discussion about that patch in that issue.
What is the reason for using dependency injection and non-static methods for this? This way it will have to persist an instance of DeleteUsersBatch in the batch process. I don't think that is an improvement.
liam morland → created an issue.
These changes are included in the merge request in 📌 Update for Drupal 10/11 Active .
I don't understand. The comments in 🐛 Layout builder fatal error Active say to apply the patch in this issue.
What has to be released? The latest toc_filter 8.x-2.x is tagged and released as 8.x-2.3.
What is the patch that needs to be applied?
liam morland → created an issue.
I haven't worked on merge request 6.
Composer files shouldn't refer to patches like: https://git.drupalcode.org/project/layout_builder_st/-/merge_requests/5....
These change anytime someone makes a commit so you can't be sure you'll get the same code each time you build.
liam morland → created an issue.
liam morland → made their first commit to this issue’s fork.
Thanks!
In 4.x, these were fixed in commit 83b89c8. Please switch the merge request back to targeting 3.x.
liam morland → made their first commit to this issue’s fork.
Drupal 7 is no longer supported. If this issue applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this issue applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this issue applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this issue applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this issue applies to a supported version, please re-open.
Thanks!
Fixed in 📌 Automated Drupal 11 compatibility fixes for auto_username Needs review .
liam morland → made their first commit to this issue’s fork.
Do we not still need the fix in the merge request?
This was done in 📌 Make coding standards fixes Active .
liam morland → made their first commit to this issue’s fork.
liam morland → made their first commit to this issue’s fork.
Re-rolled. The same test is failing. Perhaps a better test would be to check the favicon element on the page.
liam morland → made their first commit to this issue’s fork.
Thanks. But the way there is no need to make a new merge request. The new code can be force-pushed onto the same branch and the target branch of the merge request can be changed.
Please put your change into a merge request.
@haritha-c Thanks for the patch. The merge request needs to target 8.x-1.x. When it is ready, please set the issue to "Needs review". Someone else can then test and review, leading to it being set "Reviewed & tested by the community".
All coding standards checks now pass.
liam morland → created an issue.
Patch with current state of merge request !3.
Unless I am missing something ::getLastDelimitorBehaviors() gets renamed to ::getLastDelimiterBehaviors(). In the case of ::getLastDelimitorTypes(), it's still there but issues a deprecation notice and then calls ::getLastDelimiterTypes().
liam morland → made their first commit to this issue’s fork.
What alternatives are there?
This should be active until there is a patch to review or work on.
@belba, this is assigned to you. Do you intend to work on it? If not, this should not be assigned to you.
This change was committed in 💬 Drupal 10 compatibility Fixed .
There needs to be a deprecation for getLastDelimitorBehaviors() as well.
Re-rolled.
liam morland → made their first commit to this issue’s fork.
I think it would be reasonable to fix just the regression and then move on to 4.1.x.
Re-rolled.
All changes have been made in 📌 Make composer.json match info file Active .
Thanks
By the way, you could shorten your SettingsForm class by using constructor property promotion.
liam morland → made their first commit to this issue’s fork.
If changes like this are going to be made, it makes it very urgent to get a branch which is aimed at currently-supported versions of Drupal. This change introduces a coding standards error. Contributing to this module will become more difficult because people will need to remember to write in an old version of PHP. remembering what changes have been made and what coding standard issues to ignore.