Ontario, CA 🇨🇦
Account created on 22 April 2009, about 16 years ago
#

Merge Requests

More

Recent comments

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Thanks!

This could also happen if book.settings is deleted entirely. Someone trying to reset things might do that.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10/11, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

This needs a test that there is no access for an account without the permission.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

liam morland made their first commit to this issue’s fork.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

liam morland made their first commit to this issue’s fork.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Update: Use Sql::addWhere().

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Did you link to the issue that you meant to link to? It was marked as fixed.

@johankleene please try the latest development snapshot of 6.3.x. It may have been fixed.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Until the deprecated function is removed, it needs to be fixed.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

I have added the changes needed to fix book_type_is_allowed().

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Yes, that is the equivalent fix in BookNodeOutlineAccessCheck. I have added the fix in this issue there.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

liam morland made their first commit to this issue’s fork.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

I have put code based on the patch in #26 into the merge request and made some additional fixes. There are still schema errors and an undefined variable $current_value. I don't have more time to look at this right now.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

This is happening because it is a component of type select, but it is themed using a div element in bef-links.html.twig.

Why does it use a select component? That appears to be set in class DefaultWidget.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

I don't think it makes sense to have a label for an input that is hidden.

ARIA could be used to associate this label with what it is labelling. It would still not be a label element.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Fix typo.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

I have created a new merge request for the same change as the existing merge request, but targeting 10.5.x.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

If this can be re-produced, please re-open so that we can fix 6.2.x.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Thanks. Still needs tests.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

8.x-1.x is not supported. Should this be ported to 2.0.x or 3.0.x?

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

8.x-1.x is not supported. Should this be ported to 2.0.x or 3.0.x?

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

The branch for this issue, 3427383-drupal-11-compatibility, can probably be deleted.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

This problem still exists in GitLab CI.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

The project pages for drupalci and related projects should document that this has been replaced by GitLab CI.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Is this problem reproducible on Drupal 10 or 11?

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Please put the patch into an issue fork and merge request.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10 or later, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Drupal 7 is no longer supported. If this applies to Drupal 10 or later, please re-open.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

You could create a hotfix release based on 4.0.21 which just has the fix for this regression and then continue development of 4.x with a minimum of Drupal 10.3 in preparation for a 4.1.0 release.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Why not like this?

core_version_requirement: '^10.1.3 || ^11'

At this point, perhaps it should be:

core_version_requirement: '^10.3 || ^11.0'

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

@andypost why is it core_version_requirement: '>=10.1.3 || ^11'?

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Please put your patch into the merge request and target 6.3.x. This will likely not be packported to 6.2.x. This will need tests.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

It would be great if someone could write an automated test that would surface this issue.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Remove versions from API links

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Document that ::validateForm() is not required

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Updates that are listed under "Not compatible" on admin/reports/updates/update should not cause the status report to have a "Module and theme update status" "Out of date" warning so long as there is still a supported version installed.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Current state of merge request.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Current state of merge request.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

This patch is for Drupal 10.4.8, based on merge request !10900.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Yes, please work in the other issue. There isn't a patch, but there is a prose description of the change in comment 4.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Please make an issue fork and merge request with your fix.

If you can make an automated test that surfaces this problem, that would be great.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

This has caused 📌 When scrolling, the modal window opens automatically Active . Please review the fix in that issue.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

liam morland made their first commit to this issue’s fork.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Opened a merge request with the patch in #4 & #5 (they are the same).

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Reviewed

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Patch ported to 8.x-1.x for Composer patching.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

It would be wonderful if this fix were cherry-picked and a final 8.x-1.9 release made with that and the commits already made. We're on 8.x-1.x until there is a full release of 2.x.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Would you cherry-pick this onto 8.x-1.x? It applies cleanly.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

liam morland created an issue.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Is this fixed now that Facets 3.0.0 has been released?

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

OK, it will need to keep the legacy hooks. Thanks

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

I have created an issue fork with the existing code in branch 3159806-states-set-to.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

liam morland made their first commit to this issue’s fork.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Please rebase the merge request and get tests to pass. Which merge request is preferred?

I note that in addition to the two merge requests, there is also branch 3216923-composite-multiple.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Tests are now passing.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Currently, ConfigInstaller::installOptionalConfig() will only install config that does not already exist. Fixing this issue may be as simple as making it so that there is an param to ConfigInstaller::installOptionalConfig() which will cause it to overwrite any config that already exists.

🇨🇦Canada Liam Morland Ontario, CA 🇨🇦

Please put your fix into the merge request.

Production build 0.71.5 2024