🇨🇦Canada @Liam Morland

Fix as a patch for Composer.

liam morland → created an issue.

Correct command to get list of theme changes by issue

Improve demo code

Check the code for details. I think it has to be a token for a field such as [node:field_fieldname].

This issue is only about using dependency injection and should not include any other changes.

You need to visit admin/config/search/metatag, edit the tag type, scroll down to "Adobe Analytics", and put a token in the field.

Nothing has been committed. I just wanted to move this to 6.3.x because that is where it would need to be fixed. 6.2.x only gets security fixes.

Rebased on 2.x.

The changes in the patch have all been made already in branch 3.x; see commit 73bb6cd. Leaving open for more patches.

liam morland → created an issue.

liam morland → created an issue.

Merge request contains many fixes.

Fixed in #3144522: Drupal 9 compatibility → .

liam morland → made their first commit to this issue’s fork.

Please put the patch into an issue fork and merge request.

I would like to make a further suggestion:

• Release 3.0.0 based on 3.0.0-alpha3. Provide only security support for the 3.0.x branch; no other development.
• Open branch 3.1.x. Set the minimum to Drupal 10.3 (no Drupal 9 support). Implement Drupal 11 compatibility only here.

This gets around the challenges of supporting Drupal 11 along with much older versions of Drupal while avoiding dropping support for older versions in a patch-level release.

The merge request needs to be updated so that it targets branch 2.0.x.

The readme needs a newline at the end.

liam morland → made their first commit to this issue’s fork.

I have rebased the merge request and also removed trailing whitespace in the readme. The merge request should be edited to target 2.x.

I have rebased and fixed the missing comment mentioned in #166.

Looks good to me.

The problem with cl_editorial is fixed by moving to the new version of cl_editorial. That is done in 📌 Update dependency on cl_editorial Active .

Could it not get those from the info file?

Coding standards tests are passing.

liam morland → made their first commit to this issue’s fork.

I rebased the test. The test runs but it fails, perhaps because of more recent changes to the module.

Coding standards pass with the changes in this merge request.

liam morland → made their first commit to this issue’s fork.

On admin/appearance, any theme that depends on modules that are not installed will have this message:

This theme requires the listed modules to operate correctly. They must first be installed via the Extend page.

So, Drush is following what Drupal is doing by nor automatically installing the modules.

@#16: What work is needed?

Change made in 🐛 The remaining rule are ignored on missing context Fixed .

Perhaps the testing-related stuff should be moved to 📌 Write basic tests Active .

I made some simple coding standards fixes and now tests are fully passing.

Some tests are added in 📌 Automated Drupal 11 compatibility fixes for theme_switcher Needs review .

liam morland → made their first commit to this issue’s fork.

Are you saying the problem is not in theme_switcher? In that case, you could close this issue or switch the Project.

Related to this, the base theme does not need to be listed in the dependencies section of the info file.

at_theme does, but doesn't declare the dependency in its info file. I don't know of any others.

You should be able to install the dev version of gcds with Composer.

With 10.3 as the minimum, you can remove the call to version_compare().

There should be a newline at the end of .gitlab-ci.yml.

This appears to be a bug.

I think it would make sense that if facebook_app_id or facebook_app_secret are provided that the url_embed_debug_facebook_access_token() check still runs. In other words, no warning if they are not configured but if they are there, they must be valid. Other than that, reading the code, it looks good.

^9 || ^10.3 is not likely to ever be correct. If it needs 10.3, it won't work on Drupal 9.

That makes sense to me. If a site builder sees that Facebook embeds do not work, they might visit the url_embed config page to find out why and see the warning there but the warning does not appear on the main status page.

It would be best to get tests passing again first; see 📌 Make tests pass Active .

I would also like to have resolution to 📌 Remove legacy ckeditor from codebase. Active .

Test are not passing again.

liam morland → created an issue.

liam morland → created an issue.

liam morland → created an issue.

Fixed

Thanks for the reroll.

There is no need to make a new merge request. You can just force-push to the branch of existing one.

liam morland → created an issue.

I have updated the link to point to the change record.

The bot is wrong; the patch is for Drupal 10.3.

In 🐛 Allow customizing wrapper element in node.html.twig Needs review it was decided to change it so that current behaviour stays the same but wrappers can be customized in preprocess.

liam morland → made their first commit to this issue’s fork.

Sounds like it is a duplicate then.

Bug issues are always against the development branch.

7.x-1.0-rc5 can't change because it is a release. What is needed is a new release.

This link only appears if the "Authenticated" role has permission post comments; see CommentManager::forbiddenMessage().

We are only concerned about issues raised by the pipelines that run on git.drupalcode.org.

There is no need to include the entire error report. We can see the errors in the pipeline. The problem that I see is that Composer builds are failing.

liam morland → created an issue.

Thanks!

Thanks for the patch. Please move the changes regarding ::willReturnCallback() to a separate issue and merge request.

Change record updated.

Added .gitlab-ci and made some coding standards fixes. This is a good start.

Tests are passing again on 6.3.x. Please reroll and get tests to pass.

Tests are passing again on 6.3.x. Please reroll and get tests to pass.

Tests are passing again.

Please reroll for 6.3.x.

Please reroll for 6.3.x.

This sounds like a good idea to me. This should probably be started in 6.4.x so that 6.3.x can be just 6.2.x but with compatibility with Drupal 11.

Is there more code that should be removed? I note that _webform_update_html_editor() appears to include a config file that the above commit removes.

This change introduces the use of $this in static methods, which is not allowed.

This issue can probably just be left in the active state to see if any more patches come (there probably won't be). If any do, they will require careful review to ensure they do not re-introduce this problem.

The fix is to revert the last commit; see merge request.

liam morland → made their first commit to this issue’s fork.

liam morland → made their first commit to this issue’s fork.

Document how to alter ckeditor5-stylesheets

It is possible to use hook_library_info_alter() in a theme. There should be something similar for changing ckeditor5-stylesheets, perhaps something like hook_system_info_alter() (that does not currently work in a theme).

Updated issue summary to add all headings from template.

This may already have been partially done. I've been trying to get hook_system_info_alter() to run in a theme but it has not worked.

It needs to be better documented which hooks work in modules vs. themes. It appears to be that hook_system_info_alter() does not work, but hook_form_system_theme_settings_alter(), hook_form_FORM_ID_alter(), and hook_preprocess_HOOK() do.

@ddavisboxleitner I don't think that solution would work if the Drupal site is not at the root of the host, for example, www.yoursite.com/SITE/PATH/index.php.

The merge request contains the change on 2.x to update core_version_requirement in sdc_tags. A similar change should also be done in 3.x.

The minimum will be Drupal 10.3. Very soon this will be the oldest supported version of Drupal besides Drupal 7.

You can also use ::backwardsCompatibleCall() to have different code paths.