I have put code based on the patch in #26 into the merge request and made some additional fixes. There are still schema errors and an undefined variable $current_value. I don't have more time to look at this right now.
liam morland → created an issue.
This is happening because it is a component of type select, but it is themed using a div element in bef-links.html.twig.
Why does it use a select component? That appears to be set in class DefaultWidget.
I don't think it makes sense to have a label for an input that is hidden.
ARIA could be used to associate this label with what it is labelling. It would still not be a label element.
Fix typo.
liam morland → changed the visibility of the branch 10.5.x to hidden.
Current state of !12355.
I have created a new merge request for the same change as the existing merge request, but targeting 10.5.x.
liam morland → made their first commit to this issue’s fork.
If this can be re-produced, please re-open so that we can fix 6.2.x.
Thanks. Still needs tests.
8.x-1.x is not supported. Should this be ported to 2.0.x or 3.0.x?
8.x-1.x is not supported. Should this be ported to 2.0.x or 3.0.x?
The branch for this issue, 3427383-drupal-11-compatibility, can probably be deleted.
This problem still exists in GitLab CI.
The project pages for drupalci and related projects should document that this has been replaced by GitLab CI.
Is this problem reproducible on Drupal 10 or 11?
Please put the patch into an issue fork and merge request.
Drupal 7 is no longer supported. If this applies to Drupal 10 or later, please re-open.
Drupal 7 is no longer supported. If this applies to Drupal 10 or later, please re-open.
You could create a hotfix release based on 4.0.21 which just has the fix for this regression and then continue development of 4.x with a minimum of Drupal 10.3 in preparation for a 4.1.0 release.
Why not like this?
core_version_requirement: '^10.1.3 || ^11'
At this point, perhaps it should be:
core_version_requirement: '^10.3 || ^11.0'
@andypost why is it core_version_requirement: '>=10.1.3 || ^11'?
liam morland → made their first commit to this issue’s fork.
Please put your patch into the merge request and target 6.3.x. This will likely not be packported to 6.2.x. This will need tests.
It would be great if someone could write an automated test that would surface this issue.
Document that ::validateForm() is not required
Updates that are listed under "Not compatible" on admin/reports/updates/update should not cause the status report to have a "Module and theme update status" "Out of date" warning so long as there is still a supported version installed.
Current state of merge request.
Current state of merge request.
This patch is for Drupal 10.4.8, based on merge request !10900.
liam morland → created an issue.
Thank you
Yes, please work in the other issue. There isn't a patch, but there is a prose description of the change in comment 4.
Please make an issue fork and merge request with your fix.
If you can make an automated test that surfaces this problem, that would be great.
This has caused 📌 When scrolling, the modal window opens automatically Active . Please review the fix in that issue.
Please port to 6.3.x.
liam morland → made their first commit to this issue’s fork.
liam morland → made their first commit to this issue’s fork.
liam morland → made their first commit to this issue’s fork.
Opened a merge request with the patch in #4 & #5 (they are the same).
Patch ported to 8.x-1.x for Composer patching.
It would be wonderful if this fix were cherry-picked and a final 8.x-1.9 release made with that and the commits already made. We're on 8.x-1.x until there is a full release of 2.x.
Would you cherry-pick this onto 8.x-1.x? It applies cleanly.
liam morland → created an issue.
Is this fixed now that Facets 3.0.0 has been released?
OK, it will need to keep the legacy hooks. Thanks
I have created an issue fork with the existing code in branch 3159806-states-set-to.
liam morland → made their first commit to this issue’s fork.
Please rebase the merge request and get tests to pass. Which merge request is preferred?
I note that in addition to the two merge requests, there is also branch 3216923-composite-multiple.
Tests are now passing.
Currently, ConfigInstaller::installOptionalConfig() will only install config that does not already exist. Fixing this issue may be as simple as making it so that there is an param to ConfigInstaller::installOptionalConfig() which will cause it to overwrite any config that already exists.
Please put your fix into the merge request.
liam morland → created an issue.
Please create an issue fork and merge request. Please see the comments in #4.
It would be helpful to know which commit fixed it in 6.3.x.
The current behaviour is that self-referencing is possible, which is the meaning of allow_self_reference = TRUE.
allow_self_reference will appear in config export.
So, an update hook to set allow_self_reference = TRUE on all entity reference fields? Would it be OK to have it be that if allow_self_reference is NULL, it because as if it were TRUE? That would preserve existing behaviour without the need for an update hook.
@smustgrave thanks for the feedback.
The only non-PHP file that this issue updates is core/config/schema/core.data_types.schema.yml. Does that require an upgrade path? If so, what would the upgrade path be? I thought it would pick-up the schema change on the next cache clear.
When you say "post in #ux", is that referring to a Slack channel? I haven't used Slack for Drupal.
liam morland → made their first commit to this issue’s fork.
This should be a feature request.
Drupal 7 is no longer supported. If this applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this applies to a supported version, please re-open.
Drupal 7 is no longer supported. If this applies to a supported version, please re-open.
With the latest version of key module, tests are now passing on max PHP.
You can effectively do this by sending the Authorization: HTTP header. That is how basic HTTP authentication works anyway.
Drupal 7 is no longer supported. The module page should be updated.