🇺🇦Ukraine @tibezh

Looks good, thank you for the PR!

Hm, I don't have any issues, not sure, but looks like it fixed since Drupal 10.3.
Thank you for help, we can close the issue.

Hey @jsacksick, thanx a question.
The problem is a little bit deeper.
After generating sample values, they are placed into temporary key_value storage, and the size of the stored value is about 20kB and you get a PHP memory limit error.

Here is a patch.

tibezh → created an issue.

I have the same issue, but on the Commerce.
On a clear (without any products) Drupal website the Layout Builder module tries to

$entity = $entity_storage->createWithSampleValues($bundle_id);

The code should create a Product Variation, then generate a related product, again variation etc...

Looks good, we can merge it.

I had the same issue on last version (10x) install, to solve it, apply "Email address" on the Basic site settings page (/admin/config/system/site-information).
But, why hasn't the email been applied after the Drupal install - this is a need to investigate I think.

Here a patch.

tibezh → created an issue.

Hey @klausi,

Tests are failing with "PHP Fatal error: Call to undefined function rules_event_invocation_enabled() in /var/www/html/sites/all/modules/rules/tests/rules.test on line 2285"

This error was in the 1st pipeline - https://www.drupal.org/pift-ci-job/2881566 → ,
After, I've added a setUp method and loaded rules module - https://git.drupalcode.org/project/rules/-/merge_requests/24/diffs?commi...
And we have just an error without any info - https://www.drupal.org/pift-ci-job/2881570 →

Looks like smth wrong with the test execution on D7.

tibezh → changed the visibility of the branch 3440181-unable-to-enable to active.

tibezh → changed the visibility of the branch 3440181-unable-to-enable to hidden.

tibezh → created an issue.

The fix is available in the MR and can be applied as a patch by the URL https://git.drupalcode.org/project/l10n_client/-/merge_requests/10.diff

tibezh → created an issue.

Here a patch

tibezh → created an issue.

Here the same patch as above, but without changes in the .info file (for patch via .make files).

Changes are available in the https://git.drupalcode.org/project/drupal/-/merge_requests/6784 MR.

tibezh → created an issue.

Thanx @tadean, the patch works beautifully!

Here a patch

tibezh → created an issue.

Looks good, thanx!

Looks good, I think we can merge this small change.

Looks good, thanx for the patch!

I've updated the MR, just made the code style better.
Changes are still available at the https://git.drupalcode.org/project/video_embed_field/-/merge_requests/16... MR.

tibezh → made their first commit to this issue’s fork.

Looks good to me, I think we can merge it.

Sure, you are right. Added a patch with tests only and an interdiff to check difference quickly.

I've checked a patch from the #16 comment, looks good, but it will be better to have a little test.
A patch is attached.

I think it will be better to add into a new release

Yeah, you are right @klausi, attached a different patch with an interdiff.

I thing we can review it.

Seems looks good.

Here a few patches with and without tests.

tibezh → created an issue.

Could you provide more details on the issue, please? (export view, does it reproduce with another contributed module, etc.)

I've changed a little bit the ticket title and description.
Also prepared a patch to remove unused variables in the code. Just code refactoring.
Needs review.

A little mistake in my previous patch, attached an actual one.

A fail for PHP 8.2 & MySQL 8 → tests is not related to the ticket.
So we can review the patch.

It looks good now, needs review.

I can see that the issue is still present, seems the patch should be fix the issue.

Here is a patch with tests + a fix.

Here is a patch with tests only, except failed status for PHP 8.

tibezh → created an issue.

Hi All there,

I need to reopen the issue because we have the same troubles for D7 module version.

Thanx @greggles for the notice about the PHP version.

@smustgrave, could you check my new patch for D7 module version, please?
It should be good now.

We need the same changes for the D7 module version.
I've added a patch for D7.

tibezh → changed the visibility of the branch 3405414-provide-fallbacks-for to active.

tibezh → changed the visibility of the branch 3405414-provide-fallbacks-for to hidden.

Hi @TR, thanks for the help.
Sure, we need to have the same changes from 8.x.
I've updated the MR.

MR is available at https://git.drupalcode.org/project/views_aggregator/-/merge_requests/7
A patch can be applied from a link https://git.drupalcode.org/project/views_aggregator/-/merge_requests/7.diff

tibezh → created an issue.

Looks good, thanx!

Looks good to me.

Just checked, and it works.

I think the patch should support PHP 8.1. The $content can be NULL and we can get a PHP deprecation error.

Looks good.
The patch covers really important things to support PHP 8.1 on D7.

https://www.drupal.org/project/views_data_export/issues/3325212 🐛 Deprecated function: html_entity_decode(): Passing null to parameter #1 ($string) of type string is deprecated in decode_entities() RTBC

A patch is attached

tibezh → created an issue.

Looks good.

@eojthebrave here we have 2 terms: "initialized" and "items are added".
If we're using GTM, then "initialized" is already available, but the event should be added after GTM init.

I think that we need to have it in the footer to initialize after other scripts (i.n. GTM).

I've attached a patch with changes.

Hey @sano,
Looks like you are using an old version of the module.
The issue is already fixed in https://www.drupal.org/project/commerce/issues/3284128 📌 Required parameter $options follows optional parameter $data in commerce_cart.module on line 1163 Fixed

+

Here a MR with changes https://git.drupalcode.org/project/commerce_autosku/-/merge_requests/2/d...

tibezh → created an issue.

tibezh → made their first commit to this issue’s fork.

tibezh → made their first commit to this issue’s fork.

Hi there,
I have the same issue, but I think the fix should look slightly different.
We need to provide the 'file path' parameter for the overridden menu item, and no changes are needed for the .../edit route
Take a look for a patch, please.

Changes are available under merge request.

tibezh → created an issue.

The MR is available https://git.drupalcode.org/project/clever_reach_rules/-/merge_requests/1

tibezh → created an issue.

Looks good, thank you @klausi!

Here a patch

tibezh → created an issue. See original summary → .

Patch attached

tibezh → created an issue.

Looks good.

Looks good to me.
Thanx @klausi!

A patch is attached to the comment.

tibezh → created an issue.

Checked, works as expected.

The patch from the #15 comment is not applicable to 7.x-1.x, but #13 works.

Thanx @farse!
The patch from #41 works as expected.

I can confirm, it works as expected.