PHP Type error in form redirect when deleting saved searches

Looks good to me.
Thanx @klausi!

Thanks for reporting this problem, and sorry it took me so long to get back to you!
Your analysis of the problem isn’t entirely correct, though. The problem is that it seems the function was written for use with confirm_form(), for which it produces exactly the right output. However, we then also used it for drupal_goto() and $form_state['redirect'], without realizing that they use a slightly different format. It seems nobody noticed since this will only affect anonymous users’ alerts.

Anyways, I think the attached would be the proper fix: properly document what is being returned, and handle this accordingly in the caller. (Otherwise we’d need a second function, or a flag for which format to return.)
Please test/review, and thanks again!

Yup, this should also work. Thanks!

Good to hear. Merged.
Thanks again!

Automatically closed - issue fixed for 2 weeks with no activity.