Warning: Private methods cannot be final as they are never overridden

Created on 21 February 2024, 4 months ago

Updated 22 February 2024, 4 months ago

Problem/Motivation

When executing Simpletests all test files are scanned and then this PHP warnings shows up:
Warning: Private methods cannot be final as they are never overridden by other classes in redis/lib/Redis/Tests/AbstractUnitTestCase.php on line 56

Steps to reproduce

Execute any Simpletest.

Proposed resolution

Remove final keyword.

Remaining tasks

Patch

🐛 Bug report

Status

RTBC

Version

3.0

Component

Code

Created by

🇦🇹Austria klausi 🇦🇹 Vienna

Live updates comments and jobs are added and updated live.

PHP 8.1
The issue particularly affects sites running on PHP version 8.1.0 or later.

Comments & Activities

Issue created by @klausi
Status changed to Needs review 4 months ago3:10pm 21 February 2024
Comment 4 months ago →
🇦🇹Austria klausi 🇦🇹 Vienna
Patch.
Status changed to RTBC 4 months ago7:30am 22 February 2024
Comment 4 months ago →
🇺🇦Ukraine tibezh
Looks good, thanx!

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024