- Issue created by @damienmckenna
- Status changed to Needs review
about 2 years ago 11:18am 12 September 2023 - last update
about 2 years ago 232 pass, 70 fail - 🇺🇸United States damienmckenna NH, USA
Hopefully this doesn't cause any regressions.
The last submitted patch, 2: views-n3386717-2.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- First commit to issue fork.
- last update
about 2 years ago PHPLint Failed - last update
almost 2 years ago 234 pass - 🇺🇦Ukraine tibezh
I've changed a little bit the ticket title and description.
Also prepared a patch to remove unused variables in the code. Just code refactoring.
Needs review. - last update
almost 2 years ago 233 pass, 1 fail - last update
almost 2 years ago 234 pass - Status changed to RTBC
almost 2 years ago 11:27pm 20 December 2023 -
DamienMcKenna →
committed 0631676b on 7.x-3.x
Issue #3386717 by urvashi_vora, DamienMcKenna, tibezh, joseph.olstad:...
-
DamienMcKenna →
committed 0631676b on 7.x-3.x
- Status changed to Fixed
almost 2 years ago 11:17am 21 December 2023 - 🇺🇸United States damienmckenna NH, USA
Committed. Thanks everyone.
Automatically closed - issue fixed for 2 weeks with no activity.
- 🇷🇺Russia skylord
Hm. After this commit views_handler_area_result is broken 'cause all variables referenced later with curly braces syntax were removed....
- 🇺🇸United States cboyden
After this commit, I'm getting out-of-memory errors on an existing view with a contextual filter.
- 🇸🇰Slovakia trafo
In
views_plugin_argument_validate_php::validate_argument()removed variables might be used in the actual PHP code that is evaluated witheval(). Like in my case. Would be nice to give at least warning to check that code.We noticed some regression also with exposed forms, but not sure if it's tight to this.