- Issue created by @geoffreyr
- Merge request !603405414: Default to empty string when file has no extension → (Merged) created by geoffreyr
- Issue was unassigned.
- Status changed to Needs review
7 months ago 6:36am 12 December 2023 - 🇺🇦Ukraine tibezh
We need the same changes for the D7 module version.
I've added a patch for D7. - Status changed to RTBC
7 months ago 7:30am 12 December 2023 - 🇦🇹Austria klausi 🇦🇹 Vienna
Looks good to me! I'm RTBC'ing the Drupal 7 version. The "??" operator only exists in PHP 7, but I think that is ok, not sure how many Drupal 7 sites on PHP 5 are still out there.
- Status changed to Needs review
7 months ago 12:18pm 12 December 2023 - 🇦🇹Austria klausi 🇦🇹 Vienna
Right, that is a good idea! Setting back to needs review for that, the D10 change should be ready as is.
- Status changed to Fixed
6 months ago 2:09pm 13 December 2023 - Status changed to Needs review
6 months ago 7:09am 15 December 2023 - 🇺🇦Ukraine tibezh
Hi All there,
I need to reopen the issue because we have the same troubles for D7 module version.
Thanx @greggles for the notice about the PHP version.
@smustgrave, could you check my new patch for D7 module version, please?
It should be good now. -
smustgrave →
committed 5c542199 on 7.x-1.x authored by
tibezh →
Issue #3405414 by tibezh, geoffreyr, klausi, smustgrave, greggles:...
-
smustgrave →
committed 5c542199 on 7.x-1.x authored by
tibezh →
- Status changed to Fixed
5 months ago 3:10pm 23 January 2024 - 🇺🇸United States smustgrave
Don't mind committing to D7 branch but really the D7 branch is all but done.
https://git.drupalcode.org/project/stage_file_proxy/-/commit/5c54219976c...
Automatically closed - issue fixed for 2 weeks with no activity.