Denver, Colorado, USA
Account created on 21 October 2005, over 20 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States greggles Denver, Colorado, USA

Sounds good to me.

What do you think about changing the version string as affected from 7.x-1.0 to <= 7.x-1.6? That way the shipped versions from the 3rd party vendors can be seen as fixed.

🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA

OK, thanks.

I found this page for tag1 which I can add as a related article at the time of publishing.

🇺🇸United States greggles Denver, Colorado, USA

> (btw, we aligned on using the D7 version number style after this was submitted.)

I wondered about that. Thanks for pointing it out.

🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA

greggles → made their first commit to this issue’s fork.

🇺🇸United States greggles Denver, Colorado, USA

Still working on this? We should either publish the details or somehow stop using this CVE (e.g. reject it)

🇺🇸United States greggles Denver, Colorado, USA

These are now all posted. Any suggestions for improvements can be commented here or as a new issue in this queue.

🇺🇸United States greggles Denver, Colorado, USA

All of this sounds great to me. Thanks!

🇺🇸United States greggles Denver, Colorado, USA

There were some changes to the orgId in the json you provided that I didn't expect. So, I tried to manually make the changes you proposed rather than using the file as attached here.

I also used 1.0 and 1.2 for the 8.x version since I think that's how they are interpreted.

Now published and I'd appreciate your review, but consider this fixed.

🇺🇸United States greggles Denver, Colorado, USA

OK, I published this one. Thanks for your help.

🇺🇸United States greggles Denver, Colorado, USA

Thanks for the explanations in #4.

I made a few tweaks and published this.

* adjusting versions to 7.x style custom
* adding www on the package collection URL
* To be consistent with prior CVEs, the vendor should be "Drupal" not "Drupal community"
* Following previous examples - using the auto-generated description.

Those will be good things to double check for future CVEs.

🇺🇸United States greggles Denver, Colorado, USA

I reserved CVE-2026-1556.

🇺🇸United States greggles Denver, Colorado, USA

This generally LGTM. Thanks for the explanations.

🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA

Feedback welcome. I may post these tomorrow as we can always fix them if there is feedback in the future and I don't anticipate much feedback (though really, it's always welcome!).

🇺🇸United States greggles Denver, Colorado, USA

This LGTM.

🇺🇸United States greggles Denver, Colorado, USA

Hi aangel - As a project maintainer for this project I can add credit to people. Then you as the individual manage credit to volunteering or the right company for each issue. At least...I think that's how it works. If you can't figure it out I'm happy to keep digging and try to find where/ how that attribution is controlled.

🇺🇸United States greggles Denver, Colorado, USA

Good call - I think it's fixed now (caching can vary depending on your source).

🇺🇸United States greggles Denver, Colorado, USA

I notice this has some semver style versions in it that we'll need to fix. But that's not a big deal.

Adjusting status.

Assuming reviews go well the step is Jan 21 we should reserve a CVE for it.

🇺🇸United States greggles Denver, Colorado, USA

I made those changes and published this as well. Thanks for the help, everyone.

🇺🇸United States greggles Denver, Colorado, USA

I made those changes manually and published it. I think there's no need to submit a new json just for small things like this. Thanks for your help!

🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA

This has the same questions/issues with collection URL and version strings as the Flag CVE.

Do my proposed fixes on 📌 CVE Request for Flag Module Needs work make sense?

🇺🇸United States greggles Denver, Colorado, USA

I just noticed some items and wanted to discuss before posting.

I think the package collection URL should be https://www.drupal.org/project/flag → which follows the pattern in other CVEs.
For the version of 7.0.0 as minimum, do you mean for that to be 7.x-3.0? I think we should call the version scheme "custom" and use 7.x-3.x as the version string.

I see that herodevs release is being called 7.3.10 and then the tag1 is called 7.x-3.10

And then for the <= version, I'm thinking it should be 7.x-3.9.

🇺🇸United States greggles Denver, Colorado, USA

Forgot to mark needs work for publishing the page and updating the json to include the CVE id and the link.

🇺🇸United States greggles Denver, Colorado, USA

OK, I reserved CVE-2026-0750 for this.

🇺🇸United States greggles Denver, Colorado, USA

OK, I reserved CVE-2026-0749 for this.

🇺🇸United States greggles Denver, Colorado, USA

OK, I reserved CVE-2026-0748 for this.

🇺🇸United States greggles Denver, Colorado, USA

whoops, meant to set this in #17

🇺🇸United States greggles Denver, Colorado, USA

On reconsidering this, I think my concern and proposed solution from #2 is not quite right. I'd been thinking of the script that generates the CVE json as the source of truth. However, the vulnrichment program makes its own adjustments so...the only source of truth is the MITRE CVE database.

I've now made the change proposed here - please double check if you can and let me know any oversights.

🇺🇸United States greggles Denver, Colorado, USA

Great, thanks. I'll try to get to these this week.

🇺🇸United States greggles Denver, Colorado, USA

Great, thanks. I'll try to get to these this week.

🇺🇸United States greggles Denver, Colorado, USA

There appear to be 12 CVEs for December that need to be categorized with CWE and CAPEC.

🇺🇸United States greggles Denver, Colorado, USA

Plan sounds good to me so far. Thanks for thinking this through and sharing your plans.

🇺🇸United States greggles Denver, Colorado, USA

small adjustments to tone, some recommended by grammarly

🇺🇸United States greggles Denver, Colorado, USA

Yeah, I was just thinking we could probably consider this properly fixed now.

Thanks to everyone for their work on this!

🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA

Thanks aangel.

I'll adjust the status since there is a file to review.

🇺🇸United States greggles Denver, Colorado, USA

Yep, now reserved as CVE-2025-14557

Needs work for publishing an article and updating the json.

🇺🇸United States greggles Denver, Colorado, USA

Needs work to publish your article and then update the json to cite it and then I can publish it.

🇺🇸United States greggles Denver, Colorado, USA

Sure, it's been long enough for review.

I registered CVE-2025-14556 for this.

🇺🇸United States greggles Denver, Colorado, USA

greggles → created an issue.

🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA

Thanks. Acknowledging I've seen this and adjusting status to needs review so others know its time for that.

🇺🇸United States greggles Denver, Colorado, USA

greggles → created an issue.

🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA

I think this is still needs work for this part:

Currently we take the version info from the advisory and pass that along. If we need to add more versions to it then I guess we could add that info to the json and merge it on the end of the version we get from the advisory? I'm not sure I love that solution, but we should sort it out.

🇺🇸United States greggles Denver, Colorado, USA

Here's what I think will work given the needs of the herodevs system:

* Propose CVE text in an issue
* Wait some time (a week?) for reviews, especially suggestions of URLs to reference
* I can reserve a CVE ID and post it here
* HeroDevs can post in the HeroDevs system and comment on the issue with updated json
* I will publish that CVE data

🇺🇸United States greggles Denver, Colorado, USA

Thanks for sharing that URL. If there are multiple URLs the standard of CVEs that is consistent with a community project is we should cite all relevant URLs.

In general I don't think we should expect to have a reference URL on d.o about the D7ES issues (aside from coordination on CVEs).

@heddn please also see https://www.drupal.org/project/securitydrupalorg/issues/3559893 📌 CVE Request for Flag Module Needs work for a similar issue. You might want to subscribe to issues in this queue so you can help review CVE text.

🇺🇸United States greggles Denver, Colorado, USA

Still relevant for 8.x-3.x.

🇺🇸United States greggles Denver, Colorado, USA

Thanks for that explanation. I see why the CVE ID is useful now.

Let's wait for review on this then (especially given the holiday this week) and if there's no feedback in ~a week we can move forward with cve id reservation, herodevs publishes, update json to include that link and wait a shorter time for review of the json and then publishing the cve.

🇺🇸United States greggles Denver, Colorado, USA

This could be needs review since there's json here or needs work to resolve the issue where we need a public URL. Marking needs work for the public URL, but I encourage interested folks to review the proposed json.

I think it's fine that the json posted here does not (yet) have a CVE-ID in it as that can be added last minute as it gets published, so I'll remove that from the issue summary.

🇺🇸United States greggles Denver, Colorado, USA

Thanks for noticing and commenting here, damienmckenna. I'm not sure what went wrong, but I tried again and it seems to have gone through this time.

🇺🇸United States greggles Denver, Colorado, USA

Thanks for filing this issue and posting the proposed json.

Could you share an "interdiff" from the original file compared to this one? I've found that formatting issues and the vulnrichment data can make it hard to compare the data.

Currently we take the version info from the advisory and pass that along. If we need to add more versions to it then I guess we could add that info to the json and merge it on the end of the version we get from the advisory? I'm not sure I love that solution, but we should sort it out.

🇺🇸United States greggles Denver, Colorado, USA

I see this as similar to the risky content check (not sure if that feature is still present, but it was looking for stuff like iframes and script tags). On some sites that's totally normal and appropriate, so the module has a few ways to disable that check. But on other sites that represents an attack (or more likely an attempted attack).

🇺🇸United States greggles Denver, Colorado, USA

Is there a concept of optional checks? This doesn't feel like a required security setting, but is optional, from my perspective.

🇺🇸United States greggles Denver, Colorado, USA

It is valid to say that the .htaccess should not be writable by the webserver.

🇺🇸United States greggles Denver, Colorado, USA

I updated https://www.drupal.org/docs/administering-a-drupal-site/security-in-drup... → the issue is still relevant.

I've asked others to review the other page.

I think yes, they can have their weights reset.

🇺🇸United States greggles Denver, Colorado, USA

removing outdated parts so it doesn't need to be depreacted

🇺🇸United States greggles Denver, Colorado, USA

mcdruid provided some advice on 008, so updating that and also gave credit in the new system.

🇺🇸United States greggles Denver, Colorado, USA

I updated some old core values that were missing and have added the 2 contribs and 4 core.

🇺🇸United States greggles Denver, Colorado, USA

Thanks!

🇺🇸United States greggles Denver, Colorado, USA

Now that 📌 Refactor SA data so it's a single data file Active is done I think this issue can be closed since the same goal was achieved there. What do you think?

🇺🇸United States greggles Denver, Colorado, USA

This looks good to me. I reviewed a few items in the transition and also the updated logic.

Thanks for your help to make this easier to maintain and more generally useful.

🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA

greggles → created an issue.

🇺🇸United States greggles Denver, Colorado, USA

Needs work - can you create this as a patch?

🇺🇸United States greggles Denver, Colorado, USA

Great news, thanks @g-rath!

🇺🇸United States greggles Denver, Colorado, USA

I registered CVE-2025-12848 for this and published what we had.

It would be ideal to add a "public at" and update the version range and the credit values, but those are all optional, so I'll mark this fixed.

If someone updates the json I'm happy to review/post again. Thanks!

🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA

> Do we want to warn when this happens, or not allow this type of version constraint?

Agreed with #5 this could be a not allow situation. I guess if a > is present it has to be followed by =.

🇺🇸United States greggles Denver, Colorado, USA

The CVE-2025-____.txt file is still valid and loads into vulnogram.

There was lots of good discussion here about process and we've done some outreach to try to follow that process.

There wasn't much discussion about the content of the proposed CVE. I've just read it and I think its fine.

At this point, especially since there was no disagreement with my comment in #14, I think we are within our responsibility to publish this.

Moving to RTBC to indicate what I believe to be the appropriate status. I can help move this forward next time I file CVEs.

If anyone feels we should not create this, please do comment.

🇺🇸United States greggles Denver, Colorado, USA

These are now posted. I had to make the version a string to get vulnogram to parse it (that was a fun side quest to track down).

If any need adjustments, please open an issue and we can address them.

🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA

Adjusting title since I think the goal is to provide all advisories in OpenSSF Vulnerability format.

Here's where I think this stands:

There's growing agreement that we would like the Drupal Security Team to officially provide OSV files.

We hope this would be beneficial for the Drupal project to support OSV and to promote site owners using osv-scanner to scan their sites. osv-scanner will alert about vulnerabilities in all kinds of code, while most tools are either focused on one technology (e.g. composer's focus on PHP) or are paid (e.g. snyk) or are platform dependent (e.g. Github alerts).

Some key points about moving forward:

  1. The code and the published osv files will be in a place managed by the Security Team with help from Gareth and Gold.
  2. Gareth and Gold have built out the automation in Github. We will move the code and automation to a space managed by the Drupal Security Team before it is added to the OSV aggregator. I propose DrupalSecurityTeamOps as a spot for this that is segmented from our other uses of Github.
  3. We can optimize the process and code in the future (e.g. moving to CVSS, having drupal.org generate the osv file directly and then the github repo would just pull that down, maybe moving some automation to Drupal.org owned Gitlab). But this is a good solution for now.
  4. There is limited capacity among the Drupal Security Team to support this. Luckily, Gareth and Gold from Ackama are willing to help. Given that, we'll consider this a pilot for now, and we are interested in improving the sustainability of the effort by getting more support. Once it's set up, Gareth and Gold believe the ongoing effort will be limited.
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA

+1 from me. There's some history of discussion along these lines in 📌 Deprecate in favor of drupalorg maintainer:release-notes Fixed .

🇺🇸United States greggles Denver, Colorado, USA

(publishing this issue)

🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA
🇺🇸United States greggles Denver, Colorado, USA

Ah, yeah! I think that image is helpful to explain the idea.

🇺🇸United States greggles Denver, Colorado, USA

Given the details of #8, I think this should be won't fixed for now. We can revisit in the future if appropriate.

🇺🇸United States greggles Denver, Colorado, USA

Looks like great progress to me. Thanks for the work. I think you could call this "fixed" but if you want to leave it open for any reason, feel free to. Thanks.

Production build 0.71.5 2024