- Issue created by @larowlan
- π¬π§United Kingdom catch
Adding API support is a good idea, we could try to implement it in Olivero too maybe.
β¨ Allow CSS to be added at end of page by rendering assets with placeholders Active is trying to defer CSS.
Are you adding this to individual files or the library definition? And what happens if a critical file has a dependency on a non-critical one?
- π¬π§United Kingdom catch
β¨ [PP-2] Support inline and async CSS Postponed: needs info is already open but there was no progress there and I marked it 'needs more info' some time ago, so possibly we should start fresh and mark that issue duplicate of this.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Pushed up some work based on our client projects but it doesn't work with asset aggregation turned on - that's because the file doesn't exist the first time around.
It works on our client project because we have build tooling for CSS so don't use core's aggregation for the FE theme
Will have to have a think about how to do this in a way that is compatible with the lazy asset optimization/rendering.
- π¦πΊAustralia larowlan π¦πΊπ.au GMT+10
Added
preprocess: false
to the inline items for now, but ideally we could automate that. Perhaps we need to move critical up to the top level of the definition - π¦πΊAustralia rikki_iki Melbourne
Maybe something like this?
global: css: critical: css/critical-stuff.css: {} base: css/normal-stuff.css: {}
Reads a bit better, but probably changes the whole implementation :)
- πΊπΈUnited States luke.leber Pennsylvania
This feature would allow the Inline All CSS β module to continue to live in Drupal 11+.