- Issue created by @prudloff
- Assigned to smustgrave
- Status changed to RTBC
4 days ago 8:13pm 20 June 2025 - 🇺🇸United States greggles Denver, Colorado, USA
I will add my take: this doesn't feel exactly right to me from the perspective of Drupal's philosophy of restrict access. An attacker with access to a site that has a vulnerable configuration can already exploit it, regardless of the security_review report access. In fact, an attacker could look at the code of security_review on drupal.org for ideas of things to check even if the module is not installed. Restricting this access does make it less likely an attacker will find vulnerabilities and there are enough people who think this makes sense that I'm OK with the idea.
- 🇫🇷France prudloff Lille
In fact, an attacker could look at the code of security_review on drupal.org for ideas of things to check even if the module is not installed.
I think it is true for most of the checks, but some checks could reveal information that would not be available (or hard to acquire) without this module.
For example TemporaryFiles provides a list of sensitive files that could be downloaded. Without this information it could be possible to brute force the file name but if the file name is unusual it would be much harder. - 🇺🇸United States greggles Denver, Colorado, USA
Yes, that's a great point in favor of continuing with the commit.