- 🇺🇸United States greggles Denver, Colorado, USA
OK, I see it was fixed in https://git.drupalcode.org/project/govuk_theme/-/commit/7edc7e7c898c8ebc...
You could make this was fixed in that case. Thanks!
- 🇬🇧United Kingdom webfaqtory
@greggles . Thought I did that and a release 8.x-1.19 → Haven't done a merge on Drupal before, only merged patches so did I miss something?
- 🇺🇸United States greggles Denver, Colorado, USA
@webfaqtory it looks like you're a maintainer. Any reason not to commit this and make a release?
Automatically closed - issue fixed for 2 weeks with no activity.
FYI, Select2 hasn't been updated for even longer than Choices. If we're going to consider ChoicesJS abandoned, the same should be said about Select2...
- 🇳🇿New Zealand quietone New Zealand
I read the IS summary, the comments and the MR. The proposed resolution is out of dateAll questions are answered and the threads in the MR are correctly resolved.
I then applied the diff and tested. This works as expected and is an improvement!
I do think there follow up work.
- Add this feature to media files as well.
- The warning message uses the string 'It is advised' which is the first occurrence in core for a warning message. Because of that I think that the usability folks should review the string.
- The first time I read "It is advised to store file uploads for contact forms as private files. You can configure this in settings.php" I read the first as something to action so I tried to. Of course, the option is not available and I knew that but I still tried! So, again, I think the a usability review would help.
I think the above items can be done in followups. I am adding the tag for that.
I finally read the test. Is there a reason it is only testing 1 code path?
- @silviaddweb opened merge request.
- 🇮🇳India dev16.addweb
silvi.addweb → made their first commit to this issue’s fork.
- 🇬🇧United Kingdom catch
Slowly learning how cross-pipeline artifacts work in 📌 Use artifacts to share the phpstan result cache from core to MRs Needs work and it'll a bit tricky but it should work for this.
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
I agree that is the best solution. Anything else would be temporary.
- 🇺🇸United States Luke.Leber Pennsylvania
Seeing as https://www.drupal.org/project/webform/issues/3460222#comment-15692042 📌 Consider deprecating Choices Closed: duplicate closed a related issue as a duplicate, I wanted to bring over the opinion that deprecating, discouraging the use of Choices, and ultimately removing it from Webform seems to be the most responsible path forward here.
The library is abandonware.