USA
Account created on 25 June 2007, almost 18 years ago
#

Merge Requests

More

Recent comments

🇺🇸United States mradcliffe USA

Also realized there's probably some thorough instructions here (core-related) that can be extrapolated to contrib. Either a subtree split or git-filter-repo is suggested: https://www.drupal.org/about/core/policies/core-change-policies/how-to-d...

🇺🇸United States mradcliffe USA

My current process:

I find it easiest for myself to create the new issue when I go to credit participation and close the previous month's meeting issue,

  1. Review Slack for participation in the roll call and other threads:
    1. Confirm the Credit & committing > By list and check the boxes
    2. For each person, confirm their drupal.org username if it was not provided by them, and type it in Credit & committing > Credit others, then type a comma
    3. Review the list to make sure I got everybody and did not use an old username from my memory rather than a current username.
  2. Change the Status to fixed and add a comment closing the issue with credits
  3. Follow the "clone issue" link (this might be dreditor)
  4. Update the title for the correct day, month and year of the next meeting.
  5. Update the dates in the issue summary
  6. Remove the URL to the previous month's meeting with a placeholder
  7. Remove any expired agenda items such as previous DrupalCon planning threads, previous event threads.
  8. Renumber thread emoji as needed
  9. Save
  10. Update placeholder from the step above with the new URL and save the issue again

I think this should be done anywhere from 1 week after the previous meeting to account for continual discussion and 1 week prior to the next meeting to provide time for editing the agenda by any mentor.

If I am running the meeting, then just before 20:00 UTC I do the following:

  1. Set the issue in my browser to Edit mode
  2. Ensure I am on Drupal Slack in the mentoring team coordination channel
  3. I copy the initial chunk of text until the first empty line and paste it into Slack
  4. I immediately paste the :zero: agenda item into Slack and start a thread introducing myself.
  5. I try to continually copy a group of agenda items, separately, so each can be its own thread in fairly rapid succession so that I can participate in the discussion too. I try to start each group of agenda items or the next agenda item after about 2-3 minutes so that there is time to bounce between threads for active discussion.
  6. Near the 45 minute mark or later, I paste the "That's it for now" message
🇺🇸United States mradcliffe USA

If you want to keep git histories, we can use a tool like git-filter-repo to do this. It will have an extra commit to move files.

I think that these instructions could be worked on at MidCamp as long as you create the new projects exist by then.

  1. Clone a fresh copy of event_platform.
  2. Create and clone clone {submodule} issue fork and checkout the issue fork branch.
  3. Change directory into event_platform.
  4. Run git-filter-repo --path {submodule} --to-subdirectory-filter {submodule}
  5. Change directory into {submodule}.
  6. Run git remote add -f event_platform ../event_platform
  7. Run git merge --allow-unrelated-histories event_platform/2.0.x
  8. Remove any tags git tag | xargs git tag -d
  9. Run git mv {submodule}/{submodule}/* .
  10. Remove the {submodule} directory.
  11. Commit
  12. Add default files if they do not exist yet (e.g. .gitignore, gitlab-ci.yml, composer.json, README.md)
  13. Commit
  14. Cleanup namespaces, dependencies and any other files.
  15. Commit
  16. Push
  17. Create a merge request from the issue fork branch

This will essentially give the history (for event_platform_scheduler):

* fdd4530 (HEAD) Moves files into place (6 seconds ago) <Matthew Radcliffe>
*   feca34c (2.0.x) Merge branch '3366560-create-events-as' into 2.0.x (6 weeks ago) <Martin Anderson-Clutz>
|\  
| * ff45c57  Code changes and first pass on content architecture changes (6 weeks ago) <Martin Anderson-Clutz>
* | 1582ea9  Issue #3366560 by mandclu: Create Events as entities to allow for multiple years (6 weeks ago) <Martin Anderson-Clutz>
|/  
* c16a289  (1.1.x, 1.0.x) Issue #3451068 by Project Update Bot, mandclu: Automated Drupal 11 compatibility fixes for event_platform (11 months ago) <Martin Anderson-Clutz>
* 03c23b2  Fix for stuck scheduler spots (1 year, 10 months ago) <Martin Anderson-Clutz>
* 21cf0e1  Issue #3372171 by mandclu: Add a session moderator role (1 year, 10 months ago) <Martin Anderson-Clutz>
* 88e9ca0  Issue #3372042 by mandclu: Make Scheduler table full width (1 year, 10 months ago) <Martin Anderson-Clutz>
* 38d9263  Issue #3372038 by mandclu: Remove console.log call in scheduler.js (1 year, 10 months ago) <Martin Anderson-Clutz>
* e5cfd77  Issue #3372036 by mandclu: Notice: Only variables should be passed by reference in Scheduler->buildRows() (1 year, 10 months ago) <Martin Anderson-Clutz>
* 80a270a  Issue #3357829 by apaderno, mandclu: Fix the issues reported by phpcs (1 year, 10 months ago) <Martin Anderson-Clutz>
* 7518861  Issue #3371933 by mandclu: In Scheduler highlight scheduled sessions matching filters (1 year, 10 months ago) <Martin Anderson-Clutz>
* 81d46b3  Issue #3371942 by mandclu: Update empty messaging in scheduler interface (1 year, 10 months ago) <Martin Anderson-Clutz>
* 7d123fe  Issue #3371940 by mandclu: Error: Call to a member function get() on null (1 year, 10 months ago) <Martin Anderson-Clutz>
* dda89ff  Issue #3371930 by mandclu: Drupal\Core\Entity\Query\QueryException: Entity queries must explicitly set whether the query should be access checked or not (1 year, 10 months ago) <Martin Anderson-Clutz>
* 5d19f54  Issue #3371896 by mandclu: Fix code standards issues (1 year, 10 months ago) <Martin Anderson-Clutz>
* 02f8787  Issue #3371708 by mandclu: Provide session filters in scheduler view (1 year, 10 months ago) <Martin Anderson-Clutz>
* c480527  Issue #3366558 by mandclu: Scheduler Validation: Don't allow more than one session by the same presenter in the same time slot (1 year, 10 months ago) <Martin Anderson-Clutz>
* a973ebf  Issue #3366556 by mandclu: Allow sessions to be filtered by workflow status in the Scheduler (1 year, 10 months ago) <Martin Anderson-Clutz>
* 82f3047  Issue #3360405 by mandclu: Use Smart Date's updated format service method (2 years ago) <Martin Anderson-Clutz>
* 51756b1  Issue #3360403 by mandclu: Round the corners in sessions in the Gin Admin Theme (2 years ago) <Martin Anderson-Clutz>
* e2dfa5d  Issue #3360401 by mandclu: Provide a tool to generate time slots (2 years ago) <Martin Anderson-Clutz>
* d6c19ac  Issue #3355872 by mandclu: Provide a scheduler interface to quickly assign time slots and rooms (2 years ago) <Martin Anderson-Clutz>
🇺🇸United States mradcliffe USA

I went ahead with a merge request that changes both to text areas.

🇺🇸United States mradcliffe USA

mradcliffe changed the visibility of the branch 3521988-longer-description to active.

🇺🇸United States mradcliffe USA

mradcliffe changed the visibility of the branch 3521988-longer-description to hidden.

🇺🇸United States mradcliffe USA

I updated the issue summary with links from #14 and added the links to recent issues in the examples item list.

🇺🇸United States mradcliffe USA

cmlara, thank you. That jarred my memory. I was trying to find where it came from.

🇺🇸United States mradcliffe USA

In the new first-time contributor workshop slides that volkswagenchick developed we have a single slide titled "Use of AI" with the following scripted notes. This could be a good start for an official policy.

There is no doubt that artificial intelligence tools such as ChatGPT can be powerful ways to jumpstart code or content. However, AI systems still have significant flaws. Often times the code they produce is non-functional, and the content they create includes assertions or citations that are untrue.

When using AI in the course of making a contribution to Drupal, we require you to:

Disclose that AI was used in crafting the code or content.
Carefully review and test the output, to ensure it is relevant, and that it works.
Provide human intervention to correct inaccuracies, mistakes, or broken code.
Bulk use of AI when it is not relevant to an issue, provides broken or unusable code, or provides false information will likely result in a ban.

I am not sure why we mention it as required, but it probably should be changed to recommended for now pending policies.

🇺🇸United States mradcliffe USA

Thank you for creating the merge request, lostcarpark.

🇺🇸United States mradcliffe USA

The job will probably fail for both phpcs and phpstan due to rules like "Drupal calls should be avoided in classes, use dependency injection instead" and I think you can work on those later to get green :-)

🇺🇸United States mradcliffe USA

I applied the patch manually to my non-activitypub module, non-multilingual site that uses webfinger, and I did not find any regressions. +1.

🇺🇸United States mradcliffe USA

Renamed issue to reduce scope for new process. I forgot to link the role page in the issue summary.

🇺🇸United States mradcliffe USA

I stumbled on this and the other issue today working on a recipe.

I updated the steps to reproduce to use an already existing core recipe as an example (core_recommended_admin_theme).

I think that we should do the hook_themes_installed() approach and add a @todo comment linking to 📌 Copy block configuration from admin theme when enabling an admin theme Active so that we're not blocked (pun intended).

🇺🇸United States mradcliffe USA

+1 on this. I always forget I have access to create contributor roles at https://www.drupal.org/node/add/contributor-role (since it's not linked anywhere that I can find), but I don't know which permissions grant that.

We probably want to list roles or specify specific roles in the issue summary to create. Looking at some similar roles in working groups:

- Confilct resolution team member is a role inside the Community Working Group though it may not be clear that it is part of that group.
- Community health team member is a role inside the Community Working Group though it may not be clear that it is part of that group.
- Licensing working group member is a bit clearer for the LWG.
- Coding standards committee member is part of the TWG. That page links to the charter, which is nice.

🇺🇸United States mradcliffe USA

The Mentoring team is interested. We currently use https://drupalcontribution.org (OpenSocial) as a stop-gap solution, but that was originally made for helping to organize and organize virtual contribution events.

🇺🇸United States mradcliffe USA

A new branch needs to be created, potentially 3.0.x before I can create a merge request for this.

🇺🇸United States mradcliffe USA

mradcliffe made their first commit to this issue’s fork.

🇺🇸United States mradcliffe USA

Removes Needs tests tag after I wrote a test. Removes Documentation tag because this is not a documentation issue.

🇺🇸United States mradcliffe USA

We can add a test recipe in core/tests/fixtures/recipes and Drupal\KernelTests\Core\Recipe\InputTest would be a good place to either add a new kernel test?

🇺🇸United States mradcliffe USA

Added the Needs tests issue tag. I think the recipe.yml above could be used. We don't need to install anything. We only need to confirm the recipe is applied message is displayed to the user.

🇺🇸United States mradcliffe USA
    // Most of the input-collecting methods of StyleInterface have a `default`
    // parameter.
    $arguments += [
      'default' => $default_value,
    ];

But not all of them do so adding default here causes the error for askHidden.

🇺🇸United States mradcliffe USA

The test is failing with an access denied error accessing /admin/reports/upgrade.

Honestly, I am not sure why that report uses the MigrateAccessCheck rather than a permission as the controller does not run migrations, it redirects to watchdog with the query parameter "type" set to "migrate_drupal_ui". The only permission that is needed is "access site reports", which is not restricted to user 1.

Maybe fixing migrate_drupal_ui.log route to use that permission instead would make sense because an administrative user with "access site reports" already has access to it?

🇺🇸United States mradcliffe USA

Do we need to add a @todo with the issue url for the coder issue above the ignore?

I removed the Needs followup tag since @dcam created the issue.

🇺🇸United States mradcliffe USA

Thanks for making the change @koustav_mondal. The MigrateControllerTest is now failing. Running that test in isolation to debug it would be the next step here to resolving.

As part of the meta issue, 📌 [Meta] Fix all tests that rely on UID1's super user behavior Active , we need to “Assign the right permissions to make the test go green without the super user access policy.”

🇺🇸United States mradcliffe USA

Updated MWG item.

🇺🇸United States mradcliffe USA

I think this is fixed now. Pipeline is passing.

🇺🇸United States mradcliffe USA

I resolved the CS nits. I removed the use of t completely because other tests do not use it such as MapBaseFieldTest and FieldItemTest. Also I switched to using FieldType attribute.

🇺🇸United States mradcliffe USA

mradcliffe made their first commit to this issue’s fork.

🇺🇸United States mradcliffe USA

Thanks for recording the discussion, @rfay!

🇺🇸United States mradcliffe USA

Oh, nice catch. Thank you for the merge request.

🇺🇸United States mradcliffe USA

mradcliffe made their first commit to this issue’s fork.

🇺🇸United States mradcliffe USA

Added more agenda items.

🇺🇸United States mradcliffe USA

Based on some discussion at DrupalCon Atlanta, we need to merge the changes that have already decided upon.

I am going to create a new Update Mentoring Coordinators section in MAINTAINERS.txt in the Mentoring project for the Mentoring Working Group (MWG) to elicit feedback and evaluation from Mentoring Coordinators. And then once that is ready, we can move into the Core issue queue and create a merge request.

I added AmyJune, Tara, and Mauricio to the Past core maintainers page because they have already stepped down their role.

🇺🇸United States mradcliffe USA

Confirm Mentoring coordinator MAINTAINERS.txt 📌 Confirm and update mentoring coordinators section in MAINTAINERS.txt Active issue. Adding past and no longer active mentoring coordinators.

🇺🇸United States mradcliffe USA

Adding credits from the 19 March 2025 meeting.

🇺🇸United States mradcliffe USA

This might be a good candidate for Member Platform if we can switch to using that rather than OpenSocial.

@rachel_norfolk might have access to get this setup on the OpenSocial site.

🇺🇸United States mradcliffe USA

I am marking this as Needs work because we still need to add explicit test coverage based on the issue summary and we probably want to make the messenger string a translatable markup string with a placeholder.

🇺🇸United States mradcliffe USA

It looks like the issue summary has been updated. When updating the issue summary, we want to remember to remove the tag as well.

It would be nice to get another person to do a code review.

🇺🇸United States mradcliffe USA

I am a little confused. The @todo comment mentions to remove the usage of the super user, but it looks like this is still being used in the test. Does the variable also need to be removed?

For those working on this issue, can you explain why this wasn't removed too?

🇺🇸United States mradcliffe USA

I talked with Jason and postponing the issue seems like a good idea after updating the issue summary about why this is postponed / should be closed eventually.

🇺🇸United States mradcliffe USA

Thank you everyone for reviewing the code. I was talking with Gábor who knows a bit more about multilingual and translatable strings. He pointed out that the paragraph tag is allowed in translatable strings. He went to locale.drupal.org to search for use of <p in translatable strings.

So this may not be as straight-forward as we thought.

I am going to add the Needs issue summary update and Needs steps to reproduce tags and set this to Needs work as there is something else that is causing the error.

🇺🇸United States mradcliffe USA

The test runner seems to have failed on a bunch of kernel tests, but it was not clear if it is related to the changes.

🇺🇸United States mradcliffe USA

Potentially a redirect from "documentation/is-drupal-secure" the Frequently Asked Questions page .

🇺🇸United States mradcliffe USA

I added the Needs issue summary update because it would be nice to have a clear problem/motivation and proposed resolution section on the issue.

🇺🇸United States mradcliffe USA

It would be helpful to list the pages that are being worked on in the issue summary or in a comment as you are working on them so we can track what pages have been worked on.

🇺🇸United States mradcliffe USA

I added the Atlanta2025 issue tag for searchability.

Would a good criteria for assessing need be to review the Roadmap: #3446089: [Meta] Recipes Phase 2 Roadmap ?

🇺🇸United States mradcliffe USA

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because I think the requested changes from @quietone and confirmed by @joachim are clear. As well, we can confirm the uses again and update the issue summary to clarify how we found the changes.

🇺🇸United States mradcliffe USA

I am removing the Novice tag from this issue because it was hard to me to determine the novice task on the issue.

I’m using this documentation as a source: https://www.drupal.org/community/contributor-guide/task/triage-novice-is...

🇺🇸United States mradcliffe USA

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because there is a clearly defined task for resolution. The issue summary could use an update as well.

There were some test failures in the merge request, but I think those are false positives.

🇺🇸United States mradcliffe USA

I am removing the Novice tag from this issue because I think the resolution is ambiguous with the does not break anything comment.

I’m using this documentation as a source: https://www.drupal.org/community/contributor-guide/task/triage-novice-is...

🇺🇸United States mradcliffe USA

I performed Novice Triage on this issue. I added the Novice issue tag because we can update the issue summary and potentially start. We need to come up with a good test for the change.

🇺🇸United States mradcliffe USA

I performed Novice Triage on this issue. I added the Novice issue tag and the Needs issue summary update issue tag so that the notes provided by @pdureau can be added to the issue summary to clarify the scope of the issue.

🇺🇸United States mradcliffe USA

I am removing the Novice tag from this issue because I think there is not a clear path forward at the moment.

I’m using this documentation as a source: https://www.drupal.org/community/contributor-guide/task/triage-novice-is...

🇺🇸United States mradcliffe USA

Let's try to move this forward. I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because we can focus on both rebasing existing work and applying the changes from @amber himes matz in #9.

🇺🇸United States mradcliffe USA

I am removing the Novice tag from this issue because I think it is not as clear how to split the based on the various meta issues.

I’m using this documentation as a source: https://www.drupal.org/community/contributor-guide/task/triage-novice-is...

🇺🇸United States mradcliffe USA

I am removing the Novice tag from this issue because I think it is a bit confusing for a first-time issue.

I’m using this documentation as a source: https://www.drupal.org/community/contributor-guide/task/triage-novice-is...

🇺🇸United States mradcliffe USA

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue based on @smustgrave's triage. We should focus on the issue summary update based on recent work and resolving the code review.

🇺🇸United States mradcliffe USA

Re-opening the issue as Active because the other issue is now postponed. One of the two should remain open.

I updated the issue summary with the issue summary template, some steps to reproduce, and a summary of discussion.

🇺🇸United States mradcliffe USA

Both this issue and 🐛 Node created timestamp and updated timestamp are different for new nodes Needs work are now postponed. The latter issue was waiting on this issue to resolve it. One of those two should remain open.

It is not a great user experience to have to empty out the time/date every time I want to write content. This is buried in vertical tabs, and can be easy to miss depending on the theme. If I write content, and it takes me 20 minutes to write it, I should not have my creation date 20 minutes ago and the updated date the present time. Both created and changed should be equal on submit when the entity is new.

@kevin.dutra's comment 🐛 Node created timestamp and updated timestamp are different for new nodes Needs work mentions

That's the thing, this issue does not occur when creating an entity without the form. It only occurs when using the form because the entity is not created and saved within the same request. (It's created in one request when the form is generated and saved in another when the form is submitted.)

So it is related to the form in-so-much as the form requires multiple requests carrying an unsaved entity.

I think opening up the other issue as Active is appropriate now because it is more related to entity isNew and saving.

🇺🇸United States mradcliffe USA

Adding issue credits. Next monthly meeting is 📌 Mentort Meeting - 9 April 2025 Active .

🇺🇸United States mradcliffe USA

I am creating a bunch of "stub" pages with copy from past events that need to be documented because I had to go digging for hard copies from several DrupalCons and large Drupal events.

🇺🇸United States mradcliffe USA

By using this website, you warrant on behalf of yourself, your users, and other parties you represent that you will not:

Modify, copy, prepare derivative works of, decompile, or reverse engineer any materials and software contained on this website;

I am going to assume that merging DevPanel related functionality will not make DrupalPod a derivative work of DevPanel.

🇺🇸United States mradcliffe USA

I was thinking this over, and I thought "why fight it?" Maybe aggregator items should provide a Manage Fields and Manage Form Display route even if they are not used by default. It might make it easier to extend aggregator functionality dealing with description property in case someone wanted to store other metadata from a feed.

Adding a warning message to Manage Fields and Manage Form Display to indicate advanced / non-default usage would be important to not confuse default users.

Optionally, an additional setting could be added to show/hide the pages would help. Since altering the routes would still be fighting Layout Builder, maybe just hide the local tasks.

🇺🇸United States mradcliffe USA

It might also be helpful to add the "role" attribute as button since these are also essentially buttons.

This should probably be a merge request now so changing to Needs work.

I added Screen Reader Accessibility Active as a related issue.

Production build 0.71.5 2024