🇺🇸United States @mradcliffe

I created the child issues.

Once you know a little bit more about Git and GitLab, go into 📌 Adds p5js display code, formatter and js controller Active , and create an issue fork.

mradcliffe → created an issue.

mradcliffe → created an issue.

mradcliffe → created an issue.

Don't worry about it. We all start somewhere.

Yes, the first step would be to ensure you can connect to Drupal Slack: https://drupal.org/slack

For getting started with GitLab and Git in general, I would look at the Create a merge request for an issue → task in the Community Contributor's Guide. The "Using Git" link on that page also has a bunch of reference information for using Git and GitLab.

Specifically

- Using Git to contribute to drupal →
- Using GitLab to contribute to drupal →

That should lead you to setting up your user account and profile no drupal.org.,

There are also some videos about contribution if you prefer video format provided by the Drupal mentoring - https://www.youtube.com/playlist?list=PLNBrKoO2qYDXKqX_J1gLBrILRTwRzooDr, It is a bit out-of-date though.

Okay, thank you for telling me more about the p5js progress and being unfamiliar with tests. That is okay.

I think that given your progress so far, we can come up with a plan to get things integrated into this project and so you can maintain it.

1. I will create a 2.0.x branch that has some basic files updated so that GitLab CI can run
2. I will create a p5js branch that will contain all of your progress so far, and ensure that you have Developer access on GitLab to push to that branch. This way we can do things like `git checkout ` to pull in files.
3. I will create 3 issues
   1. Issue 1: we/you will get a merge request to merge the "display code and formatter", "js controller" into the main module from p5js branch into 2.0.x branch.
   2. Issue 2: we/you will get a merge request to move/merge the "filter" into the filter sub-module from p5js branch into 2.0.x branch
   3. Issue 3: we/you will get a merge request to move/ the sketches media sub-module from p5js branch into 2.0.x branch
4. We can setup a regular thread in Drupal Slack to talk about things. I don't know if we want to do weekly or what, but if we create the thread in #contribute or #maintainers we can chat publicly and possibly get more review and help. This could also help you get elevated access as a maintainer for security opt-in.

I can help write tests.

What do you think?

Yeah, it's broken upstream in my recent changes.

Why did guzzle have to get so much worse of a library? Sigh.

I literally have to merge this in order to manually test this because composer :|

mradcliffe → created an issue.

I wrote a simple hook_help implementation with only the about section.

Well, that's unfortunate. A backwards-compatible change in the test framework that causes failures in 11, but not 10.

It looks like it will not be possible to make a backwards-compatible release between releases due to Drupal core.

I'm going to ahead and merge in MR 5, but then this issue will be set to fixed and a new branch created.

Thank you for all the effort. Following up with any 11 issues in the next project update bot run in 📌 Automated Drupal 11 compatibility fixes for agreement Needs review .

Thank you for the merge request. I reviewed it last week, but I let it sit to give another review.

Merged.

Blocks reopening 📌 Automated Drupal 11 compatibility fixes for xero Needs review

Postponed on 📌 Updates xeroclient to support guzzlehttp >= 7 Active

mradcliffe → created an issue.

@acbramley, I disagree based on my previous comment about multiple commands being more confusing so solving the problem of bootstrap/non-bootstrap is important now rather than later.

I was not able to fulfill my duties effectively as a coordinator in 2023 due to an unforeseen event in my life, but I am trying to adjust and reinvigorate myself to be effective. I would like to continue, especially to work on getting the changes to the coordinator position ready for review.

I think "Anything supporting a non-booted site." should be in-scope so that we can implement this as part of the existing drupal core CLI. Having an intermediary step where we have dex and drupal and then switch back to drupal later on would seem like a lot of wasted time updating docs, training materials, tests, etc..

If we can have a resolution for both existing sites and new sites, then it would be easier to adopt to using this rather than a new command.

mradcliffe → created an issue.

Sure. I would be happy to help you get your p5.js contributed into this module, and then hand over maintainership.

Do you an idea or plan about how to replace p5.js?

You could create an issue fork to add .gitlab-ci.yml and then start replacing and refactoring until it passes tests. A Nightwatch test might be useful.

p5.js license is more-compatible with Drupal than processing.js's so that may make it easier.

mradcliffe → created an issue.

mradcliffe → created an issue.

Thank you for continuing work on this issue.

I would prefer not to change the README.md file from what it is in this issue.

The tests are still failing due to the is merge request so I am putting this back in Needs work.

Adding some tags.

The /about/strategic-initatives path now redirects to the Drupal core development about page (confusingly). The /about/core/strategic-initiatives path seems like the best path, but that also now redirects to /about/starshot (confusingly).

So I updated the strategic initiatives link to /about/starshot

Oh, wow, thank you so much for the merge request and review. I appreciate it.

I updated the issue summary to contain the resolution

mradcliffe → made their first commit to this issue’s fork.

Committed patch with modifications.

Committed patch with modifications.

I reviewed the added .gitlab-ci.yml and inspected the pipeline run.

The unit tests pass, and I think any phpstan and phpcs issues can be resolved later. Also any opt-in to the next major would help, but that can be added later as well.

mradcliffe → made their first commit to this issue’s fork.

volkswagenchick → credited mradcliffe → .

@mparker17 thanks for asking. I think the best thing is to start an issue fork and apply the patch you re-rolled into the issue fork branch and start a merge request.

Merge requests will soon be the only way to test and accept changes to Drupal core and contributed projects on drupal.org

ChrisDarke → credited mradcliffe → .

mradcliffe → created an issue.

Should the example of "Recruits mentors." be expanded to "Recruits mentors and recommends MCWG membership"?

Thank you for reviewing the charter during DrupalCon, Kristen. I think we can make a merge request into the fork main branch as well by visiting https://git.drupalcode.org/issue/mentoring-3445579/-/merge_requests/new, changing the source branch to 3445579-kristen, changing the Target branch remote to "issue/mentoring-3445579" and branch to "main".

A clear and defined scope for all Mentoring coordination with an effective plan for new members and a documented path

what does this mean?

for all contribution events.

Agreed. I think it should be a complete sentence.

Maybe something like the following..?

"We define a clear and defined scope for coordination of mentoring with an effective plan to join and leave the working group so that the members of the Drupal community understand our process."

The Mentoring Coordinators Working Group applies (?)

Maybe we should clarify "The Mentoring Coordinators Working Group charter applies to its members, the lead coordinators..."?

Responds to inquiries about mentoring to local organizers. (how is this related to initiatives?)

Hmm, maybe the duty is now classified as "Works with the Drupal community"?

#mentoring Slack channel.

I think I did not hash the channel name because it may change in the future. Maybe a change from "the mentoring Slack channel." to "the mentoring Slack channels." or "in real-time communication channels used to organize mentoring activities (e.g. Slack).". I don't think we have any plans to change from Slack though.

I think this should go into 11.x not 11.0.x. Can you re-adjust the merge request, @edutrul?

Agreed. We'll see if we need to do anything else :-)

We should also add the steps to reproduce to the issue summary rather than in the merge request comment, @skyriter.

I embedded the gif in the issue summary as well.

I updated the issue summary to add the proposed resolution that @skyriter mentioned in #12.

I think this pretty good to commit. Everything makes sense based on the changes from daffie's review.

I updated the change record.

I think we can update the issue summary with the proposed resolution now. Maybe moving some of the initial resolution into the problem/motivation?

Adding the needs tests tag to write a failing test in addition to manual testing.

No longer postponed, but I think maybe we should close this as won't fix with upcoming end of life. The fix from drupal 10 can be backported to a patch if anyone needs it for LTS.

I made some changes for grammar consistency changing "-ing" and imperative forms.

I emphasized the main duty bullet points with bold formatting and indented the membership key points.

I expanded the DA and CWG to be defined rather than using acronyms.

mradcliffe → made their first commit to this issue’s fork.

To tag as Novice, we should have clear tasks about what needs to be done on the issue.

There is also https://www.drupal.org/community/contributor-guide/reference-information... → underneath https://www.drupal.org/community/contributor-guide/reference-information... →

We have "create a follow-up issue" as a task, which we could model the steps after for a new task: https://www.drupal.org/community/contributor-guide/task/create-a-follow-... →

Merge conflicts resolved via merge from 1.0.x.

Adds instructions for authorizing git.drupalcode.org based on new contributor experiences at Portland 2024 and help from @shaal and @rfay in Drupal Slack.

Thank you for providing manual testing and screenshots everyone!

It looks like we have merge conflicts so I am changing the status to Needs work, but if those are resolved and the tests pass, then I think this can be switch back to RTBC after that.

Thank you for adding the tests and reviewing the issue @ian.ssu, @sushyl.

Thank you for reviewing the added tests and manually testing, @smustgrave.

I read the issue summary, but it was not clear to me what among the 3 proposed resolutions was the proposed resolution that was RTBC. I changed the status to Needs work only so that we can update the issue summary to clarify the proposed resolution.

The text changes should also be mentioned under User interface changes per Issue summary field - Issue Summary Template → .

I retroactively added the Portland2024 tag to the issue because contributors were working on this issue on 2024.05.08.

Also, when switching from merge requests we can hide the patches to make the issue summary a little easier to parse for final review. I've done that.

It looks there are additional changes that are yet to be made that @xjm requested in #68 so I am changing this back to Needs work.

Okay, I went over this again.

1, @jvest, could you rewrite your comment to clarify the steps you took to verify @kd_ace's work?

2, @ultimike pointed out that the merge request is about 29 commits behind. It still passes, but we should probably update the issue fork.

@capysara → was mentoring @kd_ace on this issue at DrupalCon Portland 2024.

I'm update the tag to Portland2024 to avoid confusion for other contributors.

The banner looks great! I think we can close this issue as fixed now.

It looks like this issue is almost ready to be reviewed and tested by the community. Let's review the issue to ensure that issue summary clearly states the merge request to be committed to 11.x. I added the Novice and Portland2024 tags.

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because there is a clear path forward after updating the issue summary. Because this is a regression from Drupal 7, perhaps we should also add a simple test for description so I added the Needs tests tag.

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because we should be able to update the issue summary with the work done so far and what is remaining to be done and complete any additional work and provide a review of the merge request.

I am removing the Novice tag from this issue because it is not clear for a new contributor how to move the issue forward.

I’m using this documentation as a source: https://www.drupal.org/community/contributor-guide/task/triage-novice-is... →

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because I think we can update the issue summary based on recent work on the issue. I changed the status to Needs review because this could be a Novice task for reviewing a merge request.

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because @smustgrave's comment still applies.

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because I think we can update the issue summary to include the helpful comments by @quietone and update the issue fork to Drupal 11.

core version is needed.

Adds a tip, mainly for video creators and demoers of contribution, to launch DrupalPod without an issue fork branch to latest Drupal development.

Updated project page to drupal.org

Regarding /tools (or /community/contributor-guide/reference-information/quick-info/setting-up-an-environment-to-test-drupal-patches-and-merge-requests), mentors came to a consensus to continue to maintain that page with the existing options so that no-code and low-code testing and development environments are available options for new contributors.

Once the proposed /docs/develop/local-server-setup → is up-to-date or ready, then we return the local ddev instructions on /tools to a description and link. We are still working on how best to organize /tools to recommend the option most-suited for the task a new contributor is attempting.

Updates DrupalPod project URL to new location on drupal.org

mradcliffe → created an issue.

shaal → credited mradcliffe → .

Test passes now on both Drupal 10 and Drupal 11.

I was evaluating the module and noticed the Automated Tests was setup, but no tests were added, so I created a new branch in the issue fork to add a simple test to switchover to Gitlab CI, which needs to be done soon. Hopefully it works.

mradcliffe → made their first commit to this issue’s fork.

mradcliffe → made their first commit to this issue’s fork.

I resolved the test failures in the merge request. I'll let this sit for a week or so.

Did some smoke testing and was able to go through invoices, contacts, accounts.

+++ b/src/FreelinkingManager.php
@@ -119,7 +119,7 @@ class FreelinkingManager extends DefaultPluginManager implements FreelinkingMana
-    foreach ($items as $key => $item) {

+++ b/src/Plugin/Filter/Freelinking.php
@@ -174,7 +174,7 @@ EOF;
-    foreach ($allowed_plugins as $plugin_name => $plugin_info) {

I am always hesitant to use foreach without a key or index defined due to Drupalgeddon so I would prefer to keep these variables.

I'm now using GitLab CI so patch work flow is deprecated. Setting to needs work for that and comment above.

This ended up no longer applying. Sorry I didn't get to this, but I ended up in a different direction while implementing GitLab CI.

Okay, I think the fixture is ready. I added some tests and stub tests.

Changes to Needs work because of failed test.

Okay, had a bit of extra time, so added the fixture from drupal6 into drupal7. Setting to Needs work.

mradcliffe → changed the visibility of the branch 3432198-core-profile-migrate to hidden.