I fixed the merge conflict so the tests pass again.
I went ahead and created a merge request for changing body text_with_summary field to a distinct locations provided text_long field.
@rachel_norfolk mentioned she had some feedback from Vienna 2025 about the short version and made it shorter when she presented on Wednesday.
These changes need to be adapted back into the Themed Slide deck.
Thank you for updating the merge request, @marcoliver.
The tests and test results are running again for 11.x, and BreadcrumbTest is failing so this is still Needs work. I removed the Novice tag for now as that task has been resolved.
I'm not in attendance, but I am available in Slack for a bit.
I think that means we're back to Needs work. I updated the issue summary.
I noticed that the link also includes closed issues.
- Core open Novice issues:
https://www.drupal.org/project/issues/search/drupal?issue_tags=Novice&st... →
- All open Novice issues:
https://www.drupal.org/project/issues/search?issue_tags=Novice&status[]=... →
I confirm that the link is added at the bottom of the list.
Would it be possible to make this similar to a call to action (CTA) button-like link similar to the "Watch the Video" links?
Something like
👋 Are you ready to tackle some open issues?
we curate a filtered list of issues that are ideal for beginners. Issues with the 'novice' tag are a great way to get started with contributing to the Drupal project.
This is similar to the section above issue queues on GitHub. I am not sure where to place that section on the page, but it might be better below the etiquette.
What do other people think?
I am removing the Novice tag from this issue because there is a blocker on backwards-compatibility that does not have a clear task. I updated the issue summary to include @larowlan's comment in #70.
I’m using this documentation as a source: https://www.drupal.org/community/contributor-guide/task/triage-novice-is... →
I re-added the Needs issue summary update as there is a proposed resolution somewhere in the comment chain, but it is not documented making it difficult to review the status of the issue.
I added the Needs issue summary update tag to help identify the remaining tasks and resolution. When the issue summary is updated, please remove the tag.
I added a couple of tags and left a review comment on the merge request 6492 to replace the use of deprecated annotations with the noted PHP attributes in order to get the tests to complete again.
I reviewed the remaining tasks in the issue summary and updated them because there is a kernel and functional test now.
After fixing the merge request, if the next step is unclear, please remove the Novice tag.
I think we need to work with the EOWG because we have shared documentation about contribution events.
One of our thoughts about GitLab pages was to make this a sort of link aggregator to the relevant documentation page.
We may want to hold on any merge requests until the audit is done.
I think this would also be organized as part of the event packet documentation (timeline, room layout, supplies for mentors).
Thank you, @volkswagenchick. I updated the issue summary with your instructions to create a new issue, and I will edit out the proposal in my comment above to avoid clutter when scrolling through this issue.
Would it be appropriate to add a nudge template for addressing generative AI contribution that may not abide by the de facto etiquette for generative AI?
Example issue: 🐛 CalculatedCacheContextInterface doesn't explain what's different about it Active . The comments in reply to #2 could be done via a nudge.
I wrote up the following in a blog post that probably needs work
Formatted
This discussion appears to include generative AI content that may easily be difficult to review or may contain inaccuracies without human intervention.
When using AI in the course of making a contribution to Drupal, we require you to:
- - Disclose that AI was used in crafting the code or content.
- - Carefully review and test the output, to ensure it is relevant, and that it works.
- - Provide human intervention to correct inaccuracies, mistakes, or broken code.
For more information, please refer to AI Generated Content section → on the Issue Procedures and Etiquette page.
This comment is provided as a service (currently being tested) of the Drupal Community Health Team as part of a project to encourage all participants to engage in positive discourse. For more information, please visit https://www.drupal.org/project/drupal_cwg/issues/3129687 →
HTML
<div class="nudge"><p>This discussion appears to include generative AI content that may easily be difficult to review or may contain inaccuracies without human intervention.</p>
<p>When using AI in the course of making a contribution to Drupal, we require you to:</p>
<ul>
<li>- Disclose that AI was used in crafting the code or content.</li>
<li>- Carefully review and test the output, to ensure it is relevant, and that it works.</li>
<li>- Provide human intervention to correct inaccuracies, mistakes, or broken code.</li>
</ul>
<br>
<p>For more information, please refer to <a href="https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquette/issue-etiquette#s-ai-generated-content">AI Generated Content section</a> on the Issue Procedures and Etiquette page.</p>
<p>This comment is provided as a service (currently being tested) of the Drupal Community Health Team as part of a project to encourage all participants to engage in positive discourse. For more information, please visit https://www.drupal.org/project/drupal_cwg/issues/3129687</p>
</div>
Text only
This discussion appears to include generative AI content that may easily be difficult to review or may contain inaccuracies without human intervention.
When using AI in the course of making a contribution to Drupal, we require you to:
- Disclose that AI was used in crafting the code or content.
- Carefully review and test the output, to ensure it is relevant, and that it works.
- Provide human intervention to correct inaccuracies, mistakes, or broken code.
For more information, please refer to the AI Generated Content section on the Issue Procedures and Etiquette page (https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquette/issue-etiquette#s-ai-generated-content).
This comment is provided as a service (currently being tested) of the Drupal Community Health Team as part of a project to encourage all participants to engage in positive discourse. For more information, please visit https://www.drupal.org/project/drupal_cwg/issues/3129687.
I am removing the Novice tag from this issue because this issue is confusing to me as to what needs to be done based on the issue summary.
The issue summary states removal, the 11.x commit message was incorrect, but now the title is updated but the issue summary is not. I think the idea is that we still need to backport this to 10.2.x, but I would not understand that if I was a new contributor.
I did add the Needs issue summary update tag.
I linked each option in the grid to its respective anchor on the page to reduce scrolling.
Re-adds the phpunit instructions that I had previously written but got rid of before publishing a day ago and adds instructions for the updating the port value.
Fixes DrupalForge -> Drupal Forge.
Adds recommendations to table.
Encapsulates the pro tip in the Tip wysiwyg template
Adds a note about workspace sharing being possible.
Renames the phpunit heading level
Adds a note about running tests.
I was not able to successfully setup phpunit.xml to run a kernel or functional test. The database host timed out.
Adds sections for code and non-code contribution.
Updates with correct branch URL instead of repository URL.
Clarifies that that this is the Drupal Forge browser extension rather than mentioning browser extension.
Adds some steps for first-time contributors.
Adds links to Firefox add-on page and Chrome web store page.
Removes the test issue from the work flow.
When the browser is in light mode, the contrast of the warning (yellow) text and background may be too low making it difficult to read. 1.66:1 ratio.
oklch(82% .189 84.429) or in plain hex #fcb700 is the foreground color.
oklch(82% .189 84.429) mixed with 10% white or in plain hex #fff8e6 is the background color.
I went ahead and added Darren and myself to be able to merge so that I could merge.
I did not delete the Source branch to not break any existing browser extension configuration, but we should update to use the source repository now.
Thank you everyone.
Sorry, I typoed the MR I was referencing. 6492, the MR for Drupal 11, is failing tests so this should be Needs work.
Replaces GitPod and DrupalPod links with DrupalPod+DrupalForge links.
The tests are failing on merge request #6493 so this needs to be back to Needs work.
Thank you for helping out, @ankitv18.
I tested a patch from the merge request locally and was able to install the module without schema errors.
I also manually tested changing the values in the configuration form, exporting paragraph_blocks.settings, and confirmed that the values changed from false to true.
Seems RTBC to me.
I think this is a code caching issue with PHP.
Somethings to try based on Issue #3492523, comment #55 🐛 Class "Doctrine\Deprecations\Deprecation" not found Active :
Clear APCu cache by either restarting PHP-FPM or the Web server -or- if you do not have access, update settings['class_loader_auto_detect'] = FALSE; in settings.php, clear Drupal cache, and revert the setting
I agree with #9 about not including the body field at all and changing it to field_description or field_location_description makes sense as proposed in #10.
Thank you for reporting an issue, Robert.
I am not able to reproduce this issue. There are the same number of arguments defined in the agreement.handler service as in the AgreementHandler class.
Did this this occur when updating from 3.0.1 to 3.0.2?
It is possible that Drupal’s composer autoload file has not been reloaded or cache needs to be cleared or flushed after the deployment.
mradcliffe → created an issue. See original summary → .
Applies bold formatting to the first column to emphasize options.
Aside: The collapsible accordion used in the Community section panel content is not available for use in this text format.
Sorry it took me so long to get to this. I ran through with the browser extension to test the deployment scripts and I think the deployment scripts are working fine in DrupalPod. +1.
I tagged and created a release for 3.0.2. Thank you for the reminder.
The only issue with moving the main menu to the top is that there isn't enough contrast for the text color on the Mentoring green header. This was an issue when I initially set the styles (the logo has the same problem).
Updated agenda with meeting URL.
mradcliffe → created an issue.
I created the contributor task based on the issue summary.
https://www.drupal.org/community/contributor-guide/task/facilitate-a-men... →
I am using the new Contribution Record system. I needed to ensure that I was logged into both drupal.org and new.drupal.org before I could access the interface for Credit others.
https://new.drupal.org/contribution-record/11420040
It does not seem to have synced with the issue yet, but setting this to Needs review since this is a new process.
Th exceptions are due to 🐛 ModuleHandler skips all hook implementations when invoked before the module files have been loaded Needs review which makes using hook_entity_type_build unreliable currently.
I think this is still relevant because hack Solution #3 which is in commerce_cart.module seems to be broken for me in Commerce 3.0.2 (3.1.0 not tried).
The Entity Type definition is being cached without the add_to_cart form handler and this causes EntityTypeManager via ProductLazyBuilders to throw an exception. Flushing the cache completely will resolve the issue temporarily, but it seems there are times when the Entity Type definition cache is built without calling hook_entity_type_build or a race condition might be causing it not to get called in time? The site is not using any memory cache, only database cache.
Stack trace:
Drupal\Component\Plugin\Exception\InvalidPluginDefinitionException: The "commerce_order_item" entity type did not specify a "add_to_cart" form class. in Drupal\Core\Entity\EntityTypeManager->getFormObject() (line 212 of core/lib/Drupal/Core/Entity/EntityTypeManager.php).
Drupal\commerce_product\ProductLazyBuilders->addToCartForm()
So an improved Order Item Type resolver would be better.
There are some phpcs issues to fix, but I think otherwise this seems good. Thank you.
Merged. Thank you.
Merged.
Thank you for finding the root cause. This looks good to me. I added a test to go through non-list properties that start with "xero" and assert the definition interface.
@guardadostoic there are no details in the issue summary yet.
I removed the Novice issue tag because there are no suitable tasks for new contributors → on this issue yet.
I am using the traging Novice issues and tasks → documentation as a source.
mradcliffe → created an issue.
Thank you for reporting the issue and supplying a patch. I created a merge request to run through tests.
I think the change is simple enough to merge now.
mradcliffe → created an issue.
mradcliffe → made their first commit to this issue’s fork.
Thank you for providing the merge request. This makes sense to me.
I think the incoming array may be due to some data type / definition inconsistency. Do you know what the data type and property name that caused the issue?
mradcliffe → made their first commit to this issue’s fork.
Thanks for providing the post-update! That looks good. I tested it manually.
I went ahead and resolved some of the code standard issues in the merge request so that I could merge this.
I found a couple of changes and commented in the merge request.
Updated issue link.
mradcliffe → created an issue. See original summary → .
Thank you everyone for participating last month! I believe I have everyone after reviewing the threads and issue.
Added relevant starter packs that I mentioned in a post.
getPropertyDefinition comes from \Drupal\Core\TypedData\ComplexDataDefinitionInterface and \Drupal\Core\TypedData\ComplexDataDefinitionBase which implements that method.
As far as I remember, all xero data type plugins should use a complex data definition, but I think that Drupal's Typed Data Manager will technically let a data type be instantiated with a different definition. My guess is that something happened during denormalization that caused the data type to be instantiated incorrectly.
Also adding a https://www.drupal.org/community/contributor-guide/find-a-task → about how to audit documentation would be nice after this. :-)
You may want to merge in origin/3.1.x after fetching from origin to allow the pipeline to run completely without having to create a new pipeline manually in the merge request.
Setting to Needs work for test failures.
Ah, yes. This makes sense based on Xero changes. Thank you.
I don't think there are any other changes necessary. Merging.
mradcliffe → made their first commit to this issue’s fork.