🇺🇸United States @mradcliffe

I updated the issue summary to include how to resolve and removed the tag. I left the Novice tag because I think we have some consensus on the issue.

I don't think we need a new permission, "access site reports" permission fits because the report is already accessible by users who have access to dblog (or syslog, jsonlog) as MigrateController is a redirect.

If we added a new permission, then a non-admin user would need both that permission and "access site reports" to access a filtered list of migrate_drupal_ui.

I came up with a rough outline for the change record after reviewing the changes.

• Adds a new nullable argument to the base Connection __construct method that takes an IdentifierHandler.
• Database drivers should implement IdentifierHandler (details) and pass this into Connection::parent::__construct().
  • Implement at least getMaxLength if extending IdentifierHandlerBase.
• Method calls and properties that need to be changed:
  • getPrefix() should use identifiers->tablePrefix
  • $identifierQuotes should use identifiers->identifierQuotes
  • $prefix should use identiferies->tablePrefix
  • $escapedTables is no longer used
  • $tablePlaceholderReplacements should use ????
  • escapeDatabase() should use identifiers->database()
  • Any time need to use a table or prefix in code this should be identifiers->table
  • escapeTable() should be identifiers->table. escapeTable() is no longer needed when using connection->query()? A database drive may need to use schema()->quotedMachineName . $tableIdentifier->quotedMachineName?

It looks like this also applies to any usages of query that use escapeTable manually in addition to database driver modules.

Finally a question. If a site provided a prefix and used a non-core database driver would that site stop working because $prefix isn't set anywhere by that database driver (if it relied on the protected property)?

Yes, but why do we even need it to have the special migrate access check?

If the point is to reduce the tests that depend on this special case, then maybe fixing migrate_drupal_ui.log route to use that permission instead would make sense because an administrative user with "access site reports" already has access to it?

I think we should answer the question as to why this test needs super user access when the test is not asserting anything about migrations and why the reports needs the special migrate access check prior to reverting the commit.

Switching to Needs work for phpunit and code quality failures.

In my implementation, I am using status = 1, uid > 0, and access comparisons so I can get a quick query.

For activitypub module, I think that joining to the actor table by uid makes sense. I don't think it should include the non-person actors in "users".

Aside, the Drupal activitypub module listing is probably going to disappear again. aleixq's changes got removed in https://github.com/fedidb/communityDB/commit/ce23a1bd1956f0c2788d4755869...

Thank you for running through what I had, rachel. Changing status to Needs work based on feedback.

It seems to be working for me. I can search for you via acct:CWSmith@hybridized-concepts.com now on various fediverse applications including my own.

Maybe try removing the location ~ /.well-known/webfinger { block entirely?

It's what swentel mentioned. The server, nginx, is not allowing webfinger requests from .well-known/webfinger which is configured as a location served by nginx, not drupal.

Also note that the site is detected already by FediDB, but probably not discoverable by actors without knowing the real actor id.

There's some new phpcs issues introduced, but otherwise I think the changes make sense. I added needs tests based on #10.

jdleonard → credited mradcliffe → .

Success!

These files were created as artifacts that can be downloaded via from the GitLab pipeline artifacts download link. The latest artifacts shouldn't have an expiration as far as I know from reading the gitlab documentation, but I think the merge request ones will expire after the 1 week that I set in the job.

mradcliffe → changed the visibility of the branch 3521850-autumate-calendar to hidden.

Ah, we got rid of the main branch already. good.

I need to create an initial commit again and rebase the work I just committed without the charter commits.

Would it be helpful to split this issue to tackle each of email, address and telephone separately? That way we can reduce the size of the merge request for reviewers and testers. It could mean an eventual merge conflict for update hooks.

We should avoid using a header at the top of the description to help with Project Browser initiative ( 📌 [Meta] Create a short description for a contrib module Active ). I would avoid using the Summary field because text_with_summary is proposed to be deprecated from core.

Architecture section may be better suited to a CONTRIBUTING.md or DEVELOPERS.md file or gitlab pages.

Create a short description (200 characters or less) that will be easily understood by the Project Browser target audience of site builders and those new to Drupal. The short description should answer the question - "what does this module do in a non-technical way".

MAINTAINERS: the short description should be added to the Summary field of the Description on the project page. The short description will be displayed on the cards in the Project Browser grid and list views.

Failed functional tests were

- BlockHiddenRegionTest
- InstallerThemesBlocksProfileTest

Yes, I haven't designed it to be multi-tenant since I am usually working with only one store. It makes sense as a feature.

Would need to add tenant to the resolver to resolve which strategy to use.

Yeah, Xero API module would need an update first without bypassing it.

Expanded the scope of the issue to all the things.

Small thing, but can we change the date format from mm-dd-yyyy to yyyy-mm-dd in the calculated date cells in Vienna 2025 tab?

Having a tab that's "empty" to act as a starting point "start here" might be helpful for contribution-focused Drupal camps. Then we could have people copy the spreadsheet (like how we copy the 1st time contributor workshop slides) for their event.

I think this page should continue to focus on getting the environment ready.

There are several other tasks → related to merge requests (and patches) that also link to the relevant reference information and documentation for git, merge requests, patches, composer, core and/or contrib

• Create a merge request for an issue →
• Review a patch or merge request for an issue →
• Verify an old patch or merge request →

Maybe instead of documenting here as well, we can add a what next or next steps section to link to these tasks.

DrupalPod is still relevant at the moment as well as efforts to use DrupalForge within DrupalPod and long term efforts to adapt DrupalPod. This is an active task that mentors are discussing and working on.

Also realized there's probably some thorough instructions here (core-related) that can be extrapolated to contrib. Either a subtree split or git-filter-repo is suggested: https://www.drupal.org/about/core/policies/core-change-policies/how-to-d... →

My current process:

I find it easiest for myself to create the new issue when I go to credit participation and close the previous month's meeting issue,

1. Review Slack for participation in the roll call and other threads:
   1. Confirm the Credit & committing > By list and check the boxes
   2. For each person, confirm their drupal.org username if it was not provided by them, and type it in Credit & committing > Credit others, then type a comma
   3. Review the list to make sure I got everybody and did not use an old username from my memory rather than a current username.
2. Change the Status to fixed and add a comment closing the issue with credits
3. Follow the "clone issue" link (this might be dreditor)
4. Update the title for the correct day, month and year of the next meeting.
5. Update the dates in the issue summary
6. Remove the URL to the previous month's meeting with a placeholder
7. Remove any expired agenda items such as previous DrupalCon planning threads, previous event threads.
8. Renumber thread emoji as needed
9. Save
10. Update placeholder from the step above with the new URL and save the issue again

I think this should be done anywhere from 1 week after the previous meeting to account for continual discussion and 1 week prior to the next meeting to provide time for editing the agenda by any mentor.

If I am running the meeting, then just before 20:00 UTC I do the following:

1. Set the issue in my browser to Edit mode
2. Ensure I am on Drupal Slack in the mentoring team coordination channel
3. I copy the initial chunk of text until the first empty line and paste it into Slack
4. I immediately paste the :zero: agenda item into Slack and start a thread introducing myself.
5. I try to continually copy a group of agenda items, separately, so each can be its own thread in fairly rapid succession so that I can participate in the discussion too. I try to start each group of agenda items or the next agenda item after about 2-3 minutes so that there is time to bounce between threads for active discussion.
6. Near the 45 minute mark or later, I paste the "That's it for now" message

If you want to keep git histories, we can use a tool like git-filter-repo to do this. It will have an extra commit to move files.

I think that these instructions could be worked on at MidCamp as long as you create the new projects exist by then.

1. Clone a fresh copy of event_platform.
2. Create and clone clone {submodule} issue fork and checkout the issue fork branch.
3. Change directory into event_platform.
4. Run git-filter-repo --path {submodule} --to-subdirectory-filter {submodule}
5. Change directory into {submodule}.
6. Run git remote add -f event_platform ../event_platform
7. Run git merge --allow-unrelated-histories event_platform/2.0.x
8. Remove any tags git tag | xargs git tag -d
9. Run git mv {submodule}/{submodule}/* .
10. Remove the {submodule} directory.
11. Commit
12. Add default files if they do not exist yet (e.g. .gitignore, gitlab-ci.yml, composer.json, README.md)
13. Commit
14. Cleanup namespaces, dependencies and any other files.
15. Commit
16. Push
17. Create a merge request from the issue fork branch

This will essentially give the history (for event_platform_scheduler):

* fdd4530 (HEAD) Moves files into place (6 seconds ago) <Matthew Radcliffe>
*   feca34c (2.0.x) Merge branch '3366560-create-events-as' into 2.0.x (6 weeks ago) <Martin Anderson-Clutz>
|\  
| * ff45c57  Code changes and first pass on content architecture changes (6 weeks ago) <Martin Anderson-Clutz>
* | 1582ea9  Issue #3366560 by mandclu: Create Events as entities to allow for multiple years (6 weeks ago) <Martin Anderson-Clutz>
|/  
* c16a289  (1.1.x, 1.0.x) Issue #3451068 by Project Update Bot, mandclu: Automated Drupal 11 compatibility fixes for event_platform (11 months ago) <Martin Anderson-Clutz>
* 03c23b2  Fix for stuck scheduler spots (1 year, 10 months ago) <Martin Anderson-Clutz>
* 21cf0e1  Issue #3372171 by mandclu: Add a session moderator role (1 year, 10 months ago) <Martin Anderson-Clutz>
* 88e9ca0  Issue #3372042 by mandclu: Make Scheduler table full width (1 year, 10 months ago) <Martin Anderson-Clutz>
* 38d9263  Issue #3372038 by mandclu: Remove console.log call in scheduler.js (1 year, 10 months ago) <Martin Anderson-Clutz>
* e5cfd77  Issue #3372036 by mandclu: Notice: Only variables should be passed by reference in Scheduler->buildRows() (1 year, 10 months ago) <Martin Anderson-Clutz>
* 80a270a  Issue #3357829 by apaderno, mandclu: Fix the issues reported by phpcs (1 year, 10 months ago) <Martin Anderson-Clutz>
* 7518861  Issue #3371933 by mandclu: In Scheduler highlight scheduled sessions matching filters (1 year, 10 months ago) <Martin Anderson-Clutz>
* 81d46b3  Issue #3371942 by mandclu: Update empty messaging in scheduler interface (1 year, 10 months ago) <Martin Anderson-Clutz>
* 7d123fe  Issue #3371940 by mandclu: Error: Call to a member function get() on null (1 year, 10 months ago) <Martin Anderson-Clutz>
* dda89ff  Issue #3371930 by mandclu: Drupal\Core\Entity\Query\QueryException: Entity queries must explicitly set whether the query should be access checked or not (1 year, 10 months ago) <Martin Anderson-Clutz>
* 5d19f54  Issue #3371896 by mandclu: Fix code standards issues (1 year, 10 months ago) <Martin Anderson-Clutz>
* 02f8787  Issue #3371708 by mandclu: Provide session filters in scheduler view (1 year, 10 months ago) <Martin Anderson-Clutz>
* c480527  Issue #3366558 by mandclu: Scheduler Validation: Don't allow more than one session by the same presenter in the same time slot (1 year, 10 months ago) <Martin Anderson-Clutz>
* a973ebf  Issue #3366556 by mandclu: Allow sessions to be filtered by workflow status in the Scheduler (1 year, 10 months ago) <Martin Anderson-Clutz>
* 82f3047  Issue #3360405 by mandclu: Use Smart Date's updated format service method (2 years ago) <Martin Anderson-Clutz>
* 51756b1  Issue #3360403 by mandclu: Round the corners in sessions in the Gin Admin Theme (2 years ago) <Martin Anderson-Clutz>
* e2dfa5d  Issue #3360401 by mandclu: Provide a tool to generate time slots (2 years ago) <Martin Anderson-Clutz>
* d6c19ac  Issue #3355872 by mandclu: Provide a scheduler interface to quickly assign time slots and rooms (2 years ago) <Martin Anderson-Clutz>

I went ahead with a merge request that changes both to text areas.

mradcliffe → changed the visibility of the branch 3521988-longer-description to active.

mradcliffe → changed the visibility of the branch 3521988-longer-description to hidden.

mradcliffe → created an issue.

mradcliffe → created an issue.

mradcliffe → created an issue.

I updated the issue summary with links from #14 and added the links to recent issues in the examples item list.

cmlara, thank you. That jarred my memory. I was trying to find where it came from.

Closing.

In the new first-time contributor workshop slides that volkswagenchick developed we have a single slide titled "Use of AI" with the following scripted notes. This could be a good start for an official policy.

There is no doubt that artificial intelligence tools such as ChatGPT can be powerful ways to jumpstart code or content. However, AI systems still have significant flaws. Often times the code they produce is non-functional, and the content they create includes assertions or citations that are untrue.

When using AI in the course of making a contribution to Drupal, we require you to:

Disclose that AI was used in crafting the code or content.
Carefully review and test the output, to ensure it is relevant, and that it works.
Provide human intervention to correct inaccuracies, mistakes, or broken code.
Bulk use of AI when it is not relevant to an issue, provides broken or unusable code, or provides false information will likely result in a ban.

I am not sure why we mention it as required, but it probably should be changed to recommended for now pending policies.

mradcliffe → created an issue.

Thank you for creating the merge request, lostcarpark.

jdleonard → credited mradcliffe → .

The job will probably fail for both phpcs and phpstan due to rules like "Drupal calls should be avoided in classes, use dependency injection instead" and I think you can work on those later to get green :-)

mradcliffe → created an issue.

I applied the patch manually to my non-activitypub module, non-multilingual site that uses webfinger, and I did not find any regressions. +1.

Renamed issue to reduce scope for new process. I forgot to link the role page in the issue summary.

Posted for review.

mradcliffe → created an issue.

I stumbled on this and the other issue today working on a recipe.

I updated the steps to reproduce to use an already existing core recipe as an example (core_recommended_admin_theme).

I think that we should do the hook_themes_installed() approach and add a @todo comment linking to 📌 Copy block configuration from admin theme when enabling an admin theme Active so that we're not blocked (pun intended).

+1 on this. I always forget I have access to create contributor roles at https://www.drupal.org/node/add/contributor-role → (since it's not linked anywhere that I can find), but I don't know which permissions grant that.

We probably want to list roles or specify specific roles in the issue summary to create. Looking at some similar roles in working groups:

- Confilct resolution team member → is a role inside the Community Working Group though it may not be clear that it is part of that group.
- Community health team member → is a role inside the Community Working Group though it may not be clear that it is part of that group.
- Licensing working group member → is a bit clearer for the LWG.
- Coding standards committee member → is part of the TWG. That page links to the charter, which is nice.

chrisdarke → credited mradcliffe → .

mradcliffe → created an issue.

James confirmed again.

The Mentoring team is interested. We currently use https://drupalcontribution.org (OpenSocial) as a stop-gap solution, but that was originally made for helping to organize and organize virtual contribution events.

A new branch needs to be created, potentially 3.0.x before I can create a merge request for this.

mradcliffe → made their first commit to this issue’s fork.

Removes Needs tests tag after I wrote a test. Removes Documentation tag because this is not a documentation issue.

We can add a test recipe in core/tests/fixtures/recipes and Drupal\KernelTests\Core\Recipe\InputTest would be a good place to either add a new kernel test?

Added the Needs tests issue tag. I think the recipe.yml above could be used. We don't need to install anything. We only need to confirm the recipe is applied message is displayed to the user.

    // Most of the input-collecting methods of StyleInterface have a `default`
    // parameter.
    $arguments += [
      'default' => $default_value,
    ];

But not all of them do so adding default here causes the error for askHidden.

mradcliffe → created an issue.

The test is failing with an access denied error accessing /admin/reports/upgrade.

Honestly, I am not sure why that report uses the MigrateAccessCheck rather than a permission as the controller does not run migrations, it redirects to watchdog with the query parameter "type" set to "migrate_drupal_ui". The only permission that is needed is "access site reports", which is not restricted to user 1.

Maybe fixing migrate_drupal_ui.log route to use that permission instead would make sense because an administrative user with "access site reports" already has access to it?

Do we need to add a @todo with the issue url for the coder issue above the ignore?

I removed the Needs followup tag since @dcam created the issue.

Thanks for making the change @koustav_mondal. The MigrateControllerTest is now failing. Running that test in isolation to debug it would be the next step here to resolving.

As part of the meta issue, 📌 [Meta] Fix all tests that rely on UID1's super user behavior Active , we need to “Assign the right permissions to make the test go green without the super user access policy.”

Updated MWG item.

I think this is fixed now. Pipeline is passing.

I resolved the CS nits. I removed the use of t completely because other tests do not use it such as MapBaseFieldTest and FieldItemTest. Also I switched to using FieldType attribute.

mradcliffe → made their first commit to this issue’s fork.

Thanks for recording the discussion, @rfay!

Oh, nice catch. Thank you for the merge request.

mradcliffe → made their first commit to this issue’s fork.

Added more agenda items.

mradcliffe → created an issue.

Based on some discussion at DrupalCon Atlanta, we need to merge the changes that have already decided upon.

I am going to create a new Update Mentoring Coordinators section in MAINTAINERS.txt in the Mentoring project for the Mentoring Working Group (MWG) to elicit feedback and evaluation from Mentoring Coordinators. And then once that is ready, we can move into the Core issue queue and create a merge request.

I added AmyJune, Tara, and Mauricio to the Past core maintainers page because they have already stepped down their role.

Confirm Mentoring coordinator MAINTAINERS.txt 📌 Confirm and update mentoring coordinators section in MAINTAINERS.txt Active issue. Adding past and no longer active mentoring coordinators.

mradcliffe → created an issue.

Adding credits from the 19 March 2025 meeting.

This might be a good candidate for Member Platform if we can switch to using that rather than OpenSocial.

@rachel_norfolk might have access to get this setup on the OpenSocial site.

I am marking this as Needs work because we still need to add explicit test coverage based on the issue summary and we probably want to make the messenger string a translatable markup string with a placeholder.

It looks like the issue summary has been updated. When updating the issue summary, we want to remember to remove the tag as well.

It would be nice to get another person to do a code review.

I am a little confused. The @todo comment mentions to remove the usage of the super user, but it looks like this is still being used in the test. Does the variable also need to be removed?

For those working on this issue, can you explain why this wasn't removed too?

I talked with Jason and postponing the issue seems like a good idea after updating the issue summary about why this is postponed / should be closed eventually.

Thank you everyone for reviewing the code. I was talking with Gábor who knows a bit more about multilingual and translatable strings. He pointed out that the paragraph tag is allowed in translatable strings. He went to locale.drupal.org to search for use of <p in translatable strings.

So this may not be as straight-forward as we thought.

I am going to add the Needs issue summary update and Needs steps to reproduce tags and set this to Needs work as there is something else that is causing the error.

The test runner seems to have failed on a bunch of kernel tests, but it was not clear if it is related to the changes.

Potentially a redirect from "documentation/is-drupal-secure" the Frequently Asked Questions page → .

I added the Needs issue summary update because it would be nice to have a clear problem/motivation and proposed resolution section on the issue.

It would be helpful to list the pages that are being worked on in the issue summary or in a comment as you are working on them so we can track what pages have been worked on.

Adding a tag.

mradcliffe → created an issue.

I added the Atlanta2025 issue tag for searchability.

Would a good criteria for assessing need be to review the Roadmap: #3446089: [Meta] Recipes Phase 2 Roadmap → ?

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because I think the requested changes from @quietone and confirmed by @joachim are clear. As well, we can confirm the uses again and update the issue summary to clarify how we found the changes.

I am removing the Novice tag from this issue because it was hard to me to determine the novice task on the issue.

I’m using this documentation as a source: https://www.drupal.org/community/contributor-guide/task/triage-novice-is... →

I performed Novice Triage on this issue. I am leaving the Novice tag on this issue because there is a clearly defined task for resolution. The issue summary could use an update as well.

There were some test failures in the merge request, but I think those are false positives.