- ๐ฌ๐ทGreece christiana.k Athens, Greece
To use this patch must we also apply the patch in https://www.drupal.org/project/webform_mailchimp/issues/2896695#comment-... โ ?
I'm asking because I've installed this patch and now my webform no longer creates contacts to mailchimp.
I have a webform with two Mailchimp options fields: one select dropdown with language selection, one checkboxes list with categories selection.
On the mailchimp handler I have left out the interest groups unselected.
Am I doing something wrong? - ๐ฎ๐ณIndia govind.maloo
govind.maloo โ made their first commit to this issueโs fork.
- ๐ง๐ชBelgium seutje Antwerp
It appears the changes in the path in #15 are incorporated in the latest release, even though the release doesn't mention this issue and the status wasn't changed...
- First commit to issue fork.
- Merge request !11Issue #3036323: Provide user selectable interest groups as Webform predefined options โ (Open) created by Unnamed author
I have rerolled the patch from #15 and created a merge request. This applies to `8.x-5.x-dev`. I have not yet included the changes from #21 but will add those in by the end of week as well.
Thanks @mradcliffe, I should be able to address those this week as well. I also was not able to finish including all the changes from #21 yet but will have that completed by midweek before fixing the other code quality issues.
I pushed changes to merge request !11 that address all the changes from #21, except for the last bit of from darvanen's 8th note in that comment:
Also, why add
tags to this message in particular? Why is it a special case?
- ๐บ๐ธUnited States mradcliffe USA
I added some comments in the merge request. Mainly the last commit truncated the module file so it no longer is syntactically valid i.e. it errors out.
Edit: keeping the status at Needs work. Remember also to flip the status to Needs review if you think the merge request is ready for review again.
phpstan and phpcs errors are resolved on Merge Request !11.