- Issue created by @mondrake
- Merge request !5738Resolve #3406985 "Convert all transactions to explicit commit" → (Open) created by mondrake
- 🇮🇹Italy mondrake 🇮🇹
mondrake → changed the visibility of the branch 3406985-pp-1-convert-all to hidden.
- 🇮🇹Italy mondrake 🇮🇹
mondrake → changed the visibility of the branch 3406985-pp-1-convert-all to active.
- 🇮🇹Italy mondrake 🇮🇹
mondrake → changed the visibility of the branch 3406985-pp-1-convert-all to hidden.
- 🇮🇹Italy mondrake 🇮🇹
mondrake → changed the visibility of the branch 3406985-pp-1-convert-all to active.
- 🇮🇹Italy mondrake 🇮🇹
mondrake → changed the visibility of the branch 3406985-pp-1-convert-all to hidden.
- 🇮🇹Italy mondrake 🇮🇹
mondrake → changed the visibility of the branch 3406985-pp-1-convert-all to active.
- 🇺🇸United States nicxvan
It would be helpful to have a small summary on the why in the issue summary
- 🇮🇹Italy mondrake 🇮🇹
Some point were raised in Slack https://drupal.slack.com/archives/C1BMUQ9U6/p1747310837078309
- 🇮🇹Italy mondrake 🇮🇹
Added specific deprecation tests for the implicit commit behavior and for ::commitAll() when there are pending transactions open.
- 🇺🇸United States smustgrave
Feedback appears to be addressed but CR is still tbd
- 🇮🇹Italy mondrake 🇮🇹
Per https://drupal.slack.com/archives/C1BMUQ9U6/p1747310372256759?thread_ts=..., the MR could use some manual testing to check that with xdebug 3.3+ enabled we do not get any longer failures related to the unpredictable object destruction sequence.
- 🇺🇸United States mradcliffe USA
Current test failures are deprecations for
1) /builds/issue/drupal-3406985/core/lib/Drupal/Core/Test/HttpClientMiddleware/TestHttpClientMiddleware.php:52
Database commit by letting a Transaction object go out of scope is deprecated in drupal:11.3.0 and is removed from drupal:13.0.0. Commit explicitly via Transaction::commitOrRelease() instead. See https://www.drupal.org/node/3524461 →1) /builds/issue/drupal-3406985/core/lib/Drupal/Core/Database/Transaction/TransactionManagerBase.php:364
Database commit by letting a Transaction object go out of scope is deprecated in drupal:11.3.0 and is removed from drupal:13.0.0. Commit explicitly via Transaction::commitOrRelease() instead. See https://www.drupal.org/node/3524461 →Uploaded as a text file after parsing through Functional and FunctionalJavaScript test results. Summarized as
- locale
- config_translation
- AssetOptimizationUmamiTest
- help
- demo_umami
- core Installer tests - 🇮🇹Italy mondrake 🇮🇹
Some recent commits may have added deprecated behaviour. Needs sorting out which. On that.
- 🇮🇹Italy mondrake 🇮🇹
Culprit was 📌 Use a transaction PoDatabaseWriter to improve performance Active . But that helped proving that implicit commit deprecation works.
- 🇺🇸United States mradcliffe USA
I added some manual testing scenarios for xdebug 3.3+ in develop mode.