Nice!
hooroomoo → made their first commit to this issue’s fork.
hooroomoo → changed the visibility of the branch 3541027-create-new-templates to hidden.
I approved but I think it's worth checking that the new tests are stable with the new 1.x changes that have gone in. But leaving it up to @jessebaker if he wants this in before the big rename
Playwrights been flaky, but the newly added componentOperations.spec.ts failed on the latest CI run
hooroomoo → made their first commit to this issue’s fork.
hooroomoo → created an issue.
hooroomoo → made their first commit to this issue’s fork.
tim.plunkett → credited hooroomoo → .
Mentioned this on a call but just want to record here, can the view mode response can also provide a key with the first available node entity that the frontend can use to display the template with? And if a content of that bundle doesn't exist yet then it can be null or something and the frontend can handle accordingly to maybe show an warning message in the UI to require a user to create content for it if they want to view the template for that bundle in XB.
Moving the Allow linking a component prop of a template to a dynamic field to be higher in the FE list for visibility and higher priority because this could be big one due to it also has to make sure that the component props form can be correctly generated after a dynamic field is set to a prop.
https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
hooroomoo → changed the visibility of the branch 3538576-two-add-components-to-layout to active.
hooroomoo → changed the visibility of the branch 3538576-two-add-components-to-layout to hidden.
wim leers → credited hooroomoo → .
I am not sure what the difference between the backend items in the map: HTTP endpoint: dynamic props sources and Handle dynamic props is...
I wonder if its the same thing but we just didn't realize when we created this map together. I see only 4 backend tickets got created instead of 5 so maybe it is a duplicate? But I'm not certain.
hooroomoo → created an issue.
hooroomoo → created an issue.
hooroomoo → created an issue. See original summary → .
hooroomoo → created an issue.
hooroomoo → created an issue.
hooroomoo → created an issue.
hooroomoo → created an issue.
hooroomoo → created an issue.
transferring credits from ✨ Content templates, the boss battle: create a UI for editing templates Active
My preference would be the first way (not flat). And yes the frontend can construct the 'layout_url' => '/xb/api/v0/layout-template/node/page/full/ given the response.
$view_modes = [
'node' => [
'page' => [
'full' => [
// Whether template has auto-save changes. This can be tru even if
// existing_template is false since we auto-save templates before
// first publishing without creating a new saved template.
'auto-save-changes' => TRUE,
// Where the there is an existing template saved.
'existing_template' => TRUE,
// The ID does require an exisitng template because it is based on
// entity props that can't be changed.
'template_id' => 'node.page.full',
]
'teaser' => [
'auto-save-changes' => FALSE,
'existing_template' => FALSE,
'template_id' => 'node.teaser.full',
]
]
'article' => [
'full' => [
'auto-save-changes' => FALSE,
'existing_template' => TRUE,
'template_id' => 'node.article.page',
]
'teaser' => [
'auto-save-changes' => TRUE,
'existing_template' => TRUE,
'template_id' => 'node.article.teaser',
]
]
],
];hooroomoo → created an issue.
I believe https://www.npmjs.com/package/@drupal/xb-cli should get a new tag now
Current state of MR (things are hardcoded and the UI is missing some things still e.g. showing the layers menu in the left sidebar when editing a content template ):
Front can make GET request to xb/api/v0/layout-template/node/article/full/1 and then receives the HTML to render the template. Here I added two components to the template.
Next publish the template (POST) to xb/api/v0/layout-template/node/article/full/1. PATCH also works to edit a prop. But still need to add the ability to set a component prop as a field which I'll add tomorrow to prove it works. @tedbow provided a hardcoded list of dynamic suggestions in the backend.
Can see that the content template is now being used for all articles.
Next step on the frontend side:
1. Add the ability to set a component prop as a field in the UI
@wim leers Sorry about that! I understand it was not clear and is confusing. I'm just going to close this issue and continue work on ✨ Content templates, the boss battle: create a UI for editing templates Active .
I pushed all the changes from here to 3518248-layout-controller
hooroomoo → made their first commit to this issue’s fork.
Also would be great to have this by the content templates work so the url for editing a content template can be independent of the entity type and entity in the route
balintbrews → credited hooroomoo → .
hooroomoo → created an issue.
balintbrews → credited hooroomoo → .
hooroomoo → changed the visibility of the branch xb-1346 to hidden.
hooroomoo → changed the visibility of the branch 3538602-code-editor-can to hidden.
hooroomoo → created an issue.
hooroomoo → changed the visibility of the branch 3508317-browsers-undo-state to hidden.
Merged but assigning back to @bnjmnm to add screenshots/gif
Opened 2 follow-ups.
1.
✨
[PP-1] Navigate to page/component that's causing a publish error within the same tab
Active
2.
🐛
source.pointer value from publish error response is inconsistent sometimes
Active
for
#8
📌
Link Publish errors to the page + component instance that's causing the error
Active
hooroomoo → created an issue.
This will unblock ✨ [PP-1] Navigate to page/component that's causing a publish error within the same tab Active