Yeah it still exists. I don't think it's a big problem though
hooroomoo → made their first commit to this issue’s fork.
YAY! Thanks!
Hm I'm not sure how you got the error for giving an existing name of a standard/dynamic component to a jS component, because the machine name/ID for a JS component gets appended with a "js" so if you named a JS component Breadcrumbs, then its id would be "js.breadcrumbs" therefore avoiding any conflicts.
It is by design for js components to not be allowed to have the same name. I am therefore marking this issue closed (works as designed).
https://www.drupal.org/project/experience_builder/issues/3520071#comment... ✨ Show human readable error messages when creating component fails Active will add the "js_component' entity with ID 'image' already exists." to render in the dialog, so the user will also see it right away now.
updated screenshot
checked with @lauriii, he's good with text being "Edit code" instead to match what's currently in the contextual menu in component library and layers
hooroomoo → made their first commit to this issue’s fork.
left some comments, looks great, looking forward to seeing the subsequent work
hooroomoo → made their first commit to this issue’s fork.
✨ Show human readable error messages when creating component fails Active displays errors for code component creation so renaming the title here
hooroomoo → created an issue.
hooroomoo → made their first commit to this issue’s fork.
Gonna address feedback
Follow-up issues referenced in the todo comments:
📌
Disallow deleting an XB-enabled content entity if it's currently the homepage
Active
📌
Allow CMS Author to set site's homepage from navigation
Postponed
✨
Move entity type and ID from base path and into routing parameters
Active
Adding related issue here, whoever picks this up should check that issue to see if anything can be re-used for the other dialogs.
409 ERROR: Existing name (backend response)
Client side validation for invalid formats
Closing this as a duplicate because I am implementing the suggestion from #2 in ✨ Show human readable error messages when creating component fails Active
I believe the fix for 🐛 JS component slots don't appear in the preview canvas until published Active should also solve this.
I marked 3 Layers menu related bugs as postponed on this issue. Hopefully migrating to dndkit fixes those bugs. If not, let's re-open the bugs that don't get fixed by the dndkit switch.
Postponing on ✨ Refactor Layers UI to use DnDKit Active
postponing on ✨ Refactor Layers UI to use DnDKit Active
Marking as postponed on ✨ Refactor Layers UI to use DnDKit Active as it is possible it might be solved by that, or not to waste anyones effort if another fix is needed after the move to dnd kit
Need to change one thing
Manually tested and works great.
Left some comments and the multi-select e2e test has a fail
hooroomoo → made their first commit to this issue’s fork.
Just an FYI, this regression was introduced yesterday 🐛 Hovered preview for JS components in library not working Active .
FYI there's an existing bug right now where slots on a JS component don't appear until after you publish it 🐛 JS component slots don't appear in the preview canvas until published Active
This looks good to me though
Neat
hooroomoo → created an issue.
hooroomoo → made their first commit to this issue’s fork.
hooroomoo → created an issue.
📌 Add a route for PATCHing both a config entity and its auto-saved version together Active got merged which includes updating the client PATCH requests to only send what is necessary (therefore not triggering the error) which fixes this bug
hooroomoo → changed the visibility of the branch 3513147-using-actions-from to hidden.
📌 Add a route for PATCHing both a config entity and its auto-saved version together Active fixes this issue :) Closing as outdated
adding credit @balintbrews who suggested creating a hook for the baseUrl which inspired me to create this issue
hooroomoo → created an issue.
Assigning back to @tedbow to fix the merge conflicts with 0.x and hoping for a successful test run post-rebase
experience_builder.auto_save.inc doesn't exist in 0.x anymore since 📌 Move to OO hooks now we require 11.x Active got in so this needs a rebase
Changed the title. After 📌 Allow CMS Author to set site's homepage from navigation Postponed is in, then the frontend can change it to redirect to the homepage. I don't think currently there is a way for the frontend to know whether a page is a homepage or not.