- Issue created by @lauriii
- First commit to issue fork.
- Merge request !1281Removed loading spinner and color change from Publish Review button when... → (Merged) created by jessebaker
- 🇮🇳India libbna New Delhi, India
I have reviewed MR #3, and it looks good to me.
I've also attached screen recordings showing the before and after states to demonstrate the expected outcome.I am updating the issue status to NR so that the maintainer can review it and provide feedback.
Ask ChatGPT
- 🇬🇧United Kingdom jessebaker
@libbna - I see you already reviewed/tested this earlier.
My bad, I didn't correctly assign the ticket to me when I began first thing this morning so you tested before I was ready! I've had to refactor the code since you tested which unfortunately probably invalidates the test you did. If you have an opportunity to re-test, that would be hugely appreciated.
- 🇮🇳India libbna New Delhi, India
I’ve re-tested the changes, and everything looks good to me (I don't see any loading animation on the review changes button). I had already uploaded the "before" screen recording earlier — now uploading the "after" screen recording again as proof that everything is working as expected.
- 🇫🇮Finland lauriii Finland
Nice one! Tested this manually as well and it works great.
- First commit to issue fork.
-
hooroomoo →
committed 1e5e9f54 on 0.x authored by
jessebaker →
Issue #3535558 by jessebaker, libbna, lauriii: Remove loading animation...
-
hooroomoo →
committed 1e5e9f54 on 0.x authored by
jessebaker →