- Issue created by @balintbrews
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
Just discovered over at 📌 Consider renaming javascript component ID to 'id' rather than machineName Active that:
- the CLI tool's CI jobs weren't running when the HTTP API changes (#27), fixed over there
- the CLI tool so far doesn't have functional/integration tests — and hence it was able to stop working when the HTTP API changed but it didn't cause the
CLI vitest
CI job to fail
It's that second bit that worries me — I think that's missing from this meta (and IMHO should've been done for every incremental CLI command added).
- 🇳🇱Netherlands balintbrews Amsterdam, NL
Our timeline to deliver the initial version of the CLI didn't allow for setting up the required automation and CI for integration tests. I hope we can prioritize that soon. Until then, what will definitely improve the situation is that we're planning to start sharing code between
ui
andcli
once we get to ✨ CLI command to build Tailwind CSS for code components Postponed , which will mean shared TypeScript type definitions for how the component payloads should look like. That will catch a lot of problems already by static analysis.