@jessebaker this is known issue. The issue link for the TC-05 :
https://www.drupal.org/project/canvas/issues/3557841
🐛
Cannot delete multiple custom code components consecutively without page reload
Active
Thanks for the details @wim-leers. Created separate issue - https://www.drupal.org/project/canvas/issues/3567167 🐛 Console error when adding second dynamic prop: "Cannot read properties of undefined" Active
Please check attached video to reproduce the issue :
When creating an Article, if you don’t select a default image and then try to add link prop to an image, you’ll encounter a JavaScript error.
Created separate issues for identified bugs :
https://www.drupal.org/project/canvas/issues/3561296
🐛
Error after component directory rename: "The website encountered an unexpected error. Try again later."
Active
https://www.drupal.org/project/canvas/issues/3561292
🐛
Fatal error when adding component after force deleting JS code component config
Active
@wim-leers, I can see linked prop for image but not for videos, is this expected :
Verified below scenarios on 1.x branch :
Please check failed TC03 :
The reported issue has been resolved in drupal/canvas:1.0.0-rc1.
Form submission is working as expected.
I am still able to reproduce the issue on canvas-demo, following the steps outlined in the description.
@wim-leers, After form submission I am getting below error :
The website encountered an unexpected error. Try again later.
AssertionError: Bubbling failed. in assert() (line 623 of core/lib/Drupal/Core/Render/Renderer.php).
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 61)
Drupal\canvas\Element\RenderSafeComponentContainer->renderComponent()
call_user_func_array() (Line: 107)
Drupal\Core\Render\Renderer->doTrustedCallback() (Line: 871)
Drupal\Core\Render\Renderer->doCallback() (Line: 433)
Drupal\Core\Render\Renderer->doRender() (Line: 505)
Drupal\Core\Render\Renderer->doRender() (Line: 505)
Drupal\Core\Render\Renderer->doRender() (Line: 222)
Drupal\Core\Render\Renderer->render() (Line: 491)
Drupal\Core\Template\TwigExtension->escapeFilter() (Line: 49)
__TwigTemplate_194d672454fe15ac840d86c27828eb5c->doDisplay() (Line: 402)
Twig\Template->yield() (Line: 358)
Twig\Template->display() (Line: 373)
Twig\Template->render() (Line: 51)
Twig\TemplateWrapper->render() (Line: 34)
twig_render_template() (Line: 380)
Drupal\Core\Theme\ThemeManager->render() (Line: 492)
Drupal\Core\Render\Renderer->doRender() (Line: 505)
Drupal\Core\Render\Renderer->doRender() (Line: 222)
Drupal\Core\Render\Renderer->render() (Line: 242)
Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 622)
Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 235)
Drupal\Core\Render\MainContent\HtmlRenderer->prepare() (Line: 131)
Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse() (Line: 90)
Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray() (Line: 246)
Symfony\Component\EventDispatcher\EventDispatcher::Symfony\Component\EventDispatcher\{closure}() (Line: 206)
Symfony\Component\EventDispatcher\EventDispatcher->callListeners() (Line: 56)
Symfony\Component\EventDispatcher\EventDispatcher->dispatch() (Line: 188)
Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76)
Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53)
Drupal\Core\StackMiddleware\Session->handle() (Line: 48)
Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28)
Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32)
Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116)
Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90)
Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 53)
Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51)
Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 715)
Drupal\Core\DrupalKernel->handle() (Line: 19)
Verified below scenarios, @wim-leers, please check failed test cases: TC03 and TC08
Created separate ticket for TC07 and TC09 - https://www.drupal.org/project/canvas/issues/3550533 🐛 500 Error and delete option disabled for code component after Canvas/library/usage changes Active
Created separate issue for TC04 - https://www.drupal.org/project/canvas/issues/3549793 →
Re-verified the previously failed scenarios and can confirm those are now working as expected. Details below:
Reported issues are now resolved and changes are working as expected.
This issue can also be reproduced from the Manage Library section:
- Navigate to Manage Library > Code.
- Right-click on a code component or open the options menu (three dots).
- Select the Delete option.
After deleting the code component, the page redirects to:
https://canvas-dev.ddev.site/canvas/editor
@bnjmnm @jessebaker Please check failed scenarios mentioned above : TC05, TC06 and TC07
The changes are working as expected.
Followed the steps below to verify:
- Added a Basic Page (not a canvas page) with the title "my page" (
/node/add/page). - Opened
/canvasin a new tab. - Added a page so the menu appeared on the left.
- Clicked the "Templates" icon (bottom-most icon on the far left).
- Clicked "add new template".
- In the popup, selected Content Type: Basic page, Template name: full content, and clicked "add new template".
- Confirmed that the canvas page used the title "my page" from the Basic Page as expected, reflecting the Content Template with the preview content's title.
- Returned to the original Basic Page, edited the title to "my new title", and saved the changes.
- Went back to the canvas content template page and refreshed the browser tab.
- Observed that the title successfully updated and now displays "my new title".
Changes are functioning correctly and the preview entity label is now reflected as intended.
Verified the scenarios described below:
Steps followed:
Install the module using the following commands:
ddev composer require drupal/redirectddev drush en redirect
Attached the screenshot of the UI for the redirect module page:
I have created follow-up issues for the bugs identified above:
-
Cannot create or view folders in the "Manage Library" Code tab unless at least one code component exists:
https://www.drupal.org/project/canvas/issues/3545660 🐛 Can not create or view folders in "Manage Library" Code tab unless at least one code component exists Active -
No user-facing error is displayed when creating a new folder with a duplicate name in "Manage Library":
https://www.drupal.org/project/canvas/issues/3545655 🐛 No user-facing error when creating a new folder with a duplicate name in "Manage Library" Active -
Unable to delete code components from Manage Library due to a 403 error on delete:
https://www.drupal.org/project/canvas/issues/3544776 🐛 Cannot delete code component from Manage Library: 403 error on delete Active
If a user is granted the following permissions:
- Administer code components
- Administer content templates
They should be able to view and edit both code components and content templates. These permissions are intended to provide full access to manage and configure code components, as well as to create or modify content templates.
However, in this case, the entire page is not displaying for the user, which is unexpected. With the permissions above, the user should be able to:
- Access the code components section and perform actions such as creating, editing, and deleting code components.
- View, edit, and manage content templates.
- Use any related UI features tied specifically to code components and content templates within the system.
Please review this access control, as it appears the current behavior does not align with the intended permission level.
A user role content_editor is assigned the permissions Administer code components and Administer content templates. However, when a user with this role attempts to visit the canvas editing page (e.g., /canvas/editor/canvas_page/1), a 403 Forbidden error is encountered, preventing access to the editor.
The backend (BE) permissions appear correctly set, but the frontend (FE) does not allow the user to load the editor.
I have created separate ticket to resolve FE issue - https://www.drupal.org/project/canvas/issues/3546119 🐛 403 error on canvas editor page for "content_editor" role with "Administer code components" and "Administer content templates" permissions Postponed: needs info
Steps to Reproduce
- Create a user role named content_editor.
- Assign the following permissions to the role:
- Administer code components
- Administer content templates
- Log in with a user assigned the content_editor role.
- Visit
/canvas/editor/canvas_page/[PAGE_ID], such as /canvas/editor/canvas_page/1. - Observe that a 403 Forbidden error is displayed instead of the editor.
A user role content_editor is assigned the permissions Administer code components and Administer content templates. However, when a user with this role attempts to visit the canvas editing page (e.g., /canvas/editor/canvas_page/1), a 403 Forbidden error is encountered, preventing access to the editor.
The backend (BE) permissions appear correctly set, but the frontend (FE) does not allow the user to load the editor.
I have created separate ticket to resolve FE issue - https://www.drupal.org/project/canvas/issues/3546119 🐛 403 error on canvas editor page for "content_editor" role with "Administer code components" and "Administer content templates" permissions Postponed: needs info
Steps to Reproduce
- Create a user role named content_editor.
- Assign the following permissions to the role:
- Administer code components
- Administer content templates
- Log in with a user assigned the content_editor role.
- Visit
/canvas/editor/canvas_page/[PAGE_ID], such as /canvas/editor/canvas_page/1. - Observe that a 403 Forbidden error is displayed instead of the editor.