Created an MR to fix the issue with the dynamic property - the LogMail object doesn't seem to get re-used when I stepped through it, so I stored the log object directly there, but maybe someone knows why that might be a bad idea 😅
justafish → made their first commit to this issue’s fork.
+1 :)
I've split the part about upgrading the tests to https://www.drupal.org/project/drupal/issues/3432099 📌 Update our tests to be W3C compatible Active as we can test this is working using geckodriver
justafish → created an issue.
justafish → made their first commit to this issue’s fork.
Yes we're ok to continue maintaining and handle security reports - I've also added longwave and alexpott as maintainers to the repository
alexpott → credited justafish → .
lgtm!
Ready for review - I did try and pull in the library changes separately (starting from https://git.drupalcode.org/project/drupal/-/commit/557a63899eacf28a117e7... in this MR), over in https://www.drupal.org/project/drupal/issues/3407834 📌 Update Behat from 1.10 to 1.11 Active but I think it's going to be a lot of extra unnecessary work fixing the tests and then re-fixing them as soon as we come back here, that given how small the changeset for this is I don't think it's worth splitting up
justafish → made their first commit to this issue’s fork.
justafish → created an issue.
justafish → made their first commit to this issue’s fork.
xjm → credited justafish → .
Committed, thanks!
Committed and pushed to 11.x and 10.2.x - thanks!
justafish → created an issue.
PR to minkphp/MinkSelenium2Driver for W3C compatibility fixes: https://github.com/minkphp/MinkSelenium2Driver/pull/372
I've been working on a drop-in replacement for instaclick/php-webdriver https://github.com/Lullabot/drupal-webdriver/pull/1
I've created a new drush command that works with 2.0.x
justafish → made their first commit to this issue’s fork.
Committed 1aaa480b07 and pushed to 11.x. Thanks!
I confirm I accept the role and responsibility - thank you all :-)
brianperry → credited justafish → .