I did 🥴
wim leers → credited justafish → .
justafish → created an issue.
justafish → made their first commit to this issue’s fork.
justafish → created an issue.
justafish → created an issue.
justafish → created an issue.
justafish → created an issue. See original summary → .
justafish → created an issue.
justafish → created an issue.
justafish → created an issue.
we first need to reformat some of the Playwright tests with the new package and split them into ones which can run in parallel and ones which need to run in isolation, which should stablise them 🤞
justafish → made their first commit to this issue’s fork.
justafish → created an issue.
justafish → created an issue.
Nothing more to be done here, it was fixed in https://www.drupal.org/project/experience_builder/issues/3532268 📌 XB's `test_site` recipe fails to install its default content through Drush in Playwright Active
The intention of this issue is to track moving all the tests - it'll take a few MRs though! It should have gone back to active not fixed
justafish → created an issue.
balintbrews → credited justafish → .
Wim is correct, we discussed this and though we both remember it working we can't actually reproduce it so have decided it was a Folie à deux 😆
Follow up created here https://www.drupal.org/project/experience_builder/issues/3539062 📌 `ParametrizedImageStyle`: Generate srcset for local unmanaged files Active
justafish → created an issue.
https://www.drupal.org/project/experience_builder/issues/3538858 📌 Generate srcset for remote images from allowed 3rd parties Active created for generating srcsets for remote images
I haven't created a follow up for shipped images as we can already do that 😊
justafish → created an issue.
justafish → made their first commit to this issue’s fork.
balintbrews → credited justafish → .
justafish → created an issue.
justafish → created an issue. See original summary → .
justafish → changed the visibility of the branch 1.x to hidden.
selected in error, it was 11.x 😊
justafish → created an issue.
we don’t really want to be in the business of being integrated into individual site deployments. That’s not something we’re prepared to provide support for, or guarantee availability
Absolutely! This is just enabling the exposure of links to environments in the UI that you can already deploy to with GitLab CI - the expectation isn't that the DA would be hosting environments, it's just a nice way to link to external ones. You can already see it partially working on this job here with the "This job is deployed to" banner: https://git.drupalcode.org/project/experience_builder/-/jobs/5936806
A couple of things we're using it for in Experience Builder which would be useful to surface on the MR itself:
1. Pages deployments, which are already surfaced here https://git.drupalcode.org/project/experience_builder/pages
2. Showing test result reports which are richer than JUnit, for example: https://project.pages.drupalcode.org/-/experience_builder/-/jobs/5906499...
3. It'd also be useful to display Tugboat environment links if we ever set that up again.
The API to customize the starter template has been split into a new issue https://www.drupal.org/project/experience_builder/issues/3536387 📌 Introduce an API to customize the starter template for code components Active
justafish → created an issue.
justafish → created an issue.
and also for a bit of background, it's because prettier and eslint in those forms (i.e. from the top level package.json) were only running on the Playwright tests as we have yet to reconcile this with the ui folder. However in the MR above it's now running on the new cli workspace too.
Thanks for opening and fixing this so quickly!
However, we have already split these jobs up in https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...
If you're happy with the implementation above I'll close this one
justafish → changed the visibility of the branch 3535871-tokenauthuser-does-not to hidden.
justafish → created an issue.
justafish → made their first commit to this issue’s fork.
justafish → made their first commit to this issue’s fork.
Not sure if this would be a design nightmare or not, but it could be nice to have the documentation accessible from within a pane in the editor so it's still obvious and accessible once the component author has deleted the initial code containing the link in the comment
justafish → created an issue.
justafish → created an issue.
justafish → made their first commit to this issue’s fork.
This actually also happens when you don't have media installed and with Claro enabled 🤔
(double field bug filed at https://www.drupal.org/project/experience_builder/issues/3535220 🐛 Two upload fields are shown when Media isn't enabled Active )
justafish → created an issue.
justafish → created an issue.
justafish → made their first commit to this issue’s fork.