- Issue created by @neha_bawankar
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
We discussed this yesterday. This is normal. It wouldn't make sense to upscale images and make blurrier, bigger versions of it.
So … I don't understand this bug report? 😅
P.S.: thanks for linking the related issue! 🙏
Yes , but we decided upon having a bug report that will fix the issue , where smaller images are being scaled to fit the entire page.
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
AHHHHHHH! That makes sense! But that's not what the issue title and description say 😅
The culprit here is
.image { width: 100%; height: auto; display: block; }
which was added in [#33515646].
This is a major visual regression, so increasing priority and tagging . Assigning to @justafish, who worked on #33515646.
- 🇫🇮Finland lauriii Finland
I was first not sure why this would be a beta target because I wasn't thinking that we'd use this image component for anything. Then I realized that this was probably intended to be the way in which SDCs would utilize the image optimization API? Has it actually been reviewed from that perspective?
- First commit to issue fork.
- Merge request !1260Issue #3535153: Make sure images don't display larger than their maximum size → (Merged) created by justafish
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
@lauriii in #6:
I realized that this was probably intended to be the way in which SDCs would utilize the image optimization API?
If by that you mean "serve as a reference of how to use this", yes, that's how I viewed it. Which is why 📌 Improve the front-end DX of Active is also a beta target: to improve that reference.
@justafish: wow that was fast!
- 🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺
#6: that's what 📌 Update XB's `image` SDC to comply with best practices, and document those best practices Needs review is for.
Tested changes on branch
experience_builder-3535153-3535153-regression-from-33515646
, following scenarios :- Create page
- Drag and Drop image component to page
-
wim leers →
committed d23ce798 on 0.x authored by
justafish →
Issue #3535153 by justafish, neha_bawankar, wim leers: Regression from #...
-
wim leers →
committed d23ce798 on 0.x authored by
justafish →