- Issue created by @effulgentsia
- πΊπΈUnited States effulgentsia
I tagged this as beta blocking because π± Plan how to evolve code component overrides Active is, and this is part of that.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
FYI: this is possible since π Populate data to drupalSettings to enable Dynamic Code Components Active and π xbData.* libraries aren't reliably attached for use by the preview while editing a code component Active .
This will need to update
\Drupal\experience_builder\CodeComponentDataProvider::getRequiredXbDataLibraries()
to stop checking for_drupalSettings_xbData_v0_breadcrumbs
and_drupalSettings_xbData_v0_branding
, because it'll need to check for the presence of a call to::getSiteData()
and/or::getPageData()
instead.This was agreed in π Improve the way to detect if the code component has drupalSettings Active as an intermediate step, see #3533458-5: Change CodeComponentDataProvider::getRequiredXbDataLibraries() to base its logic on information provided by the front-end rather than on naive string/regex matching β for the proposed plan, +1'd by @balintbrews at #7 and by @larowlan at #9.
- π§πͺBelgium wim leers Ghent π§πͺπͺπΊ
FYI: this is possible since π Populate data to drupalSettings to enable Dynamic Code Components Active and π xbData.* libraries aren't reliably attached for use by the preview while editing a code component Active .
This will need to update
\Drupal\experience_builder\CodeComponentDataProvider::getRequiredXbDataLibraries()
to stop checking for_drupalSettings_xbData_v0_baseUrl
and_drupalSettings_xbData_v0_pageTitle
, because it'll need to check for the presence of a call to::getSiteData()
and/or::getPageData()
instead.This was agreed in π Improve the way to detect if the code component has drupalSettings Active as an intermediate step, see #3533458-5: Change CodeComponentDataProvider::getRequiredXbDataLibraries() to base its logic on information provided by the front-end rather than on naive string/regex matching β for the proposed plan, +1'd by @balintbrews at #7 and by @larowlan at #9.
- π¬π§United Kingdom justafish London, UK
balintbrews β credited justafish β .
- π³π±Netherlands balintbrews Amsterdam, NL
I expanded the issue to cover page title as well. Also adding credits for discussions prior to this issue being created.