โšก๏ธ Live updates comments, jobs, and issues, tagged with #beta blocker will update issues and activities on this page.

Issues

The last 100 updated issues.

Activities

The last 7 days of comments and CI jobs.

  • ๐Ÿ‡ฎ๐Ÿ‡ชIreland lostcarpark

    Just noting that all tests are now passing.

    Working on adding test for keyboard navigation.

    Still need to rebase for latest changes to 2.0.x branch.

  • ๐Ÿ‡ฉ๐Ÿ‡ชGermany rkoller Nรผrnberg, Germany

    I've quickly tested the latest state. A few observations:

    1. When i tab into the category select field and press space the browser scrolls again while expanding the category list. Happens in Safari and Edge.

    2. Displaying all the categories within the select field is sort of redundant with the list of category chips. Plus the entire list of selected categories is sort of hard to read as well as to process cognitively

    As soon as you select more categories than that could fit within a single line the height of the select field expands to a multi unit height select field. problem is that the position of the modal remains one of a single unit height select field.

    3. In regards of keyboard navigation, I have to check and test a few other cases, but it feels sort of unexpected and odd if you press the tab key that the modal collapses and the focus moves to the next select field. if you try the same for example on one of the three others, pressing tab does nothing, the select field remains expanded and you are only able to navigate the options with the cursor keys and close the list by clicking outside or press esc. therefore the differing behavior for the multiselect with tab feels odd and "might" be potentially confusing in case muscle memory kicks in.

  • ๐Ÿ‡ฎ๐Ÿ‡ชIreland lostcarpark

    Latest changes to the parent issue may cover this. Clicking outside the category dropdown, or tabbing off it, will cause the drop-down to close.

  • ๐Ÿ‡ฎ๐Ÿ‡ชIreland lostcarpark

    One thing to bear in mind is the buttons could make things more difficult for keyboard users. Some thought would need to be given to make sure they aren't disadvantaged.

  • ๐Ÿ‡ฎ๐Ÿ‡ชIreland lostcarpark

    Added Tab and Shift+Tab keyboard behaviour.

    Now when pressing Tab withing the open drop-down list, it will navigate to the next filter (Security Coverage). Pressing Shift+Tab will navigate to the previous one (the search bar).

    Currently the previous and next destinations are hard coded. It would be nice to make that more generic, in case the available filters vary between browser tabs, but I'm not sure how to make that work.

    I feel this helps to make the drop-down list feel like a single control, rather than a collection of separate checkboxes, and makes it behave in a consistent way with other drop-down lists.

  • ๐Ÿ‡ฎ๐Ÿ‡ชIreland lostcarpark

    I've now removed the chips for non-category filters as suggested in #49.

    I also have it showing the selected categories (when there are categories selected), replacing the "Select categories" in the categories box.

    At present the category box gets taller as you select more categories. I thought this would look unsightly, but I think it looks surprisingly okay.

    We possibly should put a limit on how tall it can get. I can think of several approaches we could take:

    1. Just let it grow to show all categories, since most people will only pick a couple.
    2. Put all the categories in the box, but limit the height with max-height
    3. limit the number of categories shown, and have a "+X" at the end to indicate the number of unshown ones
    4. Show the category name when one category is selected, and "X categories selected" if more than one
    5. Only show "X categories selected", never the names.
  • ๐Ÿ‡ฎ๐Ÿ‡ชIreland lostcarpark

    I have fixed some issues for both mouse and keyboard navigation.

    Selecting/deselecting a category with either keyboard or mouse will now keep the drop-down open, and keep the focus on the same checkbox.

    Clicking outside the drop-down, or tabbing off the last checkbox item will close the drop-down.

    I've started making the selected categories display in the closed category box, as would be the case for a standard drop-down. At present I only have it displaying the ID, when obviously we want the category titles displayed. From Chris's comment #49, we could make it just show the count of selected categories.

Production build 0.69.0 2024