- ๐ฎ๐ณIndia divya.sejekan
Tested using MR!320 latest.
The Placeholder text now changed to 'Enter Module name here' and is visible in the search filedTesting Steps
- go to /admin/modules/browse
- take a look at the search field placeholder text before you enter anythingKeeping this in review state for approval
- Status changed to RTBC
4 months ago 6:40pm 25 February 2024 - ๐บ๐ธUnited States KurtTrowbridge
Hello! I'm looking at this during Florida DrupalCamp 2024, and freshly installed Project Browser with the MR applied. The placeholder text appears as expected, both in the visual output of the search field and in the DOM as a
placeholder
attribute. Screenshot attached of the visual output.Going to mark this as RTBC. Thanks!
- Status changed to Postponed
4 months ago 7:57pm 25 February 2024 - ๐บ๐ธUnited States chrisfromredfin Portland, Maine
I think we need to hold off on pushing this through, due to the nature of what's being searched *right now* versus what's going to be searched when there's a real Search API-backed instance running. "Module name" is good with the current mock situation, but we need to think about what this text should *actually* be against the live backend, and that we don't quite know yet.
Though, I anticipate it would be project name & project description (title & body) at a minimum.
I might suggest just "Keyword(s)..." as the placeholder, but I'm curious if that makes sense given what other folks do, and what some UI people think.