- Merge request !332Issue #3313292: Change layout to make plugin-specific content more clear → (Merged) created by narendraR
- 🇪🇸Spain fjgarlin
This needs a rebase that contains the latest changes. After that, we should review again and try to prioritize it to the top of the RTBC as all the feedback has been addressed.
- last update
over 1 year ago 80 pass - Status changed to Needs review
over 1 year ago 1:21am 29 June 2023 - Status changed to Needs work
over 1 year ago 9:01am 29 June 2023 - 🇪🇸Spain fjgarlin
Some really minor things:
1. Page size selector not aligned to page numbers when on the first page:
2. Result count mixed up with plugin name, probably should jump to new line:
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago Custom Commands Failed - Status changed to Needs review
over 1 year ago 3:03pm 13 July 2023 - 🇺🇸United States chrisfromredfin Portland, Maine
Marking NR to get testing to run.
- last update
over 1 year ago 76 pass, 2 fail - last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 80 pass - Status changed to RTBC
over 1 year ago 8:33am 14 July 2023 - 🇪🇸Spain fjgarlin
I re-tested everything in drupalpod and re-reviewed the code. All the feedback given in the previous comments has been addressed.
I pointed out just one minor styling thing, but not sure if it's worth putting it as NW.I'm marking it as RTBC, but if somebody wants to do that minor change in this issue, as long as that's the only change, the issue can continue being RTBC.
Thanks so much for all the effort put into this!
- last update
over 1 year ago Custom Commands Failed - last update
over 1 year ago 80 pass - 🇪🇸Spain fjgarlin
I retested the last commit on drupalpod and it all works as expected, so keeping the RTBC.
- last update
over 1 year ago 80 pass - last update
over 1 year ago 80 pass - last update
over 1 year ago 80 pass -
tim.plunkett →
committed e4461c28 on 1.0.x authored by
narendraR →
Issue #3313292 by narendraR, bnjmnm, srishtiiee, rkoller, fjgarlin:...
-
tim.plunkett →
committed e4461c28 on 1.0.x authored by
narendraR →
- Status changed to Fixed
over 1 year ago 6:12pm 19 July 2023 - 🇺🇸United States tim.plunkett Philadelphia
I rebased this after committing 📌 Fix test fails from upstream TUF changes Fixed and then also removed the remaining out-of-scope test changes. Not sure where those came from, but it passes without them.
Automatically closed - issue fixed for 2 weeks with no activity.