- ๐จ๐ฆCanada mgifford Ottawa, Ontario
Amazing. Thanks for quickly replicating this @sandip poddar.
There are a lot of other resources here if needed https://www.drupal.org/project/drupal/issues/3413207 ๐ META: Provide better support for color and contrast media queries Active
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
After applying the Merge Request (MR), I tested the patched code locally. When I navigated to the Moderated Blocks page (Content โ Blocks โ Moderated Blocks or "/admin/structure/block/block-content/moderated"), I encountered an error.
The website encountered an unexpected error. Try again later. TypeError: Drupal\Core\Cache\CacheableMetadata::setCacheTags(): Argument #1 ($cache_tags) must be of type array, null given, called in /var/www/html/core/modules/views/src/Plugin/views/display/DisplayPluginBase.php on line 2416 in Drupal\Core\Cache\CacheableMetadata->setCacheTags() (line 29 of core/lib/Drupal/Core/Cache/CacheableMetadata.php). Drupal\views\Plugin\views\display\DisplayPluginBase->getCacheMetadata() (Line: 228) Drupal\views\Plugin\views\cache\CachePluginBase->generateResultsKey() (Line: 148) Drupal\views\Plugin\views\cache\CachePluginBase->cacheGet() (Line: 1479) Drupal\views\ViewExecutable->execute() (Line: 1514) Drupal\views\ViewExecutable->render() (Line: 201) Drupal\views\Plugin\views\display\Page->execute() (Line: 1690) Drupal\views\ViewExecutable->executeDisplay() (Line: 80) Drupal\views\Element\View::preRenderViewElement() call_user_func_array() (Line: 107) Drupal\Core\Render\Renderer->doTrustedCallback() (Line: 825) Drupal\Core\Render\Renderer->doCallback() (Line: 387) Drupal\Core\Render\Renderer->doRender() (Line: 203) Drupal\Core\Render\Renderer->render() (Line: 241) Drupal\Core\Render\MainContent\HtmlRenderer->Drupal\Core\Render\MainContent\{closure}() (Line: 593) Drupal\Core\Render\Renderer->executeInRenderContext() (Line: 234) Drupal\Core\Render\MainContent\HtmlRenderer->prepare() (Line: 131) Drupal\Core\Render\MainContent\HtmlRenderer->renderResponse() (Line: 90) Drupal\Core\EventSubscriber\MainContentViewSubscriber->onViewRenderArray() (Line: 246) Symfony\Component\EventDispatcher\EventDispatcher::Symfony\Component\EventDispatcher\{closure}() (Line: 206) Symfony\Component\EventDispatcher\EventDispatcher->callListeners() (Line: 56) Symfony\Component\EventDispatcher\EventDispatcher->dispatch() (Line: 188) Symfony\Component\HttpKernel\HttpKernel->handleRaw() (Line: 76) Symfony\Component\HttpKernel\HttpKernel->handle() (Line: 53) Drupal\Core\StackMiddleware\Session->handle() (Line: 48) Drupal\Core\StackMiddleware\KernelPreHandle->handle() (Line: 28) Drupal\Core\StackMiddleware\ContentLength->handle() (Line: 32) Drupal\big_pipe\StackMiddleware\ContentLength->handle() (Line: 116) Drupal\page_cache\StackMiddleware\PageCache->pass() (Line: 90) Drupal\page_cache\StackMiddleware\PageCache->handle() (Line: 48) Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle() (Line: 51) Drupal\Core\StackMiddleware\NegotiationMiddleware->handle() (Line: 53) Drupal\Core\StackMiddleware\AjaxPageState->handle() (Line: 51) Drupal\Core\StackMiddleware\StackedHttpKernel->handle() (Line: 709) Drupal\Core\DrupalKernel->handle() (Line: 19)
- @prem-suthar opened merge request.
- @sandip-poddar opened merge request.
- ๐ณ๐ฟNew Zealand quietone
A view of 'users' now defaults to displaying the user name as a link.
- ๐ฎ๐ณIndia jaydev bhatt Pune, Maharashtra
i have checked this issues on Drupal 11.1.1
with the steps mention above. double checked it. but was not able to replicate this issue.Steps for testing.
- Download and enabled the gin theme and cleared the cache.
- Enable the dark mode and activated the focus colors mode
- tried giving it the different colors
- Checked on the contnet type page as well.
Attaching the screenshot for reference.
Moving this to Needs Review.
After the verification can be moved to RTBC. Automatically closed - issue fixed for 2 weeks with no activity.
- ๐ฎ๐ณIndia prem suthar Ahemdabad- Gujrat , Jodhpur - Rajsthan
prem suthar โ made their first commit to this issueโs fork.
- Issue created by @rkoller
- ๐ฎ๐ชIreland lostcarpark
Well, doh! Didn't notice this has been merged and tried to add test.
Will add in follow-on issue.
- ๐ฆ๐บAustralia acbramley
IMO this is not a bug, this is just providing a new UI to see moderated block content entities? Re-categorising to a FR. I also personally don't see much use for these screens (none of my client projects use these views) so downgrading the Priority.
Also needs a reroll onto an MR.
- @dww opened merge request.
- ๐บ๐ธUnited States chrisfromredfin Portland, Maine
chrisfromredfin โ changed the visibility of the branch 3487845-make-the-overall to hidden.
- ๐บ๐ธUnited States chrisfromredfin Portland, Maine
This will get people to their projects faster!
-
chrisfromredfin โ
committed 117cd03b on 2.0.x
Issue #3487845: Make the overall design of the browse page more compact...
-
chrisfromredfin โ
committed 117cd03b on 2.0.x
- ๐บ๐ธUnited States chrisfromredfin Portland, Maine
I figured out that the searchString is gone now in favor of $filters.search so I updated that and it worked. But then I figured it needed a test, and i couldn't make the test work (which is weird it really should...)
So, I'm moving the behavior change to a follow-up and merging with just the CSS fixes that are definitely more in-scope. The follow-up should fix it and have a test.
- @chrisfromredfin opened merge request.
Automatically closed - issue fixed for 2 weeks with no activity.
Move the Project browser specific styling from gin theme to project browser's scope. ๐ Move the Project browser specific styling from gin theme to project browser's scope. Active this issue moves the styling from gin to the Project browser's scope.I think once this is in then fixing all the css related issue specific to gin would be easier.
Attaching the issue for reference.- ๐บ๐ธUnited States smustgrave
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!
Using viewport height makes the size closer to what the JavaScript is calculating `min-height: 70vh!important;`.
Automatically closed - issue fixed for 2 weeks with no activity.
Hi @rkoller and @simobm,
I was reviewing this issue, and I believe it would be more appropriate to address it within the Gin Admin theme rather than making changes here. Could you please confirm if this approach makes sense, or if I might be overlooking something?
- First commit to issue fork.
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
The draft of the MR is a work in progress, reflecting proposed changes we've discussed over the course of several ux meetings. The MR is not complete and ready for review yet - we plan to finalize the MR in the coming weeks. We've considered it helpful at this point being able to see all the changes in context. A few remarks:
- So far i've only added the discussed changes for the available field group options, but all those changes also rely on changes on the h1. At the moment the first two steps are just called
Add fields
across all field types and field groups. โจ Use modals in field creation and field edit flow Needs work has to get in first for that. After that the proposed changes for the h1 on second step could be added as well. - While making the changes for the MR I've noticed that the changes on the field type/field group labels also entail necessary changes in help texts and tests. But those changes should happen after a final consensus was reached about the micro copy. Leave it here as a reminder.
- It has to be noted that at this point the description for every option available for the reference field group has an identical description defined in
EntityReferenceItem.php
. That way it is impossible to provide some sort of guidance to the user what the actual difference between the different reference options actually is and which option to pick in which scenario. So we probably need a separate issue to add the ability to provide individual descriptions for the different reference options. - The
file upload
field group currently has no description yet and is still using the pattern starting with "field to..." we've removed on the description for every other field type and field group. But the entire question how to deal with the media field type is out of the scope for this issue and complicates everything. @benjifisher already opened ๐ Add media reference to the same field type group as file and image Active a few weeks back - the general discussion and work should happen there.
- So far i've only added the discussed changes for the available field group options, but all those changes also rely on changes on the h1. At the moment the first two steps are just called
- @rkoller opened merge request.
Automatically closed - issue fixed for 2 weeks with no activity.
- ๐จ๐ฆCanada paintingguy
Ha! I realized I was adding #17 to the wrong theme. When I selected Claro and the theme in CSS Injector, It works much better. Thank you!
- ๐จ๐ฆCanada paintingguy
oops, #17 did not work after all. I tried adding this into CSS Injector but no change. Any other suggestion?
Automatically closed - issue fixed for 2 weeks with no activity.
- ๐ท๐ดRomania vasike Ramnicu Valcea
Some updates for MR
- Coding Standards changes - as reported in the MR threads
Btw - I have no idea why MR didn't say anything about those issues.+ Update for the thread about
ConfigTranslationEntityDisplayListBuilder
inheritance, added extra class to share with existingConfigTranslationFieldListBuilder
... instead of a "direct one"still things to do ...
- ๐บ๐ธUnited States benjifisher Boston area
When you tag an issue for usability review, please make it easy for the usability team to review the issue. Update the issue summary:
- The "Proposed resolution" section should describe all the changes made in the issue.
- The "User interface changes" should show the existing UI and the proposed UI.
- The "Remaining tasks" should include one explaining the usability issue(s).
Most of the time, I prefer to have plain text in the "Proposed resolution" section and screenshots in the "User interface changes" section.
You can also attend the weekly usability meeting to present an issue.
I am adding the tag for an issue summary update and setting the status to NW.
- ๐บ๐ธUnited States benjifisher Boston area
@rkoller, @worldlinemine, and I continued the word-smithing at ๐ Drupal Usability Meeting 2025-02-07 Active .
- ๐ฉ๐ชGermany rkoller Nรผrnberg, Germany
benjifisher โ credited rkoller โ .
- ๐บ๐ธUnited States worldlinemine
benjifisher โ credited worldlinemine โ .
-
jurgenhaas โ
committed 2d9ac365 on 1.0.x authored by
agunjan085 โ
Issue #3504968 by agunjan085, rkoller, jurgenhaas: Add a "Configure"...
-
jurgenhaas โ
committed 2d9ac365 on 1.0.x authored by
agunjan085 โ
- ๐ฉ๐ชGermany jurgenhaas Gottmadingen
Thank you @agunjan085 for your contribution. I've left a couple of comments in the MR, not much to fix those.
Note: the hook help is out of scope for this issue, and even if a separate issue for implementing this would be opened, I'd not merge that into the code because I don't see any value in that hook being implemented.
- @agunjan085 opened merge request.
- Issue created by @benjifisher
- @man-1982 opened merge request.
- Issue created by @rkoller
- ๐บ๐ธUnited States jsutta United States
When I tried the version in the
2797583-11.x
branch, the action failed to run on translations with an error stating "This value should not be null." I looked into this and was able to find that the translation was being validated even though itsisValidationRequired
flag was FALSE. Given this, my assumption is that the validation check doesn't always need to be run. However, if this is incorrect please let me know and we can reassess.For now, I've pushed an update to the branch that checks the
isValidationRequired
flag and only performs the validation if it returns TRUE. Otherwise, it sets$violations
to0
. It also checks to make sure$violations
is an instance ofEntityConstraintViolationList
before attempting to use thecount()
method.With this code in place, I'm able to use the action on both untranslated and translated nodes.
- First commit to issue fork.
- First commit to issue fork.
- Issue created by @phenaproxima
- ๐บ๐ธUnited States smustgrave
Thank you for creating this issue to improve Drupal.
We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.
Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.
Thanks!