#Usability

We already have this in the 2.x branches: a recommended source plugin which only shows projects drawn from a curated list which can be controlled by the site admin. This is pretty much the same thing as suggesting modules (or recipes!) to admins.

Check the README.md (included in the merge request) that explains how to create a separator between the prioritized and normal countries. This will enable the indentation.

As an extension of a default Drupal select field, there is no setting for the size of the field. It adapts to to the longest available value.

Please explain the issue with the whitespace in the patch (you mean in the merge request?) . The code passes the gitlab CI checks for code styling, so it should be good. But please explain in more details where it can be improved.

Thank you for creating this issue to improve Drupal.

We are working to decide if this task is still relevant to a currently supported version of Drupal. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or is no longer relevant. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

I tried hard to do this, but it turned out to be damn near impossible because trying to make this work puts you right in the middle of a fistfight between the Form API, Batch API, and AJAX API. A fight were nobody's winning, but you are definitely losing.

I discussed this with @tim.plunkett, maintainer of the Form API, and he felt that this is too much of a Pandora's box to justify the slightly improved usability. What we have now works just fine (in that nobody has complained about it), even though it's not necessarily ideal.

So I'll postpone this indefinitely and leave it for a braver (and/more foolhardy) and more skilled keyboard warrior than myself.

benjifisher → credited rkoller → .

benjifisher → credited simohell → .

I run into config import issue in our CI environment after exporting the action config created by the patch. The problem happens during the site install from existing config process.

It seems that the insert hook introduced in the patch tries to create the corresponding action config whenever a content moderation workflow is being created, which will also happen during the config import process from existing config. Later, when it gets to import the actual action config file, the site install will fail because the config has already been created by the insert hook and Drupal tries to delete and recreate the same action config due to having different UUID.

[error] Drupal\Core\Config\ConfigException: Errors occurred during import in Drush\Commands\config\ConfigImportCommands->doImport() (line 276 of /home/travis/build/nyunursing/cgph/vendor/drush/drush/src/Commands/config/ConfigImportCommands.php).

In ConfigImportCommands.php line 290:

[Exception]
The import failed due to the following reasons:
Deleted and replaced configuration entity "system.action.content_moderation
_editorial_node_change_to_published"

I’ve just pushed a change to the MR to prevent the "content_moderation_save_workflow_actions()" function from running when "\Drupal::isConfigSyncing()" returns true. I don't think we need it for the "content_moderation_workflow_update" hook since it's unlikely to trigger that hook during site install.

Here's a standalone patch for anyone who prefers not to use the patch from the MR.

Is this still an issue? I've went through:

1. Install Standard install profile
2. Install experience_builder
3. Create article node — let's assume it's node 1
4. Install xb_dev_standard
5. Go to /node/1 and ...
... add a new image (without the media module)

6. Click "Review 1 change" and "Publish"
7. Visit /node/1 and see my image

I can investigate deeper on when this was fixed, but I think this can be closed.

I still have some time 🤜🤛

Automatically closed - issue fixed for 2 weeks with no activity.

Escalating to the framework managers since Filter doesn't have a subsystem maintainer.

Thank you for sharing your idea for improving Drupal.

We are working to decide if this proposal meets the Criteria for evaluating proposed changes. There hasn't been any discussion here for over 8 years which suggests that this has either been implemented or there is no community support. Your thoughts on this will allow a decision to be made.

Since we need more information to move forward with this issue, the status is now Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

Thanks!

The proposed resolution only states the vague goal to "Provide feedback..." about unsecure tags. If implemented this feedback would only be provided when the format is saved. So on multi-admin sites only one person gets that feedback and only after saving the filter's form. What about the rest of the time, for instance when a format is imported from configuration? I don't see any discussion about when or where the feedback should be displayed. If this information is important for the site's security then shouldn't we display it every time the format is viewed or on the site status report? I'm tagging the issue for subsystem maintainer review to get comments on this.

Any takers? 😇

Re: #29 - Right, that's the basic problem I foretold at #12. The backend needs to know about this, too. If the behavior is to be determined by field cardinality, we need some way for the Field API (which knows about field cardinality) to communicate with the Form API (which handles autocomplete) about how to handle commas.

Ahh, thanks @lendude, I missed #6:

I think the collapsed “Advanced” column was a rather brute-force way to reduce clutter in the Views UI. I wouldn't mind showing it expanded again.

Updated patch from #53 so it applies on D11.2.

Patch gets applied successfully. But patch has white space.
After patch is applied , i added a country field in CT , The country dropdown is better now , easy to use.
Using drupal - 10.3.14
- But i cannot see the indentation done , like the above screenshots
Please verify
Observation

1. Pre-selected country UI (limited) - UI is fine
Steps :
- Add country field in CT
- Fill Allowed number of values as limited
- In field settings , select Set defaut value
2. pre-selected multiple countries (unlimited) - Ui Not as described - Need to fix this
- Add country field in CT
- In field settings , select Selectable
3. Box is shrinked for Selectable country option
- Add country field in CT
- In field setting - Selectable countries - select few countries and save
4. Pre-selected country UI (limited-2) - UI is like old implementation
Steps :
- Add country field in CT
- In field settings , select Set defaut value , Fill Allowed number of values as limited 2 values

I agree with @xjm this isn't really a bug, so moved to task, might be a feature ¯\_(ツ)_/¯

@dawehner seemed to be in favour of this back in the day, and so am I, so removing the subsystem tag. I understand the initial thought behind not showing this, but I believe the Views UI is still plenty complicated without showing this column. And as people have pointed out in this issue this can lead to information being hidden. Also, it always felt a little arbitrary what was considered 'Advanced', since, lets be honest, the whole Views UI is pretty advanced :)

@yoroy has commented here so not sure if a usability review is needed, but happy to follow @xjm on this, so tagging for usability review

I needed this before our D11 upgrade.

Here's a function-only patch → I made for 10.4 that works alright so far. YMMV

I've installed the patch from #21 on our Drupal 10.4 site, and it has not resolved the problem.

I did some debugging, and found that on the Javascript side, everything is handled nicely with the patch in place. It is now returning "Apples, and Bananas" instead of just "and Bananas".

But on the Drupal side, it's still not working. handleAutocomplete() in html/core/modules/system/src/Controller/EntityAutocompleteController.php looks like this:

  public function handleAutocomplete(Request $request, $target_type, $selection_handler, $selection_settings_key) {
    $matches = [];
    // Get the typed string from the URL, if it exists.
    $input = $request->query->get('q');
    // Check this string for emptiness, but allow any non-empty string.
    if (is_string($input) && strlen($input)) {
      $tag_list = Tags::explode($input);
      $tag_list = [$input];
      $typed_string = !empty($tag_list) ? mb_strtolower(array_pop($tag_list)) : '';

$input starts out as "Apples, and Bananas", but Tags::explode breaks it on the comma, and then $typed_string ends up with only "and Bananas".

This is the value that is then passed (at the end of that same function) into the matcher, which results in autocomplete results that ignore what came before the comma:
$matches = $this->matcher->getMatches($target_type, $selection_handler, $selection_settings, $typed_string);

When I replace $tag_list = Tags::explode($input); with $tag_list = [$input];, it works, for this one autocomplete field I am trying to debug. But of course that removes the multi-term handling functionality for the whole rest of the site.

I'm not sure how to proceed here. Any ideas?

Confirming requested/added functionality is maintained with inclusion of newest changes.

I double check the changes, and achieve the same result as i found at #59
(Sorry that i didnt added the screenshots back then)
The advanced column "is gone" as the collapsible behavior.

So i will add the Before Screenshot that @uesli give to us to not flood the IS with duplicated images

Before - just checked with a clean D11.2-dev instalation.

----------------------------------

After - just checked with a clean D11.2-dev instalation + MR 11424.

With regards to documentation updates how do we queue that up?