- 🇩🇪Germany rkoller Nürnberg, Germany
Left a comment on the issue: #3382787-46: Add responsive_image field widget in form display for image type field →
- 🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland
benjifisher → credited AaronMcHale → .
- Issue created by @benjifisher
- 🇳🇿New Zealand DanielVeza Brisbane, AU
I was concerned the new approach could stop the message from showing when we do want it to display, but I've checked all child classes of
EntityDisplayFormBase
and the only one that sets redirects in the form state isLayoutBuilderEntityViewDisplayForm
.I prefer the approach taken here to my original MR & it's flexible enough to be used in the future if something like this pops up again. So +1 from me
- 🇫🇷France DuaelFr Montpellier, France
@Berdir #15 > The language module provides *only* the entity type + bundle-level setting, that scales fairly well. Only when you also enable content_translation then you get the vast list of per-field-per-bundle checkboxes. Those two things were added at different times, and both pretty early in the D8 lifecycle.
What if we only changed the bit added by content_translation to only add links/buttons in this form leading to a specific page for each entity type? I think we don't even need to split it to a page per bundle to begin with (could be done in a follow up).
- 🇺🇸United States mark_fullmer Tucson
This has been rebased of the last commit on 11.x. Setting back to "Needs Review."
- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Another related problem at would be solved by this: The paging is done in
NodeController::getRevisionIds()
; that returns 50 revisions at a time. Then in::revisionOverview()
, some of the revisions may be skipped. This can result in an empty results page. I've seen a pager with several pages, but only two revisions that actually appear anywhere. - 🇩🇪Germany rkoller Nürnberg, Germany
According to @drumm this issue doesn't have to be postponed anymore since d.o has project browsing now.
- 🇺🇸United States smustgrave
Change record looks good so removing that tag.
Added release note to the summary
But MR appears to need a manual rebase.
- 🇦🇺Australia pameeela
Wrote up a whole response to this but realised that it only matters in the context of the existing modal. I have added a screenshot of that to the IS.
Short version: I think a one-liner is preferable, and there is somewhat of a precedent of using one liners in other docs → . It would save most people time, and can be pretty easily unpacked if someone needed to run one step without the other.
However, the current 'View commands' modal shows a description of each step as well as some basic troubleshooting for each. It might be tricky to merge these cleanly. Not impossible, but it would be more confusing.
So I think it's a question of saving some time vs possibly making it harder to follow if something goes wrong.
- 🇲🇦Morocco h_kac
For me, when I started working with Drupal at the beginning, I always confuse between plugins and modules.
I used to work with Wordpress CMS and what we call "Module" in Drupal is called "Plugin" in WP.
Drupal use both terms "Module" and "Plugin", but what plugin means in Drupal is different : it allows to extend fonctionnalities of a module... - 🇺🇸United States mmunjeti
mmunjeti → changed the visibility of the branch 1797438-html5-validation-is to hidden.
- 🇺🇸United States mmunjeti
mmunjeti → changed the visibility of the branch 1797438-html5-validation-is to active.
- 🇵🇱Poland gugalamaciek
@sakthi_dev I'll try to produce 11.x version in free minute... but can't promise when exactly.
- 🇵🇱Poland gugalamaciek
Ups... I forgot about schema updates. So this is #49 + schema fixes.
- 🇩🇪Germany rkoller Nürnberg, Germany
I've succesfully applied MR46. First a feedback about the points listed in the issue summary:
* When expanded, it should be possible to click outside of the button to close the dropdown.
that works as described but i wonder if would it make sense to close the dropdown also when the user clicks inside the preview area? at the moment it only closes when the dark title bar, the frame in slightly lighter dark or one of the other buttons is clicked.
and talking about closing the dropdown the usual pattern keyboard users are familiar with is pressing the ESC key. but that immediately closes the entire preview window. would it be possible and make sense when ESC key pressed and the dropdown is open the dropdown is closed while if the dropdown is closed and the ESC key is pressed the preview window is closed?
And there is also no aural feedback when the dropdown is showing or closed - a screenreader user is unaware if a dropdown is opened or closed (see keyboard_vo.mp4). that might be accomplished by introducing a toggle or switch button for the settings button?* It should be possible to click on the checkbox to toggle an option in addition to clicking on the link.
That works as described in the issue summary the only problem i notice is if you navigate by the keyboard and you have the screenreader announcement active. that way you get two announcements per setting within the aural interface (see keyboard_vo.mp4) which is sort of redundant.
✅ The dropdown should not overlap other buttons.
✅ Dropdown links should show pointer on hover.
✅ Preview panel jumps slightly when view mode control is added or removed.
aside those points there are two more details to note. First the focus outline has a too low color contrast with 1.5:1 it should be at least 3:1.
and one detail about settings in general. those four settings overlap with the settings found on
/admin/config/content/same-page-preview
in one setting, the "open preview by default". but that surfaces one problem. it is not clear to me at all if the settings on the node are "individual" settings aka overrides on a per node basis or a mirror of the global overall settings (on a sidenote "open preview by default" is way more clear than "on by default" on the settings page)? i've unticked the "on by default" checkbox on/admin/config/content/same-page-preview
while "open preview by default" is ticked on the node preview, when i open a node the preview window is opened automatically though. that is confusing, me as the user i always ask myself which of the two counts and is there a "hierarchy" or do the settings simply mirror themselve? having that kind of settings in two different places, with some only available on the node others only availble on the config page and some availble in both places, is simply confusing. - 🇬🇧United Kingdom catch
Yes I think so too, it would be a good thing to add alongside a theme builder.
I also opened #3446582: Responsive images recipe → a couple of days ago, to ship some default image styles matching Olivero's break points to start with and linked this issue from there too.
- 🇫🇷France GaëlG Lille, France
I just read about the Starshot project. This issue could be related?
- 🇮🇳India sakthi_dev
@gugalamaciek, could you please share the diff. I have created an MR for 11.x 2ith #49.
- @sakthi_dev opened merge request.
- 🇵🇱Poland gugalamaciek
#50 is #49 extended with End date optional #153 ( https://www.drupal.org/project/drupal/issues/2794481#comment-14839868 ✨ Allow end date to be optional Needs work )
- First commit to issue fork.
- 🇵🇱Poland gugalamaciek
Improved patch which covers:
- adds all_day column in DB for datetime range fields. Set it as disabled for all existing data with datetime type
- allow to enable all day dates for datetime type & set default value for it in field settings
- widget to set all day, making sure that date is stored in UTC when all day is selected (in general timezone is ignored when all day event is set)
- GraphQL - share allDay property for datetime range fields
- formatter - for now only supported inn default formatter. You can specify date format for all day and non all day dates
- js - when you'll select all day, time is set to 00:00:00 for start & end dates - 🇳🇿New Zealand quietone New Zealand
A commit was made for this issue back in Drupal 8.0 something and was set to Fixed in 2010. It was reopened the same day for a wee change but that never happened and I think is now outdated. But the request for change the links a bit is still ongoing, although it stalled by August that year. I am moving that to a new issue, 📌 Improve links on /admin/people/roles Active
Therefor, restoring the fixed status of this.
- 🇬🇧United Kingdom AaronMcHale Edinburgh, Scotland
benjifisher → credited AaronMcHale → .
- 🇩🇪Germany rkoller Nürnberg, Germany
Added a link to an article by Luke Woroblewski to the issue summary for more context.
- 🇫🇷France Tabestan
This proposed solution reduces the search box maxlength to 80 characters on desktop and 45 characters on screens smaller than 768px.
- @tabestan opened merge request.
- First commit to issue fork.