🇫🇷France @duaelfr

I am very surprised because I never faced this issue.
I just tried to reproduce this following the steps to reproduce in the Issue Summary but everything is working fine.

1. I installed Drupal 10.3.14 on simplytest.me
2. I configured the "Basic HTML" text filter to use this module's plugin (but not the "Full HTML" filter)
3. I copied a bunch of content from https://en.wikipedia.org/wiki/Drupal
4. I pasted it into my editor in "Full HTML" format, markup was preserved
5. I pasted the content into my editor in "Basic HTML" format, markup was removed

I tested both Firefox and Chrome in case it was browser dependant but I had the same results.
(See attached screencast)

Existing tests are stable. Let's merge this before moving on to the next major.

Existing tests are stable. Let's merge this before moving on to the next major.

Converted the patch in a MR to let the CI do its magic

duaelfr → made their first commit to this issue’s fork.

Existing tests are stable. Let's merge this before moving on to the next major.

Existing tests are stable. Let's merge this before moving on to the next major.

This has been fixed in 📌 [1.11.0] Fix CI failures Active to get tests green.
Thanks!

This one made my cry blood. I hope next ones will be easier ;)

duaelfr → created an issue.

(Sorry for the above commits. It was a rebase mistake.)

Done (no need for a new patch as it's only a typo in a comment).

TBH, I don't remember why I needed this such a long time ago.
I just checked 11.x code and this has not been implemented yet.
Creating this new method wouldn't impact existing code and wouldn't need any new dependency. It'd be a pure helper for DX.

Given the lack of comments here. I guess this is not really needed by anyone ;)
Let's see.

There is a proposal.
Patch attached for composer.

duaelfr → created an issue.

New attempt to fix the issue.
Patch for composer attached.

@pdureau Thanks for the review.
Do you have some examples of other locations where patterns can be found? How can this be dynamically determined?

Done
Patch attached for composer

duaelfr → created an issue.

There you go.
Patch attached for composer users.

duaelfr → created an issue.

FYI, the Audit Files → module provides a report that tries to match existing duplicated files and allow to merge them.

I needed that on D10 to delay an upgrade so I rerolled and split the patch.

If you need that feature you have to apply:

• 2741945-103-ckeditor.patch on the ckeditor module
• 2741945-103-core-10.4.patch on Drupal Core (tested on 10.4 but might also work on previous 10.x versions)

duaelfr → created an issue.

This wasn't working on Drupal 10.3+ because of the introduction of the \Drupal\Core\File\FileExists enum (See the related change record → ).
Patch attached for composer friends.

First shot has been pushed to the dev branch and release in alpha.
It still needs to support nested values, so I'm keeping this issue open.

duaelfr → created an issue.

duaelfr → created an issue.

duaelfr → created an issue.

duaelfr → created an issue.

@lendude @smustgrave I'm out of ideas to fix the test. I cannot reproduce this failure locally. Do you have some clues for me?

$ phpunit -c phpunit.xml core/modules/views/tests/src/Functional/BulkFormTest.php
PHPUnit 10.5.45 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.15
Configuration: /app/phpunit.xml

..                                                                  2 / 2 (100%)

HTML output was generated.
[...]

Time: 00:18.124, Memory: 10.00 MB

OK (2 tests, 79 assertions)

$ phpunit -c phpunit.xml core/modules/workspaces/tests/src/Functional/WorkspaceViewsBulkFormTest.php
PHPUnit 10.5.45 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.15
Configuration: /app/phpunit.xml

..                                                                  2 / 2 (100%)

HTML output was generated.
[...]


Time: 00:56.580, Memory: 10.00 MB

OK (2 tests, 97 assertions)

I think I found the issue with my test coverage! Crossing fingers ;)

@lendude destination is kept after the redirect. I believe it's been made that way in the original issue.

I am not pleased that this checkbox is out of the group.
I'll try to figure out another method to fix the issue.

This has been introduced in CKEditor after this module has been created.
I'm glad we don't have to maintain this anymore ;)
Thanks!

duaelfr → made their first commit to this issue’s fork.

Thank you!

Tests should be fixed now.

Done, thanks!

Done, thanks

Done, thanks.

@smustgrave I didn't manage to find existing coverage for other allowed tags. Would you help me find it so I can extend it, please?

Fix and tests pushed in a MR.
Patch attached for composer. Applies on both 11.x and 10.4.x.

duaelfr → created an issue.

Updated IS with references for every tag added to the list.

Progress has been made in 📌 Review/update $adminTags variable for new html elements to be whitelisted Needs work

Added to allowed tags in the MR (from 🐛 element stripped by $adminTags Active ).
Patches for composer.

Progress has been made in 📌 Review/update $adminTags variable for new html elements to be whitelisted Needs work

Progress has been made in 📌 Review/update $adminTags variable for new html elements to be whitelisted Needs work

Added <template> to allowed list to the MR (from ✨ Xss::filterAdmin() to allow "template" elements Active ).
Patches for composer.

Here is a simplified patch for Drupal 10.4 for live projects.

Fixed missing attributes lost in the reroll.
Added <audio> tag as well. (thanks #86 for that suggestion)
Again, attached patch for composer.

Rerolled and cleaned MR.
Added <button> to the allowed list.
Patch attached for composer (11.x).

This is quite old!
I was digging into an issue with inline templating within Views and found this piece of code from \Drupal\views\Plugin\views\PluginBase::viewsTokenReplace():

      // Use the unfiltered text for the Twig template, then filter the output.
      // Otherwise, Xss::filterAdmin could remove valid Twig syntax before the
      // template is parsed.

      $build = [
        '#type' => 'inline_template',
        '#template' => $text,
        '#context' => $twig_tokens,
        '#post_render' => [
          function ($children, $elements) {
            return Xss::filterAdmin($children);
          },
        ],
      ];

      // Currently you cannot attach assets to tokens with
      // Renderer::renderInIsolation(). This may be unnecessarily limiting. Consider
      // using Renderer::executeInRenderContext() instead.
      // @todo https://www.drupal.org/node/2566621
      return (string) $this->getRenderer()->renderInIsolation($build);

Here, even if we are using Twig's render engine, filterAdmin is called on post_process without any way to bypass it. In my case, I have an inline template that includes an image field rendered with a responsive style. The <picture> and <srcset> tags are dropped by this post process so I must use an external template instead of the builtin feature of views.

@maintainers: Hi! I'm willing to provide a fix but I'd need a bit of guidance because I can't figure out where this is happening. Would you help me, please?

I can confirm this issue (on a website without layout_paragraphs, cf #4).
Attaching a screencast of the bug.

As the issue can lead to unnoticed data corruption, I'm bumping it to Major priority.

That's done, Thank you!

duaelfr → made their first commit to this issue’s fork.

Hi there!
Thank you for working on this issue.
Beside @jonathanshaw comments on the MR, this needs to be rerolled now a few changes has landed.
Cheers!

This issue is worked on in ✨ Add support for media reference fields Needs review

This is now fixed! GitlabCI is happy again ;)

Thank you for suggesting that change!

Thank you all for your help with this!

duaelfr → made their first commit to this issue’s fork.

Rerolled on 2.1.x (sadly this version has no release so we cannot tag the issue on it).
Patch added for composer.

MR with proposed changes open and the related patch for composer.

In my case (huge job item), the call to the trackChangedSource method has been reduced from 83.88773 seconds to 0.34245.
The calls to the flatten method from the trackChangedSource method has been reduced from 1966 occurrences to 1.

I hope tests will pass even if I believe so, given the changes I made.

duaelfr → created an issue.

Here is a patch for composer

duaelfr → changed the visibility of the branch 3513777-simplify-getcropentity to hidden.

duaelfr → created an issue.

Note: the issue doesn't happen when manually updating interface or config translations

duaelfr → created an issue.

This issue is really annoying for websites using dialogs on front-end because gin_toolbar does not take permissions like view the administration theme into account when loading its CSS. The result is broken dialogs for non-admin users.
The MR suggests a workaround to disable all gin dialog-related styles on frontend but it kind of defeats the purpose of the module for admin users. Would it be possible to implement something like @webflo's suggestion?

Code from #89 included in a MR against 11.x
+ fix for JS errors on pages without query string
+ patch for composer

duaelfr → made their first commit to this issue’s fork.

The module supports D10 right now.
The accessCheck() method on entity queries will be added to the next major version (D11 compatibility).
See https://git.drupalcode.org/project/extra_field/-/commit/d4752a8125ed4661...

Thank you for your contribution on this module!

@idebr Of course! Sorry for the mistake (twice in a row, I must have been tired this day...)

Improved document structure for better readability

I don't know why I was convinced that 4.X was D11 only. My bad.
Is it better like this?

@anybody There you go.
Now ✨ Show machine name in "Manage form display" and "Manage display" table row Fixed has been released. This causes an issue where the weight field for the field_group line is displayed. Dragging the field_group around is still functional but it can be troubling for end users.

duaelfr → made their first commit to this issue’s fork.