🇪🇸Spain @isholgueras

I've reproduced the issue on 10.2, the patch #6 applies and fixes the issue.

Committed to 4.x and I will include it in the next release.

Thanks!

I forgot to check the checkboxes for credit in the merge but I've added later an empty commit with the appropriate credit https://git.drupalcode.org/project/environment_indicator/-/commit/e01de5....

I'll ask to see how it should be done if this is not the way.

I've included new changes from 4.x, there was a conflict, and also formatted the service argument as a list. Thanks!

isholgueras → made their first commit to this issue’s fork.

Thanks!

isholgueras → made their first commit to this issue’s fork.

Hi joachim, 🐛 weight property should be declared as an int in config schema Needs review was released in 4.0.18.

Can this be tested or there is some work left to do?

Thanks for the work

isholgueras → made their first commit to this issue’s fork.

Thanks for the work

Thanks for the work!

isholgueras → made their first commit to this issue’s fork.

Thanks for the work!

isholgueras → made their first commit to this issue’s fork.

I had the issue in my project and was able to solve it by applying this patch on MR46.

Thanks

The branch is ready to test: https://git.drupalcode.org/issue/require_on_publish-3400407/-/tree/34004...

This code was originally done by the users @marcoscano → and @pjudge → . I've just fixed a few issues and create the PR.

isholgueras → created an issue.

isholgueras → made their first commit to this issue’s fork.

Thanks for explaining it. Yes, now I can reproduce the issue and this patch fixes the issue.
Thanks!

Thanks for the patch. I will release it along with some other RTBC soon.

I like the fix, but there is another place where this should be fixed in environment_indicator.module:94. @prudloff, Can you please add the same code there?

Thanks!

Hi!

I've been reviewing this MR and I can't reproduce or identify the issue under Drupal 10.1.x, environment_indicator 8.x-4.x, gin 8.x-3.0-rc6 and gin_toolbar 8.x-1.0-rc3.

I'm changing between environment indicator 4.x branch and 3388814-fix-gin-admin branch, after clearing the cache, and I can't find any difference.

For Gin settings, I've tested Sidebar, Vertical Toolbar, Horizontal, Modern Toolbar and Legacy and also the Secondary Toolbar in the Frontend.
For the Environment indicator, I've tested the Toolbar integration enabled and disabled.

Can someone post some screenshots or describe a bit more the issue and how to reproduce it?

Another issue that I can find in the MR is that in this line: (https://git.drupalcode.org/project/environment_indicator/-/merge_request...), there is the use of the CSS variable --border-width, but this variable is not defined.

Thanks!

isholgueras → created an issue.

isholgueras → created an issue.

Thanks for the patch

isholgueras → made their first commit to this issue’s fork.

If, as a developer, wants to run unit tests, you need to require, as a dev dependency, the package drupal/core-dev.

The package drupal/core-dev brings symfony/finder and symfony/filesystem ^6.3: https://github.com/drupal/core-dev/blob/11.x/composer.json#L32-L33

As this funcionality seems to be for developers, could make sense to require, as a dev dependency, the drupal/core-dev package?

I wasn't able to reproduce the issue for Drupal 10 nor Drupal 9. I've also tested on Chrome, Firefox and Opera with the following registry: https://js-widgets.github.io/registry-starterkit-react/development/widge...

What I've found is the following javascript error:

And I've fixed in widget_type: https://www.drupal.org/project/widget_type/issues/3364465 🐛 Remove javascript error in options-filter.js Fixed

isholgueras → created an issue.

isholgueras → made their first commit to this issue’s fork.

The required version of prohecy-phpunit was the 2.0-@dev

Upgrade php requirement in composer.json to 8.1

Here is the first patch.

In relation to the fix on tests, Sebastian suggest to fix the $this->prophetize deprecation by using the PropecyTrait from phpspec/prophecy-phpunit. I've added it to widget_ingestion/composer.json as a require-dev. Is this correct?

isholgueras → created an issue.

I didn't have the branch 1.x updated. Here is the right patch

Here is the patch with the composer require on widget_type:"^1.5.14"

Here is the patch to set 'unknown' as default remote status in the ingestion process.

The test probably will fail because it's using a constant added in this issue 🐛 Wrong handle with null values on getRemoteStatus Fixed and the constant is not yet defined. At least until 3337158 is merged.

isholgueras → created an issue.

Using a different approach.

Instead of using null, widget_ingestion module will set the status to the new unknown whenever the status is not set in the registry.

The default value for the field remote_widget_status inside the customBaseFieldDefinitions is also set to unknown.

Also, I've fixed one typo.

Here the patch to add the nullable string.

isholgueras → created an issue.