- Issue created by @wim leers
- šŗšøUnited States tedbow Ithaca, NY, USA
wim leers ā credited tedbow ā .
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Actually, this is AFAICT not blocked.
Crediting @tedbow because his comments on š [PP-1] Add entity access checks to routes that deal with entities Postponed have helped me craft this. š
- First commit to issue fork.
- Merge request !957Issue #3516432 "Update routes to respect field level access." ā (Closed) created by deepakkm
- š®š³India deepakkm
The failing pipeline is due to the rebase done with 0.x otherwise all tests are passing.
- š®š³India deepakkm
deepakkm ā changed the visibility of the branch 0.x to hidden.
- š®š³India deepakkm
MR !957 was messed and hence created a new MR with similar changes
- First commit to issue fork.
- š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
Based on meeting just now, can we get:
- the failing tests to explicitly skipped on SQLite, and have a comment pointing to the relevant core issue?
- an update to
.gitlabci.yml
to use MariaDB by default instead of SQLite? (Or MySQLite, whichever is fastest.)
- š®š³India deepakkm
The pipeline passed - https://git.drupalcode.org/issue/experience_builder-3516432/-/pipelines/..., when the work was done. but failed after a rebase done from another person and i may know why because of the major changes introduced in ApiLayoutController.
I'll update the test case for this once.
but the actual update in gitlab file goes to this issue - https://www.drupal.org/project/experience_builder/issues/3518292 ⨠Allow searching for content in the editor navigation Active , where pipeline failing for 1 and passes for another , i'll update the gitlab file for that. Thanks
- šŗšøUnited States mglaman WI, USA
It failed due to type -> component_id in the tree
- š®š³India deepakkm
This is now good for review. The failing pipeline in cypress test is not part of the changes done in this MR.
- Status changed to Needs work
3 days ago 2:32pm 30 May 2025 - š§šŖBelgium wim leers Ghent š§šŖšŖšŗ
but the actual update in gitlab file goes to this issue - https://www.drupal.org/project/experience_builder/issues/3518292 ⨠Allow searching for content in the editor navigation Active , where pipeline failing for 1 and passes for another , i'll update the gitlab file for that. Thanks
and
The failing pipeline in cypress test is not part of the changes done in this MR.
But ⦠this one surely isn't introducing transliteration, so why is this one failing? š¤ Anyway, because you really want this merge order, I tried to land ⨠Allow searching for content in the editor navigation Active , but couldn't: #3518292-28: Allow searching for content in the navigator ā .